928a4d163e
build: remove unused dependencies from crates
...
This commit fixes loads of crates (47!) had unused dependencies, or
mis-configured dependencies (test deps as normal deps).
I added the "unused_crate_dependencies" to all crates to help prevent
this mess from growing again!
https://doc.rust-lang.org/beta/nightly-rustc/rustc_lint_defs/builtin/static.UNUSED_CRATE_DEPENDENCIES.html
This has the minor downside of false-positives when specifying
dev-dependencies for test/bench binaries - these are files in /test or
/benches (not normal tests). This commit includes a workaround,
importing them in lib.rs (gated by a feature flag). I think the
trade-off of better dependency management is worth it!
2023-05-23 14:55:43 +02:00
6344fe8c3f
chore: Add rationale for `clippy::future_not_send` ( #7822 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-05-18 16:58:56 +00:00
fba9836f2a
chore(deps): Bump pin-project from 1.0.12 to 1.1.0
...
Bumps [pin-project](https://github.com/taiki-e/pin-project ) from 1.0.12 to 1.1.0.
- [Release notes](https://github.com/taiki-e/pin-project/releases )
- [Changelog](https://github.com/taiki-e/pin-project/blob/main/CHANGELOG.md )
- [Commits](https://github.com/taiki-e/pin-project/compare/v1.0.12...v1.1.0 )
---
updated-dependencies:
- dependency-name: pin-project
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-05-15 02:02:32 +00:00
171113b922
feat: Add process/service names to spans, fix ingester span propagation ( #7507 )
...
* fix: Add IOx process / service name to tracing spans
* fix: Fix ingester span context propagation
---------
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-04-12 16:26:35 +00:00
faae5eb438
chore: Rerun cargo hakari manage-deps
2023-02-27 11:56:15 +01:00
30fea67701
fix: Move variables within format strings. Thanks clippy!
...
Changes made automatically using `cargo clippy --fix`.
2023-02-03 13:06:17 -05:00
cc17e5a54b
refactor: use a workspace dependency for hashbrown
2022-11-11 13:25:39 -05:00
5024523f00
chore(deps): Bump hashbrown from 0.12.3 to 0.13.1
...
Bumps [hashbrown](https://github.com/rust-lang/hashbrown ) from 0.12.3 to 0.13.1.
- [Release notes](https://github.com/rust-lang/hashbrown/releases )
- [Changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/hashbrown/compare/v0.12.3...v0.13.1 )
---
updated-dependencies:
- dependency-name: hashbrown
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-11-11 13:24:56 -05:00
5d9d1d9ee5
fix: Allow using an if to turn a boolean into 1 or 0
...
I'm not sure I agree with this clippy lint; I think the `if` is much
clearer
<https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if >
2022-11-09 10:54:18 -05:00
d2399764c5
fix: be more conservative w/ "request canceled" messages
2022-11-01 17:08:59 +01:00
b438e4b18a
feat: log cancelled HTTP/gRPC requests ( #5980 )
...
This will be helpful to see when the querier or router is too slow and
we timeout. In contrast to the existing metrics, this also helps w/ log
correlation (i.e. "when did we get stuck").
Closes #5975 .
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-10-27 07:33:22 +00:00
99f4440658
refactor: parse HTTP trace header even w/o collector ( #5979 )
...
Since we log trace IDs to allow easier correlation of logs no matter
what the `sampled` flag says, we should also parse these logs if we
don't have a tace collector at all.
In practice, this won't make a difference since we always deploy with a
trace collector, but it also makes the code easier to reason about.
Helps with #5975 .
2022-10-26 09:20:52 +00:00
2e83e04eab
feat: Use workspace package metadata to reduce differences and repetition
2022-10-24 13:04:09 -04:00
cd4087e00d
style: add no todo!() or dbg!() lints
...
Some crates had theme, some not - lets be consistent and have the
compiler spot dbg!() and todo!() macro calls - they should never be in
prod code!
2022-09-29 13:10:07 +02:00
87bdabb38a
feat: log external span for query gRPC requests ( #5187 )
...
* feat: log external span for query gRPC requests
This should simplify the correlation with our binlog data.
* refactor: address review comments
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-07-28 12:53:12 +00:00
8af9330cd7
refactor: drop trace log verbosity
...
This is very shouty, logging one INFO per HTTP request - the router logs
are almost all this one line repeated.
2022-03-09 10:38:20 +00:00
22778a3a80
chore: upgrade rskafka and parking_lot ( #3592 )
2022-02-01 11:50:42 +00:00
2062267d0f
chore: Update hashbrown ( #3551 )
...
* chore: Update hashbrown
* fix: hakari
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-01-27 15:34:10 +00:00
f3f6f335a9
chore: upgrade to snafu 0.7 ( #3440 )
2022-01-11 19:22:36 +00:00
6f8d513798
chore: remove temporary logging ( #2297 ) ( #3256 )
2021-11-30 11:11:17 +00:00
9fd4a560f5
feat: Results of running cargo hakari manage-deps
2021-11-19 09:21:57 -05:00
bc7244c48e
chore: use Rust edition 2021
2021-10-25 10:58:20 +02:00
b2698cca44
feat: add `format_jaeger_trace_context`
2021-10-19 15:26:05 +02:00
f62d2d2277
refactor: `Vec::with_capacity(0)` => `vec![]`
...
`vec![]` also results in a capacity of 0, see
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=184113a9afa945cf3cf3b8f854f4c5ce
2021-10-12 16:36:09 +02:00
173f9aefcf
feat: ability to link other spans in span context
...
This can be used when aggregating from multiple parent spans, e.g. when
we want to implement #1473 .
2021-10-12 16:32:57 +02:00
675e0846bb
feat: Add support to create new traces in IOx via JAEGER_DEBUG_HEADER
2021-09-22 08:43:42 -04:00
4ed15976de
feat: Add support for custom tracing header name via JAEGER_TRACE_CONTEXT_HEADER_NAME ( #2591 )
...
* feat: Add support for custom tracing header name via JAEGER_TRACE_CONTEXT_HEADER_NAME
* test: end to end test
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-09-22 11:12:06 +00:00
6f2301e16c
feat: migrate write buffer metrics ( #2536 )
...
* feat: migrate write buffer metrics
* feat: update server/src/write_buffer.rs
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-09-15 17:41:55 +00:00
f3bcafcfea
feat: migrate http metrics to metric crate ( #2508 )
...
* feat: migrate http metrics
* chore: review feedback
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-09-13 18:56:20 +00:00
368f0369ee
chore: Rust 1.55
2021-09-10 12:36:49 +02:00
8a1d759fb7
feat: response classification ( #2273 ) ( #2502 )
...
* feat: response classification (#2273 )
* chore: review feedback
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-09-10 09:05:47 +00:00
f7792aafe6
feat: query tracing ( #2273 ) ( #2391 )
...
* feat: query tracing (#2273 )
* chore: review feedback
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-08-24 17:35:59 +00:00
2c9c191b17
refactor: split out trace http ( #2388 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-08-24 13:37:20 +00:00
Dom Dwyer
Andrew Lamb
dependabot[bot]
Carol (Nichols || Goulding)
Jake Goulding
Marco Neumann
Raphael Taylor-Davies
Andrew Lamb