Commit Graph

13677 Commits (021e22b5bf086cc32bfd1909b214caee8ffc9634)

Author SHA1 Message Date
Dom Dwyer 021e22b5bf
refactor: remove Arc wrap from ReadThroughCache
This Arc was unnecessary in most uses.
2023-09-05 14:15:35 +02:00
Dom Dwyer 529f11e85d
refactor: remove Arc wrap from InstrumentedCache
This Arc is unnecessary in most calls.
2023-09-05 14:11:17 +02:00
Dom Dwyer bcdafa5f25
refactor: remove Arc wrapper from ShardedCache
This Arc wrapper is unnecessary.
2023-09-05 13:49:57 +02:00
Dom Dwyer 51096119be
refactor: remove Arc from MemoryNamespaceCache
Prior to this commit, the NamespaceCache was only implemented for
Arc<MemoryNamespaceCache> instead of the cache type itself.

In the vast majority of cases, this Arc wrapper is completely
unnecessary - it adds both runtime overhead, and code/type complexity.

This commit impls NamespaceCache for any Arc-wrapped NamespaceCache, and
removes all unnecessary Arc wrapping of the MemoryNamespaceCache.
2023-09-05 13:47:00 +02:00
dependabot[bot] 790e797e6c
chore(deps): Bump regex from 1.9.4 to 1.9.5 (#8667)
Bumps [regex](https://github.com/rust-lang/regex) from 1.9.4 to 1.9.5.
- [Release notes](https://github.com/rust-lang/regex/releases)
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rust-lang/regex/compare/1.9.4...1.9.5)

---
updated-dependencies:
- dependency-name: regex
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-05 08:26:38 +00:00
Dom 2e689f250b
Merge pull request #8664 from influxdata/dom/gossip-compaction-crate
feat(gossip): compaction events crate
2023-09-04 15:04:11 +01:00
Dom Dwyer 79ed787d3a
chore: fmt 2023-09-04 15:53:23 +02:00
Dom c4a9a46b3e
Merge branch 'main' into dom/gossip-compaction-crate 2023-09-04 14:52:10 +01:00
Dom 784e20ffd7
Merge pull request #8665 from influxdata/dom/merkle-consistency-probe-rename
refactor(proto): SyncMessage -> ConsistencyProbe
2023-09-04 14:52:01 +01:00
Dom a4b75fb917
docs: copy/paste doc fixes
Co-authored-by: Fraser Savage <fsavage@influxdata.com>
2023-09-04 14:45:36 +01:00
Dom 992bae0c56
Merge branch 'main' into dom/merkle-consistency-probe-rename 2023-09-04 14:43:40 +01:00
kodiakhq[bot] 8f6b416d3f
Merge pull request #8649 from influxdata/savage/cover-wal-replay-of-empty-wal-file
test(ingester): Cover WAL replay of empty files
2023-09-04 13:43:16 +00:00
kodiakhq[bot] 51c2865276
Merge branch 'main' into savage/cover-wal-replay-of-empty-wal-file 2023-09-04 13:37:59 +00:00
Dom Dwyer 96d099a295
refactor(proto): SyncMessage -> ConsistencyProbe
Rename "SyncMessage" to "ConsistencyProbe" - it's a clearer name for the
use - the message does no syncing!
2023-09-04 15:12:19 +02:00
Dom Dwyer c0b4a10874
feat(gossip): add gossip_compaction crate
Adds a crate that layers compaction-specific gossip types and
abstractions over the underlying gossip transport for a nicer (and
decoupled!) internal API.
2023-09-04 14:05:39 +02:00
Dom Dwyer 044d5bfdcf
refactor(gossip): add Topic::CompactionEvents
This adds a separate compaction event gossip topic.
2023-09-04 13:54:05 +02:00
dependabot[bot] 438d975571
chore(deps): Bump ouroboros from 0.17.2 to 0.18.0 (#8656)
Bumps [ouroboros](https://github.com/joshua-maros/ouroboros) from 0.17.2 to 0.18.0.
- [Commits](https://github.com/joshua-maros/ouroboros/commits)

---
updated-dependencies:
- dependency-name: ouroboros
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-04 10:38:31 +00:00
dependabot[bot] 755ee4111e
chore(deps): Bump tower-http from 0.4.3 to 0.4.4 (#8657)
Bumps [tower-http](https://github.com/tower-rs/tower-http) from 0.4.3 to 0.4.4.
- [Release notes](https://github.com/tower-rs/tower-http/releases)
- [Commits](https://github.com/tower-rs/tower-http/compare/tower-http-0.4.3...tower-http-0.4.4)

---
updated-dependencies:
- dependency-name: tower-http
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-04 09:59:07 +00:00
dependabot[bot] 77f340f964
chore(deps): Bump thiserror from 1.0.47 to 1.0.48 (#8658)
Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.47 to 1.0.48.
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.47...1.0.48)

---
updated-dependencies:
- dependency-name: thiserror
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-04 09:21:22 +00:00
dependabot[bot] 64cc947996
chore(deps): Bump regex-automata from 0.3.7 to 0.3.8 (#8661)
Bumps [regex-automata](https://github.com/rust-lang/regex) from 0.3.7 to 0.3.8.
- [Release notes](https://github.com/rust-lang/regex/releases)
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rust-lang/regex/compare/regex-automata-0.3.7...regex-automata-0.3.8)

---
updated-dependencies:
- dependency-name: regex-automata
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-04 09:10:42 +00:00
dependabot[bot] af75d2f53b
chore(deps): Bump handlebars from 4.3.7 to 4.4.0 (#8660)
Bumps [handlebars](https://github.com/sunng87/handlebars-rust) from 4.3.7 to 4.4.0.
- [Release notes](https://github.com/sunng87/handlebars-rust/releases)
- [Changelog](https://github.com/sunng87/handlebars-rust/blob/v4.4.0/CHANGELOG.md)
- [Commits](https://github.com/sunng87/handlebars-rust/compare/v4.3.7...v4.4.0)

---
updated-dependencies:
- dependency-name: handlebars
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-04 09:03:13 +00:00
dependabot[bot] 843c497fdd
chore(deps): Bump memchr from 2.6.2 to 2.6.3 (#8653)
Bumps [memchr](https://github.com/BurntSushi/memchr) from 2.6.2 to 2.6.3.
- [Commits](https://github.com/BurntSushi/memchr/compare/2.6.2...2.6.3)

---
updated-dependencies:
- dependency-name: memchr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-04 08:54:38 +00:00
Fraser Savage 9b57cb17e6
test(ingester): Cover WAL replay of empty files
Clearing out the TODO
2023-09-01 16:35:50 +01:00
Joe-Blount 7a6de3d422
feat: use recurring L0 end time as hint for split times (#8635)
* chore: add test case for L0 added after vertical splitting

* feat: use recurring L0 end time as hint for split times

* chore: insta test updates

* chore: add split time verification to simulator
2023-09-01 15:34:26 +00:00
Dom 296418d60f
Merge pull request #8646 from influxdata/dom/gossip-compaction-proto
feat(gossip): define CompactionEvent protobuf
2023-09-01 16:27:38 +01:00
Dom 035aa8e6ea
Merge branch 'main' into dom/gossip-compaction-proto 2023-09-01 16:20:56 +01:00
Dom Dwyer 77bfd57579
docs: typo entire
Fix typo.
2023-09-01 17:20:28 +02:00
kodiakhq[bot] ac1449c5c7
Merge pull request #8647 from influxdata/savage/fix-wal-replay-debug-log
fix(ingester): Correctly compute min sequence number for WAL replay debug log
2023-09-01 14:51:47 +00:00
kodiakhq[bot] 4cf1031fbc
Merge branch 'main' into savage/fix-wal-replay-debug-log 2023-09-01 14:46:01 +00:00
Nga Tran 93f3ec6999
feat: teach querier to use sort_key_ids (#8604)
* feat: teach querier to use sort_key_ids

* chore: add an assert to capture bugs

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-09-01 14:45:42 +00:00
Fraser Savage 168a9e37fc
fix(ingester): Correctly compute min sequence number for WAL replay debug logging 2023-09-01 15:34:22 +01:00
Dom Dwyer 855e8bb34c
feat(gossip): define CompactionEvent protobuf
This commit adds the CompactionEvent protobuf type that'll be gossiped
between peers to provide a (compact) description of completed
compactions.
2023-09-01 15:16:34 +02:00
Dom 0f138dc2a5
Merge pull request #8645 from influxdata/dom/reuse-sort-key
refactor(persist): load sort key once
2023-09-01 14:11:08 +01:00
Dom Dwyer e5e12ebb1a
refactor: remove Result from infallible return
The compact_persisting_batch() call is infallible, but prior to this
commit, would return a Result with a () unit type as the error type.

This is misleading - it's never going to return an error, so call sites
checking for errors are misleading.
2023-09-01 14:20:06 +02:00
Dom Dwyer 8853296bef
refactor(persist): load sort key once
Passes the already-loaded sort key into update_catalog_sort_key()

This makes the function inputs clear, and avoids loading the same key
twice (which should be a no-op now, but not in the future!).
2023-09-01 14:15:11 +02:00
kodiakhq[bot] edf47e907e
Merge pull request #8644 from influxdata/savage/crc-reader-checksum-consumes-self
refactor(wal): Consume `CrcReader` when invoking `checksum()`
2023-09-01 11:24:50 +00:00
kodiakhq[bot] b27060ea23
Merge branch 'main' into savage/crc-reader-checksum-consumes-self 2023-09-01 11:19:33 +00:00
kodiakhq[bot] c93045bb60
Merge pull request #8634 from influxdata/savage/cli-table-list
feat(cli): Add `table list <DATABASE>` command
2023-09-01 11:17:27 +00:00
kodiakhq[bot] e23c6840cf
Merge branch 'main' into savage/cli-table-list 2023-09-01 11:12:05 +00:00
Dom fbe2723fba
Merge pull request #8643 from influxdata/crepererum/proto_check_iq_proto
chore: apply proto lints to ingester->query gRPC
2023-09-01 12:10:54 +01:00
Fraser Savage b969d07bc7
refactor(wal): Consume `CrcReader` when invoking `checksum()` 2023-09-01 12:06:10 +01:00
Marco Neumann 3498ded991
chore: apply proto lints to ingester->query gRPC
We should catch breaking changes for the ingester->querier protobufs as well.
2023-09-01 13:03:11 +02:00
Marco Neumann 12f2716180
feat: scaffolding for ingester->querier V2 client (#8632)
Adds basic structure for #8349. This will be filled in using separate
PRs for easier review.

The layer structure was chosen to simplify testing and allow composition
of features (like retries, circuit breaking, metrics, etc.). In contrast
to the V1 client (`querier::ingester`) a client here addresses exactly 1
ingester, not multiple (via an `addr` parameter). The tracking around
mutiple states in the V1 version is not really nice and overly
complicated.
2023-09-01 07:58:26 +00:00
dependabot[bot] b337ce91d6
chore(deps): Bump clap from 4.4.1 to 4.4.2 (#8636)
Bumps [clap](https://github.com/clap-rs/clap) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/clap-rs/clap/compare/v4.4.1...v4.4.2)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-01 07:52:28 +00:00
Marco Neumann 1f732595d1
feat: re-introduce sqlx pool "used" counter (#8624)
This was removed in #8336 because the tracking was broken. However
having an "almost right" metric is still helpful because it helps with
dashboarding (see code comment).

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-08-31 16:18:36 +00:00
Marco Neumann 1f3ee8bf91
refactor: prep work for #8349 (#8626)
* refactor: make projection masks unsigned

* fix: buffer alignment

* feat: more precise serialization error

* refactor: make `client_util` tower helper public

This can be used for #8349 to set tracing headers.

* fix: impl `Eq` for `TimestampMinMax`

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-08-31 16:12:50 +00:00
Fraser Savage 4ff3998c2c
docs(cli): Table create should have help text match arg for database 2023-08-31 16:47:11 +01:00
Fraser Savage 00873fac09
test(cli): Add e2e test for `table list` command 2023-08-31 16:47:10 +01:00
Fraser Savage 2a396c1b73
feat(cli): Add `table list <DATABASE>` command
This commit hooks the influxdb_iox_client and CLI up to the new
`GetTables` gRPC endpoint on the `TableService`, allowing users to
query a list of tables within a database and consequently see any
custom partitioning schemes.
2023-08-31 16:47:09 +01:00
Marco Neumann 5af22cefe6
fix: add assertion migration for #8616 (#8623)
We don't think that there are any dirty clusters left, but better be
safe than sorry.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-08-31 15:07:18 +00:00