Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor(read_buffer): todo!() -> unimplemented!() 

todo!() is useful for incremental work (telling the compiler to shut up
during dev work).

unimplemented!() should be used for prod code that is not yet
implemented but expected to be deployed. It signifies "this isn't
implemented but doesn't need doing now".
pull/24376/head
Dom Dwyer 2022-09-29 13:06:24 +02:00
parent cd4087e00d
commit 5a5f9d104b
5 changed files with 30 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
read_buffer/src/column.rs
View File

@ -188,7 +188,7 @@ impl Column {
Some((min, max)) => (OwnedValue::Boolean(min), OwnedValue::Boolean(max)),
None => (OwnedValue::new_null(), OwnedValue::new_null()),
},
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -216,11 +216,11 @@ impl Column {
}
pub fn column_min(&self) -> Value<'_> {
todo!()
unimplemented!()
}
pub fn column_max(&self) -> Value<'_> {
todo!()
unimplemented!()
}
//
@ -242,7 +242,7 @@ impl Column {
Self::Integer(_, data) => data.value(row_id),
Self::Unsigned(_, data) => data.value(row_id),
Self::Bool(_, data) => data.value(row_id),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -261,7 +261,7 @@ impl Column {
Self::Integer(_, data) => data.values(row_ids),
Self::Unsigned(_, data) => data.values(row_ids),
Self::Bool(_, data) => data.values(row_ids),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -293,7 +293,7 @@ impl Column {
Self::Integer(_, data) => data.all_values(),
Self::Unsigned(_, data) => data.all_values(),
Self::Bool(_, data) => data.all_values(),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -313,7 +313,7 @@ impl Column {
pub fn decode_id(&self, encoded_id: u32) -> Value<'_> {
match &self {
Self::String(_, data) => data.decode_id(encoded_id),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
_ => panic!("unsupported operation"),
}
}
@ -412,7 +412,7 @@ impl Column {
Self::Integer(_, data) => data.row_ids_filter(op, value.scalar(), dst),
Self::Unsigned(_, data) => data.row_ids_filter(op, value.scalar(), dst),
Self::Bool(_, data) => data.row_ids_filter(op, value.bool(), dst),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
};
if row_ids.is_empty() {
@ -471,7 +471,7 @@ impl Column {
data.row_ids_filter_range((&low.0, low.1.scalar()), (&high.0, high.1.scalar()), dst)
}
Self::Bool(_, _) => unimplemented!("filter_range not supported on boolean column"),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
};
if row_ids.is_empty() {
@ -555,7 +555,7 @@ impl Column {
Value::Boolean(b) => meta.might_contain_value(*b),
v => panic!("cannot compare boolean to {:?}", v),
},
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -624,7 +624,7 @@ impl Column {
v => panic!("cannot compare on boolean column using {:?}", v),
}
}
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -648,7 +648,7 @@ impl Column {
Self::Integer(meta, _) => meta.match_no_values(op, value.scalar().as_i64()),
Self::Unsigned(meta, _) => meta.match_no_values(op, value.scalar().as_u64()),
Self::Bool(meta, _) => meta.match_no_values(op, value.bool()),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -666,7 +666,7 @@ impl Column {
Self::Integer(_, data) => data.min(row_ids),
Self::Unsigned(_, data) => data.min(row_ids),
Self::Bool(_, data) => data.min(row_ids),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -680,7 +680,7 @@ impl Column {
Self::Integer(_, data) => data.max(row_ids),
Self::Unsigned(_, data) => data.max(row_ids),
Self::Bool(_, data) => data.max(row_ids),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -710,7 +710,7 @@ impl Column {
Self::Integer(_, data) => data.count(row_ids),
Self::Unsigned(_, data) => data.count(row_ids),
Self::Bool(_, data) => data.count(row_ids),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -726,7 +726,7 @@ impl Column {
Self::Integer(_, data) => data.contains_null(),
Self::Unsigned(_, data) => data.contains_null(),
Self::Bool(_, data) => data.contains_null(),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -739,7 +739,7 @@ impl Column {
Self::Integer(_, data) => data.has_non_null_value(row_ids),
Self::Unsigned(_, data) => data.has_non_null_value(row_ids),
Self::Bool(_, data) => data.has_non_null_value(row_ids),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}
@ -751,7 +751,7 @@ impl Column {
Self::Integer(_, data) => data.has_any_non_null_value(),
Self::Unsigned(_, data) => data.has_any_non_null_value(),
Self::Bool(_, data) => data.has_any_non_null_value(),
Self::ByteArray(_, _) => todo!(),
Self::ByteArray(_, _) => unimplemented!(),
}
}

8
read_buffer/src/column/encoding/scalar/rle.rs
View File

@ -607,19 +607,19 @@ where
}
fn count(&self, _row_ids: &[u32]) -> u32 {
todo!()
unimplemented!()
}
fn sum(&self, _row_ids: &[u32]) -> Option<L> {
todo!()
unimplemented!()
}
fn min(&self, _row_ids: &[u32]) -> Option<L> {
todo!()
unimplemented!()
}
fn max(&self, _row_ids: &[u32]) -> Option<L> {
todo!()
unimplemented!()
}
}

8
read_buffer/src/column/encoding/string/dictionary.rs
View File

@ -631,20 +631,20 @@ impl Dictionary {
/// ids. NULL values are not considered the minimum value if any non-null
/// value exists at any of the provided row ids.
pub fn min<'a>(&'a self, _row_ids: &[u32]) -> Option<&'a String> {
todo!()
unimplemented!()
}
/// Returns the lexicographical maximum value for the provided set of row
/// ids. NULL values are not considered the maximum value if any non-null
/// value exists at any of the provided row ids.
pub fn max<'a>(&'a self, _row_ids: &[u32]) -> Option<&'a String> {
todo!()
unimplemented!()
}
/// Returns the total number of non-null values found at the provided set of
/// row ids.
pub fn count(&self, _row_ids: &[u32]) -> u32 {
todo!()
unimplemented!()
}
/// Returns references to the logical (decoded) values for all the rows in
@ -788,7 +788,7 @@ impl Dictionary {
// Returns true if there exists an encoded non-null value at any of the row
// ids.
fn find_non_null_value(&self, _row_ids: &[u32]) -> bool {
todo!()
unimplemented!()
}
}

2
read_buffer/src/row_group.rs
View File

@ -1031,7 +1031,7 @@ impl RowGroup {
_group_column: ColumnName<'_>,
_aggregates: &[(ColumnName<'_>, AggregateType)],
) {
todo!()
unimplemented!()
}
// Applies aggregates on multiple columns with an optional predicate.

6
read_buffer/src/table.rs
View File

@ -412,7 +412,7 @@ impl Table {
// identify segments where time range and predicates match could match
// using segment meta data, and then execute against those segments and
// merge results.
todo!()
unimplemented!()
}
//
@ -442,7 +442,7 @@ impl Table {
//
// Tied values (multiple equivalent min timestamps) results in an
// arbitrary value from the result set being returned.
todo!();
unimplemented!();
}
/// The inverse of `first`. Of note here is that the returned value must
@ -458,7 +458,7 @@ impl Table {
//
// Tied values (multiple equivalent min timestamps) results in an
// arbitrary value from the result set being returned.
todo!();
unimplemented!();
}
//