feat: report support for read_group in capabilities request (#586)
parent
263af1eeac
commit
163f34c27b
|
@ -332,8 +332,6 @@ where
|
||||||
InternalHintsFieldNotSupported { hints }.fail()?
|
InternalHintsFieldNotSupported { hints }.fail()?
|
||||||
}
|
}
|
||||||
|
|
||||||
warn!("read_group implementation not yet complete: https://github.com/influxdata/influxdb_iox/issues/448");
|
|
||||||
|
|
||||||
let aggregate_string = format!(
|
let aggregate_string = format!(
|
||||||
"aggregate: {:?}, group: {:?}, group_keys: {:?}",
|
"aggregate: {:?}, group: {:?}, group_keys: {:?}",
|
||||||
aggregate, group, group_keys
|
aggregate, group, group_keys
|
||||||
|
@ -569,7 +567,8 @@ where
|
||||||
//
|
//
|
||||||
|
|
||||||
// For now, hard code our list of support
|
// For now, hard code our list of support
|
||||||
let caps = [(
|
let caps = [
|
||||||
|
(
|
||||||
"WindowAggregate",
|
"WindowAggregate",
|
||||||
vec![
|
vec![
|
||||||
"Count", "Sum", // "First"
|
"Count", "Sum", // "First"
|
||||||
|
@ -577,7 +576,9 @@ where
|
||||||
"Min", "Max", "Mean",
|
"Min", "Max", "Mean",
|
||||||
// "Offset"
|
// "Offset"
|
||||||
],
|
],
|
||||||
)];
|
),
|
||||||
|
("Group", vec!["First", "Last", "Min", "Max"]),
|
||||||
|
];
|
||||||
|
|
||||||
// Turn it into the HashMap -> Capabiltity
|
// Turn it into the HashMap -> Capabiltity
|
||||||
let caps = caps
|
let caps = caps
|
||||||
|
@ -1241,6 +1242,8 @@ mod tests {
|
||||||
to_str_vec(&["Count", "Sum", "Min", "Max", "Mean"]),
|
to_str_vec(&["Count", "Sum", "Min", "Max", "Mean"]),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
expected_capabilities.insert("Group".into(), to_str_vec(&["First", "Last", "Min", "Max"]));
|
||||||
|
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
expected_capabilities,
|
expected_capabilities,
|
||||||
fixture.storage_client.capabilities().await?
|
fixture.storage_client.capabilities().await?
|
||||||
|
|
|
@ -203,7 +203,7 @@ async fn read_and_write_data() -> Result<()> {
|
||||||
let capabilities_response = capabilities_response.into_inner();
|
let capabilities_response = capabilities_response.into_inner();
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
capabilities_response.caps.len(),
|
capabilities_response.caps.len(),
|
||||||
1,
|
2,
|
||||||
"Response: {:?}",
|
"Response: {:?}",
|
||||||
capabilities_response
|
capabilities_response
|
||||||
);
|
);
|
||||||
|
|
Loading…
Reference in New Issue