diff --git a/src/server/rpc/service.rs b/src/server/rpc/service.rs index 724fd90a9e..36dc4d5230 100644 --- a/src/server/rpc/service.rs +++ b/src/server/rpc/service.rs @@ -332,8 +332,6 @@ where InternalHintsFieldNotSupported { hints }.fail()? } - warn!("read_group implementation not yet complete: https://github.com/influxdata/influxdb_iox/issues/448"); - let aggregate_string = format!( "aggregate: {:?}, group: {:?}, group_keys: {:?}", aggregate, group, group_keys @@ -569,15 +567,18 @@ where // // For now, hard code our list of support - let caps = [( - "WindowAggregate", - vec![ - "Count", "Sum", // "First" - // "Last", - "Min", "Max", "Mean", - // "Offset" - ], - )]; + let caps = [ + ( + "WindowAggregate", + vec![ + "Count", "Sum", // "First" + // "Last", + "Min", "Max", "Mean", + // "Offset" + ], + ), + ("Group", vec!["First", "Last", "Min", "Max"]), + ]; // Turn it into the HashMap -> Capabiltity let caps = caps @@ -1241,6 +1242,8 @@ mod tests { to_str_vec(&["Count", "Sum", "Min", "Max", "Mean"]), ); + expected_capabilities.insert("Group".into(), to_str_vec(&["First", "Last", "Min", "Max"])); + assert_eq!( expected_capabilities, fixture.storage_client.capabilities().await? diff --git a/tests/end-to-end.rs b/tests/end-to-end.rs index 01e7361de6..642ee9cbc7 100644 --- a/tests/end-to-end.rs +++ b/tests/end-to-end.rs @@ -203,7 +203,7 @@ async fn read_and_write_data() -> Result<()> { let capabilities_response = capabilities_response.into_inner(); assert_eq!( capabilities_response.caps.len(), - 1, + 2, "Response: {:?}", capabilities_response );