In certain situations, the http.ResponseWriter passed to the URLPrefixer
may not be an http.Flusher. A simple case where this may occur is if the
Prefixer has been wrapped up in a middleware where the above middleware
wraps the ResponseWriter in a ResponseWriter that doesn't implement the
Flush method.
Previously, the Prefixer would error, which would cause the request to
fail with a 500. Instead, the condition is logged and the request is
passed unmodified to the next middleware in the chain. This effectively
disables prefixing for requests where the above ResponseWriter is not an
http.Flusher.
Misc. Changes
=============
- Some tests for "builders" were moved to server/builders_test.go to
follow with convention. We've been naming files after different things
under test and leaving the file matching the package name for support
objects-in this case a mock logger was added to that file.
* Text and placeholder updates
* Peel types off PropTypes
* Revert to parseMode
* Update copy to be more descriptive of resulting behavior
* Add question mark tooltips to Chat ID and Token
* Expand tooltips to be hoverable with clickable contents
* Extract QuestionMarkComponent to its own file
* Update CHANGELOG
* url is never changed, so omit this field
* Extract constants to their own file
* Refactor PropTypes
* Clear up Kapacitor Alert HipChat configuration
* Update CHANGELOG
* your-room => room
* Extract this tooltip to its own file
* Reorder CHANGELOG entries
* Text and placeholder updates
* Peel types off PropTypes
* Revert to parseMode
* Update copy to be more descriptive of resulting behavior
* Add question mark tooltips to Chat ID and Token
* Expand tooltips to be hoverable with clickable contents
* Extract QuestionMarkComponent to its own file
* Update CHANGELOG
* url is never changed, so omit this field
* Extract constants to their own file
Tim Raymond
Hunter Trujillo
Jade McGough
Jade McGough
Andrew Watkins
Alex Paxton
Alex P
lukevmorris
Jared Scheib
Chris Goller