Move query options into QueryOptions component

pull/2277/head
Andrew Watkins 2017-11-03 13:12:52 -07:00
parent ad6192c4a8
commit d47cd65487
2 changed files with 40 additions and 13 deletions

View File

@ -1,9 +1,8 @@
import React, {PropTypes, Component} from 'react' import React, {PropTypes, Component} from 'react'
import _ from 'lodash' import _ from 'lodash'
import QueryOptions from 'shared/components/QueryOptions'
import FieldListItem from 'src/data_explorer/components/FieldListItem' import FieldListItem from 'src/data_explorer/components/FieldListItem'
import GroupByTimeDropdown from 'src/data_explorer/components/GroupByTimeDropdown'
import FillQuery from 'shared/components/FillQuery'
import FancyScrollbar from 'shared/components/FancyScrollbar' import FancyScrollbar from 'shared/components/FancyScrollbar'
import {showFieldKeys} from 'shared/apis/metaQuery' import {showFieldKeys} from 'shared/apis/metaQuery'
@ -134,7 +133,6 @@ class FieldList extends Component {
} = this.props } = this.props
const hasAggregates = numFunctions(fields) > 0 const hasAggregates = numFunctions(fields) > 0
const hasGroupByTime = groupBy.time
const noDBorMeas = !database || !measurement const noDBorMeas = !database || !measurement
return ( return (
@ -142,16 +140,13 @@ class FieldList extends Component {
<div className="query-builder--heading"> <div className="query-builder--heading">
<span>Fields</span> <span>Fields</span>
{hasAggregates {hasAggregates
? <div className="query-builder--groupby-fill-container"> ? <QueryOptions
<GroupByTimeDropdown fill={fill}
isOpen={!hasGroupByTime} groupBy={groupBy}
selected={groupBy.time} onFill={this.handleFill}
onChooseGroupByTime={this.handleGroupByTime} isKapacitorRule={isKapacitorRule}
/> onGroupByTime={this.handleGroupByTime}
{isKapacitorRule />
? null
: <FillQuery value={fill} onChooseFill={this.handleFill} />}
</div>
: null} : null}
</div> </div>
{noDBorMeas {noDBorMeas

View File

@ -0,0 +1,32 @@
import React, {PropTypes} from 'react'
import GroupByTimeDropdown from 'src/data_explorer/components/GroupByTimeDropdown'
import FillQuery from 'shared/components/FillQuery'
const QueryOptions = ({
fill,
onFill,
groupBy,
onGroupByTime,
isKapacitorRule,
}) =>
<div className="query-builder--groupby-fill-container">
<GroupByTimeDropdown
selected={groupBy.time}
onChooseGroupByTime={onGroupByTime}
/>
{isKapacitorRule ? null : <FillQuery value={fill} onChooseFill={onFill} />}
</div>
const {bool, func, shape, string} = PropTypes
QueryOptions.propTypes = {
fill: string,
onFill: func.isRequired,
groupBy: shape({
time: string,
}).isRequired,
onGroupByTime: func.isRequired,
isKapacitorRule: bool.isRequired,
}
export default QueryOptions