From d47cd65487f72b297358540e37044a845cb9f184 Mon Sep 17 00:00:00 2001
From: Andrew Watkins <watts@influxdb.com>
Date: Fri, 3 Nov 2017 13:12:52 -0700
Subject: [PATCH] Move query options into QueryOptions component

---
 ui/src/shared/components/FieldList.js    | 21 ++++++----------
 ui/src/shared/components/QueryOptions.js | 32 ++++++++++++++++++++++++
 2 files changed, 40 insertions(+), 13 deletions(-)
 create mode 100644 ui/src/shared/components/QueryOptions.js

diff --git a/ui/src/shared/components/FieldList.js b/ui/src/shared/components/FieldList.js
index b92623d3d..a0528d8dd 100644
--- a/ui/src/shared/components/FieldList.js
+++ b/ui/src/shared/components/FieldList.js
@@ -1,9 +1,8 @@
 import React, {PropTypes, Component} from 'react'
 import _ from 'lodash'
 
+import QueryOptions from 'shared/components/QueryOptions'
 import FieldListItem from 'src/data_explorer/components/FieldListItem'
-import GroupByTimeDropdown from 'src/data_explorer/components/GroupByTimeDropdown'
-import FillQuery from 'shared/components/FillQuery'
 import FancyScrollbar from 'shared/components/FancyScrollbar'
 
 import {showFieldKeys} from 'shared/apis/metaQuery'
@@ -134,7 +133,6 @@ class FieldList extends Component {
     } = this.props
 
     const hasAggregates = numFunctions(fields) > 0
-    const hasGroupByTime = groupBy.time
     const noDBorMeas = !database || !measurement
 
     return (
@@ -142,16 +140,13 @@ class FieldList extends Component {
         <div className="query-builder--heading">
           <span>Fields</span>
           {hasAggregates
-            ? <div className="query-builder--groupby-fill-container">
-                <GroupByTimeDropdown
-                  isOpen={!hasGroupByTime}
-                  selected={groupBy.time}
-                  onChooseGroupByTime={this.handleGroupByTime}
-                />
-                {isKapacitorRule
-                  ? null
-                  : <FillQuery value={fill} onChooseFill={this.handleFill} />}
-              </div>
+            ? <QueryOptions
+                fill={fill}
+                groupBy={groupBy}
+                onFill={this.handleFill}
+                isKapacitorRule={isKapacitorRule}
+                onGroupByTime={this.handleGroupByTime}
+              />
             : null}
         </div>
         {noDBorMeas
diff --git a/ui/src/shared/components/QueryOptions.js b/ui/src/shared/components/QueryOptions.js
new file mode 100644
index 000000000..ae2b52c1a
--- /dev/null
+++ b/ui/src/shared/components/QueryOptions.js
@@ -0,0 +1,32 @@
+import React, {PropTypes} from 'react'
+import GroupByTimeDropdown from 'src/data_explorer/components/GroupByTimeDropdown'
+import FillQuery from 'shared/components/FillQuery'
+
+const QueryOptions = ({
+  fill,
+  onFill,
+  groupBy,
+  onGroupByTime,
+  isKapacitorRule,
+}) =>
+  <div className="query-builder--groupby-fill-container">
+    <GroupByTimeDropdown
+      selected={groupBy.time}
+      onChooseGroupByTime={onGroupByTime}
+    />
+    {isKapacitorRule ? null : <FillQuery value={fill} onChooseFill={onFill} />}
+  </div>
+
+const {bool, func, shape, string} = PropTypes
+
+QueryOptions.propTypes = {
+  fill: string,
+  onFill: func.isRequired,
+  groupBy: shape({
+    time: string,
+  }).isRequired,
+  onGroupByTime: func.isRequired,
+  isKapacitorRule: bool.isRequired,
+}
+
+export default QueryOptions