Commit Graph

8 Commits (7d67017de7aff09ced5d14d8be62d510b9bb8aa4)

Author SHA1 Message Date
Jan Harkes ad6f5d3b1d Service validation for scene component. 2016-04-13 12:35:07 -04:00
MartinHjelmare c56701baaf Refactor reproduce_state for scene component
* Add tests to reach full coverage for helpers/state.py.
* Refactor reproduce_state function in helpers/state.py. Add two dicts,
	as global constants, service_attributes and service_to_state. Use
	these in combination with the dict of services per domain from
	ServiceRegistry, to find the correct service to use in a scene state
	change.
* Use break statement in for loop, to break if service was selected
	to update state, in preference to update state attributes, ie state
	update takes precedence.
* Add ATTR_CODE and ATTR_CODE_FORMAT in const. Import these in
	alarm_control_panel and lock platforms instead of making duplicate
	constants in multiple modules.
* Use ATTR_MEDIA_CONTENT_TYPE and ATTR_MEDIA_CONTENT_ID in media_player
	platform in SERVICE_PLAY_MEDIA and play_media methods, instead of
	'media_type' and 'media_id'.
* Fix PEP257 in modified files.
2016-03-09 18:52:05 +01:00
Fabian Affolter 1b8b2acb51 Fix PEP257 issues 2016-03-07 22:50:56 +01:00
sander 0f6ec9b7ac Added your suggestions.
Looking at your code suggestion below I am not sure exactly how other people might want to put in lists. (But I am missing a more general overview of the code)

 ```
if not isinstance(scene_config,list):
  scene_config=[scene_config]
```

But it is there !
And changed "config" to "states" !
2016-02-28 21:00:51 +01:00
sander 94633b3795 1. added platform per scene entry.
2. changed homeassistant scene setup_platform method to work with 1.
2016-02-28 10:24:02 +01:00
sander 019af42e94 removed unnecessary properties. 2016-02-23 09:42:34 +01:00
sander e37c232bf6 flake8 correction 2016-02-22 20:05:42 +01:00
sander fb449cbc82 first commit 2016-02-22 19:53:55 +01:00