Commit Graph

364 Commits (d6694e233539623d8df735b937aefc44e2b248c0)

Author SHA1 Message Date
Lauri Eskola 612c1fa68c Issue #2880007 by drpal, nod_, droplet: Auto-fix ESLint errors and warnings 2017-07-06 09:21:40 +03:00
Lauri Eskola b5a3346f32 Issue #2891236 by droplet, krina.addweb: Regression in #2542050: Toolbar menus always expanded 2017-07-03 18:13:34 +03:00
Lauri Eskola b67adf08f5 Issue #2542050 by droplet, nod_, dpacassi, Wim Leers, Sam152, andrewmacpherson, tameeshb, jonathanshaw, lokapujya, Daniel Schaefer, Chi, geerlingguy, tarekdj: Toolbar implementation creates super annoying re-rendering 2017-06-19 19:37:48 +03:00
Nathaniel Catchpole f3cf9c43b5 Issue #2880560 by alexpott, droplet: Fix comment added to top of .js files by build process 2017-05-23 15:31:29 +01:00
Alex Pott 8287017e03 Issue #2818825 by drpal, nod_, droplet, cilefen: Rename all JS files to *.es6.js and compile them 2017-05-19 23:12:53 +01:00
Chris McCafferty ef1db63d7b Issue #2878548 by alexpott, droplet, Cottser, idebr, joelpittet, xjm, martin107: Fix CSS whitespace issues 2017-05-19 12:46:41 -04:00
Nathaniel Catchpole 477fbfd292 Issue #2863597 by Lendude, Jo Fitzgerald, michielnugter, nlisgo, dawehner: Convert web tests to browser tests for toolbar module 2017-04-28 13:28:52 -04:00
Nathaniel Catchpole 01f8bd64ed Issue #2854529 by alexpott, xjm, klausi, Chi, Mixologic: Fix Drupal.Scope.MethodScope - all methods should have scopes 2017-03-06 11:25:01 +00:00
xjm 72d65cc85c Issue #2857822 by alexpott, klausi: Fix coding standards issues introduced mostly by array syntax conversion 2017-03-04 08:02:01 -06:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
Nathaniel Catchpole 4c64f7b840 Issue #2770921 by dawehner, klausi, Mile23, mpdonadio, xjm, claudiu.cristea: Feb 21st: Convert chunk of WTB to BTB by just moving classes, changing use statements adding traits 2017-02-21 12:07:44 +00:00
Chris McCafferty 91736cadcb Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, andypost, jsimonis, bojanz: Simplify module form structure and fix bugs when Suhosin is used 2017-02-10 16:55:04 -05:00
Nathaniel Catchpole a90e686658 Revert "Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, jsimonis, andypost, bojanz: Certain modules can't be enabled when Suhosin is used"
This reverts commit 7f37114aca.
2017-02-09 21:40:11 +00:00
Nathaniel Catchpole 7f37114aca Issue #2665152 by alexpott, Andrej Galuf, tfranz, longwave, jsimonis, andypost, bojanz: Certain modules can't be enabled when Suhosin is used 2017-02-09 16:09:22 +00:00
Scott Reeves 85aea4e650 Issue #2551785 by roland.molnar, nod_, MattA: Unable to scroll toolbar menu items or show contextual links on mobile browsers 2016-09-01 22:25:45 -04:00
Nathaniel Catchpole f6ae58526c Issue #2572801 by alexpott, vprocessor, andriyun, andypost, chishah92, Mile23, attiks, hussainweb, klausi, dawehner, pfrenssen: Fix 'Drupal.WhiteSpace.ScopeIndent' coding standard 2016-08-28 18:16:36 +01:00
Alex Pott c2b28643f6 Issue #2745953 by dawehner, tim.plunkett, Wim Leers: AjaxBasePageNegotiator should not require _theme: ajax_base_page to be specified 2016-06-22 16:01:50 +02:00
Alex Pott df0425cfe1 Issue #2721909 by anoopjohn: Fix Drupal.Commenting.FunctionComment.ReturnCommentIndentation 2016-06-02 15:20:55 +01:00
Alex Pott 899f647387 Issue #2716661 by anoopjohn: Fix 'Drupal.Commenting.FunctionComment' coding standard - Issues related to @see references 2016-05-08 17:42:30 -05:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott 70f58860c8 Issue #2716685 by Mile23: Part 2: Fix several errors in the 'Drupal.Commenting.DocComment' coding standard 2016-05-05 12:32:19 +01:00
Alex Pott d5d0d6ce87 Issue #2572777 by andypost, alexpott, attiks, andriyun: Fix 'Squiz.Strings.ConcatenationSpacing' coding standard 2016-05-05 12:07:19 +01:00
Alex Pott 6098437ef5 Issue #2572793 by attiks, andypost: Fix 'Drupal.WhiteSpace.OperatorSpacing' coding standard 2016-04-29 12:02:20 +01:00
Alex Pott 7aab1f5c39 Issue #2711963 by jibran: Modernized ToolbarIntegrationTest 2016-04-26 19:40:26 +01:00
Alex Pott 904b0de0d3 Issue #2700661 by anoopjohn: Ensure core compliance to Drupal.Commenting.FunctionComment.ParamCommentIndentation (part 1). 2016-04-16 13:17:32 +01:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Alex Pott ca48ed6d92 Issue #2469713 by dawehner, pfrenssen, alexpott, elachlan, Mixologic, larowlan, hussainweb, benjy, jibran, Wim Leers, isntall: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary 2016-04-07 12:25:35 +01:00
Alex Pott e8ae668964 Revert "Issue #2469713 by dawehner, pfrenssen, alexpott, elachlan, Mixologic, larowlan, hussainweb, benjy, jibran, Wim Leers, isntall: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary"
This reverts commit 9c9fae71c2.
2016-03-16 17:28:57 +00:00
Alex Pott 9c9fae71c2 Issue #2469713 by dawehner, pfrenssen, alexpott, elachlan, Mixologic, larowlan, hussainweb, benjy, jibran, Wim Leers, isntall: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary 2016-03-16 16:37:02 +00:00
Alex Pott 11d0d76ed3 Revert "Issue #2469713 by dawehner, pfrenssen, elachlan, Mixologic, larowlan, alexpott, hussainweb: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary"
This reverts commit e6f491d8f9.
2016-03-15 15:14:07 +00:00
Alex Pott e6f491d8f9 Issue #2469713 by dawehner, pfrenssen, elachlan, Mixologic, larowlan, alexpott, hussainweb: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary 2016-03-15 13:12:34 +00:00
Jennifer Hodgdon d87ade36a4 Issue #2572643 by alexpott, attiks, Jelle_S, jhodgdon: Fix Drupal.Commenting.FileComment coding standard 2016-02-11 12:54:33 -08:00
Alex Pott 9f4034ac98 Issue #2642236 by TR: Various setUp() and tearDown() methods are not protected (the sequel) 2016-01-05 10:53:08 +00:00
Alex Pott 970cfb3a98 Issue #2603988 by heykarthikwithu: Unnecessary ternary condition in toolbar JS 2015-11-12 22:46:06 +00:00
Alex Pott 9e826723b3 Issue #2609400 by tim.plunkett, effulgentsia, benjamin.merkley: menu.html.twig says that menu_name is an available variable, but it's not 2015-11-12 15:19:54 +00:00
Alex Pott 6dd4b186ad Issue #2400197 by pwolanin, fgm, znerol, neclimdul, mpdonadio, thekevinday, Fabianx: Harden the security where hash values are compared 2015-10-25 20:57:21 -07:00
xjm cd569936a7 Issue #2598500 by krknth, nicrodgers: Remove unused variables from core/modules/toolbar/src/Tests/ToolbarAdminMenuTest.php 2015-10-23 19:57:46 -07:00
webchick 8f487d2806 Issue #2544176 by lauriii, joelpittet: Remove drupal_render_children() usage in Drupal\toolbar\Element\Toolbar 2015-10-22 17:03:11 -07:00
Alex Pott b0e82e5871 Issue #2548195 by nod_, JohnAlbin, madhavvyas, sriharsha.uppuluri: Only use single quotes in JavaScript and update .eslintrc 2015-10-13 23:37:56 +01:00
Nathaniel Catchpole 8b65164c5a Issue #2533800 by alexpott: Remove all unused use statements from core 2015-10-08 20:46:26 +01:00
effulgentsia bb8be56e67 Issue #1832946 by Sutharsan, Jose Reyero, Gábor Hojtsy, Wim Leers, vijaycs85: Runtime translation download fallback works different from installer translation download fallback 2015-10-05 15:39:44 -07:00
webchick 2b8e559040 Issue #2503755 by Wim Leers, bobrov1989, webchick, dcrocks, andypost, emma.maria, catch, Bojhan, dawehner, Gábor Hojtsy, alexpott, tstoeckler, yoroy: Switch from user login block to login menu link and search block in standard profile 2015-10-05 14:46:10 -07:00
webchick 105518a28e Issue #2547159 by mdrummond, mortendk, davidhernandez, lauriii, joelpittet, Wim Leers, Cottser: menu class generating should be in the template not in a function 2015-09-30 14:00:27 -07:00
Alex Pott ede4d4ace0 Issue #2341267 followup by nod_: Bind event handlers for future multiple toolbars 2015-09-28 00:16:55 +02:00
Alex Pott e8b5f46813 Issue #2341267 by tohesi, nod_, gaas, gendoas, droplet, DuaelFr, bartvig: Bind event handlers for future multiple toolbars 2015-09-27 16:31:53 +02:00
webchick b89752c124 Issue #2546196 by andriyun, neclimdul, hussainweb, mgifford, Wim Leers, TR, andypost: Toolbar's orientation-toggling arrows broken by #2173527 2015-09-22 09:10:53 -07:00
Alex Pott 7a25f513f5 Issue #2560783 by stefan.r, joelpittet, lauriii, Cottser, Sutharsan, kgoel, justAChris, Gábor Hojtsy, dawehner, jhodgdon, effulgentsia, xjm, andypost, googletorp: Replace !placeholder with :placeholder for URLs in hook_help() implementations 2015-09-21 12:38:19 +01:00
webchick a937892097 Issue #2531688 by kekkis, nod_, eiriksm, evilfurryone: JSDoc toolbar module 2015-08-31 09:15:48 -07:00
Nathaniel Catchpole a7fc1a2728 Issue #2557871 by alexpott: Remove all usages SafeMarkup::checkPlain() from template preprocess functions and attributes 2015-08-27 15:43:18 +01:00
Nathaniel Catchpole 98e2b931b3 Issue #2552013 by Wim Leers: Follow-up for #2481453: ensure the 'url.query_args': MainContentViewSubscriber::WRAPPER_FORMAT cache context is set 2015-08-20 16:22:26 +01:00
Alex Pott 5f79d63431 Issue #2548027 by nod_: Follow-up add back aria-label to toolbar tray 2015-08-09 01:08:09 +01:00
Alex Pott fad555c2eb Issue #2545826 by JohnAlbin, nod_: Update.eslintrc to work with eslint 1.0.0 2015-08-07 15:08:23 +01:00
Alex Pott 184d4b42b8 Issue #2173527 by idflood, scresante, rpayanm, mgifford, Sam152, Wim Leers: The Menu-Toolbar area should be refactored so that Tray items are nested in the same container as their associated parent Toolbar item 2015-08-06 15:28:50 +01:00
Alex Pott 0c810aa1a0 Issue #2535118 by longwave, Wim Leers, borisson_, effulgentsia: Toolbar subtrees not working on admin pages due to lack of theme negotiation on Toolbar's custom JSONP route 2015-07-29 09:12:30 +01:00
Alex Pott 37c1ee8c47 Issue #2056089 by BarisW, TR, mgifford, rodvolpe, Dom., nambisolo, nod_, katewelling, Manjit.Singh, jhodgdon, Bojhan, Wim Leers: UI problems on the Modules/Extend page 2015-07-27 13:03:51 +01:00
webchick a28e94b3bc Issue #2532490 by tim.plunkett, dawehner, Wim Leers, Crell, mtift: Unrouted URLs break toolbar but are hidden by caching 2015-07-17 15:27:09 -07:00
Alex Pott 0feb1b692e Issue #2534830 by Wim Leers: Toolbar subtrees not working 2015-07-17 09:46:05 +01:00
Alex Pott 7fb23ea26c Issue #2534856 by Dave Reid: Remove unused _toolbar_get_user_cid() 2015-07-17 09:07:05 +01:00
webchick 756dc7bbae Issue #2424805 by mdrummond, YesCT, vijaycs85, xjm, marcoscano, ifrik, joelpittet, Jelle_S, attiks, lauriii: Toolbar can no longer switch horizontal and vertical -- expects breakpoints ordered from smallest to largest; responsive images need largest to smallest 2015-07-15 12:53:14 -07:00
Nathaniel Catchpole cbcbfc15e6 Issue #2217985 by Berdir, Wim Leers: Replace the custom menu caching strategy in Toolbar with Core's standard caching 2015-07-14 12:34:15 +01:00
Alex Pott 68d4f0be10 Issue #2511472 by Wim Leers, Fabianx, dawehner: Refactor all usages of drupal_render()/Renderer::render() that break #2450993 2015-06-24 16:31:20 -05:00
Nathaniel Catchpole 5756615df3 Issue #2498625 by jhedstrom, larowlan: Write tests that ensure hook_update_N is properly run 2015-06-12 12:31:10 +01:00
Jennifer Hodgdon 38833e0f83 Issue #2493683 by nod_, dawehner, eiriksm, Wim Leers: JSDoc for JS using Backbone 2015-06-06 08:55:42 -07:00
webchick ea37327b42 Issue #2498689 by lauriii, Wim Leers, David_Rothstein: "Back to site" link no longer appears in the toolbar 2015-06-02 19:34:52 -07:00
Nathaniel Catchpole 5c8a50ed7f Issue #2254865 by Wim Leers, lauriii, borisson_, JeroenT, alexpott, Fabianx: toolbar_pre_render() runs on every page and is responsible for ~15ms/17000 function calls 2015-06-01 17:49:02 +01:00
Alex Pott 73b5652a74 Issue #2470693 by dawehner, Berdir, jibran, hussainweb, pwolanin, znerol: Upgrade to Symfony 2.7.0 2015-06-01 11:47:08 +01:00
webchick d81c9865da Issue #2487704 by AlexB-appnovation, Bojhan, rudraram, zetagraph: Use underline as the focused state (not border left/bottom) 2015-05-24 16:03:27 -07:00
webchick 7f541efcf4 Revert "Issue #2487704 by AlexB-appnovation, Bojhan, rudraram, zetagraph: Use underline as the focused state (not border left/bottom)"
Oopsie. That was quite a bit more than I bargained for. ;)

This reverts commit 223f92b6ae.
2015-05-24 16:02:56 -07:00
webchick 223f92b6ae Issue #2487704 by AlexB-appnovation, Bojhan, rudraram, zetagraph: Use underline as the focused state (not border left/bottom) 2015-05-24 15:51:35 -07:00
webchick 72c59cdab8 Issue #1944572 by hass, Cottser, idebr: Remove "ul.menu" dependency to prevent theme clashes 2015-05-24 15:17:43 -07:00
xjm 088f8b357a Issue #2491155 by mikeburrelljr, Mac_Weber, opdavies: Update drupal.org and kernel.org URLs in core modules (Follow-up to 2489912) 2015-05-24 15:08:46 -05:00
Alex Pott 437fa3781b Issue #2471809 by Dom., skippednote, nod_, jessebeach: Toolbar module does not follow W3C 2015-05-08 18:29:53 -07:00
Alex Pott b676df9303 Issue #2031641 by aburrows, lauriii, nlisgo, Pol, redsquid, tuutti, LewisNyman, akalata, agviu, kallehauge, _nolocation, rpayanm, saki007ster, mdrummond, RavindraSingh, brahmjeet789: Change active class to is-active 2015-04-16 16:25:55 +02:00
Alex Pott fdc1c3daf8 Issue #2383863 by rpayanm, mgifford, maximpodorov, Valentine94: Spellchecking Drupal - Comments 2015-04-02 11:59:11 +01:00
webchick 70f8ac6f31 Issue #2457887 by prateekMehta, stefan.r, rpayanm, alexpott: Use Utility\SafeMarkup class instead of Utility\String for placeholder(), checkPlain(),format() functions 2015-03-29 15:13:25 -07:00
catch 1208ddd979 Issue #2428703 by Wim Leers: Add a 'user.permissions' cache context (was: "Should cache contexts be able to associate a cache tag?") 2015-03-26 09:41:35 +00:00
Alex Pott cbd01844a2 Issue #2348321 by RobLoach, nod_: Upgrade to jQuery Once 2.x 2015-03-23 10:29:17 +00:00
Alex Pott 59388d8c46 Issue #2433281 by neclimdul, mrjmd: Move Role Constants on to a Class/Interface 2015-03-14 21:50:47 +00:00
Alex Pott 84292588e6 Issue #2448023 by anksy: Fix or remove dead CSS in toolbar.module.css 2015-03-10 12:48:16 +00:00
Alex Pott db60a8c7ec Issue #2273923 by mpdonadio, pfrenssen, effulgentsia, pcambra, xjm, tim.plunkett, martin107, cilefen: Remove html => TRUE option from l() and link generator 2015-03-09 15:57:27 +00:00
Alex Pott 02965ca732 Issue #2382561 by Sabreena, DickJohnson, aliyakhan, Tom Verhaeghe, emma.maria: In narrow viewports (<320px), the toolbar menu tray should be 100% width 2015-03-01 12:34:52 +00:00
Alex Pott a2af0ed804 Issue #2403639 by eshta, hass, LewisNyman: Remove toolbar from print view 2015-02-27 17:24:12 +00:00
Alex Pott 806def404d Issue #2422363 by mortendk, joelpittet, davidhernandez: Rewrite the menu CSS components inline with our CSS standards 2015-02-19 09:18:40 +00:00
webchick 5b8809b782 Issue #2421373 by mortendk, Wim Leers: rename *.icons.css files to *.icons.theme.css 2015-02-11 14:43:41 -08:00
Alex Pott dbb32f2e18 Issue #2260061 by Jelle_S, attiks, Wim Leers, mdrummond, mgifford, holist: Responsive image module does not support sizes/picture polyfill 2.2 2015-02-11 16:12:46 +00:00
Alex Pott 0fe7e02f2a Issue #2409427 by joelpittet, SteveK, sivaramakrishnan, skippednote, idebr: Toolbar vertical orientation link not expanding to fill the space 2015-02-09 12:37:52 +00:00
Alex Pott 1a18f03e57 Issue #2349767 by mortendk, kallehauge, saki007ster, lauriii: Copy toolbar templates to Classy 2015-02-06 12:21:25 +00:00
Alex Pott fb65eb30ee Issue #2410441 by idebr: 'People' icon missing from toolbar 2015-01-26 11:47:32 +00:00
Alex Pott 28977ae6fd Issue #2350837 by dawehner, Berdir, larowlan, Wim Leers: Convert most usages of EntityInterface::getSystemPath() to use routes 2015-01-17 09:13:34 +00:00
Alex Pott 5859ca2cf2 Issue #2040135 by Wim Leers, Berdir: Caches dependent on simple config are only invalidated on form submissions 2015-01-15 09:36:26 +00:00
Alex Pott a3efcb6fb3 Issue #2389515 by nod_: Update ESLint rules 2015-01-10 01:36:01 +00:00
Nathaniel Catchpole 503e46bb6b Issue #918538 by Berdir, slashrsm, damiankloip, sun, tobiasb: Decouple cache tags from cache bins 2015-01-06 13:25:59 +00:00
Alex Pott 1d29fd0a00 Issue #2387973 by tibbsa, hussainweb: Clean-up toolbar module test members - ensure property definition and use of camelCase naming convention 2015-01-02 22:58:58 +00:00
Nathaniel Catchpole 37e7d708c9 Issue #2207629 by droplet, tarekdj, Devin Carlson, rpayanm: Update matchMedia library to latest release 2014-12-19 10:10:06 +00:00
Alex Pott 970ea07c17 Revert "Issue #2273923 by mpdonadio, pfrenssen, dawehner, xjm, cilefen: Remove html => TRUE option from l() and link generator"
This reverts commit 0bcabf50e0.
2014-12-13 21:44:18 +01:00
Alex Pott 0bcabf50e0 Issue #2273923 by mpdonadio, pfrenssen, dawehner, xjm, cilefen: Remove html => TRUE option from l() and link generator 2014-12-13 18:20:19 +01:00
Nathaniel Catchpole 4ecc4ead39 Issue #2382557 by Wim Leers: Change JS settings into a separate asset type 2014-12-04 11:37:59 +00:00
Nathaniel Catchpole 0bfb32b55b git commit -m 'Issue #2377397 by Wim Leers, alexpott: Themes should use libraries, not individual stylesheets' 2014-11-26 10:37:53 +00:00
webchick 9f6975a85e Issue #2349871 by borisson_, Wim Leers, Arjandew: Vertical toolbar menu is broken in narrow viewports 2014-11-23 21:36:37 -08:00
Alex Pott cba3bf6c6e Issue #1855066 by Tom Verhaeghe, Wim Leers, benjifisher: In the "menu" toolbar tray, clicking/tapping white space should show the child level 2014-11-21 10:00:37 +00:00