Commit Graph

166 Commits (ca07ff36d600e778a71dbe52dce9e82c3f1ebd92)

Author SHA1 Message Date
Dries Buytaert ca07ff36d6 - Fixed typo: "Allow users comments" -> "Allow user comments"
- By default, "Allow user comments" is set to "read-write".
2002-12-24 14:39:08 +00:00
Kjartan Mannes ca743aa6fd - fixing doctype in rss feeds. 2002-12-21 19:36:27 +00:00
Dries Buytaert c10ce14d1e - Switched the "short version" and the "long version" on the preview page.
- Removed a broken filter which caused some line breaks to be stripped.

- It is now possible to create short teasers and the '---' delimiter can
  be outside the allowed range but not more than a factor two.

- Fine-tuned teaser extraction in absence of the '---' delimiter.
2002-12-21 18:53:39 +00:00
Dries Buytaert 70c21f7ee0 - Added DOCTYPE. 2002-12-15 21:08:02 +00:00
Dries Buytaert 99d84c9330 - Committed Marco's pager improvements.
- Fixed another annoyance with editing content.
2002-12-14 11:55:54 +00:00
Dries Buytaert 9c11b14dc6 - Bugfixes by Marco.
- Attempt to fix linebreak handling.
2002-12-12 22:31:39 +00:00
Dries Buytaert 7ce686c152 o Permission improvements:
+ Removed the "post content" permission and replaced it by more fine-grained permissions such as "maintain static pages", "maintain personal blog", "maintain stories", etc.

o Usability improvements to teasers:

   + Teaser forms are no more.  Teasers are extracted automatically but can also be instructed using a delimiter "---".  Furthermore, when a post it too short for a teaser, the user won't be bother with teaser stuff anymore.

   + Added an option to set the teaser length, or to disable teasers all together.

   + When previewing a post, both the short (if any) and the full version of a post are shown.  This addresses a common complaint; for example, when writing a book page there was no way you could preview the short version of your post.

   + Forum posts can be teasered now.  This is particularly helpful in the context of drupal.org where we promote forum topics.

o Bugfix: replaced all PHP short tags (<?) with long tags (<?php).

o Bugfix: removed hard-coded dependence on comment module.

o Bugfix: when the queue module was disabled, it was not possible to approve updated book pages.

o Bugfix: applied modified version of Marco's node_teaser() fix.
2002-12-10 20:35:20 +00:00
Dries Buytaert dcbb71f4e5 - Fixed node revisions. 2002-12-02 21:37:08 +00:00
Dries Buytaert ab143d6870 - Fixed "Allow user comments: disabled" no longer works and so on. Patch by
Marco.
2002-12-02 18:47:12 +00:00
Dries Buytaert 8fa5440bb4 - Applied Jeremy's statistics module patches:
+ Fixed "recent users" title/timestamps.
   + Added statistics_node_delete() function.

- Applied Jeremy's node module patches:
   + Added call to statistics_node_delete().
   + Fixed call to taxonomy_node_delete().
2002-11-26 19:39:07 +00:00
Dries Buytaert 9e32c2e960 Patch based on work of Kjartan:
- Changed cache API.

- Fixed caching bug in comment.module.  Odd this hasn't been reported yet.

- Fixed caching bug in forum.module.

- Fixed caching bug in system.module.

- Fixed caching bug in block.module.

- Simplified caching support in forum.module thanks to improved cache API.
2002-11-17 06:42:52 +00:00
Dries Buytaert a6c8b10d8e Applied Moshe's patches:
- Adds more title info to each line in the block: now showing author and number of comments in a unified way accross all modules.

- Added pager support to blog module.

- Blog module now uses standard node view, not its own hack which is more theme friendly (http://www.drupal.org/node.php?id=133).

- Blog module now uses node_feed() function for making RSS feeds. since all feeds are now consolidated, a couple tweaks to node_feed() and format_rss_* would lead us to support new RSS formats easily.

- Fixed bugs where unpublished entries were displayed.
2002-11-11 20:59:28 +00:00
Kjartan Mannes 211d65b94f - Fixing read more link showing when teaser is empty. 2002-11-10 17:41:15 +00:00
Dries Buytaert 562df8fe43 * Added Jeremy's pager:
"This is a simple, generic pager for Drupal-CVS.  It is designed to be
  easily themeable and expandable.  The code is highly-commented to
  enhance readability."

 "Pagers are constructed by combining the provided pieces (all of which
  can be easily modified to display the text or image you prefer) into
  your custom pager."

* Statistics module fixes by Jeremy:

 - removed superfluous check for existence of watchdog()
 - saving changes in admin page displays status and returns same page
 - no longer return 1971/01/01 in "view statistics" table
 - switched from "!=" to "<>" in SQL queries for ANSI-SQL compliance
 - switched from "MAX(timestamp) as timestamp" to "MAX(timestamp) as
   max_timestamp" moving towards ANSI-SQL compliance.

* Added a "theme_item_list" function to format itemized lists.  Also
  changed a couple of modules to take advantage of it.  Makes for a
  more consistent UI.
2002-11-09 13:59:36 +00:00
Dries Buytaert cc381c1461 - Fixed glitch in block module: the admin links were not composed
correctly.  Patch by Stefan.

- Added missing t() functions and improved the %x directives for
  better readability and to ease the process of translating your
  site.  Patches by Stefan.

- Made two small additions to the 'code-clean.sh' script; it will
  now remove patch related junk.

NOTES:

- I removed the &middot; related bits.  Let's tackle these later on
  in a separate patch after we got some sort of consensus.

- I removed the 'module_exist("drupal")' check in the user module;
  I *think* it is incomplete and therefore incorrect.

- Stefan, try using quotes in your translations and check whether
  everything still works.  Example: translate the "Create account"
  button to "Create \"haha\" account \'hihi\'" and see if you can
  still create new accounts.  Maybe automate this using a quick
  hack in the locale module ...
2002-11-01 10:47:20 +00:00
Dries Buytaert 8d103a0898 - Committed Marco's block rewrite:
+ Blocks are not longer called if not rendered: major performance
     improvement.
   + Fixed some bugs (preview option was broken, path option was broken).
   + Removed "ascii"-type blocks.
   + Added permission to for "PHP blocks"
   + ...

  NOTES:

   + You'll want to run "update.php":

       ALTER TABLE blocks DROP remove;
       ALTER TABLE blocks DROP name;

   + You'll want to update your custom modules as well as the modules in
     the contrib repository.  Block function should now read:

       function *_block($op = "list", $delta = 0) {
         if ($op == "list") {
           return array of block infos
         }
         else {
           return subject and content of $delta block
         }
       }
2002-10-26 15:17:26 +00:00
Dries Buytaert 66c5b70736 - Wrapped some hardcoded colors in "theme_invoke()"s; we can still create
a drupal_error() later on but I think we better get used to theme_invoke().

- Fixed translation bug.  Patch by Moshe.

- Fixed PHP warning.  Patch by ax.
2002-10-22 18:46:43 +00:00
Kjartan Mannes 623397d6dd - fixing the logic for populating $node when adding a new node. Title, teaser,
body will now be set correctly, or be left unset if no values are included in
  the request.
2002-10-17 09:21:03 +00:00
Kjartan Mannes 1ff4da96e3 - submit page will now use $edit[teaser/body] if available in the initial request. 2002-10-15 09:40:40 +00:00
Kjartan Mannes 9ec70dfa9e - fixing authored dated for new posts. 2002-09-27 16:49:19 +00:00
Dries Buytaert 56bd15ef4f - Applied Marco's first regex patch. 2002-09-26 16:12:09 +00:00
Dries Buytaert bfe5b85dbd - Applied a (modified) version of Marco's SQL sequence patch. 2002-08-20 19:29:16 +00:00
Kjartan Mannes 5f7e2f7ae0 - increased the "Authored by" field to max 60 chars to fit the length of valid
usernames.
2002-07-21 18:14:35 +00:00
Dries Buytaert 36fca09232 - Added missing t() functions. Patch by Ori. 2002-07-13 17:56:54 +00:00
Dries Buytaert 0544d005f5 - Made node_comment_mode() cache the mode when possible. Patch from Marco's
sandbox.
2002-06-23 13:42:29 +00:00
Kjartan Mannes a6121c1503 - fixing some incorrect l*() calls.
- fixing node_feed() to work with tax feeds. Thanks Moshe.
2002-06-15 13:48:08 +00:00
Kjartan Mannes 53a53ce6db - fixing an error when no DA modules were loaded.
- indentation issue in node module.
2002-06-13 09:19:17 +00:00
Kjartan Mannes 5d36c70449 - improved module descriptions.
- removed admin options for queue and comment module if the modules are not
  loaded.
- nodes are now auto promoted when queue module isn't enabled.
- moderation result block is now visible by the node author.
2002-06-08 16:17:29 +00:00
Kjartan Mannes 4a28077f46 - adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
    * security check isn't in effect if the db hasn't been updated.
    * instructions re-organized.
    * fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
2002-06-01 21:57:29 +00:00
Dries Buytaert af075abb3d - Fixed but #197: "Shouldn't going to index.php?or=xxx show all content
for the term rather than only promoted content?".  Reported by Barry,
  fixed by Revar's patch.
2002-05-30 20:26:08 +00:00
Kjartan Mannes 000ee5d162 - cleaning up the access checks in node.module.
- reverting a taxonomy patch that added $context checking to node/comments.
2002-05-29 17:16:27 +00:00
Dries Buytaert 4191481453 - Bugfix: just before submitting a node, one could change the content of
that node to something that would not have passed the preview pages.

  Patch by Revar:

    "If you uploaded a valid file, and filled out the form right, you will
    get a Submit button.  The problem comes in when you choose a different
    file to upload, and then click Submit.  The filestore_save() function
    cannot do proper validation and handling of the form data, as it only
    returns a list of what node fields to save.  On error, a node entry is
    still created, but with only the nid field set.  The user can't be
    forced to fix their bad entry."

    "Add a _form_validate() node hook to process and validate any form
    results.  That way even on Submit, the node code would check the
    validity of the data, and if bad, it could drop you back to the preview
    screen with the current bad data warnings.  Have it return an array of
    errors that can be passed in as $error to the _form() hook.  If it
    returns a null array, then there's no errors, and the submit can go
    through."
2002-05-26 09:23:46 +00:00
Dries Buytaert 04e491f846 - Now all themes use the new taxonomy stuff, we can remove the depricated
function node_index() - it was an empty function.
2002-05-24 21:37:42 +00:00
Kjartan Mannes 66e1bbfb93 - pending user accounts will not be notified to the site_email.
- fixed access checks on the register form, do this before you enter the
  _save function. If registrations are disabled the register link will
  no longer show (again).
- changed &#187 to &raquo, using the names of entities are better than
  the numbers.
- fixed user information being set when account is registered (properly this
  time, really!)
- reversed the if(!...) commit.
- node_add specifies more defaults.
- added link to blog entries from user page.
2002-05-23 14:14:48 +00:00
Kjartan Mannes 5f6d733b70 - node security fixes.
- fixing the UI to represent what actually happens when you are an admin.
2002-05-22 23:28:48 +00:00
Kjartan Mannes 3d5d247690 - changing sort order. 2002-05-20 09:19:43 +00:00
Dries Buytaert f3c8757179 - Ran the code through 'scripts/code-clean.sh': removed trailing whitespace
(and possibly tabs).
2002-05-20 07:34:38 +00:00
Kjartan Mannes f86a944979 - applied Stevens link patch.
- fixed block permissions.
- fixed user admin page errors: http://www.drupal.org/node.php?id=173.
- cleaned up common.inc a bit: removed format_info, path_img, field_merge.
2002-05-12 15:40:57 +00:00
Kjartan Mannes 86552cb4b6 - changed block, module and theme config pages to use checkboxes.
- coding style clean ups.
- fixed taxonomy causing errors.
2002-05-11 16:21:48 +00:00
Kjartan Mannes 69ec1a6996 - making sure the nodes call filter(). 2002-05-04 18:56:43 +00:00
Kjartan Mannes d09d6d2d97 - fixing the style filter. 2002-05-03 20:35:34 +00:00
Kjartan Mannes 8b153f32f4 - filter changes part 1. Part 2 tomorrow. 2002-05-03 20:27:53 +00:00
Kjartan Mannes de5b9a168d - bug fixes:
* fixed mails not being parsed properly.
    * tracker now shows user name when you view your own recent
      comments.
    * link to submission queue now points to the right place.
    * fixed jabber module.
    * theme is now activated when changed.
- applied Gerhards coding style patch.
2002-04-22 09:05:36 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Kjartan Mannes 1b573fb0ba - book log is now saved and shown when necessary.
- fixed poll title not showing up.
2002-04-17 10:15:13 +00:00
Kjartan Mannes 03c4b3c308 - submit page will no longer give errors.
- empty taxonomy sets should now be well behaved.
2002-04-15 16:39:26 +00:00
Dries Buytaert d8cd54969c - Added Marco's long-awaited taxonmy module and patches - a replacement
for the meta system.  The patches add some extra functionality to the
  comment system (for example, comments can be set read-only) and fix a
  couple of small problems.

  + I integrated the required SQL updates from the varius *.mysql files
    into the "update.php" script.  Upgrading should be easy ...

  + I did not apply/commit the "user.diff" as requested by Marco ...

  + I didn't know what to do with "forum.module" and "forum2.module":
    what do you want me to do with it Marco?  Which one should go in?

  + Can we remove "node_index()" now; both from "node.module" and the
    themes?

  + Thanks Marco!
2002-04-14 20:46:41 +00:00
Kjartan Mannes 5592761620 This is a major change to the system, needs more testing!
Committing Changes by Moshe Weitzman:
- admin_user_account(), user_edit(), and user_view() no longer have any
  hard code for authentication modules. instead authentication modules
  implement the _user hook.
- fixed a couple 'help' typos.
- linked the 'REGISTER' text in the login block to the register page.
  this page now advertises DA better if site employs DA.
- admins may now edit everything about a user account (was a feature
  request).
- user #1 may now login immediately, in addition to receiving his
  password via email.

Other changes:
- modules and themes are now enabled/disabled in the administrative /
  settings / modules | themes pages. Requires SQL update and things must
  be enabled before your site returns to normal. TODO: enable all
  functionality. (For now just do UPDATE system SET status = 1;)
- removed $themes from conf.php.
- added a $theme->system() function where theme can specify settings.
  All themes in the Drupal CVS have been updated to use this.
- added _system hook to modules. TODO: update modules to use this.
- changed strange use of sprintf to the usual strtr. The disadvantage of
  sprintf is that it requires translations to keep the string order,
  which may not be possible in all languages.
- an invalid/nonexisting theme in a user profile will now fallback to the
  BaseTheme instead of crashing.
2002-04-14 19:34:04 +00:00
Steven Wittens 6d959ebe3f Fixed bug: the first node's id is not calculated correctly 2002-04-04 18:22:56 +00:00
Dries Buytaert 9111bfa901 - Small bugfix. 2002-03-26 21:33:23 +00:00