Commit Graph

772 Commits (bb62eec3ceb19212dec2ad988f73cae32a5af23f)

Author SHA1 Message Date
Dries Buytaert eda100b83d - Patch #338403 by drewish: code comments clean-up. 2008-11-25 13:14:29 +00:00
Angie Byron 66df602593 #314870 by Rob Loach, drewish, catch, and sun: Add hook API documentation to Drupal core. 2008-11-25 02:37:33 +00:00
Angie Byron f91cfba34f #302438 by maartenvg and cwgordon7: Only show the 'queued for approval' message for non-administrators. 2008-11-23 16:04:41 +00:00
Dries Buytaert 9c72e9209a - Patch #334826 by maartenvg: editing of anonymous comments was broken. Bugfix with test\! 2008-11-21 14:48:59 +00:00
Dries Buytaert dc65b62ace - Patch #74645 by drewish, roychri et al: modify file_scan_directory to use a regex for the nomask (and code clean-up). 2008-11-16 19:41:14 +00:00
Dries Buytaert 15671f471b - Patch #332123 by webchick, lilou: remove t() function from schema descriptions. 2008-11-15 13:01:11 +00:00
Dries Buytaert 97fdc49191 - Patch #334030 by justinrandell: replace module_list with module_implements when calling a hook. 2008-11-15 11:45:04 +00:00
Dries Buytaert 9d631d22f9 - Patch #314532 by jsaints, Crell, Arancaytar, CorniI, Rob Loach, et al: convert comment module to new DB layer. Doesn't break any additional tests so if we discover a regression, please submit a test with it. 2008-11-11 21:44:01 +00:00
Dries Buytaert bd108c7f10 - Patch #299778 by hswong3i, Arancaytar, Dave Reid et al: code clean-up. 2008-11-11 16:49:38 +00:00
Dries Buytaert 0290031d45 - Patch #319788 by stella, nedjo et al: pass language code to filters when available. 2008-11-08 20:43:54 +00:00
Dries Buytaert 424250196a - Patch #279516 by c960657: removed many PHP4-isms. Great patch. 2008-11-01 19:51:06 +00:00
Dries Buytaert 5371104a2d - Patch #316225 by sun et al: allow behaviors to detach from AHAH/AJAX. 2008-10-29 10:01:28 +00:00
Dries Buytaert 63d0ea9914 - Patch #296485 by johnskulski, catch: fixed problem with comment threading. 2008-10-14 20:39:42 +00:00
Dries Buytaert 126a5e3c88 - Patch #320784 by johnskulski: added test for comment threading. This test currently fails. 2008-10-14 20:34:56 +00:00
Angie Byron 8292bdd40a Re-commit of #242873 by pwolanin and bjaspan: Make drupal_set_title() check_plain() by default. 2008-10-13 00:33:05 +00:00
Angie Byron a3a420c3e6 Roll-back of #242873: This caused horrendous problems with SimpleTest on some configurations. 2008-10-12 06:27:06 +00:00
Angie Byron f76acb2d9d #282405 by Damien Tournoud, lilou, Dave Reid: Enforce coding standard on elseif. 2008-10-12 04:30:09 +00:00
Angie Byron ecf7ad41d0 #242873 by pwolanin and bjaspan: Make drupal_set_title() do check_plain() by default. 2008-10-11 21:11:02 +00:00
Angie Byron 7e02f2f782 #318984 by Xano and Dave Reid: Change 'Core - optional' to 'Core' in modules UI. 2008-10-11 02:33:14 +00:00
Angie Byron 464be0b8bd #318892 by justinrandell and chx: Add .install files to the list of files added to .info files. 2008-10-09 22:51:41 +00:00
Angie Byron d59ba41f65 #313213 by maartenvg, Gábor Hojtsy: Add a 'title' attribute for permissions to allow for localization of permission names 2008-10-09 15:15:55 +00:00
Dries Buytaert 87567f8916 - Patch #310212 by justinrandell: killed in _node hook, as well as twelve sable tooth tigers. 2008-10-06 12:55:56 +00:00
Dries Buytaert 026af5df34 - Patch #310212 by justinrandell, catch, et all: killed in _user hook, as well as two small kittens. 2008-10-06 11:30:12 +00:00
Dries Buytaert 9f3d9f1115 - Patch #161301 by Eaton, Sun, moshe and webchick: make checking for node edit forms easier. DX improvement. 2008-09-27 20:37:01 +00:00
Angie Byron 4a0e68e838 #125315 by chx, sun, Gábor Hojtsy, drumm, and friends: Add #input_format FAPI property that can be used by WYSIWYG editors. WOOHOO. 2008-09-27 19:47:43 +00:00
Angie Byron 1fc0b924f2 #313044 by Amitaibu: Remove silly assertion. 2008-09-24 22:38:20 +00:00
Angie Byron 804b313a85 #296486 by lyricnz and boombatower: Tests for viewing an individual comment. 2008-09-19 03:11:53 +00:00
Angie Byron c32c0f517f #296487 by lyricnz and beeradb: Tests to make sure comment posting fails when it should. 2008-09-19 03:00:10 +00:00
Angie Byron 893942bb4f #108979 by ewhipple, catch, and sun: Order permissions consistently, keep node type related permissions together. 2008-09-17 20:37:32 +00:00
Dries Buytaert 7f29b14277 - Patch #305645 by pwolanin: ['REQUEST_TIME'] -> REQUEST_TIME. Improved developer experience. 2008-09-17 07:11:59 +00:00
Angie Byron 54d2daec35 #302396 follow-up by catch: Fix typo in tests. 2008-09-09 00:29:24 +00:00
Dries Buytaert b6fd223d1a - Patch #302396 by chx, catch: made some tests more granular so they an be run in parallel or stand-alone. 2008-09-08 21:37:21 +00:00
Dries Buytaert e5b0e5f76c - Patch #302763 by Dave Reid, Rob Loach: replace time() by ['REQUEST_TIME'] as per Rasmus' suggestion. Removed drupal_referrer() for consistency. 2008-09-06 08:36:22 +00:00
Dries Buytaert 69e6f411a9 - Patch #225450 by Crell, chx, bjaspan, catch, swentel, recidive et al: next generation database layer for Drupal 7. 2008-08-21 19:36:39 +00:00
Dries Buytaert d9c682e6af - Patch #66264 by boombatower: fixed typo in title. 2008-08-14 19:42:26 +00:00
Dries Buytaert 6f167edd7c - Patch #187061 by Rob Loach: give feedback when a comment was posted. 2008-08-03 18:52:27 +00:00
Dries Buytaert aade5fbf24 - Patch #237636 by marcingy: comment status field should match node status field. 2008-08-02 20:29:43 +00:00
Dries Buytaert 57fe5103da - Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value. 2008-07-16 21:59:29 +00:00
Dries Buytaert 1415340ce3 - Patch #191499 by catch: remove display order settings and cleaned up some white space. 2008-07-03 17:57:03 +00:00
Dries Buytaert 81c71bc891 - Patch #216515 by chx, Damien Tournoud, et al: fixed form API glitch with caching. 2008-06-24 17:01:33 +00:00
Dries Buytaert 928822d0a9 - Patch #272054 by David Rothstein: fixed code comment for comment_form(). 2008-06-20 16:52:55 +00:00
Dries Buytaert 95c66fa9fb - Patch #272848 by catch: update comment settings form help text. 2008-06-20 16:45:27 +00:00
Dries Buytaert 61cc35f2b0 - Patch #255918 by R.Muilwijk: performance improvement: comment_link querying for already retrieved data. 2008-06-18 16:06:42 +00:00
Dries Buytaert 6e2358b232 - Patch #270045 by drewish, Susurrus: clean up return values. 2008-06-18 03:36:24 +00:00
Dries Buytaert d8ff9967e6 - Patch #250729 by R.Muilwijk: fixed typo. 2008-06-17 00:52:00 +00:00
Dries Buytaert cf42d0c25a - Patch #250729 by R.Muilwijk: removed unnecessary SQL query. 2008-06-14 16:02:50 +00:00
Dries Buytaert 201e1dd356 - Patch #268449 by catch: fixed some tests that failed due to invalid permissions. 2008-06-09 16:33:20 +00:00
Dries Buytaert 5ed9cf76a0 - Patch #253577 by Morbus Iff: allow new comment timestamp to be passed. 2008-06-09 07:07:36 +00:00
Dries Buytaert dc613626d4 - Patch #266465 by R.Muilwijk: fixed the comment module tests. 2008-06-05 17:57:04 +00:00
Dries Buytaert 3f052180dc - Patch #66264 by boombatower: comment approval displayed on node view of comment. Comes with tests and everything. 2008-06-03 16:30:20 +00:00
Dries Buytaert c6c26b5e23 - Patch #247423 by boombatower: code style fixes for the tests. 2008-05-30 07:30:53 +00:00
Dries Buytaert 8cc4aaeeae - Patch #258171 by Senpai: code cleanup. 2008-05-14 13:12:41 +00:00
Dries Buytaert 11aeff6016 - Patch #145242 by douggreen et al: refactor node_rank to modules can add scoring factors. 2008-05-14 11:10:54 +00:00
Dries Buytaert 2e18cb8924 - Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit
et al.  Can you say 'registry'?  Drupal now maintains an internal registry of
  all functions or classes in the system, allowing it to lazy-load code files as
  needed (reducing the amount of code that must be parsed on each request). The
  list of included files is cached per menu callback for subsequent loading by
  the menu router. This way, a given page request will have all the code it needs
  but little else, minimizing time spent parsing unneeded code.
2008-05-06 12:18:54 +00:00
Dries Buytaert d1bc889242 - Patch #227830 by JohnAlbin: link attributes added to l() incorrectly. 2008-05-02 15:11:05 +00:00
Dries Buytaert 159bb6dd08 - Rollback. 2008-04-25 18:34:05 +00:00
Dries Buytaert d7f3c18d17 - Patch #250729 by R.Muilwijk: performance improvement. 2008-04-25 17:59:36 +00:00
Dries Buytaert 21576021bf - Patch #249546 by pwolanin: rip menu access inheritance -- was already committed to D6. 2008-04-23 20:01:56 +00:00
Dries Buytaert d1779405d2 - Patch #249941 by John Morahan: fixed incorrect parameters of watchdog() calls. 2008-04-23 18:05:58 +00:00
Dries Buytaert af474609e3 - Added a test framework to Drupal along with a first batch of tests for
Drupal core!  This is an important milestone for the project so enable
  the module and check it out ... :)

  Thanks to Rok Žlender, Károly Négyesi, Jimmy Berry, Kevin Bridges, Charlie
  Gordon, Douglas Hubler, Miglius Alaburda, Andy Kirkham, Dimitri13, Kieran
  Lal, Moshe Weitzman, and the many other people that helped with testing
  over the past years and that drove this home.

  It all works but it is still rough around the edges (i.e. documentation
  is still being written, the coding style is not 100% yet, a number of
  tests still fail) but we spent the entire weekend working on it in Paris
  and made a ton of progress.  The best way to help and to get up to speed,
  is to start writing and contributing some tests ... as well as fixing
  some of the failures.

  For those willing to help with improving the test framework, here are
  some next steps and issues to resolve:

    - How to best approach unit tests and mock functions?
    - How to test drupal_mail() and drupal_http_request()?
    - How to improve the admin UI so we have a nice progress bar?
    - How best to do code coverage?
    - See http://g.d.o/node/10099 for more ...
2008-04-20 18:24:07 +00:00
Dries Buytaert 46546ef478 - Patch #175841 by catch et al: remove comment controls for users. Yowza. 2008-04-16 11:26:29 +00:00
Dries Buytaert 56d2664a90 - Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators. 2008-04-14 17:48:46 +00:00
Dries Buytaert 79b016d915 - Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php.  The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:

    block-user-0.tpl.php --> block-user-navigation.tpl.php
    block-user-1.tpl.php --> block-user-login.tpl.php

  You get the picture.
2008-04-10 10:28:23 +00:00
Dries Buytaert 23602afbe1 - Patch #195072 by webchick and coltrane: make _comment_load() a public API function by renaming it to comment_load(). 2008-04-10 10:13:57 +00:00
Dries Buytaert 91824358be - Patch #216504 by webchick et al: added missing table alias in comment_render function. 2008-04-10 01:45:38 +00:00
Dries Buytaert 1dfd1717c1 - Patch #240387 by matt2000 et al: move 'content types' to 'site building' per the UMN usability study results. 2008-04-06 18:50:12 +00:00
Dries Buytaert f5d4287cd5 - Patch #214271 by recidive: improved schema identation. 2008-03-15 12:31:29 +00:00
Dries Buytaert 33853f6d9c - Patch #228120 by jvandyk: fixed code comment. 2008-03-10 18:25:48 +00:00
Dries Buytaert 6030a5b2e4 - Patch #81931 by keith.smith: improved wording of help text. 2008-02-23 08:02:48 +00:00
Dries Buytaert 657935c263 - Patch #81931 by webchick et al: made the recent comments block configurable. Somme minor changes by me. 2008-02-21 19:38:07 +00:00
Dries Buytaert 584f3e886a - Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page. 2008-02-20 13:46:43 +00:00
Dries Buytaert b05db1f176 - Patch #221384 by webernet: update core compatibility to Drupal 7. 2008-02-18 19:19:49 +00:00
Dries Buytaert b8a1eab1fb - Patch #210131 by dvessel, catch, John, et al: updated jQuery library. 2008-02-06 19:38:28 +00:00
Gábor Hojtsy 85cae0d01a #204411 by chx, slightly modified: heal a possible MySQL import error when the anonymous user becomes broken 2008-01-25 16:19:13 +00:00
Gábor Hojtsy 7f85bc5bc4 #208938 by bjaspan, scor: use schema PI for index updates instead of database dependent code 2008-01-16 21:45:30 +00:00
Gábor Hojtsy c5aa55b38e #204705 by pwolanin: abort user_save on SQL errors, to avoid data corruption 2008-01-10 15:03:53 +00:00
Gábor Hojtsy b78a990270 #207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks 2008-01-08 10:35:43 +00:00
Dries Buytaert 7127adabb0 - Patch #205465 by jvandyk: add missing index on comment table. 2008-01-05 22:45:40 +00:00
Gábor Hojtsy 258b576020 #199809 by theborg: comment templates were not checking status properly (fix notice, allows themes to theme in-preview comments differently) 2008-01-04 19:24:24 +00:00
Gábor Hojtsy a555202276 #195161 follow up by keith.smith: fix typo in code comment 2008-01-04 15:11:59 +00:00
Gábor Hojtsy 9bc7c07cb7 #195161 by mcarbone with some modifications: only show 'login to post comments' if logging in actually lets you post comments 2008-01-04 11:34:19 +00:00
Dries Buytaert a88c178b91 - Patch #204221 by webernet: code style fixes. 2007-12-28 12:02:52 +00:00
Gábor Hojtsy 1d4fc1b1af #202473 by keith.smith: pre-RC1 spell checking on hopefully final text 2007-12-19 21:40:05 +00:00
Gábor Hojtsy fcbd175337 #189878 by O Govinda, keith.smith: comment module help updates, removing help on features which are not there, and adding help on Drupal 6's new per content type comment settings 2007-12-19 19:17:20 +00:00
Gábor Hojtsy d17b6ad1cf #199336 by JirkaRybka: remove improper t() use in update code (update goes all in English, but there were some mistakes), and add messages to updates where there was no return value otherwise, so users know what happens in each update 2007-12-19 10:34:51 +00:00
Dries Buytaert b339b47fc0 - Patch #199510 by Pancho: fixed form API conversions. 2007-12-18 22:16:55 +00:00
Dries Buytaert c8b1ddf26a - Patch #164532 by catch, pwolanin, David Strauss, et al.: improve table indicies for common queries. 2007-12-18 12:59:22 +00:00
Gábor Hojtsy 191beee5fa #194310 follow up by chx and myself: only load comment module when we can actually do it, and when we need it in comment.install 2007-12-17 16:26:12 +00:00
Gábor Hojtsy dfe1225147 #194310 by chx, catch, KarenS: run updates for disabled but previously installed modules, if they are compatible with the current system 2007-12-17 12:23:01 +00:00
Gábor Hojtsy b7a2becd15 #197314 by vitezslav.smid (as GHOP 39): improve/add/update phpdoc in aggregator, comment and system modules 2007-12-16 21:01:45 +00:00
Gábor Hojtsy b6532a4fdb #200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed 2007-12-14 18:08:50 +00:00
Gábor Hojtsy c6d841c096 #197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc 2007-12-13 09:34:40 +00:00
Gábor Hojtsy 5622bce2d5 #198579 by webernet and hswong3i: a huge set of coding style fixes, including:
- whitespaces at end of lines
 - indentation
 - control structure usage
 - whitespace in empty lines
 - phpdoc comment formatting
2007-12-08 14:06:23 +00:00
Gábor Hojtsy d83289f857 #196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions 2007-12-06 09:58:34 +00:00
Gábor Hojtsy 259e2f5c7e #195678 by catch: standardise on Save and Preview button terminology (for comments) and button placement for comments and nodes, so Save is always the leftmost button, and there is no guessing to find it 2007-11-29 11:54:37 +00:00
Gábor Hojtsy f77b60f291 #195543 by hass and yhager: CSS inherit was completely misused in RTL CSS files 2007-11-27 12:09:27 +00:00
Gábor Hojtsy 22a4c039da Rollback the accidentally committed #194310 2007-11-26 19:55:15 +00:00
Gábor Hojtsy e6a88be5d1 #193333 by quicksketch et al: taxonomy drag and drop support 2007-11-26 19:46:52 +00:00
Gábor Hojtsy c856eac135 #191104 by keith.smith: (usability) change occurances of node to 'post' and 'content' as appropriate 2007-11-12 19:06:33 +00:00
Dries Buytaert beb7cfa80e - Patch #190483 by webernet et al: tiny code cleanup. 2007-11-09 07:46:10 +00:00