Dries Buytaert
ce9c92ef4f
- Patch #191544 by Crell: split up profile module. Tested by catch.
2007-11-13 12:28:36 +00:00
Gábor Hojtsy
a0c920badf
#140377 by tostinni: provide a default weight to new profile fields, so they will not be saved with -5
2007-10-24 13:27:12 +00:00
Gábor Hojtsy
ed1a53698a
#180897 by sun and dvessel: fix various XHTML validity issues in Drupal by closing unclosed tags, avoiding empty table containers, and so on
2007-10-11 09:51:29 +00:00
Gábor Hojtsy
8cf6fefe54
#164983 by multiple contributors: document the core database schemas
2007-10-10 11:39:35 +00:00
Dries Buytaert
39706e3c51
- Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes.
2007-10-05 14:43:26 +00:00
Gábor Hojtsy
25465ee76e
#176503 by chx and bennybobw: hidden profile fields cannot be required and cannot be put on the registration form, so we needed warnings on the editing form to not let admins save forms set with these combinations.
2007-10-05 13:26:53 +00:00
Dries Buytaert
b0493c003c
- Patch #173303 by dvessel: fixed E_NOTICE.
2007-09-05 18:11:27 +00:00
Gábor Hojtsy
4072667666
#170546 by ChrisKennedy: fix 7 E_ALL notices in profile module
2007-09-01 06:15:33 +00:00
Dries Buytaert
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
Dries Buytaert
74292cd062
- Patch #80951 by killes, yched et al: block caching.
2007-08-19 08:08:45 +00:00
Gábor Hojtsy
626b757308
#165775 by hswong3i: profile name field has a unique key, so it should not allow NULL as a value
2007-08-09 11:05:40 +00:00
Gábor Hojtsy
f23c24c8a3
#164935 by Ralf Stamm: standardize CVS Id tags in files:
...
- always include CVS Id tags in all files
- add a new line after the CVS Id, if more code or phpdoc follows in the same code block
- fix bogus Id tags previously added
2007-08-07 08:39:36 +00:00
Dries Buytaert
99276849da
- Patch #162134 by dvessel: tplify profile module.
2007-08-02 10:36:42 +00:00
Gábor Hojtsy
0d86b33282
#161142 by dvessel: kill notice on profile page when there are less then three components in the path
2007-07-26 08:49:11 +00:00
Gábor Hojtsy
b9c40a5237
#114103 by adixon and webchick, slightly modified: custom profile fields show above built-in account fields
2007-07-05 08:38:58 +00:00
Dries Buytaert
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Gábor Hojtsy
9e6ef53c2c
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
2007-06-30 19:46:58 +00:00
Gábor Hojtsy
2da0d41ac2
#123577 by spatz4000 (originally by tostinni for Drupal 5): do not allow hidden profile fields to be browsed by non-admins
2007-06-28 00:29:05 +00:00
Steven Wittens
569ede574f
#115139 : Add centralized json handler (and send text/javascript content-type header).
2007-06-22 08:46:16 +00:00
Steven Wittens
fe8b35f527
#153781 : Convert all remaining confirm_forms() to deletion api.
2007-06-22 08:32:28 +00:00
Steven Wittens
e7d31327cf
#144397 : Use drupal_render for user profiles and convert to themer-friendly .tpl.php files.
2007-06-21 04:38:41 +00:00
Dries Buytaert
50197a8abc
- Patch #145647 by spatz4000: unneeded fields in profile SQL query.
2007-06-15 21:48:02 +00:00
Dries Buytaert
b0f759516a
- Patch #150344 by webernet: language fixup.
2007-06-09 07:25:15 +00:00
Dries Buytaert
29eb5a6284
- Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version.
2007-06-08 05:50:58 +00:00
Dries Buytaert
e629deb94d
- Patch #146667 by Jeff Eaton: form API fixes.
2007-06-04 15:56:34 +00:00
Dries Buytaert
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
Dries Buytaert
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
Dries Buytaert
3cafffe63f
- Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave.
2007-05-25 12:46:46 +00:00
Dries Buytaert
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00
Dries Buytaert
7d4f2836ba
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
2007-04-30 17:03:29 +00:00
Dries Buytaert
f73610bec6
- Patch #76588 by Gabor: made log messages translatable. Yay.
2007-04-24 13:53:15 +00:00
Dries Buytaert
2127487be3
- Patch #121425 by Chris Bray: fixed capitalization glitch.
2007-04-23 17:02:17 +00:00
Dries Buytaert
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
Dries Buytaert
dd30a14208
- Patch #119114 by edkwh: profile fields incorrectly saved.
2007-03-30 09:38:13 +00:00
Steven Wittens
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
Dries Buytaert
a1e6728a46
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-02-11 09:30:51 +00:00
Dries Buytaert
4980327172
- Patch #115315 by kkaefer: fixed autocomplete for users.
2007-02-02 15:25:25 +00:00
Dries Buytaert
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
Dries Buytaert
03752e35a4
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
2007-01-24 14:48:36 +00:00
Dries Buytaert
35fa510657
- Patch #108731 by add1sun: code cleanup.
2007-01-23 19:09:46 +00:00
Steven Wittens
7f2a4fbfc5
#108379 : Faster profile field validation (eregi to preg_match)
2007-01-11 03:31:18 +00:00
Steven Wittens
8bd8a97282
#108366 : Fix type on profile help.
2007-01-11 03:16:50 +00:00
Dries Buytaert
74e3c74b81
- Always check the username.
2007-01-10 15:17:51 +00:00
Dries Buytaert
58de01883a
- Patch #105216 by dww: profiles where no longer being themed due to missing CSS.
2006-12-27 12:55:52 +00:00
Steven Wittens
212a038129
#102871 : Fix profile.module fields that appear on registration page
2006-12-13 23:50:26 +00:00
Steven Wittens
b86f45b1e6
#100516 : CSS preprocessor to cache and compress all .css files. Benchmarks show up to 40% faster page loads.
2006-12-10 09:54:35 +00:00
Dries Buytaert
039453164e
- Patch #101546 by webchick: added PHPdoc comments.
2006-12-07 16:53:56 +00:00
Steven Wittens
47f527fbbe
Fixing commit of #100563 (thanks webernet)
2006-12-01 23:17:26 +00:00
Steven Wittens
0ea4e1c5f6
#100563 : Conditional loading of (some) module.css files
2006-12-01 22:47:53 +00:00
Dries Buytaert
54190b5605
- stray files
2006-11-28 14:37:44 +00:00
Neil Drumm
b5bf8a8f47
#97824 by Gurpartap. Move enclosing elements outside of their t().
2006-11-26 02:20:01 +00:00
Dries Buytaert
6ae6dc0d85
- Patch #87298 by webchick, neil, dww et al: show version numbers on modules page.
2006-11-21 20:55:36 +00:00
Dries Buytaert
b004f328ee
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
2006-11-21 20:14:19 +00:00
Dries Buytaert
ab43e83eb4
- Patch #88402 by chx et al: made it possible to remove profile field.
2006-11-12 19:33:30 +00:00
Steven Wittens
6ffdf055d9
Add missing array keys to fields when building user profile view, to make hook_profile_alter() use more consistent.
2006-11-03 01:35:17 +00:00
Kjartan Mannes
e070e83238
- Patch #90662 by hunmonk: profile registration fields broken for user admins
2006-10-22 17:47:51 +00:00
Steven Wittens
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
Dries Buytaert
97568421b9
- Patch #89823 by jvandyck: removed unused line of code
2006-10-18 11:37:51 +00:00
Dries Buytaert
64a24732f7
- Modified patch #89405 by hiweed: fixed SQL error in profile module.
2006-10-17 18:54:54 +00:00
Dries Buytaert
2b4a7762ea
- Patch #87540 by MikalH: don't show blocked users on profile pages.
2006-10-12 20:12:11 +00:00
Dries Buytaert
18b297abf8
- Patch #81740 by merlinofchaos, webchick, moshe, neclimdul et al: added package support to the modules page.
2006-10-05 15:47:57 +00:00
Steven Wittens
b7071b6c2c
#79052 : Category name cannot contain ampersands
2006-10-04 20:28:41 +00:00
Dries Buytaert
35c33e3cf5
- Patch #83222 by edkwh: more theme('placeholder') clean-up. Good catch.
2006-09-09 08:25:24 +00:00
Dries Buytaert
d5af416e06
- Patch #48344 by Tobias: fixed type in profile_browse().
2006-09-04 14:33:26 +00:00
Neil Drumm
94098f7e93
#81033 by webchick and neclimdul. Uninstall module API.
2006-09-01 07:40:08 +00:00
Dries Buytaert
c64db1da29
- Patch #80952 by earl, webchick, neclimdul et al: .info files
2006-08-31 20:22:37 +00:00
Dries Buytaert
92a01e2057
- Patch #79476 by assimonds and webchick: fixed broken t()-iness.
...
CVS: ----------------------------------------------------------------------
2006-08-20 07:07:17 +00:00
Dries Buytaert
7178f2f99e
- Patch #79428 by Chris Johnson: remove int display width declarations from MySQL create table statements.
2006-08-20 06:38:50 +00:00
Dries Buytaert
7de41539df
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
2006-08-18 18:58:47 +00:00
Steven Wittens
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Dries Buytaert
e7982b3815
- Patch #69228 by openwereld: profile field values that should be browse-able (clickable) are not displayed as such.
2006-08-18 07:43:44 +00:00
Neil Drumm
bf3487c0b1
#76681 by sammys, sync posgres install and change unsigned annotation.
2006-08-15 05:25:20 +00:00
Neil Drumm
3cc2b1e3d7
#77183 by m3avrck and timcn, split up drupal.css by module.
2006-08-14 07:14:50 +00:00
Dries Buytaert
729fa6c11b
- Patch #77422 by timcn: corrected various paths in the documentation.
2006-08-07 15:04:16 +00:00
Neil Drumm
4b4a398605
#77179 by asimmonds, don't execute both MySQL and Postgres quesries on install of a couple modules.
2006-08-06 23:13:46 +00:00
Neil Drumm
cd430165d7
#73884 by RobRoy, various code cleanup.
2006-08-05 00:26:36 +00:00
Dries Buytaert
a7f67e01de
- Patch #76681 by sammys: PostgreSQL support for install system. Woot! :)
2006-08-04 06:58:44 +00:00
Dries Buytaert
b138793b68
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
2006-07-31 11:25:55 +00:00
Neil Drumm
7d9f57ff63
#73591 by Flanker, add missing CVS Ids.
2006-07-14 01:05:10 +00:00
Dries Buytaert
1c75a210bd
- Patch #68926 by chx, jeremy, steven, eaton, webchick, amazon, neil, nedjo et al: an initial install system for Drupal core.
2006-07-13 13:14:25 +00:00
Dries Buytaert
58752cfaa2
- Patch #72284 by me:
...
+ reorganized ?q=admin/settings
+ deprecated the _settings hook
2006-07-10 19:27:52 +00:00
Dries Buytaert
e93f8be871
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
2006-07-05 11:45:51 +00:00
Neil Drumm
451f44c4f0
#71772 by Bart Jansens, fix various php warnings
2006-07-02 20:06:31 +00:00
Dries Buytaert
bddd9aeb6f
- Patch #51506 by gordon: new feature: added auto-complete functionality to user profiles.
2006-05-12 08:50:22 +00:00
Dries Buytaert
33cac6420d
- Patch #61952 by Matt: usability improvement: add auto-complete functionality on the profile configuration patch.
2006-05-05 09:25:21 +00:00
Dries Buytaert
d071f99172
- Removing trailing whitespace.
2006-04-17 20:48:26 +00:00
Steven Wittens
506c80bdb9
#58568 : Multiple profile selection boxes repeat items
2006-04-13 13:21:15 +00:00
Gerhard Killesreiter
badeac698c
#58239 , required profile list not required, patch by Dries K
2006-04-11 13:02:04 +00:00
Steven Wittens
e1c749fac4
#56930 : Custom values fall through on user listing (tenrapid)
2006-04-04 23:04:58 +00:00
Gerhard Killesreiter
4a10595248
#55797 , consistency in author block, patch by dww
2006-04-04 07:03:07 +00:00
Steven Wittens
2e3826ad7c
#56656 : Make browsing profiles by value more consistent and usable.
2006-04-04 06:56:34 +00:00
Steven Wittens
616840245b
#56750 : Make date profile field work with ISO date format
2006-04-04 06:52:59 +00:00
Gerhard Killesreiter
4a68748802
#56682 , missing t() in profile.module, patch by Goba.
2006-03-31 11:49:16 +00:00
Gerhard Killesreiter
5885925b0d
#53348 , Handling of deleted/blocked user accounts, patch by jreyero and Zen
2006-03-26 19:31:00 +00:00
Gerhard Killesreiter
d25fa75e2b
#55788 , author block configure page should only show public fields, patch by dww
2006-03-25 11:07:54 +00:00
Gerhard Killesreiter
d8ee6e0d4e
#55040 , Author block doesn't obey settings, patch by dww
2006-03-24 14:43:35 +00:00
Gerhard Killesreiter
e9985c2195
#55640 , change string comparion on $_GET[q] to arg(), patch by Robert Douglass.
2006-03-24 13:12:44 +00:00
Gerhard Killesreiter
fd99435941
#53628 , postscriptum to Profile module: fapi conversion + minor fixes, patch by Zen
2006-03-18 01:38:29 +00:00
Gerhard Killesreiter
5db4a65da3
#53628 , Profile module: fapi conversion + minor fixes, patch by Zen
2006-03-17 18:39:29 +00:00
Gerhard Killesreiter
80e53f26c6
#53628 , reformatting of profile.module. Patch by Zen.
2006-03-12 14:08:55 +00:00
Steven Wittens
d29d596674
- Reverting accidental commit
2006-03-10 15:13:21 +00:00
Steven Wittens
9c944c2d58
- Code cleanup
2006-03-10 15:11:07 +00:00
Dries Buytaert
47cf9dd9fb
- Patch #46746 by Matt: fixed inconsistent encoding of path aliases. Fixes broken URLs on profile pages.
2006-03-03 08:46:09 +00:00
Dries Buytaert
f63bb3a3f1
- Patch #38578 by Zen: field->id -> field->fid.
2006-02-26 19:46:13 +00:00
Dries Buytaert
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
Dries Buytaert
cf5475a7e1
- Patch #41509 by munga: setting profile field to hidden does not remove it from the user edit form. (Today's critical bugfix #2.)
2006-02-21 08:41:42 +00:00
Dries Buytaert
eeae26b227
- Patch #49132 by Tobias and Zen: fixed problem with profile fields being mangled.
2006-02-16 15:29:46 +00:00
Dries Buytaert
8b8a585ab2
- Patch #44724 : fixed problem with profile.module.
2006-01-30 18:32:24 +00:00
Dries Buytaert
d958fad0d6
- Patch #40200 by Ax, Drewish, Zen et al: user_view() isn't merging view items correctly + CSS cleanup + form handling cleanup.
2006-01-26 13:43:04 +00:00
Dries Buytaert
53a2ca41b4
- Patch #23538 by Zen: mark required fields are being required. The new forms API will enforce this too. :)
2006-01-25 08:52:47 +00:00
Dries Buytaert
542e6e0d22
- Patch #33102 by Kobus et al: show dates properly.
2006-01-22 07:37:17 +00:00
Dries Buytaert
155aff37d7
- Patch #44490 by darius: don't show blocked users on the profile pages.
2006-01-13 15:54:05 +00:00
Dries Buytaert
08098a34f3
- Patch #43989 by darius: critical bugfix: removed debug code from profile module.
2006-01-10 12:22:18 +00:00
Dries Buytaert
68ced8da59
- Patch #24678 by jmengle, DriesK, Richard et al: bugfix: deleting a profile field doesn't delete values in profile_values table.
2006-01-08 12:06:13 +00:00
Dries Buytaert
9d1d40e609
- Patch #39639 by Richard: 'users' appearing twice in menu.
2006-01-06 07:42:31 +00:00
Steven Wittens
b43fa0f9da
- #41744 : global urlencode() for menu paths
2005-12-22 22:58:12 +00:00
Dries Buytaert
21707ae0e6
- Modified patch #41120 by chx: profile category 'account' overwrites regular user fields.
2005-12-15 16:34:48 +00:00
Dries Buytaert
4b9cd4fcd6
- Patch #38820 by wtanaka: profile listing carries over people's data on subsequent users.
2005-12-03 17:12:56 +00:00
Steven Wittens
a5c43ec402
- #37956 : Respect weighting in profile browse pages
...
- Fix non-pgsql compliant ORDER BY queries
- Clean up ugly section that used db_escape_string()
2005-11-24 20:54:22 +00:00
Dries Buytaert
86db338c64
- Patch #/38339 by crunchywelch: make the profile module display fields properly.
2005-11-23 10:43:30 +00:00
Dries Buytaert
61ebf7b56b
- Patch #37401 by webchick: fixed dependency of date selection form element on profile module.
2005-11-21 09:42:14 +00:00
Dries Buytaert
30059b1a59
- Patch #34514 by darius: fixed forms API glitches.
2005-11-13 08:33:44 +00:00
Dries Buytaert
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
Dries Buytaert
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
Steven Wittens
f31db8d70f
- #22850 : Search query containing / results in 404 on clean URLs.
2005-10-21 11:14:55 +00:00
Steven Wittens
5f0e0f3649
- #33433 : More form API fixes, and error handling improvements by Chx.
2005-10-13 10:02:31 +00:00
Dries Buytaert
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
Dries Buytaert
a1ae4da70b
- Removing tabs and trailing whitespaces.
2005-10-07 06:51:43 +00:00
Dries Buytaert
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert
125fa0189e
- Patch #31585 by Thox: fixed author information block.
2005-09-19 14:59:44 +00:00
Dries Buytaert
4005922332
- Patch #31123 by Ber: make it easier to theme the user profile pages.
2005-09-14 21:16:00 +00:00
Dries Buytaert
f3cb254cb7
- Patch #23536 by chx: custom registration fields should appear on admin/user/create.
2005-09-08 19:32:31 +00:00
Dries Buytaert
e6f4f5ab14
- Patch #27949 by Robert: the two theme functions in profile.module both violate good theming practice by running user control logic in the middle of them. Worse yet, this isn't immediately visible since it happens in yet another function. Thus themers overriding these functions to style profile pages inadvertently break access control, thus leading to the misperception that overriding theme functions is inherently dangerous.
2005-09-06 20:39:10 +00:00
Dries Buytaert
d57db29ee3
- Patch #27948 by Robert Douglas: fixed problem with author information block.
...
(Looks like MySQL rewrites ORto IN() internally.)
2005-09-06 19:05:10 +00:00
Dries Buytaert
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
Dries Buytaert
f3b28d37d1
- Patch #27947 by Robert Douglas: simplified code, removed SQL query.
2005-08-10 20:52:00 +00:00
Dries Buytaert
63a10fdce8
- Bug 23810: removed redundant variable from SQL query.
2005-08-10 20:48:40 +00:00
Dries Buytaert
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
Steven Wittens
e4096e1418
- #27551 : Rename check_output() to check_markup(). Needs contrib updates!
2005-07-29 21:06:33 +00:00
Dries Buytaert
58aee8cdad
- Patch #25603 by Stefan: made the sizes of forms consistent.
...
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert
8436082fe1
- Removing some whitespace
2005-06-06 14:07:04 +00:00
Steven Wittens
1a3f0ddb86
- #23685 : urlencode() profile field names and values in the URL (any dynamic data in an url should be urlencoded to prevent characters like # and & from being interpreted by the browser/server).
2005-06-01 04:29:57 +00:00
Dries Buytaert
229e2e4f23
- Bugfix: changed -> access
2005-05-12 16:20:36 +00:00
Dries Buytaert
4d80b374e9
- Modified patch #21617 by Robin: added confirmation screen to delete profile fields. (I tidied up the coding style and fixed two typos.)
2005-05-01 09:41:23 +00:00
Dries Buytaert
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
Dries Buytaert
0fb6af111e
- Fixed broken query
2005-04-21 18:49:06 +00:00
Dries Buytaert
05e9c8c76c
- Patch #12737 by pyromanfo: added support for private profile fields.
2005-04-18 20:58:39 +00:00
Dries Buytaert
a2e0957bbb
- Modified version of patch #20115 by Nedjo: added author information block.
...
I rewrote part of the patch to improve the themability of the block, as
well as its default look. I also left out the 'Recent posts' for now and
shuffled some code around.
2005-04-18 20:37:32 +00:00
Steven Wittens
23bccfd1c8
- #4166 : Respect 'access userlist' permission for profile data.
2005-04-11 22:48:27 +00:00
Dries Buytaert
a3e9b35afc
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
2005-04-01 15:55:02 +00:00
Steven Wittens
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
Steven Wittens
c3f1f7345e
- #18939 (Stefan): Always use paragraph tags around page help text.
2005-03-18 07:07:04 +00:00
Steven Wittens
cc3fd1715f
- #16271 : Clean up Admin - users - configure.
2005-01-28 20:49:00 +00:00
Dries Buytaert
696ac8a9d8
- Patch #15937 by wulff: made it so that titles of profile fields only need to be unique within a single category.
2005-01-24 21:39:58 +00:00
Dries Buytaert
fe58724f25
- Small bugfix + small improvement.
2005-01-04 19:52:33 +00:00
Dries Buytaert
2b17b3a966
- Patch #13907 by Neil: less ways to set the page title.
...
* Less logic in theme code.
* Encourages use of the menu system.
* Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
* Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert
3d491defbd
- Patch #14035 by Goba: fixed problem with UTF-8 conversion when mixing LOWER() and strtolower().
2004-12-07 17:42:35 +00:00
Dries Buytaert
fa97839088
- Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
...
Read the manual for pg_escape_string: "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
Dries Buytaert
869a91b72e
- Patch #11505 by Steven: 'my account' information is not saved.
...
+ Drupal 4.4 stored profile data in the serialized user->data column. Drupal 4.5 stores profile data in tables (but user->data is still available and used for other stuff, like locale or themes). The update from 4.4 to 4.5 didn't remove the old data from the user->data column properly, because there is no mechanism in user_save to do so (it did try to unset the fields, but this has no effect).
+ On registration, hook_user('insert') is invoked after saving the data column. This means that any module-specific data is put into the data field. We cannot move hook_user('insert') higher up, because before that point, we do not have a complete $user object yet.
2004-10-16 16:59:59 +00:00
Steven Wittens
aaa214e4a8
#6595 : Unifying profile.module textbox widths with user.module.
2004-10-13 20:35:46 +00:00
Steven Wittens
c6281c464c
Profile.module: removing incorrect use of strtolower which messes up UTF-8 data.
2004-09-20 23:42:11 +00:00
Dries Buytaert
2b9aaf7159
- Bugfix: making changes to the user profiles should flush the cache.
2004-09-19 13:33:08 +00:00
Dries Buytaert
6dbd0bcfb4
- Patch #6500 by Mathias with help from Steven: made it possible to add fields to the registration form. This feature used to exist.
2004-09-19 13:28:11 +00:00
Dries Buytaert
5c7983c4de
- Patch #8179 by JonBob: reintroduced menu caching.
2004-09-16 07:17:56 +00:00
Dries Buytaert
94e30bf776
- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
2004-08-21 06:42:38 +00:00
Dries Buytaert
fa25c7a0ca
- Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
2004-08-19 15:41:57 +00:00
Dries Buytaert
83a739bd89
- Code improvements by Stefan: made all status messages consistent (and easier to translate).
2004-08-18 19:57:27 +00:00
Steven Wittens
6a380525d4
#10012 - Profile.module:
...
- Restoring broken update path.
- Adding birthday/date function back, with update path.
- Show private fields when viewing your own profile, or for admins.
- Do not allow browsing of private fields for non admins (403)
- Throw a 404 for browsing unbrowsable fields, rather than an SQL error
- Fixing input processing: nothing is filtered twice anymore, and I replaced several strip_tags with specialchars (more flexible).
- Minor admin UI tweaks + added friendly field type names.
2004-08-14 11:54:31 +00:00
Dries Buytaert
d4a8bd5877
- Modified patch #9924 by njivi: added a basic member list to the profile module. (If this deprecates the memberlist module, it ought to be deprecated.)
...
I removed the permission njivi introduced and made the page title match the link title.
2004-08-12 22:03:31 +00:00
Dries Buytaert
4cad8d5c31
- Patch #9865 by njivy: avoid mangling %'s in the profile SQL query.
2004-08-09 05:40:16 +00:00
Dries Buytaert
90581e7349
- Patch #9866 by njivy: when the links are generated for each item in a list-type profile field, double quotes in the item name can break the link. To fix this, this patch gives drupal_specialchars() the ENT_QUOTES parameter to convert quotes into HTML entities. This fix is also applied to selection-type profile fields which can have the same problem.
2004-08-08 16:19:32 +00:00
Dries Buytaert
702a057683
- Patch #9478 by JonBob: allow printf-style arguments in pager_query.
...
Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
2004-07-25 14:25:42 +00:00
Dries Buytaert
ac5b5616c0
- More tab-improvements by JonBob: improved support for the default tabs!
2004-07-10 15:51:48 +00:00
Dries Buytaert
bf42dddea7
- Usability improvement: users can also separate 'list items' (i.e. favorite
...
movies) using a comma. Only few users actually read the form description,
it seems ...
2004-07-08 15:17:21 +00:00
Dries Buytaert
fe2b3e7c00
- Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
...
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
* The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Steven Wittens
72155f8bbf
Using drupal_specialchars() instead of htmlentities(). htmlentities() is not UTF-8 safe.
2004-06-27 22:09:12 +00:00
Dries Buytaert
1b1c47025a
I refactored quite a bit of the user.module:
...
$ diffstat user.patch
database/database.mysql | 4
database/database.pgsql | 2
database/updates.inc | 10 -
modules/block.module | 20 +-
modules/locale.module | 9
modules/profile.module | 108 +++++++----
modules/system.module | 8
modules/user.module | 456 +++++++++++++++++++-----------------------------
8 files changed, 289 insertions(+), 328 deletions(-)
More functionality, less code. Here is a list of the changes:
- Some user API changes:
+ When $type is 'form', you have to return an associative array of groups. In turn, each group is an array with a 'title', 'data' and 'weight'.
+ A new $type has been added, namely 'categories'. User settings can be organized in categories. Categories can be sorted, as can the groups within a category. (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
- The 'my account > edit' page will use subtabs for each 'category'. Read: you can break down the account settings into multiple subpages.
- Profile module improvements:
+ Added support for private fields to the profile module!
+ Improved workflow of profile administration pages.
+ Improved the form descriptions.
- Code improvements:
+ Unified user_edit() and user_admin_edit().
+ Unified and cleaned up the validation code. Fixed some validation glitches too.
2004-06-27 19:10:52 +00:00
Dries Buytaert
fa2be0b8f0
- Fixed administration pages being broken due to tabs changes, improved form
...
handling and form descriptions and fixed an incorrect title.
2004-06-22 20:33:12 +00:00
Dries Buytaert
54b77d6435
Tabs patch!
...
CHANGES
-------
+ Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
+ Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
+ Grouped settings. All settings have been grouped under 'administer > settings'.
TODO
----
+ Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help.
+ Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert
fbbf510511
- Patch #8105 by mathias: made the menu system aware of path aliases.
2004-06-01 21:58:46 +00:00
Dries Buytaert
7f08110a5e
- Improved form handling.
...
+ Introduced two new functions:
1. form_set_error($name, $message): files an error against the form
element with the specified $name.
2. form_has_errors(): returns true if errors has been filed against
form elements.
+ Updated the form handling:
1. The form_ functions will add 'class="error"' when a form field
has been found to be erroneous.
2. The error message is passed to theme_form_element() when the
particular form field has been found to be erroneous.
+ I updated the user and profile module to take advantage of these new
functions.
+ IMPORTANT: the _user() hook changed. The 'validate' case should no
longer retun an error message when something goes wrong but should
set it with form_set_error().
2004-05-31 09:40:56 +00:00
Dries Buytaert
8c75cda0b1
- Added some error checking to the profile module.
2004-05-28 20:02:11 +00:00
Dries Buytaert
0e6221a192
- Patch #7585 by Gerhard: extra data added by profile.module to the user
...
object got saved in the user's data column even if there is a dedicated
table for that information.
2004-05-05 21:17:25 +00:00
Kjartan Mannes
dfd66f998d
- Fixed sitewide timezone settings not being saved.
...
- Making sure profile fields are saved properly.
2004-04-29 23:27:15 +00:00
Kjartan Mannes
7e017fce0f
- Applied patch #6552 : Put back register_form and register_validate callbacks in user.module.
...
- Fixed bug #7406 : User delete hook incorrect params.
2004-04-29 22:39:55 +00:00
Dries Buytaert
dc8a68ea28
- Patch #6791 : mark required fields. Modified patch by Michelangelo.
2004-04-24 15:39:31 +00:00
Dries Buytaert
7231c88a32
- Added support for 403 handling. Patch by JonBob. As a side benefit,
...
administrators will be able to define a custom 403 page, just as they
can define 404 pages now.
This needs to be documented in the "Changes since / migrating to ..."
pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert
10bdb51c37
- Patch by JonBob/Jonathan: reworked the menu system so that menus are
...
configurable! Menu items can be disabled, repositioned, added and
so on.
Upgrading to requires you to run update.php.
This functionality depricates some of the 'navigation modules' in the
contributions repository. Furthermore, modules can now 'suggest'
menu items and site adminstrators can choose to enable them. Modules
in the contributions repository should try to take advantage of this.
2004-04-15 20:49:42 +00:00
Dries Buytaert
6e4d93b943
- Patch 6751 by TDobes: fixed call-by-reference problem
2004-03-29 18:19:10 +00:00
Dries Buytaert
5f17ad3c2d
- Profile module improvement:
...
* Made it possible to set certain fields as 'required'.
To do:
* Mark them as required visually.
* Add required fields to the subscription page.
2004-03-27 14:50:56 +00:00
Dries Buytaert
3fbfc52030
- Patch #6632 by Moshe: added missing brackets around table name.
2004-03-27 11:56:01 +00:00
Dries Buytaert
754f2ac26a
- More profile module improvements:
...
+ Updated the _user() hook's "$type == 'view'" case to match the
"$type == 'edit'" case. That is, both have to return an associtive
array of the format array('category' => 'fields').
+ Updated the profile pages to group fields by category. Made possible
thanks to the above change.
+ Moved logic out of the theme_ functions.
2004-03-21 14:28:15 +00:00
Dries Buytaert
f43cd3bb33
- More profile module improvements:
...
+ Add a new field type: 'list'.
2004-03-21 12:46:06 +00:00
Dries Buytaert
93cf70d72e
- Profile module improvements: added a URL-type field to the profile module.
...
We can use this for the 'URL of homepage' field on drupal.org. URL fields
are rendered as links and are being validated.
2004-03-21 10:28:10 +00:00
Dries Buytaert
b5c441a926
- Profile module improvements:
...
+ Made it possible to define the page title of the user listing pages.
+ Used form_group()s for the profile administration page.
+ Fixed bug in database/updates.inc.
2004-03-20 19:41:42 +00:00
Dries Buytaert
576968c471
- Patch #6406 by TDobes: fixed typos in profile/user module.
2004-03-15 20:09:54 +00:00
Dries Buytaert
73ab05f4e6
- Added a CVS Id
2004-03-13 06:10:20 +00:00
Dries Buytaert
2101f6c454
- Rewrote the profile module:
...
+ Added a 'created' field to the users table and renamed the 'timestamp'
fied to 'changed' (cfr. node table). Update.php will try to determine
a 'created' timestamp for existing users.
+ The profile module no longer uses serialized data but has its own set
of tables. Known existing profile data is migrated by these new tables.
TODO: migrate the birthday field.
+ The profile fields can be grouped, and within each group, profile fields
can be sorted using weights.
+ The profile pages can be themed.
+ The profiles can be browsed based on certain properties/settings.
+ Change the _user hook: (i) 'private_view' and 'public_view' are merged
into 'view' as there are no private fields and (ii) 'edit_form' has
been renamed to 'edit'.
+ Avatar handling has been refactored and is now part of the user module.
The users table has a dedicted 'picture' field.
+ Simplified the way themes should use display/visualize pictures or
avatars.
+ Made it possible for administrators to replace or delete avatars.
+ ...
I hope this make for a good base to build on collectively.
2004-03-11 20:33:59 +00:00
Dries Buytaert
cfd7751653
- Patch 5969 by Chris: improved the profile module's context sensitive help text
2004-02-21 21:26:57 +00:00
Dries Buytaert
bd78422715
- Patch 5592 by Goba: let drupal_map_assoc() rule. :-)
...
- Renamed CHANGELOG to CHANGELOG.txt for Windows uses.
2004-02-15 15:19:36 +00:00