Commit Graph

1822 Commits (a4b13976775152a44f720f96319c167926397f01)

Author SHA1 Message Date
Dries Buytaert a4b1397677 - Ported David's taxonomy patch to Drupal CVS. 2003-01-09 20:02:42 +00:00
Dries Buytaert 6744e34066 - Fixed the pager. It might not be 100% correct, but it will work in 95%
of the cases.
2003-01-09 19:53:51 +00:00
Dries Buytaert 22c3f055e1 - Bugfix: fixed the SQL query in _forum_topics_read to avoid counting shadowed
topics in forums.  Patch by David.
2003-01-08 19:43:35 +00:00
Dries Buytaert 28aa217f90 - Made sure the $links array is properly initialized before doing an
array_merge.  According to Ori, this fixes a problem when using PHP
  as an ISAPI module with the Sambar server.
2003-01-08 05:47:57 +00:00
Dries Buytaert affacdf508 - Added a few line breaks in the HTML emitted by the table() function
for better readability of the HTML code.  Patch by Moshe.
2003-01-07 19:21:28 +00:00
Dries Buytaert 33da658c4d - Bugfix: RSS auto-discovery was broken due to clean URL work. Patch by
Breyten.
2003-01-07 19:16:59 +00:00
Dries Buytaert 485e1c394a Great patch from Ulf:
- The href target for a new window is "_new", not "new".

- Generating <div> sections within <p> sections is forbidden by the
  XHTML standard. Using just the right aligned <div> should be
  sufficient and makes XHTML themes possible.
  (Prove at http://blog.rompe.org/ )

- While parsing the header of an RSS feed one should be aware that
  there may be more <title> tags in subsections and that POSIX regular
  expressions are always gready. So make shure we don't get too much.
  (If you agree that using PCRE instead of the POSIX ones would be
  generally a good idea, then I am willing to make the patch, but for
  now I didn't want to mix POSIX and PCRE in one file.)
  (Prove at http://blog.rompe.org/index.php?q=import/feed/43 , try
  this feed without my patch)

- Some RSS 2.0 feeds don't have a per item <link> section but have the
  permalink embedded in the <guid> section. This is not perfectly
  correct and the documentation mentions this possibility only in the
  examples, but since Dave Winer himself implements it this way it
  will happen more than once. So, if there is no link available and
  the guid looks like an address, then use that one.
  (Prove at http://blog.rompe.org/index.php?q=import/feed/22 , try
  this feed without my patch)

- Don't only write eventually new Feed Header information into the
  database but also use them immediatly. Reuse the $feed array that is
  made for it.

- If a feed doesn't provide per item titles, make shure to not produce
  defective markup by cutting the remainder of an entity. Instead of
  just cutting off anything behing the leading 30 characters of the
  cleaned description, it seems slicker to use up to 40 characters and
  split on word boundaries, but not on "&" or ";".
  (Prove also at http://blog.rompe.org/index.php?q=import/feed/22 .
  This feed will have title tags starting on February 1st, but I
  suspect many others without them out there.)

With this patch one could consider Drupals aggregator RSS 2.0 ready.
2003-01-07 19:09:42 +00:00
Dries Buytaert 337b80b1a6 - Fixed access log update bug introduced during clean URL commit. Patch by
Moshe.
2003-01-07 05:58:36 +00:00
Dries Buytaert d026d15d2a - Fixed links to admin page. Added help text. 2003-01-07 05:56:47 +00:00
Dries Buytaert 56d0434f82 - Fixed bug in update of taxonomy links. 2003-01-06 21:43:07 +00:00
Dries Buytaert 2647a943f0 - Forgot to update the taxonomy links. Reported by Adam. 2003-01-06 21:24:21 +00:00
Dries Buytaert a380356d6e - Fixed typo in watchdog(). Reported by Marco. 2003-01-06 20:58:31 +00:00
Dries Buytaert bfb3575c09 - Some usability improvements requested by Michael. 2003-01-06 20:51:39 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Steven Wittens 97858f9b2e Typo ('tat' > 'that') 2003-01-05 01:19:37 +00:00
Dries Buytaert 36556762f9 - Made a database query ASNI compliant. Patch by Ax. 2003-01-05 00:05:53 +00:00
Dries Buytaert 520416d977 - In the taxonomy administration pages, the dropdown to select a term's
parent is supposed to exclude terms that are descendants of the current
term, to avoid creating cycles. However, the terms with the first few
term IDs are excluded instead.  Patch by JonBob.
2003-01-04 23:58:27 +00:00
Dries Buytaert 56e5c29b40 - Added a check for register_globals. 2003-01-04 23:43:49 +00:00
Dries Buytaert 2da18e8d0c - The statistics module would sometimes mistake a non-node ID with that
of a node.  Thanks David and Jeremy.
2003-01-04 23:38:58 +00:00
Dries Buytaert 8a63646576 - Added an extra parameter to watchdog() which lets you specifiy an "action"
or "operation" link.

- Made the main page of the administration section show an overview of all
  watchdog entries with such action link.

- Fixed typo in PostgreSQL database scheme.
2003-01-04 11:03:15 +00:00
Dries Buytaert 7a6b8e3d3c - Added Michael's dummy print.css to avoid watchdog errors.
- Added a comment to explain why we include a dummy stylesheet.
2003-01-02 23:35:04 +00:00
Dries Buytaert 408bf86abd - Usability improvement; the drop-down menu showed the first vocabulary in
the list even though it has not been selected.  Reported by Adam Shand.
2003-01-02 23:26:43 +00:00
Dries Buytaert 2b5dfdafa5 Bugfix: when we have to extract a comment's title from the comment's body,
first strip the body's HTML tags or we might get an empty title after all.
2003-01-02 18:34:13 +00:00
Dries Buytaert a728900dba - Bugfix: some variables were not being reset causing wrong links to be
displayed.  Patch by Ax.
2003-01-02 06:08:05 +00:00
Dries Buytaert 56da7ebfa2 - Fixed bug that prevented results containing multiple occurences of the
search word(s).  Patch by Ax.
2003-01-01 21:06:22 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 8cb66b212e - Improvement: remove vi left-overs. 2002-12-31 12:11:34 +00:00
Dries Buytaert c97e36fb06 - Simplified the page module. Patch by Marco. 2002-12-31 11:37:29 +00:00
Dries Buytaert 92758279fa - Bugfix: wrapped an RSS item's description in a check_output() to ensure
proper markup.
2002-12-31 10:58:47 +00:00
Dries Buytaert 3c7d0f9575 - Fixed typo. Patch by Marco. 2002-12-31 10:40:26 +00:00
Dries Buytaert 84ad17f73b Patch by Michael:
admin.css:

* Removed border-bottom for menu list items. The only work around to retain
the border-bottom on lists with nested items is to use divs rather than li
tags as far as I know. I think the list items are still readable this way.
* Made title of site in sidenav more differentiated from menu.
* Made color changes so that all headings are the same hue (navy bluish).
* Modified th text-align: left; for better readability. Modified
border-bottom: 1px solid #ccc; Black addded visual noise.
* Modified tr.dark background-color: #ddd, tr.light background-color: #fff;
* Changed all colors to #xxx three number hex shortcuts.
* Added hr rule to make horizontal rules have height: 1px; color: #ccc;

admin.php:

* Added 1 line to admin.php to include <link rel="stylesheet" ...>. The
stylesheet refers to a misc/print.css stylesheet which may not exist in your
misc/ directory. This fixes the flash of unstyled content that users of Win
IE 5+ are experiencing. You can use this to specify print styles if you
like. See more about this here: http://www.bluerobot.com/web/css/fouc.asp
2002-12-30 23:30:55 +00:00
Dries Buytaert 927cb12ffb - Fixed small braino in the cloud module table. 2002-12-30 16:31:55 +00:00
Dries Buytaert 105eef9896 - Small improvement to the links. 2002-12-30 16:30:16 +00:00
Dries Buytaert e97c6a73d6 - Code improvement: menu_tree() will no longer generate empty "<ul></ul>"
constructs.
2002-12-30 15:54:06 +00:00
Dries Buytaert 5598417c3f - Some small improvements/fixes to the node system. Suggested by Marco. 2002-12-30 13:02:47 +00:00
Dries Buytaert 0475d4fbc4 Patch by Marco:
- rewrote taxonomy_get_tree() for improved performance and cleaner code
- fixed a bug in _taxonomy_term_select() with multiple parents
- added hooks in vocabulary and term insert, update and delete
- fixed a bug in taxonomy_save_vocabulary() (cache_clear_all() was never
called)
2002-12-30 12:03:53 +00:00
Dries Buytaert cc01e61388 - Bugfix: user_save() should not be called for anonymous users. Patch by
Marco.
2002-12-30 09:26:05 +00:00
Dries Buytaert 769ebb666c - Check input given to table rendering functions to avoid warning. 2002-12-30 08:33:02 +00:00
Dries Buytaert f281f0a7e3 - Fixed a typo in the documentation, as well as extended the documentation
while I was at it.
2002-12-29 21:46:13 +00:00
Dries Buytaert 62fa5541dd - Added pager support to watchdog. Based on modified patch from Moshe. 2002-12-29 18:31:46 +00:00
Dries Buytaert c9ca1c6c80 - Usability improvement: made the locale module tables use the new table
rendering functions.

- Usability improvement: a couple of strings could not be translated.
2002-12-29 17:46:29 +00:00
Dries Buytaert df650e54a1 - Usability improvement: made the cloud module table use the new table
rendering functions.

- Usability improvement: a couple of strings could not be translated.

- Bugfix: removed redundant links.
2002-12-29 16:59:45 +00:00
Dries Buytaert 3a43fdd414 - Usability improvement: made the access log, referrer logs and popular post
tables use the new table rendering functions.

- Usability improvement: a couple of strings could not be translated.
2002-12-29 16:54:31 +00:00
Dries Buytaert e9148b9180 - Usability improvement: made the access log, referrer logs and popular post
tables use the new table rendering functions.

- Usability improvement: a couple of strings could not be translated.
2002-12-29 16:40:08 +00:00
Dries Buytaert 50cac553d5 - Removed table markup from watchdog module; should be done in admin.css. 2002-12-29 16:14:37 +00:00
Dries Buytaert bef0244c9a - Usability improvement: made the theme selector and module selector pages
use the new table rendering functions.
2002-12-29 16:08:05 +00:00
Dries Buytaert d626a6cfda CHANGES:
- Usability improvement: made the block administration pages use the
  new table rendering functions.  By the way, the old code rendered
  invalid HTML code.

- Usability improvement: saving block changes will now show a status
  message.

- Usability improvement: quite a few strings could not be translated.

TODO:

- I think the "enabled" and "custom" field are somewhat confusing.
  Suggestions?
2002-12-29 16:03:01 +00:00
Dries Buytaert 2020853524 - Usability improvements: made the taxonomy administration pages use
the new table rendering functions, made the overview table's HTML
  code a lot simpler, tidied up the status messages, and removed some
  redundant check_output()s.
2002-12-29 15:37:36 +00:00
Dries Buytaert 74d315b34a - Usability improvement: made the remaining user administration pages use
the new table rendering functions; access rule table, permission table,
  role table, etc.

- Usability improvement: made the permission table translatable.  Requested
  by Stefan.

- Code improvement: removed some redundant check_output()s.
2002-12-29 13:46:30 +00:00
Dries Buytaert d9919f50c5 CHANGES:
- Usability improvement: made the user administration pages use the
  new table rendering functions.

- Usability improvement: added pager support to the user administration
  pages.

- Code improvement: fixed code indentation.
2002-12-29 13:14:38 +00:00