Commit Graph

3746 Commits (95595ae6f821fd616a60031b166b035482736c10)

Author SHA1 Message Date
Steven Wittens 95595ae6f8 #12384: Test if clean URLs work before allowing them to be turned on. 2004-11-02 12:47:10 +00:00
Steven Wittens 3e36c7864b #12167: Respect 'bypass input data check' permission in file.inc. 2004-11-02 12:43:35 +00:00
Steven Wittens f69437dead #12363: Bug in user_access() with uid 1 and $account parameter. 2004-11-02 12:20:59 +00:00
Dries Buytaert 29b32eff2b - Patch #7161 by jhriggs: fixed probem with 'last page' link not being correct under certain circumstances. 2004-10-31 07:59:18 +00:00
Dries Buytaert 4021b429a7 - Updated CHANGELOG.txt 2004-10-31 07:37:27 +00:00
Dries Buytaert b3adcf05a3 - Patch #11875 by Neil Drumm: block module configuration improvements.
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.

Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.

The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.

An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
Dries Buytaert 8daed9cbf3 - Patch #12232 by Steven/UnConed: search module improvements.
1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...

2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.

3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.

4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).

5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.

6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).

7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.

8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.

9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.

10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
2004-10-31 03:03:27 +00:00
Steven Wittens 83dc5f9bab #12295: missing </p> in filter help. 2004-10-30 16:58:51 +00:00
Steven Wittens 979b482c7a - #12305: Blog it icon was broken due to missing parameter. 2004-10-29 19:43:51 +00:00
Steven Wittens f46a82da51 #7607: Sort node types in node/add by translated names. 2004-10-29 00:51:49 +00:00
Steven Wittens 3e406e8f40 #12128: Change label for comment subject settings to match behaviour; 2004-10-28 23:56:14 +00:00
Steven Wittens 11b0b805fa #12186: Add xml icon to taxonomy listings. 2004-10-28 23:46:10 +00:00
Steven Wittens 987988300a #12183: surpress php error on copy() 2004-10-28 23:42:36 +00:00
Dries Buytaert 6238bf449d :- Patch #12096 by Axel: fixed problem with plurals for some languages. 2004-10-27 18:23:06 +00:00
Steven Wittens a4cc9aa817 #12155 : use defined constant rather than integer in file.inc. 2004-10-26 20:57:34 +00:00
Steven Wittens 1cbf2f63b2 #12146: Improve locale import/export messages (Stefan) 2004-10-26 17:20:58 +00:00
Dries Buytaert c2f174e1f1 - Patch #11725 by mrrowe: custom menus are not wrapped in <div class="menu"> tags which made their appearance differ from the built-in "navigation" menu. 2004-10-23 17:24:49 +00:00
Dries Buytaert f1a087e376 - Patch #11879 by Moshe: deprecated the _content hook.
TODO:
   + Update Doxygen hook list (if required).
   + Document this in the developer's upgrade section.
2004-10-23 17:18:23 +00:00
Dries Buytaert c6df88ddf0 - Patch #11868 by Neil Drumm: fixed broken link in the help text and made the help text more accurate. 2004-10-23 16:29:31 +00:00
Dries Buytaert 89db09746f - Patch #11935 by Neil Drumm: removed left-over documentation from archive module. 2004-10-23 16:15:29 +00:00
Dries Buytaert 1400f75737 - Patch #11952 by Neil Drumm: the path module's help text contained information that was no longer up-to-date. 2004-10-23 13:47:11 +00:00
Dries Buytaert a73f63f10c - Patch #11947 by puregin: ensured that a book node's weight is captured when the book node lists returned by book_location() and book_location_down() are generated. This information is required when selecting next page candidates in book_next().
Note that book_location_down() was missing an explicit field b.weight in the SQL SELECT statement, but this value would usually be supplied implicitly because it is used to ORDER the result.
2004-10-23 13:41:37 +00:00
Steven Wittens 474beff640 Missing check if file upload fails. 2004-10-20 16:57:35 +00:00
Dries Buytaert 10f329c057 - Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.
Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
2004-10-19 18:02:31 +00:00
Steven Wittens b2f8787c90 Comment deleting broken 2004-10-18 20:10:18 +00:00
Dries Buytaert f37f79d2c3 - Updating the date. 2004-10-18 18:56:15 +00:00
Dries Buytaert 25bbc0d4c4 - Fixed parentheses. 2004-10-18 18:40:53 +00:00
Dries Buytaert e86b041fa3 - Modified patch #11689 by Adrian: made the locale module work with PostgreSQL. 2004-10-18 18:35:19 +00:00
Dries Buytaert 07cdcb439b - Patch by James: made the blogapi module work again. 2004-10-18 18:29:15 +00:00
Dries Buytaert 1362571d09 - Patch #11510 by Adrian: turned a non-ANSI SQL query into ANSI SQL so it works with PostgreSQL. 2004-10-18 17:46:19 +00:00
Dries Buytaert c9d1894911 - Patch #11682: changed FILTER_DEFAULT_FORMAT to FILTER_FORMAT_DEFAULT to make the Blog API work. 2004-10-18 08:00:41 +00:00
Dries Buytaert a423eefe95 - Patch #11670 by TDobes: comment.module did not properly set a breadcrumb for creating/previewing new comments. The node on which your commenting and its location within the menu is not displayed. Instead, there is only a "Home" link. This is especially apparent when the "add new comment" form is set up to display on a separate page. 2004-10-17 19:09:09 +00:00
Dries Buytaert 3302104ffc - Patch by Gerhard: small update to INSTALL.txt. 2004-10-17 18:38:22 +00:00
Steven Wittens b228f0183a #11449: Adding a failsafe check for an improperly prefixed menu sequence. This is a temporary fix, awaiting a proper install system to end manual prefixing ;). 2004-10-16 19:42:52 +00:00
Dries Buytaert 869a91b72e - Patch #11505 by Steven: 'my account' information is not saved.
+ Drupal 4.4 stored profile data in the serialized user->data column. Drupal 4.5 stores profile data in tables (but user->data is still available and used for other stuff, like locale or themes).  The update from 4.4 to 4.5 didn't remove the old data from the user->data column properly, because there is no mechanism in user_save to do so (it did try to unset the fields, but this has no effect).

  + On registration, hook_user('insert') is invoked after saving the data column. This means that any module-specific data is put into the data field. We cannot move hook_user('insert') higher up, because before that point, we do not have a complete $user object yet.
2004-10-16 16:59:59 +00:00
Dries Buytaert 5a2e0d0377 - Patch #11642 by Steven: when editing a user as an admin, you can choose the user's roles through form checkboxes. If the form validation fails and the form is redisplayed, the roles are lost. This is because the format for $user->roles is different from what form_checkboxes uses. 2004-10-16 16:48:04 +00:00
Dries Buytaert 2c45ab85fb - Fixed bug #9948: added some checks to system_setting_save() to avoid PHP warnings/errors. 2004-10-16 07:35:29 +00:00
Dries Buytaert 7ebd772f41 - Patch #10664 by TDobes: fixed collapsed comments + updated the code comments. 2004-10-16 07:22:26 +00:00
Steven Wittens ba2761929c #7289: locale import fixes 2004-10-16 01:00:23 +00:00
Steven Wittens ea17f39811 Tablesort used to output class=" active" for active columns with other properties (align="right"). Now it correctly uses class="foo active" if a class 'foo' was specified, and class="active" otherwise. 2004-10-15 22:16:00 +00:00
Steven Wittens a35ff36673 search: Removing iso-8859-1 characters from update_index() and adding the same stripping to do_search().
This fixes the embarrasing bug of not being able to search for "4.5.0" because it is indexed as "450".
2004-10-15 22:01:41 +00:00
Dries Buytaert 7cf0e9af33 - Patch #9252 by TDobes: admins should be able to edit anonymous commenters' names. 2004-10-15 16:57:20 +00:00
Dries Buytaert 49dcf84fdf - Patch #11605 by TDobes: if a user happens to have uid=0 defined in their database, the name assigned to that user will always override any name submitted by an anonymous commenter. Checking against $user->uid instead of $user->registered_name fixes this problem. 2004-10-15 11:13:11 +00:00
Dries Buytaert 1f1a772a11 - Mofified patch #8862 by puregin: improved book module documentation. 2004-10-15 10:56:23 +00:00
Dries Buytaert a5691cccc9 - Patch #11600 by jhriggs: the module_load_all() function will currently behave unexpectedly if a module cannot be found (has been removed, renamed, etc). Once one module fails to load, all subsequent modules will not be loaded due to a short circuit condition when performing a boolean AND. 2004-10-15 10:47:54 +00:00
Dries Buytaert dfb3c3aec4 - Patch #11577 by drumm: changed t('ago') -> t('%time ago', ...) to make it
translatable in languages such as Spanish.
2004-10-15 05:10:35 +00:00
Dries Buytaert 6a8e394301 - Fixed bug #11312: menu caching to aggresively. I did not apply the proposed
patch but moved the menu-logic to the $may_cache clause and added some checks
  to avoid SQL overhead.  I think this is the most performant solution.
2004-10-14 21:45:37 +00:00
Dries Buytaert 12eb20238c - Patch #11430 by JonBob: reseting the menus broke the admin pages. 2004-10-14 21:38:12 +00:00
Dries Buytaert 4a0e047469 - Patch #10869 by JonBob: the menu.module forget the parent item on form error. 2004-10-14 21:35:12 +00:00
Dries Buytaert df4ec83120 - Patch #10677 by drumm: removed dead code. Leftover. 2004-10-14 21:27:33 +00:00