Steven Wittens
dd4f143df6
#75002 : Install-time and run-time requirements checking + status report page
2006-09-01 08:44:53 +00:00
Neil Drumm
e57fac565a
#65151 by m3avrck. theme_links() is now marked up as a list.
2006-08-30 07:37:14 +00:00
Steven Wittens
849a10fbba
Allow absolute urls for theme('image'), needed for user pictures to work properly.
2006-08-24 00:04:44 +00:00
Neil Drumm
a58d877108
#66569 by m3avrck. Put all the feed icons in the same place.
2006-08-23 05:55:38 +00:00
Dries Buytaert
a8de1e92d7
- Patch #76637 by timnc: streamline JavaScript addition and add settings storage.
2006-08-22 09:00:31 +00:00
Steven Wittens
55eec8f66f
#79601 : module_exist() -> module_exists()
2006-08-20 05:57:41 +00:00
Steven Wittens
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Neil Drumm
28f7908f8c
#2039 by Boris Mann ("My first diff to the list"), moshe weitzman, and David Lesieur, nested lists.
2006-08-17 06:55:26 +00:00
Neil Drumm
9709598a52
Fixing the CSS for theme maintainence and install pages.
2006-08-05 22:17:31 +00:00
Steven Wittens
3ffb612aea
#76741 : Allow <th> tags for theme_table cells
2006-08-03 20:37:52 +00:00
Dries Buytaert
2c0571b894
- Patch #73961 by m3avrck, timcn, et al: simplify adding CSS in Drupal.
2006-08-03 07:06:36 +00:00
Dries Buytaert
1c75a210bd
- Patch #68926 by chx, jeremy, steven, eaton, webchick, amazon, neil, nedjo et al: an initial install system for Drupal core.
2006-07-13 13:14:25 +00:00
Dries Buytaert
e93f8be871
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
2006-07-05 11:45:51 +00:00
Neil Drumm
59aa2ae8e8
#71925 by Steven, remove # prefix from link array keys.
2006-07-04 08:59:05 +00:00
Neil Drumm
efb10dfd17
#52059 by Crell, allow attributes for items in theme_item_list().
2006-07-02 00:25:40 +00:00
Dries Buytaert
13c32bab15
- Patch #71454 by moshe: removed redundant module_invoke. Committing from the Google campus.
2006-06-29 20:40:26 +00:00
Neil Drumm
963dc77bb7
#68170 by xtony and Heine, Use basename not pretty name in theme_get_settings().
2006-06-23 07:54:00 +00:00
Neil Drumm
168a3dcd8e
#63485 by fgm, theme_item_list should receive an attributes parameter
2006-05-20 01:24:30 +00:00
Dries Buytaert
1b291a2917
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
2006-05-18 14:58:57 +00:00
Neil Drumm
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
Neil Drumm
6411e09dc9
#56508 by chx (modified), Remove notices from form.inc and move theme_form_element from theme.inc to form.inc.
2006-05-02 09:26:33 +00:00
Neil Drumm
130c1492c5
#61304 by fgm, use t() for a string.
2006-05-02 09:01:23 +00:00
Dries Buytaert
d071f99172
- Removing trailing whitespace.
2006-04-17 20:48:26 +00:00
Steven Wittens
8b04c7f0db
#51002 : Admins could not see unpublished comments (plus minor usability enhancements for previewing/unpublished)
2006-04-15 04:07:18 +00:00
Gerhard Killesreiter
70aae83c8e
#58166 , fixes for typos, patch by Uwe Herrmann
2006-04-11 11:33:15 +00:00
Steven Wittens
9814b832b2
- Remove trailing whitespace
2006-04-07 10:40:55 +00:00
Steven Wittens
b3c245c08c
#57519 : Custom favicon did not use base_path()
2006-04-06 02:35:57 +00:00
Steven Wittens
6ab6b8abcd
#57333 : Only set logo image path if it exists
2006-04-04 23:31:04 +00:00
Gerhard Killesreiter
cb49e19e9e
#54003 , Watchdog not logging update errors, patch by Steven
2006-03-28 09:29:23 +00:00
Steven Wittens
16fd8c89a5
- sa-2006-002: XSS issues with username log and mission
2006-03-13 21:42:35 +00:00
Dries Buytaert
6d9e5084d8
- Patch #52508 by TDobes: fixed theme system regressions.
2006-03-07 11:28:22 +00:00
Steven Wittens
15590cdc06
- #48036 : Don't show search box in theme if you have no search permission
2006-02-05 19:08:11 +00:00
Dries Buytaert
048bec139e
- Patch #13148 by Morbus: less globals.
2006-02-02 12:44:57 +00:00
Dries Buytaert
4ffb77baae
- Patch #13148 by Morbus: further base path fixes / clean-ups.
2006-01-30 21:32:09 +00:00
Dries Buytaert
81660bc662
- Patch #13148 : fix problems with using relative path names! (Please document this change.)
2006-01-29 07:36:29 +00:00
Dries Buytaert
55c88ae09c
- Added .
2006-01-20 09:30:12 +00:00
Dries Buytaert
e38f0403a3
- Patch #45451 by wtanaka: added explanation for the red star.
2006-01-20 09:19:21 +00:00
Dries Buytaert
56d0d76f0f
- Patch #27884 by gordon: js addLoadEvent not working.
2006-01-20 08:54:07 +00:00
Dries Buytaert
5f829187e6
- Patch #45209 by markus et al: added some missing t() functions.
2006-01-18 19:40:18 +00:00
Dries Buytaert
6048d282cc
- Modified patch #45214 by markus: don't generate empty breadcrumb div.
2006-01-18 19:02:34 +00:00
Dries Buytaert
1d9b81d3b8
- Patch #44976 by m3avrck: cleaned up some CSS.
2006-01-16 20:57:53 +00:00
Dries Buytaert
57447dc571
- Patch #42105 by chx / merlinofchaos: made form elements themable.
2006-01-10 19:37:27 +00:00
Dries Buytaert
303720fb62
- Patch #15609 by m3avrck: get rid of forced <br />-tag after <label>-tags. Makes it easier to theme forms.
2006-01-06 07:32:54 +00:00
Dries Buytaert
6c20d333d2
- Patch #35667 by Crell: bug fix: on ?q=admin/block style.css was imported twice.
2006-01-06 07:25:44 +00:00
Dries Buytaert
9385794e23
- Patch #41548 by Neil: critical bugfix: theme didn't load when styles are used.
2006-01-04 09:32:28 +00:00
Steven Wittens
79a193a2d2
- #42234 : Use standardized feed icon for RSS
2005-12-29 04:46:40 +00:00
Dries Buytaert
b362985de5
- Patch #41118 by Goba: various upgrade script fixes.
2005-12-26 17:20:23 +00:00
Dries Buytaert
a19acb219e
- Patch #35924 by Neil: improved the update system.
2005-12-06 09:25:22 +00:00
Dries Buytaert
5f36738a11
- Patch #38279 by paddy_deburca: fixed theme_item_list() not to generate an empty <ul></ul> tag when $items is empty.
2005-11-24 20:08:54 +00:00
Dries Buytaert
ea53aad7c8
- Patch #22215 by Richard Archer: refactored primary and secondary links.
...
Deprecates the primary_links module.
This patch was much needed. Thanks Richards!
NOTE: if some themers could investigate if there is room for improvement
with regard to theming, that would be awesome.
2005-11-03 19:33:37 +00:00
Dries Buytaert
f6764cfbd8
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
2005-10-22 15:14:46 +00:00
Dries Buytaert
8d460b406d
- Patch #32573 by Moshe: added support for ordered lists to theme_item_list().
2005-10-18 14:45:09 +00:00
Dries Buytaert
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert
cec8db72dd
- add some space
2005-09-29 08:02:55 +00:00
Dries Buytaert
5971f1e645
- Patch #28777 by Neil: use <thead> and <tbody> in theme_table().
2005-09-15 20:58:17 +00:00
Dries Buytaert
013b73e6ec
- Patch #30122 by m3verick: changed include_once()'s to include "./$file"
...
for performance's sake.
2005-09-08 19:19:01 +00:00
Dries Buytaert
3b1e763d03
- Patch #30423 by Crell: added support for table <captions>.
...
TODO: look into http://drupal.org/node/28777 ?
2005-09-06 20:32:53 +00:00
Dries Buytaert
c9fc300b1f
- Patch #29785 by Chx: multiple node types were broken so we refactored
...
part of the node system! If you have a module that implements node
types, you'll have to udpate its CVS HEAD version.
We replaced _node_name() and _node_types() by _node(). The new _node()
hook let's you define one or more node types, including their names.
The implementation of the _node() hook needs to:
return array($type1 => array('name' => $name1, 'base' => $base1),
$type2 => array('name' => $name2, 'base' => $base2));
where $type is the node type, $name is the human readable name of the type
and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.
For example, the story module's node hook looks like this:
function story_node() {
return array('story' => array('name' => t('story'), 'base' => 'story'));
}
The page module's node hook module like:
function page_node() {
return array('page' => array('name' => t('page'), 'base' => 'page'));
}
However, more complex node modules like the project module and the
flexinode module can use the 'base' parameter to specify a different base.
The project module implements two node types, proejcts and issues, so it
can do:
function project_node() {
return array(
array('project_project' => array('name' => t('project'), 'base' => 'project'),
array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
}
In the flexinode module's case there can only one base ...
This hook will simplify the CCK, and will make it easy (or easier) to merge
the story and page module.
In addition, node_list() became node_get_types(). In addition, we created
the following functions: node_get_name($type) and node_get_base($type).
2005-08-28 15:29:34 +00:00
Dries Buytaert
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
Dries Buytaert
1836d3b365
- Patch #29002 by Neil: list_themes() currently returns all themes, not just enabled themes. This functionality is only used in one place- configuration for disabled themes. These configuration pages can be removed with a usability improvement since you shouldn't be able to configure things which are disabled. Additionally, this allows us to remove some extra logic in system_user(). And it it more consistent with the module API which only lists enabled modules.
...
list_themes() sorts the results by name. This uses filesort in MySQL since there aren't any indexes. Sorting is not used except in system_user(). This one use can be handled with ksort since it is not often executed (only on the user edit screen when multiple themes are enabled).
And a one line fix to remove a variable in system_user() is in here too.
2005-08-18 22:07:14 +00:00
Dries Buytaert
26fa7c730f
- Patch #16216 by nedjo: multiple block regions!
2005-08-16 18:06:18 +00:00
Dries Buytaert
b69b43d1ec
- Patch #28482 by Uwe: add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s.
...
Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?).
2005-08-11 12:57:41 +00:00
Steven Wittens
8660655a9a
- #27981 : Add media parameter to theme_add_style
2005-08-05 00:22:03 +00:00
Dries Buytaert
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
Steven Wittens
c81bbf4aa1
- #24673 : Fix deprecated usage of implode
2005-07-30 12:52:54 +00:00
Steven Wittens
3084036576
- #27231 : (fix) Pretty db error screens.
2005-07-29 07:49:43 +00:00
Steven Wittens
d9d4b9bdab
- #27231 : Friendly DB error screens.
2005-07-27 01:58:43 +00:00
Dries Buytaert
ba1660168f
- Patch #27003 by Neil: use named constants instead of strings
2005-07-23 05:57:27 +00:00
Dries Buytaert
db3a2cc175
- Patch #11927 by stefan/Robin: improved theming of tablesort icons.
2005-07-02 12:32:09 +00:00
Dries Buytaert
5c8843704c
- Patch #18213 by chx: boostrap system. Modified to work with HEAD, tidied
...
up the documentation a little.
chx: can you double-check whether the global $conf variable is secure?
(That is, make sure it can't be send using the URL or something.)
2005-06-22 20:19:58 +00:00
Dries Buytaert
eb536bf5ec
- Patch #24157 by chx/Robin/...: changed file_exists() to is_file() to fix several problems with modules using theimage toolkit.
2005-06-19 08:59:06 +00:00
Dries Buytaert
abc16b1d6d
- Patch #25067 by Thox: renamed 'light' and 'dark' to 'odd' and 'even'.
...
TODO: update the "Migrating themes from Drupal 4.6 to Drupal HEAD"-page in
the Drupal handbook!
TODO: update the themes in the contributions repository.
2005-06-19 08:50:46 +00:00
Dries Buytaert
a7af266b6d
- Patch #25143 by Robin: use count() instead of is_array() so we don't render code for empty arrays, and such you don't get warnings using PHP5.
2005-06-19 08:13:14 +00:00
Steven Wittens
a597354bcb
- Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags.
2005-05-31 21:14:27 +00:00
Dries Buytaert
0250938e2b
- Patch #17028 by Ber: theme xml_icon should allow inline XML icons.
2005-05-26 19:08:14 +00:00
Steven Wittens
6be2c61896
- #20809 : User-configurable, per-theme, optional favicons.
2005-05-25 06:03:18 +00:00
Steven Wittens
a52bb9b1dd
- #23516 : Remove ][ from form item id's.
2005-05-25 03:50:25 +00:00
Steven Wittens
5154c3aca4
- Fixing some plain/url check calls.
2005-05-18 21:12:17 +00:00
Dries Buytaert
03250bd3e3
- Patch #21397 by jjeff: fixed behavior of theme_image with regard to attributes.
2005-05-06 09:01:46 +00:00
Dries Buytaert
2debcfb1ef
- Patch #15595 by Stefan and Djun: improved status messages.
...
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
2005-05-05 22:22:46 +00:00
Dries Buytaert
6658273b36
- Patch #21855 by TDobes: the recent commit of phptemplate caused a number of problems for non-phptemplate themes. A patch is attached to address these issues.
...
Changes include:
* parsing of the primary/secondary links has been moved out of phptemplate and into theme_get_setting.
* unnecessary and XHTML-invalidating duplicate div#help removed from themes/bluemarine/page.tpl.php (this is already generated by theme_help)
* weird generation of the "edit primary/secondary links" messages removed from bluemarine and placed in theme.inc
* unnecessary changes to themes/bluemarine/style.css rolled back (the phptemplate bluemarine had an older version of style.css than the one in core)
* chameleon updated to work with new link scheme (passes links through theme_links)
2005-05-05 07:35:58 +00:00
Dries Buytaert
e274f97c87
- Removed the Xtemplate engine and added the PHPTemplate engine.
...
- Converted the Bluemarine theme from XTemplate to PHPTemplate.
- Moved the the Pushbutton theme and the Xtemplate engine to the contributions repository.
2005-05-04 18:12:18 +00:00
Dries Buytaert
a10eac3291
- Patch #21517 by Stefan and TDobes: theme system improvements.
2005-04-30 17:47:57 +00:00
Dries Buytaert
79a5700c57
- Usability improvement: made the markers easier to understand.
2005-04-24 16:22:30 +00:00
Dries Buytaert
495a03ae9d
- Patch #12794 by assimonds: make sure the node module is optional.
2005-04-13 17:59:39 +00:00
Dries Buytaert
7bdcba1720
- Patch #19739 by Uwe: corrected many typo's in the documentation and code comments
2005-03-31 21:18:08 +00:00
Steven Wittens
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
Dries Buytaert
99233a9c99
- Patch #19590 by Moshe: lazy initialization of the theme system. Improves
...
performance of pages that don't need the theme system (such as RSS feeds)
and makes it easier to set a custom theme.
2005-03-29 21:01:47 +00:00
Dries Buytaert
97ae6568e6
- Patch #13738 by TDobes: theme system fixes:
...
* Fix a bug which would cause the "configure" link for styles to be broken.
* Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
* Correct an inaccurate comment in theme.inc
* Populate the default primary links with an "edit primary links" link for consistency with the secondary links
* remove some unnecessary variables in the theme administration which had misleading and confusing names
* replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
* usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
2005-03-16 19:41:12 +00:00
Steven Wittens
198ec98f75
#18329 : Unify confirmation messages (and make them themable)
2005-03-03 20:51:27 +00:00
Dries Buytaert
59c2208ea6
- Patch #16253 by Goba: incremental improvements to the new content markers.
...
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert
467dbdc4a1
- Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though.
2005-01-27 12:57:08 +00:00
Dries Buytaert
2b17b3a966
- Patch #13907 by Neil: less ways to set the page title.
...
* Less logic in theme code.
* Encourages use of the menu system.
* Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
* Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert
cc508ad2f0
- Patch 13738 by TDobes: there was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all).
2004-12-01 22:41:19 +00:00
Dries Buytaert
4e4e2aa777
- Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly.
2004-11-24 22:50:25 +00:00
Dries Buytaert
30110a8770
- Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
...
TODO:
1. Update theme upgrade instructions in the handbook: node_link() is gone.
2. Remove page_link() just like we removed node_link().
2004-11-23 23:11:59 +00:00
Steven Wittens
583e63c136
Theme system bug: only show search box if search.module is enabled.
2004-10-14 02:38:33 +00:00
Steven Wittens
9c9905d9a0
#10648 : Fix watchdog-related tablesort coloring bug in IE, add support for <tr> attributes to theme_table() and reduce specificy of watchdog coloring CSS rules.
2004-09-14 20:01:00 +00:00
Dries Buytaert
b84b6e42cf
- Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
2004-09-09 05:51:08 +00:00
Steven Wittens
98a9d5ee2d
- #9576 : Patch by TDobes, only allow the user to choose between enabled themes.
2004-08-22 14:43:49 +00:00