- #24673: Fix deprecated usage of implode

includes/common.inc

@@ -1648,7 +1648,7 @@ function drupal_attributes($attributes = array()) {
     foreach ($attributes as $key => $value) {
       $t[] = $key .'="'. check_plain($value) .'"';
     }
-    return ' '. implode($t, ' ');
+    return ' '. implode(' ', $t);
   }
 }
 

includes/pager.inc

@@ -394,10 +394,10 @@ function theme_pager_link($text, $page_new, $element, $attributes = array()) {
 
   $page_new = pager_load_array($page_new[$element], $element, explode(',', $page));
   if (count($attributes)) {
-    $url = url($q, 'page='. implode($page_new, ',') .'&'. implode('&', $query));
+    $url = url($q, 'page='. implode(',', $page_new) .'&'. implode('&', $query));
   }
   else {
-    $url = url($q, 'page='. implode($page_new, ','));
+    $url = url($q, 'page='. implode(',', $page_new));
   }
 
   return '<a href="'. check_url($url) .'">'. check_plain($text) .'</a>';

includes/theme.inc

@@ -538,7 +538,7 @@ function theme_image($path, $alt = '', $title = '', $attributes = NULL, $getsize
  * @return a string containing the breadcrumb output.
  */
 function theme_breadcrumb($breadcrumb) {
-  return '<div class="breadcrumb">'. implode($breadcrumb, ' &raquo; ') .'</div>';
+  return '<div class="breadcrumb">'. implode(' » ', $breadcrumb) .'</div>';
 }
 
 /**
@@ -900,7 +900,7 @@ function theme_xml_icon($url) {
  */
 function theme_closure($main = 0) {
   $footer = module_invoke_all('footer', $main);
-  return implode($footer, "\n");
+  return implode("\n", $footer);
 }
 
 /**

modules/statistics.module

@@ -455,7 +455,7 @@ function statistics_block($op = 'list', $delta = 0, $edit = array()) {
         }
 
         if (count($content)) {
-          $block['content'] = implode($content, '<br />');
+          $block['content'] = implode('<br />', $content);
           $block['subject'] = t('Popular content');
           return $block;
         }

modules/statistics/statistics.module

@@ -455,7 +455,7 @@ function statistics_block($op = 'list', $delta = 0, $edit = array()) {
         }
 
         if (count($content)) {
-          $block['content'] = implode($content, '<br />');
+          $block['content'] = implode('<br />', $content);
           $block['subject'] = t('Popular content');
           return $block;
         }