Commit Graph

100 Commits (75d4c15f0725d9d730d44713b4c1346b40b88adb)

Author SHA1 Message Date
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Kjartan Mannes 7e6acb5bbd - fixing bug reported by Remco. 2002-04-15 15:10:06 +00:00
Kjartan Mannes 5592761620 This is a major change to the system, needs more testing!
Committing Changes by Moshe Weitzman:
- admin_user_account(), user_edit(), and user_view() no longer have any
  hard code for authentication modules. instead authentication modules
  implement the _user hook.
- fixed a couple 'help' typos.
- linked the 'REGISTER' text in the login block to the register page.
  this page now advertises DA better if site employs DA.
- admins may now edit everything about a user account (was a feature
  request).
- user #1 may now login immediately, in addition to receiving his
  password via email.

Other changes:
- modules and themes are now enabled/disabled in the administrative /
  settings / modules | themes pages. Requires SQL update and things must
  be enabled before your site returns to normal. TODO: enable all
  functionality. (For now just do UPDATE system SET status = 1;)
- removed $themes from conf.php.
- added a $theme->system() function where theme can specify settings.
  All themes in the Drupal CVS have been updated to use this.
- added _system hook to modules. TODO: update modules to use this.
- changed strange use of sprintf to the usual strtr. The disadvantage of
  sprintf is that it requires translations to keep the string order,
  which may not be possible in all languages.
- an invalid/nonexisting theme in a user profile will now fallback to the
  BaseTheme instead of crashing.
2002-04-14 19:34:04 +00:00
Kjartan Mannes a6f0fd4dae - removed some warnings caused by implode. 2002-02-19 22:58:33 +00:00
Kjartan Mannes 9062b566b2 - applying patches from Axel Kollmorgen. See
http://list.drupal.org/drupal-devel/2002-February/thread.html#6678
  http://list.drupal.org/drupal-devel/2002-February/thread.html#6629
- removed references to $this->user() from themes.
- removed $BaseTheme->user(). It was deprecated a while back.

NOTE: this update will break custom themes, so make sure you update your
themes before updating!
2002-02-17 13:04:50 +00:00
Kjartan Mannes 8c672011a2 - moved user block from theme.inc to user.module.
* only problem is that the admin.php link is not available until the
      admin enables the block.
    * $theme->user is obsolete, will patch the themes properly in a
      later patch.
- moved moderation block from theme.inc to queue.module.
    * removed theme_moderation_results().
- updated database/database.mysql.
2002-01-21 17:31:13 +00:00
Dries Buytaert 7e50326274 - Fixed a typo in the example theme. (Patch by Mark) 2002-01-12 21:35:13 +00:00
Dries Buytaert 0567413c85 - Added a "title"-attribute to the "register" link and translated the
"Rembember me" checkbox.
2002-01-11 21:19:54 +00:00
Dries Buytaert a95c2a68aa - import.module:
+ Improved input filtering; this should make the news items look
      more consistent in terms of mark-up.

    + Quoted all array indices: converted all instances of $foo[bar]
      to $foo["bar"].  Made various other changes to make the import
      module compliant with the coding style.

- theme.inc:

    + Fixed small XHTML glitch

- comment system:

    + Made it possible for users to edit their comments (when certain
      criteria are matched).

    + Renamed the SQL table field "lid" to "nid" and updated the code
      to reflect this change: this is a rather /annoying/ change that
      has been asked for a few times.  It will impact the contributed
      BBS/forum modules and requires a tiny SQL update:

        sql> ALTER TABLE comments CHANGE lid nid int(10) NOT NULL;

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

    + Added a delete button to the comment admin form and made it so
      that Drupal prompts for confirmation prior to deleting a comment
      from the database.  This behavior is similar to that of deleting
      nodes.

    + Disabled comment moderation for now.

    + Some of the above changes will make it easier to integrate the
      upcomcing mail-to-web and web-to-mail gateways.  They are part
      of a bigger plan.  ;)

- node system:

    + Made it so that updating nodes (like for instance updating blog
      entries) won't trigger the submission rate throttle.

    + Fixed a small glitch where a node's title wasn't always passed
      to the $theme->header() function.

    + Made "node_array()" and "node_object()" more generic and named
      them "object2array()" and "array2object()".

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

- misc:

    + Applied three patches by Foxen.  One to improve performance of
      the book module, and two other patches to fix small glitches in
      common.inc.  Thanks Foxen!
2001-12-30 16:16:38 +00:00
Steven Wittens e28981f072 - Updated BaseTheme and the Drupal themes to have header($title = "") as the header declaration and use title when provided. This is just a step towards having unique titles.
In all themes, except Marvin which already had $title, I put the $title first, because it's usually the thing the page is about:

"The future of weblogs? - Drop.org"
"Your account settings - Drop.org"

rather than the other way around, right?
2001-12-15 16:22:31 +00:00
Dries Buytaert 42ecb27802 A set of updates to the "_link" system:
- Made the /comment links/ jump to the comments instead of to the top
   of the page.

 - Replaced the "Add comment"-button by a "add new comment"-link.
   (This should make UnConeD jump up and down of wild excitement.)

 - Moved all comment related logic from theme.inc and node.module to
   comment.inc and comment.module (where they belong).

 - Added some links to ease the site's usability/navigation.
2001-11-24 12:14:31 +00:00
Kjartan Mannes f5be5fdfa4 - modified node_save so that revisions are not validated using check_input,
as this breaks revisions.
- modified link_node() to take a third parameter $main, which will be passed on
  to _link hooks. This lets modules decide which links a node will get when
  shown on the main page, or when not.
- updated themes to use the new syntax.
2001-11-23 17:10:46 +00:00
Dries Buytaert 336b713a5f - A large batch of updates, amongst them a rewritten node system. More
information available on the mailing list.
2001-11-01 11:00:51 +00:00
Kjartan Mannes 2f8a5bed5f - added a path field to the blocks. Its a regexp to define which pages you
want the blocks to show up on.
- updated the help.
- did some XMLification.
- SQL update script has a new table collumn which needs to be applied.
2001-10-22 12:55:41 +00:00
Kjartan Mannes 864c18d4c3 - added the CVS keyword $Id$ to all files to make future version tracking
easier. Also changed the <? tag to <?php in some cases.
2001-10-20 18:57:09 +00:00
Dries Buytaert d595fc8f4e - Started a theme.inc clean-up. 2001-10-20 13:35:12 +00:00
Kjartan Mannes 2ec1512419 - blocks will now show up again if 'Enabled: always' 2001-10-16 11:51:03 +00:00
Dries Buytaert 625455b53b - I tidied up most SQL tables to be more consistent with the rest of the
tables: I changed all "id"s to "xid"s where "x" is the first letter of
  the table name.  I also renamed all remaining "userid"s to "uid"s as I
  mentioned I would do.  Take a look at ./drupal/updates/3.00-to-x.xx.sql
  for the MySQL updates.
2001-10-14 15:27:00 +00:00
Dries Buytaert 54d76f753b - Pass theme objects by reference, avoids creating copies and lets called
functions to store data in the theme (patch by Mike Krus).
2001-10-14 07:47:11 +00:00
Dries Buytaert 73d61b7839 - fixed 4 SQL queries to use ANSI SQL instead: '||' --> 'OR' 2001-10-12 18:35:21 +00:00
Dries Buytaert f1932821be - PEAR-ification of Drupal by claw: you can now host Drupal on a wide
range of databases including MySQL, PostgreSQL, MSSQL, and others.

  For additional information and an 'how to upgrade', check the mails
  sent to the mailing list.
2001-10-09 21:01:47 +00:00
Dries Buytaert 47c6fce5ce - added a comment() function to the base theme: you don't have to overload
it in your custom themes

- moved 'theme_account()' to the base theme as '$theme->user()' so that it
  can be themed.
2001-10-07 12:27:58 +00:00
Dries Buytaert 7a9bc86bd2 - Improved search architecture derived from Axel's new search patches.
(There is room for improvement so let's go from these ... and build
  on them.)

- Removed some $status's by calls to node_status().
2001-10-03 20:57:01 +00:00
Dries Buytaert 4a0e498f52 - a batch of updates, including some experimental changes to the moderation
of comments and nodes.
2001-09-27 20:51:26 +00:00
Kjartan Mannes a9d2e12419 - modified theme_block() to ignore blocks that have no content. 2001-09-25 21:26:20 +00:00
Dries Buytaert c5a349ca51 - added the "Log in" block 2001-09-16 16:05:16 +00:00
Dries Buytaert 2d1e9126cb - Added the new user module! 2001-09-16 11:33:14 +00:00
Dries Buytaert 808b6b6cae - Changed the authentication and login scheme as discussed on the mailing
list.
- Fixed the export function in book.module (patch my Julian).
- Fixed the comment alignment (comments got truncated).
2001-08-11 14:54:39 +00:00
Kjartan Mannes 1e5afb398e comment.inc
- removed comment_controls().
- modified comment_render() to use $theme->comment_controls().

theme.inc
- added BaseTheme->comment_controls().

locale.module
- can now search for status independant of language.
- string is now a regular expression. For wildcard searches do .*text.*.
- can search in modules + pages, all modules or a specific module.

account.php
- fixed viewing other accounts info would show the active users name in the
  real name field.
- now shows users recent contributions and comments (if the user has access to
  them).
2001-07-25 08:31:53 +00:00
Dries Buytaert f086779890 - import.module:
+ added new "tab" to import.module called "news sources".
   + improvement to import.module navigation.

- theme.inc:
   + renamed 'your contributions' to 'your submissions'.
2001-07-15 11:32:46 +00:00
Dries Buytaert e724f18db9 - blog.module:
+ added RSS 0.91(5) feeds to the blog module which makes it possible
     to both syndicate an particular user's latest blog entries, or the
     latest entries of all users.
2001-07-14 13:36:38 +00:00
Dries Buytaert b99d4d7a42 - theme system:
+ added $theme->images()

- blog.module:
    + improved user-friendliness and rewrote most of the output routines
    + made quoted text /italic/ by default
    + integrated discussion system like it should
    + ...

- marvin.theme:
    + small visual improvements
2001-07-14 12:12:41 +00:00
Steven Wittens e62e3417f7 Update of the box function in themes to allow a difference in style/output/look of a box() depending on the position on the page.
Basically this is a 'nice version' of a hack that you could do as a theme author.
I've updated all the standard themes, but 3rd party themes will of course have to be updated by their authors, in the following manner:

- Replace the box() declaration:
< function box($subject, $content) {
> function box($subject, $content, $region = "main") {

- Replace the theme_account call:
< theme_account($this);
> theme_account("region", $this);

Note that you'll have to replace "region" with the correct region that the box is placed in. However if you have a one-column theme, you should use "all", and not for example "left" (if all boxes are on the left).
Usually the "region" here should be the same as the nearest theme_blocks() call.

Those theme authors who want to can make boxes that appear in the center look different from those that appear in the sides for example.
2001-07-14 01:01:45 +00:00
Dries Buytaert adfbda3d9a - Tidied up some stuff in account.php and theme.inc.
- Tidied up the box() API.
2001-07-07 11:14:25 +00:00
Dries Buytaert 9c43e8fc7a Extremely large commit:
- Fixed tiny quote problem in account.php.

- Fixed tiny bug in comment.inc.

- Fixed tiny bug in comment.module.

- Fixed tiny bug in meta.module.

- Simplified user_access() API.

- Rewrote link system: still needs fine-tuning and testing so don't
  upgrade if you are running a production site. ;)

  Updated all modules and themes to reflect this change.  All other
  themes and modules need updating too!
2001-06-29 22:08:57 +00:00
Dries Buytaert 5ff9dd653f - Made it possible to enter longer username such as 'Gerhard K*llesreit'.
- Updated database.mysql.
2001-06-23 14:59:15 +00:00
Dries Buytaert 72065fb835 - Added a brand-new access.module which allows you to manage 'roles'
(groups) and 'permissions' ... (inspired by Zope's system).

    + Once installed, click the help-link for more information.

    + See updates/2.00-to-x.xx.sql for the SQL updates.

- Modified loads of code to use our new access.module.  The system
  still has to mature though: new permissions have to be added and
  existing permissions need stream-lining.  Awaiting suggestions.

- As a direct result of the new access system, I had to rewrite the
  way the top-level links in admin.php are rendered and displayed,
  and xhtml-ified admin.php while I was at it.

TODO

- Home-brewed modules need updating, home-brewed themes not.
  (Examples: file.module, trip_link.module)

- As soon we *finished* the refactoring of the user system (KJ has
  been working on this refactoring already) we should consider to
  embed this role and permission code into account.module ...
2001-06-20 20:00:40 +00:00
Dries Buytaert 3d73a48edc - Merged "system settings" and "module settings" into one page. IMHO
it wasn't a good idea to split them up in first place, and it turned
  out to be quite hard to decide where to put some variables.

  Also moved some variables around and even renamed a few variables
  while doing so.

- Added a page_header() and page_footer() to all top-level .php pages.
2001-06-17 20:35:48 +00:00
Kjartan Mannes 7f58ef2970 Changes
- Added a conf option to disable/enable user registrations.
- Added a add account feature to account.module.
- Moved some functions from account.php to account.module.

Todo
- Move most (all?) of account.php to account.module.
2001-06-15 11:34:05 +00:00
Dries Buytaert 2285afd1e0 - Applied Remco's patch:
the <LI>-bullets were not valid HTML and did only take up space.
2001-06-13 08:48:47 +00:00
Steven Wittens 9e5878ae45 - Fixed "administer" not being locale'd. (req. by Gerhard) 2001-06-12 20:24:11 +00:00
Dries Buytaert c56ee67e29 - Changed field_set(), field_get() and field_merge() to use ',' and
'=' instead of ';' and ':'.  It is considered to be more readable.
  --> A _first_ step towards and improved index.module.  Stay tuned
      for more.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

- Changed all 'attribute' to 'attributes'.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

  + Important:
     This might require to ieni-wieni small update to your custom
     themes and/or node-related modules:
      - themes: node_index($node->attribute) -> node_index($node)
      - node modules: attribute -> attributes
2001-06-11 20:01:13 +00:00
Kjartan Mannes 8f7eddbed6 Changes
- fixed the trailing | in some cases.
- removed theme_morelinks().
- added node_links().
- simplified BaseTheme->links().
- updated themes.

Notes
- the new links system is taking form, but concider it beta. There might still
  be some major changes ahead so I suggest waiting a little longer before
  modifying your theme to take advantage of it.
2001-06-11 17:42:51 +00:00
Dries Buytaert d397bbe935 This a rather large commit that needs a lot of fine-tuning. If you
update, you'll break your site as you need switching from structure
to index.module: so this can be considered an intermediate commit.

If you upgrade, and you are welcome to, just create a collection
called "section" (for now) and assign your nodes some attributes
in the described format.

Feedback and bugreports are welcomed.  Questions will be answered.

CHANGES:

- comment system:
   + when replying to a node (rather then to a comment), that
     node is displayed above the reply form.
   + when replying to a comment (rather then to a node), that
     comment is displayd above the reply form.

- removed structure.inc, removed structure.module.

- node.inc:
   + added 2 new node functions called 'node_attribute_edit()' and
     'node_attribute_save()' used to 'hook in' any indexing system
    including your home-brewed stuff if you'd want to.  Currently,
    index.module is the facto default index system.

    See story.module for usage.

- book.module, story.module, poll.module, page.module, forum.module:
   + added preview functionality to administration section (via node
     module).
   + removed all references to structure.inc (category, topic).

- moderate.module:
   + removed all references to structure.inc (category, topic).

- book.module, story.module, page.module, forum.module:
   + increased the sizes of some textareas.

- submit.php:
   + removed all references to structure.inc (category, topic).

- marvin.theme:
   + removed dead code: function story() was depricated.

- unconed.theme:
   + removed hardcoded references to drop.org.

- marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
   + removed all references to structure.inc (category, topic).

TODO:

- file.module, trip_link.module:
   + update preview functionality:
       see story.module for example.
   + remove references to 'cid' and 'tid', use 'attribute' instead:
       see story.module for example.

- extend and build upon index.module as well as making it configurable
2001-06-10 15:01:20 +00:00
Kjartan Mannes 9e4984588c Changes
- created a BaseTheme class in theme.inc.
- added links($links = array(), $status = 0, $node = 0) to BaseTheme.
- modified all themes to extend from BaseTheme.
- modiefied theme_link() to take advantage of $theme->links().
- theme_morelink() does not require a $theme argument.

Todo
- add the other standard variables and functions to BaseTheme.
- some themes could use some more modifications.

Weird
- marvin.theme still has a story() function.
2001-06-10 13:53:44 +00:00
Dries Buytaert 532233a979 - Removed includes/timer.inc: it has been integrated in common.inc.
- Fixed a bug in node.php: UnConeD forgot to update 1 node_get_object().

- I changed the look of theme_morelink() a bit: it might not look better,
  but at least the output is "correct".

- Various small improvements.
2001-05-20 19:30:39 +00:00
Dries Buytaert 6f02738cc2 - Removed the "history"-field from the SQL table "users" and added
this information to the "users"-field in both nodes and comments.
  This database/table change reduces the number of SQL queries and
  makes Drupal scale better where a lot of voting/moderation takes
  place.  Last but not least it can be considered a new and better
  foundation for future moderation metrics / algorithms.  In other
  words: it is plain better.

    --> oops, all voting/moderation results will be lost!
    --> requires database update, see "2.00-to-x.xx.sql"!

- Updated database/database.mysql
2001-05-16 20:54:37 +00:00
Dries Buytaert 86bb9a10cb - Made the main page display sub-topics when a specific topic
is selected.

- Made theme_link() less "hard coded", we still have to make
  it fully configurable though.

- Fixed glitch in story submission: the warning messages were
  not displayed.

- Tidied up block.module a bit.
2001-05-12 21:06:13 +00:00
Dries Buytaert 25c379fb61 - Added custom PHP error handler to track down warnings and errors.
(Jeroen: let's sit back and wait until that warning bites again.)

- Simplified drupal.module.  We still need a feature list, anyone?
2001-05-06 17:19:58 +00:00
Dries Buytaert be8e898d23 - Uhm. Rewrote the module system: less code clutter, less run-time
overhead, and a lot better (simpler) module API.  I had to edit a
  LOT of files to get this refactored but I'm sure it was worth the
  effort.

  For module writers / maintainers:

  None of the hooks changed, so 95% of the old modules should still
  work.  You can remove some code instead as "$module = array(...)"
  just became obsolete.  Also - and let's thank God for this - the
  global variable "$repository" has been eliminated to avoid modules
  relying on, and poking in drupal's internal data structures.  Take
  a look at include/module.inc to investigate the details/changes.

- Improved design of the content modules "story", "book" and "node"
  (to aid smooth integration of permisions + moderate.module).  I'm
  still working on the permissions but I got side tracked for which
  I "Oops!".
2001-05-05 13:57:29 +00:00