Commit Graph

262 Commits (6fc4eb9f945ecd7c2bea4742e3febe4632c88e99)

Author SHA1 Message Date
Angie Byron d59ba41f65 #313213 by maartenvg, Gábor Hojtsy: Add a 'title' attribute for permissions to allow for localization of permission names 2008-10-09 15:15:55 +00:00
Dries Buytaert 87567f8916 - Patch #310212 by justinrandell: killed in _node hook, as well as twelve sable tooth tigers. 2008-10-06 12:55:56 +00:00
Dries Buytaert 9f3d9f1115 - Patch #161301 by Eaton, Sun, moshe and webchick: make checking for node edit forms easier. DX improvement. 2008-09-27 20:37:01 +00:00
Dries Buytaert 9020f77388 - Patch #302149 by pwolanin: fixed confusing/duplicate use of names in menu admin. 2008-09-18 10:44:19 +00:00
Angie Byron 161a9970f7 #308534 by Dave Reid: Remove stray whitespace core-wide. 2008-09-15 20:48:10 +00:00
Dries Buytaert 69e6f411a9 - Patch #225450 by Crell, chx, bjaspan, catch, swentel, recidive et al: next generation database layer for Drupal 7. 2008-08-21 19:36:39 +00:00
Dries Buytaert ccf1af94fa - Patch #245329 by christefano and dmitrig01: code comment love. 2008-07-24 16:25:19 +00:00
Dries Buytaert 57fe5103da - Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value. 2008-07-16 21:59:29 +00:00
Dries Buytaert 5299b92689 - Patch #270917 by catch, Bojhan, et al: renamed 'primary links' and 'secondary links' to 'main menu' and 'secondary menu' respectively. Based on usability study conducted with the help of Bojhan. 2008-06-25 09:12:25 +00:00
Dries Buytaert c6c26b5e23 - Patch #247423 by boombatower: code style fixes for the tests. 2008-05-30 07:30:53 +00:00
Dries Buytaert a96ffc1185 - Patch #256736 by flobruit: fixed bad HTML in help text. flobruit is on a patching spree! 2008-05-10 06:52:32 +00:00
Dries Buytaert 2e18cb8924 - Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit
et al.  Can you say 'registry'?  Drupal now maintains an internal registry of
  all functions or classes in the system, allowing it to lazy-load code files as
  needed (reducing the amount of code that must be parsed on each request). The
  list of included files is cached per menu callback for subsequent loading by
  the menu router. This way, a given page request will have all the code it needs
  but little else, minimizing time spent parsing unneeded code.
2008-05-06 12:18:54 +00:00
Dries Buytaert 21576021bf - Patch #249546 by pwolanin: rip menu access inheritance -- was already committed to D6. 2008-04-23 20:01:56 +00:00
Dries Buytaert af474609e3 - Added a test framework to Drupal along with a first batch of tests for
Drupal core!  This is an important milestone for the project so enable
  the module and check it out ... :)

  Thanks to Rok Žlender, Károly Négyesi, Jimmy Berry, Kevin Bridges, Charlie
  Gordon, Douglas Hubler, Miglius Alaburda, Andy Kirkham, Dimitri13, Kieran
  Lal, Moshe Weitzman, and the many other people that helped with testing
  over the past years and that drove this home.

  It all works but it is still rough around the edges (i.e. documentation
  is still being written, the coding style is not 100% yet, a number of
  tests still fail) but we spent the entire weekend working on it in Paris
  and made a ton of progress.  The best way to help and to get up to speed,
  is to start writing and contributing some tests ... as well as fixing
  some of the failures.

  For those willing to help with improving the test framework, here are
  some next steps and issues to resolve:

    - How to best approach unit tests and mock functions?
    - How to test drupal_mail() and drupal_http_request()?
    - How to improve the admin UI so we have a nice progress bar?
    - How best to do code coverage?
    - See http://g.d.o/node/10099 for more ...
2008-04-20 18:24:07 +00:00
Dries Buytaert 56d2664a90 - Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators. 2008-04-14 17:48:46 +00:00
Dries Buytaert 79b016d915 - Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php.  The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:

    block-user-0.tpl.php --> block-user-navigation.tpl.php
    block-user-1.tpl.php --> block-user-login.tpl.php

  You get the picture.
2008-04-10 10:28:23 +00:00
Dries Buytaert 39f1a6be73 - Patch #234065 by David_Rothstein: added missing period. 2008-03-14 08:54:31 +00:00
Dries Buytaert a730d23d14 - Patch #216813 by pwolanin et al: fixed upgrade path for primary links and navigation. 2008-02-23 08:13:09 +00:00
Dries Buytaert 584f3e886a - Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page. 2008-02-20 13:46:43 +00:00
Dries Buytaert b05db1f176 - Patch #221384 by webernet: update core compatibility to Drupal 7. 2008-02-18 19:19:49 +00:00
Dries Buytaert bbc65c30fa - Patch #220004 by webernet et al: menu items reorder after edit one of menu item. 2008-02-12 13:43:21 +00:00
Dries Buytaert ec9f8e090a - Patch #216904 by pwolanin et al: if there are more than 21 menu items under a parent, the weights got screwy. 2008-02-10 19:14:08 +00:00
Dries Buytaert b8a1eab1fb - Patch #210131 by dvessel, catch, John, et al: updated jQuery library. 2008-02-06 19:38:28 +00:00
Gábor Hojtsy 39d28bd43e #215858 by pwolanin: localized menu options were saved into the database, avoid this by using different variable names / array keys 2008-02-04 12:07:23 +00:00
Gábor Hojtsy d171a9e75a #216014 report by meba, patch by myself: menu_install() did not use get_t() for its menu item creation 2008-01-30 20:27:28 +00:00
Gábor Hojtsy 3a126a55ba #208498 by pwolanin: remove pager from menu admin page (for big menus, you will need to use a contrib module) 2008-01-21 12:12:44 +00:00
Gábor Hojtsy 00f0a95ade #207372 by Pancho, pwolanin, chx: remove duplicate query from menu_enable() 2008-01-08 15:49:09 +00:00
Gábor Hojtsy be324d8f70 #195091 by Rowanw: (usability) swap enabled and expanded checkbox in menu admin and allow setting elements without children to be expanded 2008-01-08 11:31:49 +00:00
Gábor Hojtsy 18cabdb8d3 #205843 report by asimmonds, patch by chx: menu_valid_path() was used as an API function, but was located in menu.module, move to menu.inc 2008-01-03 09:59:00 +00:00
Gábor Hojtsy ac4c8f7ab0 #203274 by Pasqualle: remove excessive witespace from our code (minor) 2007-12-22 23:24:26 +00:00
Gábor Hojtsy 6a95c27147 #202425 by keith.smith: standardize reference to block placement page as 'blocks administration page' to avoid any confusion 2007-12-19 19:13:29 +00:00
Gábor Hojtsy 4c6f9664b8 #189881 by keith.smith: document drag and drop in menus and clean up some more help text 2007-12-19 13:49:23 +00:00
Dries Buytaert 02539ac3f8 - Patch #195496 by bjaspan and hunmonk: no 'char' data type in Schema API (and removed spaces). 2007-12-18 10:31:42 +00:00
Gábor Hojtsy 6d77540b23 #199428 by Lynn: default to the primary links for content menu items (usability) 2007-12-16 18:25:22 +00:00
Gábor Hojtsy b6532a4fdb #200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed 2007-12-14 18:08:50 +00:00
Gábor Hojtsy a64e5f38d1 #195083 by Rowanw and keith.smith: menu items are not displayed on the main menu page anymore; update help text 2007-12-13 10:34:07 +00:00
Gábor Hojtsy 6b5364a856 #199191 by Nick Lewis, Lynn: (usability) include the enabled checkbox directly on the menu item editing page too 2007-12-11 12:17:58 +00:00
Gábor Hojtsy cd8afc2be1 #196043 by chx: menu items saved in the update but broken on the new system (due to coming from disabled or old modules) were not possible to delete 2007-12-06 21:35:14 +00:00
Gábor Hojtsy ccf72e9417 #197386 follow up by JirkaRybka: tiny coding style issue 2007-12-06 21:02:57 +00:00
Gábor Hojtsy 490386721d #197385 by chx and catch: the menu system stores only non-aliased paths, so alert users to this, when they try to save aliased paths 2007-12-06 10:37:47 +00:00
Gábor Hojtsy d83289f857 #196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions 2007-12-06 09:58:34 +00:00
Dries Buytaert 9a96837b89 - Patch #163246 by keith smith, freso, O Govinda, catch, webchick et al: fixed minor spelling issues and fixed spacing issues. 2007-11-26 16:36:44 +00:00
Dries Buytaert 58852d4b7b - Patch #192736 by quicksketch et al: drag and drop for book module. 2007-11-26 16:19:37 +00:00
Gábor Hojtsy 5dcacebf26 #194166 rollback and additional comments by chx: developers can modify menu editing behavior with hook_form_alter(), no need for menu API hacks, which were half done anyway 2007-11-24 20:59:32 +00:00
Dries Buytaert 4d6c7bd41a - Modified patch #194166 by profix898 and chx: menu system does not respect MENU_MODIFIABLE_BY_ADMIN. 2007-11-23 13:31:36 +00:00
Gábor Hojtsy 06c886d45b #194174 by webernet: flag DnD modified links as customized, so they can be restored to their original form on the UI 2007-11-21 19:12:00 +00:00
Gábor Hojtsy 7f85abe0e5 #191360 by chx: allow contributed modules to override the book and menu parent selectors (to improve usability and performance) 2007-11-21 19:08:18 +00:00
Dries Buytaert ece869b0b2 - Patch #192242 by catch, quicksketch, webchick, keith et all: usability improvements for the vocabulary/term forms. 2007-11-20 13:24:54 +00:00
Gábor Hojtsy 6d4862c258 #181126 by quicksketch et al: drag and drop support for menus 2007-11-20 10:18:43 +00:00
Dries Buytaert 8ebc345b9d - Patch #191914 by chx: you cannot add user/register to a menu. Also removed some whitespace. 2007-11-17 14:25:23 +00:00
Dries Buytaert 073eb45833 - Patch #191073 by Keith: another good string cleanup by Keith. (Also removed some trailing whitespace.) 2007-11-11 06:56:44 +00:00
Gábor Hojtsy a42a9d3efd #178608 by chx: convert menu overview page to a form to overcome any CSRF vulnerabilities 2007-11-09 22:14:41 +00:00
Gábor Hojtsy b94f2716cf #184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed 2007-10-21 18:59:02 +00:00
Gábor Hojtsy 8cf6fefe54 #164983 by multiple contributors: document the core database schemas 2007-10-10 11:39:35 +00:00
Dries Buytaert afb7bf85fe - Clean-up menu link 2007-10-07 09:50:01 +00:00
Dries Buytaert 39706e3c51 - Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes. 2007-10-05 14:43:26 +00:00
Gábor Hojtsy fc79722b39 #90570 by bdragon and chx: GET query and fragment information were not possible to define in menu links 2007-09-27 16:59:54 +00:00
Gábor Hojtsy 206d652a82 #162276 by Rowanw: usability - reword menu item deletion checkbox label 2007-09-20 08:41:33 +00:00
Gábor Hojtsy ffa1f6ef69 #174267 by kkaefer: improve wording of some menu messages, and add a missing format_plural() 2007-09-12 11:48:15 +00:00
Gábor Hojtsy 614f685bdc #170651 by pwolanin: slipt menu module into the module and an admin.inc for admin pages, to help performance 2007-08-30 16:27:12 +00:00
Gábor Hojtsy bd380ed915 #147657 follow up patch by drewish and bdragon: fixed coding style and a notice 2007-08-29 23:18:58 +00:00
Gábor Hojtsy 2765d143c0 #147657 by chx: menu module update function 2007-08-29 20:46:18 +00:00
Gábor Hojtsy 89aef5b74f #171019 by pwolanin: do not exclude the primary and secondary links from the menu block list 2007-08-28 13:16:36 +00:00
Dries Buytaert fb322f08da - Patch #169065 by pwolanin: links to new menus can exist outside 'navigation'. 2007-08-22 14:48:39 +00:00
Gábor Hojtsy 6eaaa3c1b3 #160168 by kkaefer and pwolanin: restore lost Drupal 5 functionality of being able to set primary and secondary links differently 2007-08-20 18:26:41 +00:00
Gábor Hojtsy ced08bf27a #166586 by hswong3i: move literal values out of menu module queries (for better db compatibility, ie. easier query rewriting) 2007-08-20 18:18:15 +00:00
Gábor Hojtsy f4dc86046f #165675 follow up patch by pwolanin: retain menu information on node previews to check, do not use the newly selected values yet, to be consistent with the DB 2007-08-20 17:54:35 +00:00
Dries Buytaert 74292cd062 - Patch #80951 by killes, yched et al: block caching. 2007-08-19 08:08:45 +00:00
Gábor Hojtsy 115285f30a #165675 by pwolanin: only show allowed parent items in menu/book select fields to avoid going deeper then what is allowed 2007-08-16 12:47:34 +00:00
Dries Buytaert 15c68075d9 - Patch #154470 by pwolanin et al: optimize menu queries and indices. 2007-08-11 14:06:15 +00:00
Dries Buytaert 80ff5109a7 - Patch #162708 by Eaton and Earl: add support for image buttons to FAPI3.
This is a small form API extension (doesn't break existing code) that
  facilitates the Drupal 6 upgrade of the Views module.  A good example
  of why it can be beneficial to start upgrading your modules early on in
  the code freeze. ;)
2007-07-29 17:28:23 +00:00
Gábor Hojtsy 50955e3801 #156626 by pwolanin: allow deletion of custom menus 2007-07-25 14:44:03 +00:00
Dries Buytaert 78031b77e1 - Patch #154469 by pwolanin: improve performance of access checks and add localized sorting. 2007-07-16 12:51:03 +00:00
Gábor Hojtsy 64def7cb3e #100641 by kkaefer, ChrisKennedy and RobRoy: change 'Submit' buttons to 'Save' to compliy with the desktop metaphor and actually tell what the button does ('we know it submits the form, but what it does?') 2007-07-16 12:43:06 +00:00
Dries Buytaert 6ec2ff7e15 - Patch #94154 by dww, Earl et al: update notifications for Drupal!
Woot, woot! :)
2007-07-11 15:15:40 +00:00
Gábor Hojtsy 70f9297c10 #156770 by pwolanin: fix bug to only prepend 'menu-' to menu item names when submitting a *new* menu item, not on all edit operations 2007-07-10 11:23:32 +00:00
Dries Buytaert c7eef3d27b - Patch #151055 by pwolanin et al: fixed problems with moving menu items. 2007-07-09 18:08:15 +00:00
Gábor Hojtsy 806d0a3dee #156910 by asimmonds: fix code indentation problems introduced with new code in this development cycle; only whitespace changes 2007-07-05 08:48:58 +00:00
Gábor Hojtsy 07a8d9bcb3 #156782 by webernet and pwolanin: clean up menu API and menu module code comments, fix typos, wrap lines properly and fix some coding style issues 2007-07-04 21:33:55 +00:00
Gábor Hojtsy 0c0a340f29 #156793 by webernet: menu reset confirmation form contained deletion API remainings 2007-07-04 18:56:12 +00:00
Dries Buytaert e0fe1ae8eb - Patch #151583 by pwolanin, Shakur, webernet, Arancaytar et al: various menu module fixes. 2007-07-04 15:49:44 +00:00
Dries Buytaert ee701b3336 - Patch #155986 by Uwe: fixed typos. 2007-07-02 14:41:37 +00:00
Dries Buytaert e59852d336 - Rollback of patch #147723: delete API. Talked to Steven and Gabor and we
unanimously agreed to rollback the deletion API.  We all support the
  features this patch added, yet not its actual design and implementation.
  After some talk, we decided that it would be better for Drupal -- in the
  long term -- not to go with a solution that isn't 100%. We also recognize
  that in the short term, this patch would have been useful addition. So
  let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Gábor Hojtsy 9e6ef53c2c #154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array 2007-06-30 19:46:58 +00:00
Steven Wittens 7093495f7c #154046: Optimize confirm_form syntax for common usage (and fix some $form_state bugs). 2007-06-24 10:09:53 +00:00
Steven Wittens fe8b35f527 #153781: Convert all remaining confirm_forms() to deletion api. 2007-06-22 08:32:28 +00:00
Dries Buytaert 29eb5a6284 - Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version. 2007-06-08 05:50:58 +00:00
Dries Buytaert 722f8faae9 - Patch #147656 by Shakur: bugfix. 2007-06-06 06:18:47 +00:00
Dries Buytaert c4d170c961 - Patch #147656 by pwolanin and chx: menu module update for Drupal 6. 2007-06-05 09:15:02 +00:00
Dries Buytaert e629deb94d - Patch #146667 by Jeff Eaton: form API fixes. 2007-06-04 15:56:34 +00:00
Dries Buytaert 1fe90cba4f - Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments 2007-06-04 07:22:23 +00:00
Dries Buytaert 96926ca047 - Patch #146470 by Eaton et al: standardize form API3 hook parameter order. 2007-05-28 06:08:47 +00:00
Dries Buytaert a8ceb7613b - Patch #145058 by pwolanin (and chx): re-parenting and caching for menu links. 2007-05-27 20:31:13 +00:00
Dries Buytaert 633540ef8c - Patch #144765 by ChrisKennedy, drewish, bjaspan et al: schema fixes. 2007-05-25 20:52:44 +00:00
Dries Buytaert 3cafffe63f - Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave. 2007-05-25 12:46:46 +00:00
Dries Buytaert a243145d3f - Patch #137767 by chx and pwolanin: multiple menu support. 2007-05-16 13:45:17 +00:00
Dries Buytaert ac65ff9074 - Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :) 2007-05-14 13:43:38 +00:00
Dries Buytaert 7d4f2836ba - Patch #128082 by Goba et al: Allow localization of built-in menu items. 2007-04-30 17:03:29 +00:00
Dries Buytaert f73610bec6 - Patch #76588 by Gabor: made log messages translatable. Yay. 2007-04-24 13:53:15 +00:00
Dries Buytaert 7c89dee568 - Patch #131009 by chx: menu system fixes/improvements. 2007-04-15 14:38:16 +00:00