Commit Graph

51 Commits (61a62b27ce14a3a775eaefc9c29ce36dff1e911e)

Author SHA1 Message Date
webchick ae4177b829 Issue #2159965 by Wim Leers, jessebeach: Fix two memory leaks + subtle bugs in Edit's JS (discovered by working on the Backbone upgrade in the D7 backport). 2013-12-23 12:50:36 -08:00
catch c049f3f1d6 Issue #2005644 by Wim Leers, damiankloip, beejeebus, amateescu: Use client-side cache tags & caching to eliminate 1 HTTP requests/page for in-place editing metadata, introduce drupalSettings.user.permissionsHash. 2013-12-22 21:58:10 +00:00
webchick 5e4fb4fcd5 Issue #2154589 by Wim Leers: Edit breaks when the entity title is promoted to the page title (discovered by backporting). 2013-12-19 10:22:19 -08:00
Dries ebad0cd942 Issue #2075185 by Wim Leers: When an entity is in-place edited (i.e. saved), other instances of that entity on the same page are not updated (no propagation). 2013-12-18 14:41:13 -05:00
webchick c5ec897acf Issue #2055937 by Wim Leers, jessebeach: Introduce error handling to in-place editing; if an AJAX request to commit changes fails, the user cannot recover. 2013-12-13 23:19:04 -08:00
webchick a5bff94dc6 Issue #2149933 by nod_: Improve Edit module JS to use .find(...) instead of .is(':has(...)'). 2013-12-10 23:03:58 -08:00
webchick b8288cf90a Revert "Issue #2149933 by effulgentsia: Improve Edit module JS to use .find(...) instead of .is(':has(...)')."
Wrong commit credit.

This reverts commit af335ce5c7.
2013-12-10 23:03:36 -08:00
webchick af335ce5c7 Issue #2149933 by effulgentsia: Improve Edit module JS to use .find(...) instead of .is(':has(...)'). 2013-12-10 23:03:17 -08:00
webchick 46f4289e8a Issue #2137005 by jessebeach: Don't hide comments during in-place editing of an Article; position the entity toolbar more intelligently. 2013-12-10 23:00:36 -08:00
Dries 258b9a310c Issue #2149599 by Wim Leers: Fix minor bugs and minor coding standards violations in edit.module, discovered by backporting. 2013-12-10 17:01:45 -05:00
Dries 7d36579df3 Issue #2133889 by Wim Leers: Clean up Edit: rename EditorDecorationView to FieldDecorationView. 2013-12-10 17:00:13 -05:00
Dries 1069bef402 Issue #2141055 by Wim Leers: When multiple instances of the same entity on one page, only the first can be edited. 2013-12-10 16:54:38 -05:00
webchick 8e7a2905ef Issue #2135689 by Wim Leers: Clean up edit.module to match coding standards. 2013-12-03 21:18:34 -08:00
Jennifer Hodgdon 80fbd33d97 Issue #2145077 by TR, longwave: Fix about a zillion spelling errors, mostly in comments 2013-12-03 07:54:20 -08:00
Nathaniel Catchpole 15fded0c84 Issue #1988612 by effulgentsia, yched, Wim Leers, Berdir, Pancho: Apply formatters and widgets to rendered entity base fields, starting with node.title. 2013-12-03 11:53:16 +00:00
webchick afa2377dca Issue #2134929 by Wim Leers: Clean up Edit: rename EntityView to EntityDecorationView. 2013-11-22 19:13:41 -08:00
webchick 0871544264 Issue #2133869 by Wim Leers: Clean up Edit's data- attributes. 2013-11-13 07:26:44 -08:00
webchick b810cf1dbd Issue #2133871 by Wim Leers: Remove dead code from Edit: Drupal.edit.AppView.enableEditor. 2013-11-13 07:24:27 -08:00
webchick cf59aaf8fb Issue #2133877 by Wim Leers: Clean up Edit's AppView variable names. 2013-11-13 07:23:33 -08:00
webchick 64c97584c4 Issue #2133897 by Wim Leers: Clean up Edit: don't pass AJAX URLs from the server to the client through drupalSettings, use Drupal.url() instead. 2013-11-13 07:06:05 -08:00
webchick 8a68d25d9a Issue #2133907 by Wim Leers: Clean up Edit's in-place editors: consistent naming, library naming and file naming. 2013-11-13 07:04:04 -08:00
webchick 7a17c82533 Issue #1993894 by mgifford, Jelle_S, Wim Leers | jessebeach: Contextual quick edit toggle should be a <a role='button'> not a <a> because it tracks on/off state. 2013-10-11 07:34:17 -07:00
webchick ea72375a15 Issue #2107199 by Wim Leers: Allow Close(Modal)DialogCommand to remove the dialog from the DOM, document how client-side dialogs can do that too. 2013-10-10 08:32:35 -07:00
webchick 9f6d0920f6 Issue #2089397 by jessebeach, swentel, Wim Leers: Fixed Double 'Quick edit' contextual link. 2013-10-10 07:53:15 -07:00
webchick 1a1ba935cf Revert "Issue #2089397 by swentel, Wim Leers: Fixed Double 'Quick edit' contextual link."
Wrong commit message.

This reverts commit 9bc576cded.
2013-10-10 07:52:48 -07:00
webchick 9bc576cded Issue #2089397 by swentel, Wim Leers: Fixed Double 'Quick edit' contextual link. 2013-10-10 07:52:28 -07:00
webchick 5b24f7bcdd Issue #2080217 by Wim Leers, tkoleary, Bojhan: Polish entity toolbar visually. 2013-10-05 00:14:39 -07:00
webchick 34078b7291 Issue #2058843 by rteijeiro, jessebeach: Be consistent with respect to which strings within JS code should be overriddable via drupalSettings. 2013-09-22 01:05:50 +02:00
webchick 690e51d545 Issue #1872296 by nod_, Wim Leers, jessebeach: Edit should use core-provided Dialog (instead of its own). 2013-08-28 01:59:51 -07:00
Dries e924593126 Issue #1678002 by jessebeach, Wim Leers, Gábor Hojtsy: Edit should provide a usable entity-level toolbar for saving fields. 2013-06-29 17:42:22 -04:00
Alex Pott da1b134af1 Issue #1363112 by mparker17, mgifford, tlattimore, Jacine, dcmouyard, bowersox, ry5n, ahdiaz: Simplify names of 'element-x' helper classes. 2013-06-17 21:58:27 +02:00
Alex Pott 3b61f06bf9 Issue #2019481 by nod_: JavaScript AJAX commands object is borked: it is shared among all Drupal.ajax instances, preventing scoped overrides. 2013-06-14 15:37:00 +02:00
Dries 30251ca252 Issue #1980744 by Wim Leers: Turn edit/metadata into a JsonResponse again, to allow contrib to implement client-side caching of metadata. 2013-06-05 12:58:11 -04:00
Alex Pott 895e29fce3 Issue #1955292 by tmckeown, droplet, nod_: JSHint edit. 2013-05-31 10:14:36 +01:00
Nathaniel Catchpole eea18a4869 Issue #914382 by Wim Leers, Cottser, Gábor Hojtsy, franz, droplet, sun, Niklas Fiekas, catch, dawehner, effulgentsia: Fixed Contextual links incompatible with render cache. 2013-05-20 09:35:41 +01:00
Dries ea2ac54516 Issue #1979784 by Wim Leers, jessebeach: Factor Create.js and VIE.js out of the Edit module. 2013-05-14 15:02:48 -04:00
webchick cbdaaaf21e Issue #1981760 by Wim Leers, nod_: Edit should use the new drupalContextualLinkAdded event to cleanly instead of hackily insert its 'Quick edit' contextual link. 2013-05-03 09:08:47 -07:00
webchick bceb85e8d4 Issue #1943776 by Wim Leers, nod_: In-place editors (Create.js PropertyEditor widgets) should be loaded lazily. 2013-04-26 08:52:01 -07:00
webchick 3c89188181 Issue #1967728 by Wim Leers: Fixed In-place editing toolbars in DOM not removed after stopping in-place editing. 2013-04-12 00:08:19 -07:00
webchick dd85e54ab1 Issue #1799594 by nod_, Wim Leers, jessebeach, jcisio: Update to jQuery 1.9 version. 2013-04-09 13:58:51 -07:00
webchick 2e3c6842c0 Issue #1960612 by Wim Leers, bergie, scottgonzalez: Fixed jQuery UI 1.10 update broke Create.js, and thus in-place editing. 2013-04-07 12:51:35 -07:00
webchick 2ad7c18229 Revert "Issue #1960612 by Wim Leers: Fixed jQuery UI 1.10 update broke Create.js, and thus in-place editing."
Sorry, this should be giving credit to more people. Rolling back.

This reverts commit 96b69b0a5d.
2013-04-07 12:50:50 -07:00
webchick 96b69b0a5d Issue #1960612 by Wim Leers: Fixed jQuery UI 1.10 update broke Create.js, and thus in-place editing. 2013-04-07 12:49:13 -07:00
webchick 8199247dc8 Issue #1954246 by Wim Leers: Fixed Underlying content visible in the editing area while using PropertyEditor widget that uses padding. 2013-04-02 08:46:33 -07:00
webchick 03b6a41085 Issue #1886566 by Wim Leers, sun, effulgentsia, quicksketch: Make WYSIWYG editors available for in-place editing. 2013-03-20 14:38:12 -04:00
Dries ac85fddb90 Issue #1894454 by Wim Leers: port improvements from D7 Edit to D8. 2013-03-15 12:06:54 -04:00
Dries 6d5c211392 Issue #1874664 by Wim Leers, jessebeach, tkoleary, Gábor Hojtsy, quicksketch, Bojhan: Reconcile 'Edit' toolbar option with local tasks (tabs) and contextual links for editing. 2013-02-12 16:46:04 -05:00
webchick 6a7def45fb Issue #1908624 by jessebeach, tkoleary: Update edit modules implementation of hook_toolbar(); refresh the design to match current mockups. 2013-02-08 16:18:00 -08:00
webchick 65e54edbe7 Issue #1874936 by frega, Wim Leers: Pluggable in-place editors (allow modules to define new Create.js PropertyEditor widgets). 2013-01-14 14:25:23 -08:00
webchick e42ba76986 Issue #1875874 by Wim Leers, frega: Minor clean-up for Edit (more generic WYSIWYG editor integration facilities, prevent Drupal behaviors on transport forms) 2013-01-02 16:03:22 -08:00