Gábor Hojtsy
ac7637bc9b
#172773 by numerous contributors: Make the actions interface usable by mere mortals (including rename of actions.module to trigger, but keeping the actions themselfs).
...
Complete previous history of actions module:
- #148410 by jvandyk: added rewrite of the actions module!
- #155986 by Uwe: fixed typos.
- #155828 by Eaton, pwolanin and jvandyk: let actions live even if actions.module is not turned on
2007-09-11 14:50:05 +00:00
Gábor Hojtsy
e3daf88ec7
#166742 by Crell and dvessel: split user module (for performance reasons)
2007-09-10 13:14:38 +00:00
Gábor Hojtsy
ea0f102c21
#174224 by kkaefer: send user notification email after the user object is updated
2007-09-09 20:21:02 +00:00
Gábor Hojtsy
4a347be7ed
#173225 corrective fix: there were two uses of the ip variable, so revert to the original patch
2007-09-08 13:57:22 +00:00
Dries Buytaert
15b52931a2
- Patch #173225 by killes: missing ip_address(). Slightly modified by me.
2007-09-08 08:57:26 +00:00
Gábor Hojtsy
9307321817
#148677 by pwolanin: set active menu item on 403/404 pages (and on the user page)
2007-09-06 12:47:20 +00:00
Dries Buytaert
957997516d
- Patch #172765 by webchick and chx: path 'user' returns 403
2007-09-04 14:37:48 +00:00
Gábor Hojtsy
1e04b134f4
#172453 by webchick: proper default value for user roles (radios need an int, not an array)
2007-09-02 12:46:21 +00:00
Gábor Hojtsy
3d6b273206
#172455 by chx: a notice and missing form API conversions in user module
2007-09-02 12:24:49 +00:00
Gábor Hojtsy
118e91cc40
#155828 by Eaton, pwolanin and jvandyk: let actions live even if actions.module is not turned on
2007-08-29 14:57:50 +00:00
Dries Buytaert
7531f956aa
- Patch #169627 by JirkaRybka: improved logging of mail problems.
2007-08-26 08:00:49 +00:00
Dries Buytaert
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
Dries Buytaert
74292cd062
- Patch #80951 by killes, yched et al: block caching.
2007-08-19 08:08:45 +00:00
Gábor Hojtsy
8971add849
#163191 follow up patch by hswong3i and pwolanin: use a has_rows flag where we dont need a counter
2007-08-18 20:03:19 +00:00
Gábor Hojtsy
6ecef0ee38
#156796 by webernet, asimmonds and pwolanin: user editing forms cleanup and fixing deletion API remainings
2007-08-16 13:07:31 +00:00
Gábor Hojtsy
c3207e0ec1
#162050 by dvessel: user_comment() now modifies the comment, although hook_comment() was not intended to modify the comment, so we need to pass it in by reference to get modified
2007-08-16 09:32:06 +00:00
Gábor Hojtsy
bc33e002fa
#166688 by pwolanin: user_build_content() needs to have the account passed by reference
2007-08-12 19:25:57 +00:00
Dries Buytaert
c17499b6fe
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement. (Correct version this time.)
2007-08-12 16:12:00 +00:00
Dries Buytaert
b134b023e1
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement.
2007-08-12 15:55:36 +00:00
Gábor Hojtsy
51b0221331
#165358 by John Morahan: do not regenerate the session when the user is saved without a password specified
2007-08-09 10:49:26 +00:00
Dries Buytaert
d713b11adb
- I forgot to remove these earlier when we renamed them.
2007-08-08 07:50:38 +00:00
Gábor Hojtsy
f23c24c8a3
#164935 by Ralf Stamm: standardize CVS Id tags in files:
...
- always include CVS Id tags in all files
- add a new line after the CVS Id, if more code or phpdoc follows in the same code block
- fix bogus Id tags previously added
2007-08-07 08:39:36 +00:00
Dries Buytaert
79d8390f90
- Patch #161510 by dvessel: tplified user.module.
2007-08-02 10:41:26 +00:00
Dries Buytaert
bf7a70f98c
- Patch #156553 by AjK: fixed E_NOTICE
2007-08-02 10:22:45 +00:00
Dries Buytaert
1c55ed7d88
- Patch #162486 by Eaton: user/%user/edit/foo tabs only appear if additional profile categories have been defined.
2007-07-27 13:08:17 +00:00
Gábor Hojtsy
6ea74bfe47
#149092 by Gurpartap Singh slightly modified: Usability: generalize timezone discovery to use on user registration
2007-07-25 17:35:47 +00:00
Gábor Hojtsy
61b225ee8b
161496 by meba: display message about successful login, if registration verification is not required
2007-07-25 14:49:55 +00:00
Gábor Hojtsy
64def7cb3e
#100641 by kkaefer, ChrisKennedy and RobRoy: change 'Submit' buttons to 'Save' to compliy with the desktop metaphor and actually tell what the button does ('we know it submits the form, but what it does?')
2007-07-16 12:43:06 +00:00
Dries Buytaert
08c059ec77
- Rollback of patch #147947 : lacks proper upgrade path.
2007-07-15 10:09:21 +00:00
Dries Buytaert
83654b3dd9
- Patch #159332 by jakeg: can't save roles on user_save().
2007-07-14 15:21:38 +00:00
Gábor Hojtsy
e4c7378ef3
#158289 by merlinofchaos: Remove paragraph tag from drupal_set_message()
2007-07-11 19:59:11 +00:00
Gábor Hojtsy
806d0a3dee
#156910 by asimmonds: fix code indentation problems introduced with new code in this development cycle; only whitespace changes
2007-07-05 08:48:58 +00:00
Gábor Hojtsy
92a32a8676
#156812 by tangent: coding style issues corrected in user.module, identified with coder module
2007-07-04 21:42:39 +00:00
Dries Buytaert
ee701b3336
- Patch #155986 by Uwe: fixed typos.
2007-07-02 14:41:37 +00:00
Gábor Hojtsy
8caf4da7f1
#82499 by Jose A Reyero and a little bit from myself: send emails localized in the language needed in specific situations, and centralize mail composing operations with hook_mail()
2007-07-01 19:49:19 +00:00
Dries Buytaert
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Dries Buytaert
c11cb4ec24
- Patch #120360 by nedjo: enable AJAX by making all behaviours reattachable.
2007-07-01 15:37:10 +00:00
Gábor Hojtsy
9e6ef53c2c
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
2007-06-30 19:46:58 +00:00
Dries Buytaert
15bf4681c2
- Patch #130108 by webchick: link to newly created account in admin panel.
2007-06-29 18:19:25 +00:00
Dries Buytaert
2348e7de6f
- Patch #148410 by jvandyk: added rewrite of the actions module!
...
This is a very important patch, but one that is merely an enabler.
Hopefully we'll see more people submitting "action patches" in the
near future.
Thanks for the hard work and persistence, John. *If* you decide
to update the Drupal Pro Development book to Drupal 6, make sure
to add a chapter on actions. ;)
2007-06-29 18:06:51 +00:00
Dries Buytaert
8dd8b0c223
- Patch #118730 by kaerast, kkaefer and webchick: subltle but important documentation improvement
2007-06-29 11:18:40 +00:00
Dries Buytaert
2bf7c1c0e3
- Patch #147662 by Gordon et al: add new #pre_render callback to drupal_render().
2007-06-28 07:48:41 +00:00
Gábor Hojtsy
cc9f167e49
#154218 by Steven: HTML to text email converter, centralizing email wrapping in Drupal core and providing a solid conversion function for contributed modules
2007-06-26 22:21:08 +00:00
Steven Wittens
7093495f7c
#154046 : Optimize confirm_form syntax for common usage (and fix some $form_state bugs).
2007-06-24 10:09:53 +00:00
Steven Wittens
028c8e6050
#148678 : Fix notices/warnings on invalid paths like 'node/zzz'. (chx/pwolanin/webernet)
2007-06-24 00:38:40 +00:00
Gábor Hojtsy
b1d45297e7
#113983 by damien_vancouver and myself: allow administrators to search users by e-mail too
2007-06-23 21:35:08 +00:00
Gábor Hojtsy
68e7598b87
#152492 by JohnAlbin: clean up global user setting, which is done already
2007-06-23 13:15:49 +00:00
Gábor Hojtsy
1d6be6f0b7
#153372 by bjaspan: fix user login form values and openid interacion
2007-06-23 08:58:31 +00:00
Steven Wittens
569ede574f
#115139 : Add centralized json handler (and send text/javascript content-type header).
2007-06-22 08:46:16 +00:00
Steven Wittens
fe8b35f527
#153781 : Convert all remaining confirm_forms() to deletion api.
2007-06-22 08:32:28 +00:00
Steven Wittens
e7d31327cf
#144397 : Use drupal_render for user profiles and convert to themer-friendly .tpl.php files.
2007-06-21 04:38:41 +00:00
Dries Buytaert
6102d02d21
- Patch #149692 by asimmonds: fixed FAPI breakage.
2007-06-17 11:59:05 +00:00
Dries Buytaert
ae0392b2eb
- Patch #147947 by hswong3i: some files shouldn't defined as text:big for Oracle compatibility.
2007-06-15 07:15:25 +00:00
Dries Buytaert
dbaddb73c3
- Patch #148419 by Moshe, bjaspan et al: refactor distributed auth out of user.module.
2007-06-15 06:53:26 +00:00
Dries Buytaert
727304d03d
- Patch #151270 by moshe: fixed braino.
2007-06-12 20:37:07 +00:00
Dries Buytaert
2290800c78
- Patch #143532 by Gurpartap: don't redirect to 'my account' after editing profiles.
2007-06-11 15:27:52 +00:00
Dries Buytaert
bc1c4defa2
- Patch #150167 by fwalch: fixed problem with fapi migration -- one-time login not working.
2007-06-11 15:01:32 +00:00
Dries Buytaert
9e0da3dc7c
- Patch #143026 by ChrisKennedy and Steven: dynamically check password strength and confirmation.
2007-06-08 06:04:15 +00:00
Dries Buytaert
29eb5a6284
- Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version.
2007-06-08 05:50:58 +00:00
Dries Buytaert
27388f6655
- Patch #149176 by chx, David et al: getting rid of the sequences table, using db_last_insert_id() instead of db_next_id().
2007-06-05 12:13:23 +00:00
Dries Buytaert
e629deb94d
- Patch #146667 by Jeff Eaton: form API fixes.
2007-06-04 15:56:34 +00:00
Dries Buytaert
19b8132289
- Patch #148974 by hunmonk: fixed whois online block on PostgreSQL.
2007-06-04 07:24:53 +00:00
Dries Buytaert
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
Dries Buytaert
712c5758ff
- Patch #148744 by catch: fixed some code comments.
2007-06-03 06:17:58 +00:00
Gábor Hojtsy
fd9dc74c9d
Some RTL CSS files had wrong CVS Id comments, fix that
2007-05-30 18:28:14 +00:00
Dries Buytaert
4fd54aabc5
- Patch #115267 by drewish, dopry et al: simplified file uploads code, improved file API, centralized file validation, implemented quotas and fixed file previews.
2007-05-30 08:08:59 +00:00
Dries Buytaert
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
Gábor Hojtsy
860947d3c8
#145737 by yhager, documentation cleaned up by myself: add support for RTL CSS overrides and default RTL CSS override files for modules
...
Note: properties, which are different in the RTL display are marked with /* LTR */ in default CSS files now,
so maintainers remember that changing them should also have an effect on RTL CSS files.
This should open the way for better RTL (right-to-left written) language (such as Arabic and Hebrew) support.
2007-05-27 17:57:48 +00:00
Dries Buytaert
5b45c4afc5
- Patch #146313 by walkah: _user_edit_validate assumes arg(1) == 'register' when being called for the user_register form
2007-05-25 12:52:16 +00:00
Dries Buytaert
3cafffe63f
- Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave.
2007-05-25 12:46:46 +00:00
Dries Buytaert
5094312d3b
- Patch #140218 by Crell et al: make it possible to move page callbacks to their own include files.
2007-05-22 05:52:17 +00:00
Dries Buytaert
d79082769a
- Patch #144919 by dww: hide user picture settings when possible.
2007-05-20 16:38:19 +00:00
Dries Buytaert
2934a3d9bd
- Patch #144859 by dww: added optional e-mail notifications when user are approved, blocked, or deleted.
2007-05-20 12:34:48 +00:00
Dries Buytaert
99338b7896
- Patch #144676 by webchick and dww: form API-fied user settings.
2007-05-17 21:33:59 +00:00
Dries Buytaert
a243145d3f
- Patch #137767 by chx and pwolanin: multiple menu support.
2007-05-16 13:45:17 +00:00
Dries Buytaert
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00
Dries Buytaert
258c653f56
- Patch #141637 by merlinofchaos, gabor, et al: provide a site config form at the end of install to collect data, plus allow profiles to modify and add more.
2007-05-10 19:55:24 +00:00
Dries Buytaert
571013af8c
- Patch #142619 by erdemkose: fixed E_ALL warnings.
2007-05-10 10:00:50 +00:00
Dries Buytaert
7d4f2836ba
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
2007-04-30 17:03:29 +00:00
Dries Buytaert
248703477d
- Patch #76588 by kbahey and RobRoy: made the syslog deamon strip HTML tags.
2007-04-30 14:25:14 +00:00
Dries Buytaert
9a6099c234
- Patch #76588 by Gabor: made log messages translatable. Yay.
2007-04-24 13:55:36 +00:00
Dries Buytaert
2a2b767239
- Patch #138531 by bjaspan: destroy existing sessions when a user password is changed.
2007-04-23 17:07:57 +00:00
Dries Buytaert
61f46c6aa9
- Patch #138234 by webchick: Missing theme_user_signature from user_theme().
2007-04-23 16:58:10 +00:00
Gábor Hojtsy
45aa7f61ac
#136250 : The upload directory might exist, but is not writable. Fix error message. Investigated with Moshe Weitzman and Gerhard Killesreiter.
2007-04-21 20:47:30 +00:00
Dries Buytaert
e675979091
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
2007-04-13 08:56:59 +00:00
Dries Buytaert
ea3c495a55
- Patch #135329 by Zen: clean up password reset form.
2007-04-13 08:42:36 +00:00
Dries Buytaert
807c2a2d09
- Patch #134364 by lyricnz: simplified SQL query
2007-04-13 08:26:34 +00:00
Dries Buytaert
4a7be0f2f0
- Patch #134839 by webchick: allow turning of signatures site-wide.
2007-04-10 10:40:40 +00:00
Dries Buytaert
15d739a504
- Patch #133431 by alexis: #redirect won't work with user registration.
2007-04-09 13:45:30 +00:00
Dries Buytaert
b9b015ff19
- Patch #130366 by webchick and Steven: make signatures pretty.
2007-04-09 13:41:10 +00:00
Dries Buytaert
ec3c0716aa
- Patch #133865 by alexis: incorrect form_set_error() calls.
2007-04-06 14:27:22 +00:00
Dries Buytaert
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
Dries Buytaert
9e94bb6101
- Patch #130366 by webchick and steven: improved signature handling. Step 1 of 2.
2007-03-30 07:45:20 +00:00
Steven Wittens
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
Dries Buytaert
eb6b848de6
- Patch #110888 by Eaton: unify hook _alter()
2007-03-26 00:35:59 +00:00
Steven Wittens
4f5e7ecba4
#130194 : Left over #base.
2007-03-24 05:36:30 +00:00
Dries Buytaert
4b635f6d0a
- Patch #128081 by Eaton: remove #base, paving the path for a simpler form API.
2007-03-17 18:30:14 +00:00
Dries Buytaert
0cb5532a23
- Patch #125763 by chx: menu system fixes/enhancements.
2007-03-08 19:03:48 +00:00
Dries Buytaert
afb4242ad1
- Patch #125232 by kkaefer: overlooked an l() convertion.
2007-03-06 16:17:55 +00:00
Dries Buytaert
dc5843bd30
- Patch #111347 by Steven: refactor url() and l().
2007-02-15 11:40:19 +00:00
Dries Buytaert
a1e6728a46
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-02-11 09:30:51 +00:00
Dries Buytaert
aae033952f
- Patch #107051 by webchick: duplicate user names in who is online block
2007-02-10 13:43:47 +00:00
Dries Buytaert
4980327172
- Patch #115315 by kkaefer: fixed autocomplete for users.
2007-02-02 15:25:25 +00:00
Dries Buytaert
489903a08e
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-01-31 21:26:56 +00:00
Dries Buytaert
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
Dries Buytaert
f66606751e
- Patch #113872 by webchick: 403 on user/password for anon users.
2007-01-29 19:17:55 +00:00
Dries Buytaert
00f377cdcb
- Patch #81891 by alusiani and dww: fixed problem with matching permissions.
2007-01-29 19:07:53 +00:00
Dries Buytaert
3b543c18f5
- Rollback of E_ALL patch. Too much extra breakage.
2007-01-25 22:14:06 +00:00
Dries Buytaert
fd32b42196
- Patch #112715 by webchick et al: fixed some E_ALL errors.
2007-01-25 21:32:07 +00:00
Dries Buytaert
03752e35a4
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
2007-01-24 14:48:36 +00:00
Dries Buytaert
678af8a021
- Patch #107425 by webchick: code style fixes.
2007-01-11 08:52:45 +00:00
Steven Wittens
dea04b3d19
#108339 : Tiny performance improvement in user.module (ereg to strpos)
2007-01-11 03:27:05 +00:00
Steven Wittens
36cd6b2b21
#107966 : Make login fields consistent size.
2007-01-11 03:24:42 +00:00
Dries Buytaert
74e3c74b81
- Always check the username.
2007-01-10 15:17:51 +00:00
Dries Buytaert
f927e66862
- Patch #107966 by Ralf: consistent length of textfields.
2007-01-10 09:57:46 +00:00
Steven Wittens
432d6244f3
#108130 : Don't allow empty autocomplete searches
2007-01-10 08:08:44 +00:00
Steven Wittens
90b00a688f
#80085 : Don't show user picture form on registration pages (chx / webchick)
2007-01-07 08:20:31 +00:00
Steven Wittens
365439ffdf
#107015 : Code consistency, capitalization of class names.
2007-01-05 05:32:23 +00:00
Neil Drumm
dfd86399c0
#106232 by chx. Add spaces for code style.
2007-01-02 05:05:38 +00:00
Dries Buytaert
12a55af8d1
- Patch #105216 by dww and merlin: fixed CSS comment.
2006-12-30 07:45:31 +00:00
Neil Drumm
f46f6abeae
#105698 by dww. Edit permissions links for all roles, including anonymous and authenticated.
2006-12-29 08:27:19 +00:00
Dries Buytaert
58de01883a
- Patch #105216 by dww: profiles where no longer being themed due to missing CSS.
2006-12-27 12:55:52 +00:00
Neil Drumm
59b94f0610
#102170 by ChrisKennedy. Make username and email field #maxlengths consistent.
2006-12-25 10:04:03 +00:00
Dries Buytaert
96c913dca9
- Patch #88707 by chx: Make menu_set_active_item a complete inner redirection.
2006-12-23 17:27:03 +00:00
Neil Drumm
124c5aebc2
#45453 by ChrisKennedy. Clear up the username field description.
2006-12-19 09:22:22 +00:00
Dries Buytaert
aa3daa3256
- Patch #103937 by kkaefer: dropdown list items on mass user editing page not translated.
2006-12-18 21:45:56 +00:00
Steven Wittens
f016b1647b
#100518 : Fix bad URL/callback in access control.
2006-12-12 10:11:43 +00:00
Steven Wittens
f865087dd4
#87241 : Use absolute links for search results, to allow syndication.
2006-12-12 09:55:18 +00:00
Steven Wittens
4eda8b315d
#101900 : Can't create blocked user
2006-12-12 07:06:29 +00:00
Steven Wittens
b86f45b1e6
#100516 : CSS preprocessor to cache and compress all .css files. Benchmarks show up to 40% faster page loads.
2006-12-10 09:54:35 +00:00
Dries Buytaert
5acb423c4f
- Patch #16798 by profix898: flush the page cache when someone changes his user profile.
2006-12-07 19:06:34 +00:00
Dries Buytaert
38f3050777
- Patch #101236 by Uwe Herman: fixed typos in the documentation.
2006-12-05 05:47:37 +00:00
Dries Buytaert
ab1d68d166
- Patch #90612 by Bart Jansens: user_logout should only end the current session.
2006-12-04 10:41:20 +00:00
Dries Buytaert
5e70fc97ef
- Patch #100352 by ChrisKennedy: fixed parse error on pasword reset page.
2006-12-01 08:18:53 +00:00
Neil Drumm
05a9e540b4
Don't append to non-existent variables.
2006-11-30 01:37:56 +00:00
Neil Drumm
58a1351c1d
#99426 by RobRoy. Fully save users during mass editing.
2006-11-30 01:35:46 +00:00
Neil Drumm
b5bf8a8f47
#97824 by Gurpartap. Move enclosing elements outside of their t().
2006-11-26 02:20:01 +00:00
Neil Drumm
205f8ff01b
#97941 by webchick. Consistent defaults for 'site_name' variable.
2006-11-25 09:04:22 +00:00
Dries Buytaert
827f064deb
- Patch # #98366 by webchick and ac: simplified strings for translators.
2006-11-24 10:18:24 +00:00
Dries Buytaert
d721a4f0d9
- Patch #98365 by webchick and RobRoy: added missing t() functions.
2006-11-24 09:01:57 +00:00
Dries Buytaert
74679f5553
- Patch #99287 by webchick: missed some title capitalizations.
2006-11-23 11:06:53 +00:00
Dries Buytaert
3518d7bdf3
- Patch #99027 by greggles and webchick: help users request a new password when registration fails.
2006-11-22 09:12:05 +00:00
Dries Buytaert
6ae6dc0d85
- Patch #87298 by webchick, neil, dww et al: show version numbers on modules page.
2006-11-21 20:55:36 +00:00
Dries Buytaert
837bacfaaf
- Patch #98063 by jhm: user_admin_access_form ignores the default value for access type.
2006-11-21 20:25:24 +00:00
Dries Buytaert
b004f328ee
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
2006-11-21 20:14:19 +00:00
Steven Wittens
001d54f663
#84961 : Add 'select all' and range select feature to admin tables.
2006-11-21 08:16:39 +00:00
Dries Buytaert
73bcacf2cf
- Patch #41293 by edkwh et al: proper validation of role names (duplicates).
2006-11-17 21:46:32 +00:00
Neil Drumm
c8a996a2ee
#79804 by pwolanin. Junk keeps falling in $user->data.
2006-11-16 09:01:55 +00:00
Neil Drumm
7fb6b1ac80
#97686 by chx. Replace a loop with a standard PHP function.
2006-11-16 08:45:49 +00:00
Dries Buytaert
72fc8dbc98
- Patch #93042 by profix898: fixed the inconsistent who's online message.
2006-11-15 20:18:28 +00:00
Neil Drumm
82a36d5d78
#87700 by webchick. Link to specific modules in permissions.
2006-11-11 23:52:11 +00:00
Neil Drumm
f56dd87878
#54167 by Ralf Stamm. Prevent editing the locked roles.
2006-11-10 08:29:08 +00:00
Dries Buytaert
57688517f8
- Patch #84146 by RobRoy: missing capitalization fixes.
2006-11-07 12:02:56 +00:00
Neil Drumm
aeaa07c9f2
#85358 by hunmonk. Fix variable substituition in adminitrator notification of pending accounts.
2006-11-07 06:08:17 +00:00
Neil Drumm
235d9a7e4a
#76931 by robertDouglass. Remove an instance of loading uid 0.
2006-11-07 05:48:53 +00:00
Steven Wittens
d0169f4b41
#91473 : Fix user.module username validation with nul characters
2006-10-28 15:13:41 +00:00
Dries Buytaert
cb8be5f821
- Patch #89285 by profix: code simplifications.
2006-10-26 05:31:14 +00:00
Dries Buytaert
13232aba97
- Patch #88474 by webernet: fixed incorrect commit.
2006-10-26 04:16:34 +00:00
Dries Buytaert
6675dbc68c
- Patch #62628 by imagine et al: added missing element in user.module.
2006-10-25 17:53:30 +00:00
Dries Buytaert
61c8e5b01a
- Patch #88474 by chx, webernet, etc: fixed 'access denied' problem
2006-10-25 16:41:35 +00:00
Dries Buytaert
a911066ad2
- Patch #88233 by hunmonk et al: uninstall UI for modules.
2006-10-23 20:59:56 +00:00
Dries Buytaert
d842ff8150
- Patch #89976 by jvandyk: remove left-over code from pre-form API days.
2006-10-23 06:37:34 +00:00
Dries Buytaert
778a2dc5bb
- Patch #87622 by chx: added maxlength for password in user login block.
2006-10-23 06:33:41 +00:00
Dries Buytaert
905a679c55
- Patch #89964 by jvandyk: improved performance of user_is_blocked() by removing a redundant query.
2006-10-23 06:21:58 +00:00
Steven Wittens
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
Neil Drumm
c93c0fc700
#90119 by ontwerpwerk and profix898. Clean up misnamed permissions.
2006-10-20 21:00:17 +00:00
Dries Buytaert
d7705ea683
- Patch #89356 by RobRoy: only show labels when necessary.
2006-10-18 11:46:18 +00:00
Neil Drumm
4d70f796d6
#58524 by chx. Fix another array/object mixup.
2006-10-17 08:31:49 +00:00
Dries Buytaert
1238ccd6d0
- Patch #89323 by hunmonk: control access to mass operations.
2006-10-15 20:09:18 +00:00
Dries Buytaert
8d74e4c132
- Patch #87995 by merlinofchaos: added missing css.
2006-10-15 19:57:06 +00:00
Dries Buytaert
d7df0ca8bd
- Small usability imrpovement for 'add role' screen per Flickr photos: add link from the 'add role page' to the 'permission matrix'.
2006-10-14 10:05:48 +00:00
Dries Buytaert
89f58dafc9
- Patch #88474 by chx: fixed broken login.
2006-10-11 12:08:29 +00:00
Dries Buytaert
03299556f9
- Patch #69985 by Tobias: user/login shouldn't be accessible for authenticated users.
2006-10-09 07:20:45 +00:00
Dries Buytaert
18b297abf8
- Patch #81740 by merlinofchaos, webchick, moshe, neclimdul et al: added package support to the modules page.
2006-10-05 15:47:57 +00:00
Dries Buytaert
8c86bc5ad1
- Rollback of patch #41739 : this has been debated a dozen time in the past, and the behavior is intentional.
2006-10-04 06:20:38 +00:00
Steven Wittens
92de1f9051
#75289 : Don't allow user 1 to be blocked or deleted
2006-10-03 14:09:48 +00:00
Dries Buytaert
7647b5f13e
- Patch #84820 by Goba: fixed some problems with the distributed authentication.
2006-10-02 11:53:56 +00:00
Dries Buytaert
5f8027f94c
- Patch #83397 by edkwh: -> . Getting rid of super-globals.
2006-09-17 19:14:16 +00:00
Neil Drumm
2e22d4bcee
#58860 by edkwh. Proper validation for editing roles.
2006-09-11 09:05:46 +00:00
Neil Drumm
e21c0c6545
#40535 by Wesley Tanaka. Configurable number of user for the "Who's new" block.
2006-09-11 08:26:47 +00:00
Neil Drumm
9ce45873a1
#82859 by RobRoy. Fix an uninitialized variable.
2006-09-08 23:18:51 +00:00
Neil Drumm
b73417011b
#82925 by Heine. Fix password reset mail variables.
2006-09-08 23:03:48 +00:00
Dries Buytaert
6f0e54b037
- Patch #82465 by webchick: renamed variables in hooks for consistency.
2006-09-08 16:33:02 +00:00
Neil Drumm
72a19d0063
#81958 by edkwh. Fix multi-user deletion.
2006-09-07 07:32:12 +00:00
Dries Buytaert
fa60c7630f
- Patch #81809 by John: removed stray variables.
2006-09-06 14:01:51 +00:00
Dries Buytaert
40fba3d73b
- Patch #77936 by Robert: fixed variable name.
2006-09-06 11:16:39 +00:00
Dries Buytaert
eef5c49847
- Patch #82435 by chx: usability: reworked the 'request new password' form.
2006-09-05 11:37:08 +00:00
Dries Buytaert
9c7eecaa8d
- Patch #82432 by edkwh: fixed user filter being broken.
2006-09-05 10:14:53 +00:00
Neil Drumm
99d07eedc0
#82345 by jvandyk. Better wording for user edit/registration/etc form.
2006-09-05 02:30:17 +00:00
Neil Drumm
f96e48456d
#80844 by Uwe Hermann. Various string cleanup, which should have been put in smaller patches.
2006-09-01 07:32:58 +00:00
Neil Drumm
06c9841480
That help text was in the 40x messages.
2006-09-01 06:12:47 +00:00
Steven Wittens
7fd9aa5c8a
#69786 : jQuery JavaScript Library in Drupal core
2006-08-31 23:31:25 +00:00
Dries Buytaert
c64db1da29
- Patch #80952 by earl, webchick, neclimdul et al: .info files
2006-08-31 20:22:37 +00:00
Dries Buytaert
cdd120ed20
- Patch #77936 by moshe and rdouglass: pluggable session handling.
2006-08-31 19:52:39 +00:00
Dries Buytaert
8fdf7a8750
- Patch #72290 by killes: split up the cache table.
2006-08-30 08:46:17 +00:00
Neil Drumm
bceaf8f0da
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
2006-08-29 09:12:03 +00:00
Dries Buytaert
1d0dbfde6e
- Patch #80825 by Uwe: t() fixes.
2006-08-28 05:52:33 +00:00
Dries Buytaert
d5aae21fa2
- Patch #73087 by beginner and Rol: fixed alt-attribute in user profile pages.
2006-08-27 08:56:35 +00:00
Neil Drumm
554a2808a3
#78656 by m3avrck. Drupal Core's first CSS hack.
2006-08-25 09:01:12 +00:00
Neil Drumm
f046f2956a
Remove an errant character.
2006-08-24 09:14:19 +00:00
Dries Buytaert
c994ea1e28
- Patch #79629 by chx: fixed adding new roles.
2006-08-20 13:16:34 +00:00
Dries Buytaert
4f024f7311
- t() fixed by Justin.
2006-08-20 13:15:30 +00:00
Steven Wittens
55eec8f66f
#79601 : module_exist() -> module_exists()
2006-08-20 05:57:41 +00:00
Dries Buytaert
7de41539df
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
2006-08-18 18:58:47 +00:00
Steven Wittens
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Steven Wittens
30a322e454
#34505 : Add filter form for user admin (like node admin has)
2006-08-17 19:19:15 +00:00
Dries Buytaert
937f9099b4
- Patch #77183 by m3vrck: cleaned up some of the CSS mess.
2006-08-14 20:35:11 +00:00
Neil Drumm
3cc2b1e3d7
#77183 by m3avrck and timcn, split up drupal.css by module.
2006-08-14 07:14:50 +00:00
Neil Drumm
766e6494d9
#77525 by hunmonk, clean up for hook_(node|user)_operations().
2006-08-14 06:53:57 +00:00
Dries Buytaert
ce85b7c7f8
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
...
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
Dries Buytaert
729fa6c11b
- Patch #77422 by timcn: corrected various paths in the documentation.
2006-08-07 15:04:16 +00:00
Neil Drumm
6f22da3540
#75582 by hunmonk, add mass editing to admin/user/user.
2006-08-05 18:56:35 +00:00
Neil Drumm
cd430165d7
#73884 by RobRoy, various code cleanup.
2006-08-05 00:26:36 +00:00
Dries Buytaert
4b9a3cf73e
- Patch #4942 by webchik et al: e-mail verification is optional now.
2006-08-03 13:50:53 +00:00
Steven Wittens
38e4c1ae91
#76209 : (Eaton et al)
...
- Make installer code integrate better with module.inc / system.module
- Fix schema version bug when installing core
2006-08-03 01:02:51 +00:00
Gerhard Killesreiter
8b820834e5
SA-2006-011
2006-08-02 18:13:40 +00:00
Dries Buytaert
bd5c16ecf4
- Patch #76653 by paranojik: adding and searching users was broken.
2006-08-02 10:29:26 +00:00
Dries Buytaert
b138793b68
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
2006-07-31 11:25:55 +00:00
Dries Buytaert
3a7b64ae03
- Patch #61893 by timnc: remove message_na().
2006-07-29 17:56:41 +00:00
Neil Drumm
b6ee7cef86
#75594 by eafarris, remove of gender-specific pronouns
2006-07-27 08:07:04 +00:00
Neil Drumm
1a88d134b8
#74395 by moshe, add hook_profile_alter() to let modules alter the profile page
2006-07-27 07:46:31 +00:00
Steven Wittens
f3265fa4d0
Fix missing user name field on user/register (Arto Bendiken)
2006-07-18 10:14:26 +00:00
Neil Drumm
2ddb81af02
#66697 by hunmonk, simplify user role deletion.
2006-07-18 07:46:30 +00:00
Neil Drumm
a73303a882
#73810 by hunmonk, remove code duplication between user edit and user register processes
2006-07-18 07:43:09 +00:00
Dries Buytaert
58752cfaa2
- Patch #72284 by me:
...
+ reorganized ?q=admin/settings
+ deprecated the _settings hook
2006-07-10 19:27:52 +00:00
Dries Buytaert
af976d339f
- Patch #71194 by Goba: introducing hook_mail_alter(), chaning user_mail() to drupal_mail().
2006-07-10 08:12:31 +00:00
Dries Buytaert
9d5d9ab009
- Patch #72137 by Ber: improved Doxygen of user_mail().
2006-07-07 18:49:13 +00:00
Dries Buytaert
e93f8be871
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
2006-07-05 11:45:51 +00:00
Neil Drumm
899123af50
#70302 by adixon and killes, avoid deleting uid 0 on duplicate deletions.
2006-06-23 07:06:17 +00:00
Dries Buytaert
c0c172bb02
- Patch #67036 by naudefj and ajk: fixed some warnings.
2006-06-16 07:23:39 +00:00
Dries Buytaert
e5de216aab
- Patch #68553 by Neil: logout -> log out.
2006-06-12 11:02:44 +00:00
Dries Buytaert
a3667dc567
- Patch #67036 by naudefj: make it possible to add roles from the user creation page.
2006-06-11 19:23:47 +00:00
Dries Buytaert
e1a55712ca
- Patch #67425 by webchick: usability improvement: improved the label of the 'register' tab.
2006-06-09 08:11:57 +00:00
Dries Buytaert
30ac7b496c
- Patch #66777 by greggles: remove references to drop.org/drupal.org from welcome message.
2006-06-09 05:43:48 +00:00
Dries Buytaert
87dca6df9a
- Patch #62855 by webchick: admin/user/create should redirect back to admin/user/create
2006-05-29 13:02:14 +00:00
Neil Drumm
ff6a9390f0
#64893 by beginner, deny access to new accounts for non-administrators
2006-05-24 05:51:10 +00:00
Neil Drumm
9eed2da5ab
#29147 by naudefj, markus_petrux, and Moshe:
...
- Clean up API for authenticating users.
- Default distributed authentication server.
2006-05-23 02:37:48 +00:00
Neil Drumm
2d9eaf01cf
#61150 by Zen, hook_user categories type should pass $account
2006-05-16 07:17:40 +00:00
Neil Drumm
b090fc1a21
#49403 by Bèr and jvandyk, improve documentation for user_save.
2006-05-16 02:13:44 +00:00
Dries Buytaert
49b90a5d04
- Patch #57993 by Neil: clarified a status message.
2006-05-12 18:14:50 +00:00
Neil Drumm
b3c245ecbc
#62061 by KarenS, Modules cannot set form attributes on edit form
2006-05-07 03:52:34 +00:00
Neil Drumm
b6ff48e8e7
#61992 by chx (modified), Provide an 'after_update' op on hook_user.
2006-05-07 03:08:34 +00:00
Neil Drumm
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
Dries Buytaert
0f7ed2a590
- Patch #59346 by DriesK: incorrect defailt "who's online block" setting.
2006-05-04 18:57:21 +00:00
Neil Drumm
0906c80d20
Removing a stray ;
2006-05-03 09:22:05 +00:00
Dries Buytaert
d761ded1f2
- Patch #59763 by Ber: doxygen for user_roles().
2006-05-02 13:26:30 +00:00
Neil Drumm
806d0f5393
Forward prot from 4.7
...
#60907 , better patch by Zen and dww
2006-05-01 08:04:08 +00:00
Neil Drumm
f0cd92ddde
Forward port from 4.7
...
#60907 , don't use t() during user submit, neede for external auth, patch by Moshe
2006-04-30 00:37:44 +00:00
Dries Buytaert
adb88830d8
- Patch #43818 by Derek: make user/0 result in a 404.
2006-04-27 05:43:31 +00:00
Gerhard Killesreiter
7af9e6cfdd
#60476 , simplify frontpage related code, leftovers from #59222 , patch by Zen
2006-04-26 15:07:12 +00:00
Gerhard Killesreiter
dc4acbcb93
#59763 , doxygen for user_roles, patch by Ber
2006-04-26 11:07:25 +00:00
Gerhard Killesreiter
ce1d915a26
#60458 , remove notice and not needed variable, patch by Zen
2006-04-26 10:36:22 +00:00
Dries Buytaert
d071f99172
- Removing trailing whitespace.
2006-04-17 20:48:26 +00:00
Gerhard Killesreiter
b9d3b47ec6
#55096 , don't show online users in block if nobody online, patch by tenrapid
2006-04-13 18:17:07 +00:00
Gerhard Killesreiter
d6a164c400
#5371 , drupal_get_destination, pager and tablesort array handling, patch by Steven
2006-04-13 08:25:27 +00:00
Steven Wittens
1cf1772be1
- Missing filter_xss_admin() for user_registration_help
2006-04-10 19:11:25 +00:00
Gerhard Killesreiter
d37485699e
#54294 , don't show DA stuff, if disabled. Patch by Moshe
2006-04-09 08:48:50 +00:00
Steven Wittens
4821200689
#57415 : Replace drupal_implode_autocomplete() by drupal_to_js()
2006-04-06 02:41:48 +00:00
Gerhard Killesreiter
8447307ed2
#48714 , theme_user_picture should take "access user profiles" in to account, patch by frjo
2006-03-28 12:40:13 +00:00
Gerhard Killesreiter
0a8da7fb97
#42119 , notify user of admin created accounts. Patch by m3avrck
2006-03-27 20:28:10 +00:00
Gerhard Killesreiter
5885925b0d
#53348 , Handling of deleted/blocked user accounts, patch by jreyero and Zen
2006-03-26 19:31:00 +00:00
Gerhard Killesreiter
c529d247ff
#53489 , New User == Query failed: ERROR: invalid input syntax for integer: "", patch by Cvbge
2006-03-25 19:50:48 +00:00
Gerhard Killesreiter
4b84de9a0c
#14591 , User.module links for blocked/non-existant accounts + menu 403/404 issue, patch by Steven and merlinofchaos
2006-03-17 18:56:25 +00:00
Steven Wittens
e4a27b8f34
- sa-2006-003: Session fixation issue
2006-03-13 21:48:55 +00:00
Steven Wittens
2fb572d002
- Rollback
2006-03-13 21:35:31 +00:00
Steven Wittens
0539f5483b
- sa-2006-001: Custom menu items are accessible to anyone
2006-03-13 21:33:18 +00:00
Steven Wittens
9c944c2d58
- Code cleanup
2006-03-10 15:11:07 +00:00
Dries Buytaert
189ad85bcd
- Patch #52433 by Zen: removed redundant db_escape_string().
2006-03-04 18:00:55 +00:00
Gerhard Killesreiter
a1e932f733
#51127 , hook_user submit passes incorrect values, patch by wtanaka
2006-02-27 22:51:31 +00:00
Gerhard Killesreiter
bf8b6a531a
#46617 , Restore some module listings, partially applied, I've omitted places where I felt that sortign by weight would be wanted.
...
We can discuss those on the issue. Patch by chx.
2006-02-27 15:04:45 +00:00
Gerhard Killesreiter
72a73fedbd
#51125 , _user_forms: change array_merge to array_merge_recursive, patch by wtanaka
2006-02-27 14:15:41 +00:00
Dries Buytaert
58d9b02e3e
- Patch #51189 : fixed submit redirects.
2006-02-26 19:44:45 +00:00
Dries Buytaert
9e7ecfa1f9
- Patch #48313 by Tobias: added missing t() function.
2006-02-23 12:52:02 +00:00
Dries Buytaert
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
Dries Buytaert
5298688d8d
- Patch #24398 : make password reset work in case someone does prefetching. (Today's critical bugfix #4.))
2006-02-21 16:00:55 +00:00
Dries Buytaert
8b3bf4d005
- Patch #50106 by webchick: code clean-up.
2006-02-21 14:45:46 +00:00
Dries Buytaert
eeae26b227
- Patch #49132 by Tobias and Zen: fixed problem with profile fields being mangled.
2006-02-16 15:29:46 +00:00
Dries Buytaert
9dacf2f8d7
- Patch #47785 by chx: login block not w3 compatible (two id attributes)
2006-02-15 21:03:20 +00:00
Dries Buytaert
21eb666a9b
- Patch #11031 by Zen:
...
* Makes the user login and password fields in the login _block_ required.
* Uses just if ($form['name']) rather than if (isset($form['name']) && $form['name']). AFAIK, using both is unnecessary with the form API.
* Changes maxlength for usernames to 60 which is the (rather odd) database value. The maxlength fields at present don't accomodate affiliate logins with extra long usernames/domains, but I've left that issue alone for now.
* Removes all instances of maxlength for password. They were a)not being applied with any degree of consistency, and b)unnecessary as only the hash is stored.
* Corrects an e-mail address maxlength from 55 to 64.
* unset() accepts more than one variable.
2006-02-10 05:46:39 +00:00
Dries Buytaert
583d5a4ee9
- Patch #48622 by adrian: remove drupal_goto from _submit functions.
2006-02-10 05:25:57 +00:00
Dries Buytaert
c6328111a3
- Patch #48242 by markus: add/edit form in user access rules is broken.
2006-02-09 08:20:49 +00:00
Dries Buytaert
b28f48dc48
- Patch #44290 by Steve Dondley: fixed problem with user picture getting deleted after editing user account.
2006-02-09 07:43:43 +00:00
Steven Wittens
cebc884331
- #44133 : User login block not fully themed
2006-02-02 01:51:54 +00:00
Dries Buytaert
1db149b7d5
- Patch #46126 by killes: properly initialize the user roles array.
2006-02-01 15:43:11 +00:00
Dries Buytaert
ece2aab4fd
- Patch #47344 by gordon: fixed problem with anonymous user role not being properly initialized.
2006-02-01 14:08:26 +00:00
Dries Buytaert
52c0c18cad
- Patch #46622 by Neil: more forgiving hook_user('view').
2006-01-29 08:01:55 +00:00
Dries Buytaert
15ff8c8e32
- Patch #46827 by wulff: fixed incorrect links.
2006-01-29 07:50:45 +00:00
Dries Buytaert
c046333610
- Patch #35499 by samo, m3avrck, et al: one-time login link does not provide adequate feedback to user errors.
2006-01-27 18:49:48 +00:00
Dries Buytaert
d958fad0d6
- Patch #40200 by Ax, Drewish, Zen et al: user_view() isn't merging view items correctly + CSS cleanup + form handling cleanup.
2006-01-26 13:43:04 +00:00
Dries Buytaert
6996292d52
- Patch #46262 by Neil: load the anonymous user on logout.
2006-01-26 08:52:24 +00:00
Dries Buytaert
794b53e195
- Patch #46137 by drumm/moshe: load anonymous user if authentication failed.
2006-01-26 08:51:10 +00:00
Dries Buytaert
017cbf5e2b
- Patch #46388 by m3avrck: removed some dead code. Yay.
2006-01-26 08:43:28 +00:00
Dries Buytaert
d20ed7e3be
- Patch #45665 by wtanaka/moshe: removed dead code! w00t!
2006-01-24 18:32:20 +00:00
Dries Buytaert
bc9cbefa30
- Patch #45729 by markus, jvandyk, moshe: fixed problem with permission checking.
2006-01-23 08:06:43 +00:00
Dries Buytaert
25f13a64c4
- Patch #45843 by markus: roles are no longer required.
2006-01-22 07:23:58 +00:00
Dries Buytaert
4da4f4c1af
- Patch #44379 by Moshe: code improvements: always grant the 'authenticated user' role to authenticated users. Fixed glitch with udpate path.
2006-01-21 08:28:55 +00:00
Dries Buytaert
0ff0c4beaa
- Patch #42137 by Richard: deleting non existent user blocks the whole drupal site.
2006-01-20 09:37:00 +00:00
Dries Buytaert
8c02d4ec93
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
...
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert
4a7abb95b6
- Patch #45312 by Robin and Zen: made theme_user_list() more like theme_item_list(), made it robust for empty lists.
2006-01-20 08:58:09 +00:00
Dries Buytaert
8b5175a983
- Patch #44754 by Zen: fixed "Who's new" block inaccuracy.
2006-01-17 09:04:20 +00:00
Dries Buytaert
f649b42d9c
- Patch #44767 by jvandyk: small (code) improvements
2006-01-15 16:57:56 +00:00
Dries Buytaert
776e6501cd
- Patch #44210 by DriesK: made it possible to edit blocked users.
2006-01-13 19:02:38 +00:00
Dries Buytaert
403c1c0404
- Added trailing point.
2006-01-13 14:54:51 +00:00
Dries Buytaert
11b9259db0
- Patch #44507 by DriesK: consistency: email -> e-mail.
2006-01-13 07:33:13 +00:00
Dries Buytaert
cccca3b17e
- Patch #44261 by Kobus/Zen: drupal -> Drupal.
2006-01-12 19:29:36 +00:00
Dries Buytaert
e136a247c3
- Patch #40401 by driesk: fixed incorrect form conversion.
2006-01-12 19:15:31 +00:00
Dries Buytaert
3607a2b059
- Patch #44373 by m3avrck: improved generated HTML/CSS.
2006-01-12 09:58:49 +00:00
Dries Buytaert
79cdc915ec
- Modified patch #44156 by Zen: '%s' -> %d.
2006-01-10 20:11:46 +00:00
Dries Buytaert
afb923a00a
- Patch #36716 by m3vrick: made deleting user accounts work.
2006-01-09 19:18:46 +00:00
Dries Buytaert
7c862e924a
- Patch #43668 by chx: fixed warning.
2006-01-09 18:27:26 +00:00
Dries Buytaert
6f0bd9499b
- Patch #43668 by chx: fixed problem with changing usernames.
2006-01-09 14:14:39 +00:00
Dries Buytaert
fb393415bb
- Patch #43833 by killes: give the first user a default role.
2006-01-08 16:32:08 +00:00
Dries Buytaert
9d1d40e609
- Patch #39639 by Richard: 'users' appearing twice in menu.
2006-01-06 07:42:31 +00:00
Dries Buytaert
db1e1b5388
- Patch #42541 by merlinofchaos: critical bug fix: public user registrations not always working.
2006-01-05 10:55:51 +00:00
Dries Buytaert
749284633f
- Patch #42057 by hunmonk and chx: made saving user accounts work again.
2006-01-02 08:35:59 +00:00
Dries Buytaert
89e89a3b9b
- Patch 42115 by Cvbge/ m3avrck: improved performance of session loading.
2005-12-31 11:50:47 +00:00
Dries Buytaert
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
Dries Buytaert
d21dda89b3
- Patch #41305 by chx: user edit form submit model rewrite.
2005-12-19 10:02:33 +00:00
Dries Buytaert
63ece6f957
- Patch #29060 by tostinne/ax: added tabindex to user login page.
2005-12-11 12:53:09 +00:00
Dries Buytaert
30450039f9
- Patch #40583 by canen: make user_autocomplete function work with PostgreSQL.
2005-12-10 08:08:44 +00:00
Dries Buytaert
c54234d71a
- Patch #40341 by Neil: fixed problems with database schema versions.
...
- When user #1 creates an account (we can assume this happens only once), system.module's schema version is set to the latest availiable.
- system_get_files_database() now includes a 'schema_version' child of each file object.
- That new information is re-saved when Drupal re-populates the system table.
- An array of newly-enabled modules is built, module_list() is reloaded, and the schema versions of each newly-enabled module are set to the most recent availiable. If the schema version is already set (presumably from a previous installation) it is not changed.
2005-12-08 08:40:10 +00:00
Dries Buytaert
9ccb6d7a80
- Patch #26641 by Uwe: tabs disappear in user.module settings after saving a role.
2005-12-06 12:36:37 +00:00
Dries Buytaert
26bd449860
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
2005-12-02 15:21:01 +00:00
Dries Buytaert
0dad5d9e45
- Patch #39547 by saerdna et al.: added a 'change own username' permission.
2005-12-02 15:18:32 +00:00
Dries Buytaert
b8ae0b3218
- Patch #38981 by Robert: add permission to enable/disbale theme switching by users.
2005-11-30 11:09:38 +00:00
Dries Buytaert
fff9a51352
- Patch #38945 by wtanaka: made the login block redirect back to the original page.
2005-11-28 12:31:47 +00:00
Dries Buytaert
f532273a13
- Patch #38412 by m3avrck: fixed problem with creating first account.
2005-11-22 21:00:40 +00:00
Dries Buytaert
ecc279aef6
- Patch #37416 by Zen: make auto-completion of usernames work with short names.
2005-11-21 18:36:12 +00:00
Dries Buytaert
0bb347ccbe
- Patch #38248 by hunkmonk: updated the user login form to the forms API's _execute model.
2005-11-21 09:17:04 +00:00
Dries Buytaert
48929eba7a
- Patch #37738 by Junyor: fixed problem with Drupal not properly unsetting $user on logout.
2005-11-15 20:47:06 +00:00
Dries Buytaert
ad74b700c4
- Patch #32669 by DriesK: split blocking users from 'adminsiter access'.
2005-11-14 21:49:47 +00:00
Dries Buytaert
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
Dries Buytaert
64a617c208
- Patch #26249 by Morbus: improved handling of temporary files/directory.
...
If your module uses variable_get('file_directory_temp', ...) or
variable_get('file_directory_path', ...) please update it to use the new
API.
A list of affected modules is available at http://drupal.org/node/26249#comment-54194 .
2005-11-12 09:23:50 +00:00
Dries Buytaert
7dd24bec5c
- SQL query maintenance: '%d' -> %d.
2005-11-12 09:14:30 +00:00
Dries Buytaert
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
Dries Buytaert
4af960646d
- Patch #35648 by asimmonds: fixed permissions page.
2005-10-31 13:37:38 +00:00
Steven Wittens
08f8876f48
- #35440 : Fix user 1 login bug after forms api
2005-10-28 00:37:06 +00:00
Dries Buytaert
f6764cfbd8
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
2005-10-22 15:14:46 +00:00
Dries Buytaert
a5f9391550
- Modified patch #34472 by Moshe: uid=1 does not redirect to edit page after registration.
2005-10-21 09:30:14 +00:00
Dries Buytaert
f905ab181f
- Patch #34031 by drewish: delete button on the edit user account form should be after the submit button.
2005-10-21 09:07:12 +00:00
Dries Buytaert
1c0b946535
- Modified version of patch #33348 by wolff: clean URL emitted when creating first user.
2005-10-13 10:39:56 +00:00
Steven Wittens
5f0e0f3649
- #33433 : More form API fixes, and error handling improvements by Chx.
2005-10-13 10:02:31 +00:00
Steven Wittens
1b1a2d7750
- Restore user login block alignment (form api patch undid some recent class/id changes)
2005-10-11 20:52:16 +00:00
Dries Buytaert
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
Dries Buytaert
fd96728f3c
- Second batch of form API fixes by chx.
2005-10-09 10:39:15 +00:00
Dries Buytaert
27625fcf83
- Patch #31341 by kbahey: delete a user's session when the user is deleted.
2005-10-07 06:53:25 +00:00
Dries Buytaert
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert
c267c749e7
- Patch #32669 by DriesK: added an 'administer access control' permission.
...
In several setups, one wants to grant the 'administer users' permission to certain roles (for example to forum admins), however without allowing those users to change permissions on the 'access control' page, and without allowing them to change the users' roles (so that they can't, for example, promote themselves to admin).
2005-10-01 13:42:00 +00:00
Dries Buytaert
67e68fc679
- Patch #28786 by Neil: move pagers out of table.
2005-09-24 07:53:26 +00:00
Dries Buytaert
ce3b6d4eee
- Patch #28301 by jjeff: show tooltip when hovering over a permission. Temoprary
...
solution until we have a better permission page.
2005-09-15 21:45:21 +00:00
Dries Buytaert
4005922332
- Patch #31123 by Ber: make it easier to theme the user profile pages.
2005-09-14 21:16:00 +00:00
Dries Buytaert
cead2e37b1
- Patch #26033 by m4avrck: fixed PHP5 warnings (call by reference)
2005-09-08 19:46:05 +00:00
Dries Buytaert
f3cb254cb7
- Patch #23536 by chx: custom registration fields should appear on admin/user/create.
2005-09-08 19:32:31 +00:00
Dries Buytaert
013b73e6ec
- Patch #30122 by m3verick: changed include_once()'s to include "./$file"
...
for performance's sake.
2005-09-08 19:19:01 +00:00
Dries Buytaert
16262e03d5
- Patch #28320 by Neil: improved the HTML/CSS of the user login block.
2005-09-07 20:56:00 +00:00
Dries Buytaert
bcd59aa0dd
- Patch #24617 by Morbus: fixed incorrect access checking.
2005-09-07 20:41:38 +00:00
Dries Buytaert
298b403bf1
- Patch #18252 by tostinni: don't try creating the picture directory when picture support is not enabled.
2005-09-06 19:22:50 +00:00
Dries Buytaert
7f08b766aa
- Patch #30382 by Robert: removed unused variable by ''.
2005-09-06 19:10:50 +00:00
Dries Buytaert
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
Dries Buytaert
78317bca79
- Patch #27897 by kubaZygmunt: fixed PHP warning.
2005-08-11 13:52:44 +00:00
Dries Buytaert
192dcd04ba
- Patch #18778 by Gerhard/Olen: sort users by creation date rather than user ID.
2005-08-10 20:46:29 +00:00
Dries Buytaert
5270f7fd88
- Patch #28599 by Cvbge: fixed typo in documentation: 'user' -> 'used'.
2005-08-10 20:38:57 +00:00
Steven Wittens
64299d7455
- #27852 : redirect to user edit page on first log-in
2005-08-05 01:18:39 +00:00
Steven Wittens
3feef48da2
- #28154 : remove useless /view from user results
2005-08-03 23:23:48 +00:00
Dries Buytaert
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
Steven Wittens
22479d8761
- Add some Unicode checks to username validation
2005-07-31 21:54:39 +00:00
Steven Wittens
2a561f3bc1
- #16705 : Make user_access always return a boolean.
2005-07-29 21:34:56 +00:00
Steven Wittens
8de43c320a
- #27694 : Correct username validation.
2005-07-29 07:18:36 +00:00
Steven Wittens
11a4aba9a6
- #26688 : Add mbstring support to Drupal and clear up string handling fuzzies.
2005-07-25 20:40:35 +00:00
Dries Buytaert
7480e9ac3c
- Modified patch #27131 by DriesK: removed some cache_clear_all()s.
2005-07-23 05:53:43 +00:00
Steven Wittens
02ca763ea0
- Fix PHP notice (killes)
2005-07-20 00:50:34 +00:00
Dries Buytaert
7ee24ccfe4
- Patch #27062 by nysus: improved the help text of the 'access control' page.
...
Generally improves readability; gets rid of technical jargon; provides
concrete example; provides suggestions for how permissions can be used.
2005-07-19 17:57:55 +00:00
Dries Buytaert
d96e7e0bbb
- Patches by Ber: move user settings and node settings to admin/settings.
2005-07-03 16:41:42 +00:00
Dries Buytaert
58aee8cdad
- Patch #25603 by Stefan: made the sizes of forms consistent.
...
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert
5365db7e07
- Patch by Robert: fixed problem with username blocking.
2005-06-23 19:26:51 +00:00
Dries Buytaert
e7cc200eeb
- Patch by deekayen: roll back permission patch.
2005-06-23 05:10:38 +00:00
Dries Buytaert
f3a9a99570
- Patch #25121 by Robrecht J.: changed itemized lists with hardcoded CSS to definition lists.
2005-06-21 18:58:27 +00:00
Dries Buytaert
22ea50dfec
- Patch #21566 by deekayan: fixed user_access() function returning a string and not a boolean. Also improves performance of user_access().
2005-06-21 18:45:30 +00:00
Dries Buytaert
8f82f92a10
- Patch #25398 by Ber: drop.org -> drupal.org.
2005-06-21 18:22:26 +00:00
Dries Buytaert
4c77761efb
- Patch #3962 by deekayen: improved error message when a blocked user attempts to login.
2005-06-21 18:21:08 +00:00
Dries Buytaert
b3336096a3
- Patch #24766 by deekayen (David): fixed user module showing the epoch instead of 'never'.
2005-06-19 09:06:02 +00:00
Dries Buytaert
1474632aa0
- Patch #24135 by Moshe: made it possible to ban visitors based on hostname/IP. Banning visitors can either be done from the 'access control' pages, or directly from the statistics pages. This feature is very convenient to block badly behaving crawlers.
2005-06-07 18:54:37 +00:00
Dries Buytaert
263b7e230d
- Fixed registration bug.
2005-06-01 20:21:35 +00:00
Dries Buytaert
f68f9111ca
- Patch #23633 by Moshe: improve grouping in default profile page.
2005-05-26 19:03:05 +00:00
Dries Buytaert
e579f4d407
- Patch #23588 by Ber: fixed incorrect call to theme_user_picture.
2005-05-25 19:54:49 +00:00
Steven Wittens
58bddf8abc
* cue Star Wars theme tune *
...
Return of the JavaScript!
- #22519 : form_autocomplete(): Ajax based autocompletion. Currently used for user names and folksonomy tags.
2005-05-24 06:00:22 +00:00
Dries Buytaert
0de88f50ba
- Patch #23383 by Ber: added theme_user_list() function.
2005-05-23 21:23:04 +00:00
Dries Buytaert
2a744f8950
- Patch #11791 by kps: trim passwords to avoid copy-paste mistakes.
2005-05-21 11:57:59 +00:00
Dries Buytaert
cdec2f7e3e
- Patch #16303 by Gerhard: fixed some warnings.
2005-05-21 11:33:03 +00:00
Dries Buytaert
2b7f504dc8
- Added the ability to track page generation times in the statistics module.
...
(Made some improvements as per the suggestions in the issue.)
- Added extended timer implementation.
2005-05-12 11:21:35 +00:00
Dries Buytaert
a1a3d53caa
- Patch #22262 by Robert: removed extra comma from SQL query.
2005-05-07 22:37:26 +00:00
Dries Buytaert
39d0fe9a38
- User module improvements: added an 'access' column to the users-table to
...
keep track of the user's last access. In turn, this allowed me to:
1. Optimize the "Who's online" block. On drupal.org, the "Who's online"
block requires 32 SQL queries. With this patch, only 2 queries are
left (eliminated 30 SQL queries), and one of the two remaining queries
became appr. 20 times faster.
2. Correct the "Last access" column in the user administration overview
table. The presented data was not accurate, which led to the column
being removed. You can now sort users by 'last access'.
2005-05-07 11:39:54 +00:00
Dries Buytaert
65fa603fc5
- Removed the user IDs from the users administration table and added a 'Member for' column.
2005-05-05 11:55:52 +00:00
Dries Buytaert
92b10946ac
- Patch #21686 by Robin Monks: added two missing t() functions.
2005-05-01 09:34:17 +00:00
Dries Buytaert
8bedd376fe
- Patch #21344 by Moshe: admin/user/create results in a blank page
2005-04-30 09:27:19 +00:00
Steven Wittens
c99f000c6f
- #20910 : print -> return
2005-04-24 22:09:16 +00:00
Dries Buytaert
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
Dries Buytaert
e2b256dcf6
- Patch #18719 by Jose: reworked the 'request new password' functionality.
2005-04-24 11:43:08 +00:00
Dries Buytaert
52826b0052
- Patch #20690 by jhriggs: editing a user does not clear the menu cache.
2005-04-18 20:43:26 +00:00
Dries Buytaert
db8dfcae39
- Patch #20457 by Morbus: removed hardcoded <br />
2005-04-13 19:44:31 +00:00
Dries Buytaert
1bc5fe183b
- Patch #20058 : move user_module_invoke('load', $array, $user) after loading of roles.
2005-04-13 18:02:48 +00:00
Dries Buytaert
b1392fb143
- Patch #20396 by Junyor: fixed broken watchdog message in user module.
2005-04-12 21:26:18 +00:00
Dries Buytaert
bbb746b814
- Patch by Gerhard: refinements and bugfixes for the 'access user profiles' patch.
2005-04-12 18:32:00 +00:00
Dries Buytaert
2bd8840e3b
- Patch #20349 by Gerhard: drop.org -> drupal.org
2005-04-12 05:13:17 +00:00
Steven Wittens
23bccfd1c8
- #4166 : Respect 'access userlist' permission for profile data.
2005-04-11 22:48:27 +00:00
Steven Wittens
bc44805f3c
- #20338 : Improve api docs on $user field deletion.
2005-04-11 22:31:12 +00:00
Dries Buytaert
a3e9b35afc
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
2005-04-01 15:55:02 +00:00
Steven Wittens
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
Steven Wittens
c3f1f7345e
- #18939 (Stefan): Always use paragraph tags around page help text.
2005-03-18 07:07:04 +00:00
Dries Buytaert
f4b5313483
- Patch #18983 by Ber: small code improvement.
2005-03-16 19:34:13 +00:00
Steven Wittens
ebc7c0dfe0
- Fix missing parameter in user.module
2005-03-05 18:03:16 +00:00
Steven Wittens
ad973366ab
- Fix overzealous session wiping
2005-03-04 03:43:41 +00:00
Steven Wittens
198ec98f75
#18329 : Unify confirmation messages (and make them themable)
2005-03-03 20:51:27 +00:00
Dries Buytaert
84268b3a34
- Patch #17770 by chx: added missing NULL-arguments to _user() hook.
2005-03-01 20:21:08 +00:00
Steven Wittens
ea08f062b2
- Fix broken session deleting on account blocking.
2005-03-01 18:44:41 +00:00
Steven Wittens
9803bc4321
- Delete a user's sessions when blocking his/her account.
2005-02-28 18:13:12 +00:00
Dries Buytaert
174d22dbbb
- Patch #17931 by Neil: fixed bug in access rules page:
...
* split up the menu callback for editing/adding/deleting rules
* improved the delete message
* fixed a double page printing bug
2005-02-28 16:41:15 +00:00
Steven Wittens
cd552adee0
More search usability improvements!
...
- Clean URLs: search/type/keywords e.g. "search/node/drupal release". The search
form is POST submitted, but drupal_gotos to a GET page. This makes it easy to
copy/paste search URLs, and makes the pager a lot cleaner.
- Remember the search keywords when switching between the search tabs. This is
done through the same GET URLs rather than the session, so it does not mess up
between multiple browser tabs.
- Report which keywords were ignored because they were too short.
- #820 : Provide search block
- Treat multiple wildcards in a row as one
2005-02-27 02:15:57 +00:00
Steven Wittens
d2bfc18880
#17477 : Remove dependency on GD for avatars.
2005-02-22 06:18:23 +00:00
Dries Buytaert
5b7ecb8650
- Patch #17208 by asimmonds: help text fixes:
...
- permissions menu link updates in a number of modules help
- anchor link fix in distributed auth help
- "my account" link fix in user help
- spelling correction in tracker.module help
- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
Dries Buytaert
16993da34f
- Fixed two broken URLs in the help text.
2005-02-10 19:19:43 +00:00
Dries Buytaert
d77ac14c31
- Patch #16972 by Neil: don't use align operations. Removed hard-coded CSS.
2005-02-08 19:28:33 +00:00
Dries Buytaert
fbec279e4c
- Patch #16246 by Moshe: added mechanism to direct the user back to the referring page after completing a form.
...
(Moshe: the patch against node.module failed to apply.)
2005-02-01 19:45:58 +00:00
Dries Buytaert
7ccc5a6b1b
- Patch #16358 by James: added toolkit to enable better image handling. The avatar code and the upload module have been updated to take advantage of the new image API.
...
There are 5 main functions that modules may now utilize to handle images:
* image_get_info() - this function checks a file. If it exists and is a valid image file, it will return an array containing things like the pixel dimensions of the image, plus the 'type' and common extension.
* image_scale - resizes a given image to fit within a given width / height dimensions, while maintaining aspect ratio (not distorting the image). This function can be used to generate thumbnails, or ensure a maximum resolution, etc.
* image_resize - similar to image_scale (but will not respect aspect ratio - may well distort the image).
* image_rotate - rotate an image by X degrees
* image_crop - crops an image to a given rectangle (defined as top-left x/y coordinates plus a width & height of the rectangle).
Contribution modules will now be able to rely on these base manipulation functions to offer additional functionality (such as image nodes, photo galleries, advanced image manipulation, etc).
2005-02-01 16:27:43 +00:00
Dries Buytaert
993ea0c6c5
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
2005-01-29 22:02:37 +00:00
Steven Wittens
cc3fd1715f
- #16271 : Clean up Admin - users - configure.
2005-01-28 20:49:00 +00:00
Dries Buytaert
b4d516f423
- Patch #13184 by JonBob: changed the 'my account' menu to a 'dynamic menu' so it can't be edited.
2005-01-27 21:34:38 +00:00
Dries Buytaert
7f4be97763
- Patch #16176 by Drumm based on mockup from Kika: improve access rules UI.
2005-01-25 20:27:09 +00:00
Dries Buytaert
d9382d8c15
- Patch #16028 by Goba: added class="form-password" to the password form.
2005-01-23 15:39:49 +00:00
Dries Buytaert
9252be8bc0
- Consistency glitch: 'operations' => 'Operations'.
2005-01-22 12:10:16 +00:00
Dries Buytaert
a6e7e9c104
- Patch #15566 by drumm: must specify a userneme or password error happens when it shouldn't.
2005-01-14 15:15:19 +00:00
Steven Wittens
8655d4368a
- Fixing a couple of watchdog() calls.
2005-01-09 12:58:53 +00:00
Dries Buytaert
64b100d19a
- Patch #13260 by UnConeD: watchdog module improvements.
...
We added a 'severity' column to watchdog():
watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);
* Specify a severity in case you are reporting a warning or error.
* The $link-parameter is now the fourth parameter instead of the third.
TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert
0f91dce414
- Patch #15247 by Drumm: simplified the logout code.
2005-01-07 18:01:13 +00:00
Dries Buytaert
7f890fd1b1
- Patch #15184 by drumm: clean up user password mailing.
...
+ After mailing the password, set a message and go to the login form (was print a message as the entire page).
+ Provide feedback if neither field was filled in.
+ Make it a full menu callback instead of going through user_page().
+ Fixed some indentation.
+ Changed some double quotes to single quotes.
+ Made sure all if statements have {}.
2005-01-06 20:38:19 +00:00
Dries Buytaert
9f2952aa3f
- Bug #14609 : improved the status messages and avoid empty roles being saved.
2004-12-22 08:51:39 +00:00
Dries Buytaert
2b17b3a966
- Patch #13907 by Neil: less ways to set the page title.
...
* Less logic in theme code.
* Encourages use of the menu system.
* Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
* Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert
6e3eb60aab
- Removed some cruft: left-over xxx_help_page() functions.
2004-12-11 14:13:24 +00:00
Dries Buytaert
5520513879
- Modified patch by Goba: don't save user roles in the serialized data field of the user table.
2004-12-08 19:41:16 +00:00
Dries Buytaert
1365740f6e
- Patch #14006 by Neil:
...
* user/view/$n has been replaced with user/$n.
* More blank lines in the right places.
* Prevent unwanted case fallthrough.
2004-12-07 07:24:46 +00:00
Dries Buytaert
95610bdd6c
- Patch #13647 by Goba:
...
1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
2. Removed t() functions from user contributed content.
2004-11-29 17:52:35 +00:00
Dries Buytaert
29337ad8bb
- Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
...
db_query($query, $a, $b, $c);
db_query($query, array($a, $b, $c));
This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
- array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
- $params[] = 0;
- $params[] = 1;
- $result = call_user_func_array('db_query_range', $params);
+ $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
and
- return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
+ return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query. This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself. With the new, documented syntax, there is no more excuse to put data directly in the query.
2004-11-29 13:13:29 +00:00
Dries Buytaert
9574766ad8
- Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency.
2004-11-23 22:20:41 +00:00
Dries Buytaert
e19a3cf42d
- Patch #12363 : fixed glitch in user_access() as pointed out by TDobes.
2004-11-23 21:52:13 +00:00
Dries Buytaert
fa97839088
- Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
...
Read the manual for pg_escape_string: "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
Dries Buytaert
9979aceab0
- Patch #12783 by Stefan: various small consistency/usability improvements.
2004-11-15 11:16:39 +00:00
Dries Buytaert
f01bd675c0
- Performance improvement: made 'sid' the primary key of the sessions table.
...
That should improve performance of session handling as well improve
performance of the "Who's online"-block. Drupal.org's sessions table
contains appr. 40.000 sessions on a slow day and rendering the "Who's
online"-block became a performance bottleneck.
This change has yet to be tested on a busy site so things might go wrong.
2004-11-07 21:53:55 +00:00
Dries Buytaert
a16be3495e
- Patch #12658 by menesis: when an administrator adds a user, the 'authenticated user' role was not assigned to the new user.
2004-11-07 07:54:35 +00:00
Dries Buytaert
b63d529a15
- Patch #12515 by Goba: fixed problem with cookies not being set properly, causing users getting logged out.
2004-11-03 22:39:55 +00:00
Steven Wittens
f69437dead
#12363 : Bug in user_access() with uid 1 and $account parameter.
2004-11-02 12:20:59 +00:00