5622bce2d5
#198579 by webernet and hswong3i: a huge set of coding style fixes, including:
...
- whitespaces at end of lines
- indentation
- control structure usage
- whitespace in empty lines
- phpdoc comment formatting
2007-12-08 14:06:23 +00:00
f77b60f291
#195543 by hass and yhager: CSS inherit was completely misused in RTL CSS files
2007-11-27 12:09:27 +00:00
e6a88be5d1
#193333 by quicksketch et al: taxonomy drag and drop support
2007-11-26 19:46:52 +00:00
70d494620c
#192242 follow up by catch: unset multiple parent form item on forum term pages
2007-11-21 14:02:23 +00:00
f803a82151
#194075 by neclimdul: nodeapi load should return an array by documentation, and forum's nodeapi load returns an object
2007-11-21 09:31:57 +00:00
ece869b0b2
- Patch #192242 by catch, quicksketch, webchick, keith et all: usability improvements for the vocabulary/term forms.
2007-11-20 13:24:54 +00:00
1cf05b0019
- Patch #89196 by catch, keith, earnie, webchick et al: string massaging.
2007-10-25 15:32:56 +00:00
4e187261ab
#177497 by chx and Desbeers: revive Drupal 5's menu_set_location() functionality by introducing menu_set_item() (for consistency in function naming), thus fixing a regression in the current development code. Also fixing some misuse of menu_set_location() by using drupal_set_breadcrumb() instead.
2007-10-25 08:24:43 +00:00
8cd97cdd7d
#147492 by flobruit: make 'more' links themeable
2007-10-22 09:36:05 +00:00
0ada4f136a
#72487 by chx, pwolanin and moshe weitzman: let node_access() work on arbitrary users, so independent user access checks can be done in a request
2007-10-11 16:37:43 +00:00
8cf6fefe54
#164983 by multiple contributors: document the core database schemas
2007-10-10 11:39:35 +00:00
f87245c202
#175979 by Desbeers: forum module does not need to call node_prepare anymore, because it is already done
2007-10-08 08:40:26 +00:00
ca8e9a1e18
- Patch #180432 by hunmonk, sun, et al: make comment settings per node type. This is a new feature that slipped in because it is required for the project module on drupal.org.
2007-10-07 19:25:57 +00:00
39706e3c51
- Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes.
2007-10-05 14:43:26 +00:00
c4b02c1213
#174343 by Shiny: move JOIN condition to ON clause in forum_nodeapi, so our SQL is standards compatible
2007-09-10 08:06:59 +00:00
531b45d045
- Patch #172643 by chx and fresco: fixed the leave shadow copy functionality.
2007-09-05 08:27:57 +00:00
e310d9e4a4
#6162 by various people: actually point new anchors to the page the first new comment is displayed (in a multipage comment view)
2007-09-02 14:56:18 +00:00
d82fe113bc
#53905 by fax8, Gurpartap Singh and dvessel: give meaningful names to term variables in forum templates and add unique IDs for easier themeing
2007-08-30 18:58:12 +00:00
94c1729eac
#161107 by fwalch and bragon: actually implement the missing forum_term_load to work behind the %forum_term menu item resolving calls
2007-08-29 18:25:51 +00:00
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
b134b023e1
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement.
2007-08-12 15:55:36 +00:00
f23c24c8a3
#164935 by Ralf Stamm: standardize CVS Id tags in files:
...
- always include CVS Id tags in all files
- add a new line after the CVS Id, if more code or phpdoc follows in the same code block
- fix bogus Id tags previously added
2007-08-07 08:39:36 +00:00
3488a1ed44
- Patch #158536 by dvessel: more forum template massaging.
2007-08-03 06:07:52 +00:00
80ff5109a7
- Patch #162708 by Eaton and Earl: add support for image buttons to FAPI3.
...
This is a small form API extension (doesn't break existing code) that
facilitates the Drupal 6 upgrade of the Views module. A good example
of why it can be beneficial to start upgrading your modules early on in
the code freeze. ;)
2007-07-29 17:28:23 +00:00
bec12a215d
- Patch #158536 by dvessel: some more gentle massaging of template files. Trying to make it easier to discover the different template files.
2007-07-26 06:48:03 +00:00
af00a845fb
- Patch #161350 by Crell: slicing and dicing the forum.module.
2007-07-24 18:08:54 +00:00
a466354823
- Patch #158536 by merlinofchaos and dvessel: tpl-ified the forum module.
2007-07-22 07:01:07 +00:00
64def7cb3e
#100641 by kkaefer, ChrisKennedy and RobRoy: change 'Submit' buttons to 'Save' to compliy with the desktop metaphor and actually tell what the button does ('we know it submits the form, but what it does?')
2007-07-16 12:43:06 +00:00
b6c069ad7d
- Patch #20295 by pyromanfo, webchick, Gurpartap Singh et al: allow forum topics to be custom node types.
2007-07-02 17:08:36 +00:00
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
9e6ef53c2c
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
2007-06-30 19:46:58 +00:00
fe8b35f527
#153781 : Convert all remaining confirm_forms() to deletion api.
2007-06-22 08:32:28 +00:00
38a1300df2
#147723 : Deletion API (by hunmonk). Woop woop.
2007-06-22 05:44:21 +00:00
29eb5a6284
- Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version.
2007-06-08 05:50:58 +00:00
e629deb94d
- Patch #146667 by Jeff Eaton: form API fixes.
2007-06-04 15:56:34 +00:00
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
fd9dc74c9d
Some RTL CSS files had wrong CVS Id comments, fix that
2007-05-30 18:28:14 +00:00
3568709803
- Patch #144295 by Gurpartap Singh: forum module fixes.
2007-05-30 08:04:38 +00:00
5d35dbd3d4
- Patch #147034 by webchick: removed redundant dependency checking.
2007-05-28 06:19:05 +00:00
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
860947d3c8
#145737 by yhager, documentation cleaned up by myself: add support for RTL CSS overrides and default RTL CSS override files for modules
...
Note: properties, which are different in the RTL display are marked with /* LTR */ in default CSS files now,
so maintainers remember that changing them should also have an effect on RTL CSS files.
This should open the way for better RTL (right-to-left written) language (such as Arabic and Hebrew) support.
2007-05-27 17:57:48 +00:00
3cafffe63f
- Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave.
2007-05-25 12:46:46 +00:00
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00
c32e17e3f2
- Patch #141665 by ChrisKennedy: E_ALL fixes.
2007-05-07 17:02:54 +00:00
7d4f2836ba
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
2007-04-30 17:03:29 +00:00
f73610bec6
- Patch #76588 by Gabor: made log messages translatable. Yay.
2007-04-24 13:53:15 +00:00
03b4b58e9a
- Patch #132018 by Steven et al: add .info files to themes.
2007-04-17 07:19:39 +00:00
e675979091
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
2007-04-13 08:56:59 +00:00
dcbb5fa3f4
- Patch #107061 by Steven et al: add jQuery teaser splitter.
2007-04-09 13:58:03 +00:00
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
b20618aa12
- Patch #128866 by Gabor et al: new language subsystem fixes.
2007-03-28 14:08:23 +00:00
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
eb6b848de6
- Patch #110888 by Eaton: unify hook _alter()
2007-03-26 00:35:59 +00:00
4b635f6d0a
- Patch #128081 by Eaton: remove #base, paving the path for a simpler form API.
2007-03-17 18:30:14 +00:00
7f4e49016a
- Patch #122824 by PMunn: fixed SQL query to be compatible with PostgreSQL.
2007-02-28 20:42:50 +00:00
dc5843bd30
- Patch #111347 by Steven: refactor url() and l().
2007-02-15 11:40:19 +00:00
72501e54df
- Patch #115667 by rotzi: added versioning support to node terms.
2007-02-12 17:47:08 +00:00
a1e6728a46
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-02-11 09:30:51 +00:00
ce358d8c7a
- Patch #113286 by maynich: added missing t() function.
2007-02-01 21:44:36 +00:00
489903a08e
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-01-31 21:26:56 +00:00
1126d5cfe9
- Patch #40575 by Wesley: made it easier to theme the forum overview page.
2007-01-31 16:01:17 +00:00
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
3b543c18f5
- Rollback of E_ALL patch. Too much extra breakage.
2007-01-25 22:14:06 +00:00
89c8b3feaf
- Patch #112563 by webchick: prevent double-escaping.
2007-01-25 21:49:32 +00:00
03752e35a4
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
2007-01-24 14:48:36 +00:00
74e3c74b81
- Always check the username.
2007-01-10 15:17:51 +00:00
365439ffdf
#107015 : Code consistency, capitalization of class names.
2007-01-05 05:32:23 +00:00
3111774ef7
#19891 by edkwh. Make forum and container names links in forum administration.
2006-12-25 22:22:42 +00:00
fdef98345a
- Patch #104882 by dww: fixing forum topic teasers.
2006-12-23 19:30:46 +00:00
bdf5dc9d1d
- Patch #102413 by yched: path node/add/[poll|forum|blog] defined twice.
2006-12-10 20:34:03 +00:00
47f527fbbe
Fixing commit of #100563 (thanks webernet)
2006-12-01 23:17:26 +00:00
0ea4e1c5f6
#100563 : Conditional loading of (some) module.css files
2006-12-01 22:47:53 +00:00
f94622db5d
- Patch #99948 by neclimdul: added some help text.
2006-11-28 09:48:45 +00:00
b5bf8a8f47
#97824 by Gurpartap. Move enclosing elements outside of their t().
2006-11-26 02:20:01 +00:00
0b61aef454
#83190 by webchick. Remove misleading links.
2006-11-25 09:07:26 +00:00
6ae6dc0d85
- Patch #87298 by webchick, neil, dww et al: show version numbers on modules page.
2006-11-21 20:55:36 +00:00
b004f328ee
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
2006-11-21 20:14:19 +00:00
392041edf6
#72467 by m3avrck. Better display for long book page and forum topic titles.
2006-11-14 06:30:10 +00:00
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
18b297abf8
- Patch #81740 by merlinofchaos, webchick, moshe, neclimdul et al: added package support to the modules page.
2006-10-05 15:47:57 +00:00
772d7624ba
#47692 by Wesley Tanaka. Clean up some PHP notices.
2006-10-04 06:07:05 +00:00
f24e304fa3
#84875 : Dependency system for core
2006-10-02 16:49:08 +00:00
030f9741b7
#84076 by edkwh. Interim fix for being able to delete forums and forum containers.
2006-09-23 08:10:40 +00:00
66fe517e0b
#40751 by chx. Redirect back to the forum when logging in from there.
2006-09-05 02:48:33 +00:00
6c406e39a1
- Patch #76742 by beginner, eaton et al: fixed problem with editing container description of forums.
2006-09-03 14:42:12 +00:00
94098f7e93
#81033 by webchick and neclimdul. Uninstall module API.
2006-09-01 07:40:08 +00:00
49fa25fb76
- Rollback of patch #68418 : clean up node submit hooks. Needs more thinkering.
...
Restores the old node API.
2006-08-31 21:58:36 +00:00
c64db1da29
- Patch #80952 by earl, webchick, neclimdul et al: .info files
2006-08-31 20:22:37 +00:00
5524604a95
- Patch #68418 by Moshe et al: clean up node submit hooks.
2006-08-29 18:43:26 +00:00
bceaf8f0da
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
2006-08-29 09:12:03 +00:00
07ad89db03
#70660 by pwolanin. Forum last post time was considering non-forum items.
2006-08-26 00:19:02 +00:00
6ea9204889
#56093 by webchick. Fix forums.
2006-08-25 08:55:04 +00:00
2d05938082
- Patch #66569 by m3avrck: Consolidate the drupal_add_link() calls.
2006-08-23 07:23:09 +00:00
a58d877108
#66569 by m3avrck. Put all the feed icons in the same place.
2006-08-23 05:55:38 +00:00
7178f2f99e
- Patch #79428 by Chris Johnson: remove int display width declarations from MySQL create table statements.
2006-08-20 06:38:50 +00:00
55eec8f66f
#79601 : module_exist() -> module_exists()
2006-08-20 05:57:41 +00:00
7de41539df
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
2006-08-18 18:58:47 +00:00
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
bf3487c0b1
#76681 by sammys, sync posgres install and change unsigned annotation.
2006-08-15 05:25:20 +00:00
3cc2b1e3d7
#77183 by m3avrck and timcn, split up drupal.css by module.
2006-08-14 07:14:50 +00:00
ce85b7c7f8
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
...
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
729fa6c11b
- Patch #77422 by timcn: corrected various paths in the documentation.
2006-08-07 15:04:16 +00:00
129c8eb18c
#62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types.
2006-08-06 23:00:42 +00:00
5c57a53165
#76339 by pwolanin, allow non-forum category changes while leaving a shadow copy
2006-08-05 01:42:56 +00:00
cd430165d7
#73884 by RobRoy, various code cleanup.
2006-08-05 00:26:36 +00:00
6839ce965f
#76742 by paranojik, fix a bug preventing editing of forums
2006-08-05 00:13:06 +00:00
a7f67e01de
- Patch #76681 by sammys: PostgreSQL support for install system. Woot! :)
2006-08-04 06:58:44 +00:00
b138793b68
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
2006-07-31 11:25:55 +00:00
3a7b64ae03
- Patch #61893 by timnc: remove message_na().
2006-07-29 17:56:41 +00:00
7d9f57ff63
#73591 by Flanker, add missing CVS Ids.
2006-07-14 01:05:10 +00:00
1c75a210bd
- Patch #68926 by chx, jeremy, steven, eaton, webchick, amazon, neil, nedjo et al: an initial install system for Drupal core.
2006-07-13 13:14:25 +00:00
eaf5f2e029
#49299 by wtanaka, properly break words
2006-07-11 07:04:34 +00:00
58752cfaa2
- Patch #72284 by me:
...
+ reorganized ?q=admin/settings
+ deprecated the _settings hook
2006-07-10 19:27:52 +00:00
e93f8be871
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
2006-07-05 11:45:51 +00:00
59aa2ae8e8
#71925 by Steven, remove # prefix from link array keys.
2006-07-04 08:59:05 +00:00
af6c897056
#65024 by killes, remove an extra condition.
2006-06-12 03:44:54 +00:00
226eed7047
- Patch #67146 by webchick: make sure that the forum vocabulary shows up first.
2006-06-06 15:35:39 +00:00
cf3bfe006b
- Patch #18260 by Morbus: fixed taxonomy links.
2006-05-29 12:58:19 +00:00
1b291a2917
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
2006-05-18 14:58:57 +00:00
e1304697c4
- Patch #62350 by hunmonk: fixed problem with deleting forum containers.
2006-05-08 15:16:16 +00:00
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
d6a164c400
#5371 , drupal_get_destination, pager and tablesort array handling, patch by Steven
2006-04-13 08:25:27 +00:00
9794b5538e
- #55898 : Generic, permissive admin XSS/HTML filtering for mission/footer/...
...
- Clean up some raw output
2006-04-07 15:32:17 +00:00
3000db0d13
#40664 , adding new forum topic, forum not pre-selected in pull down menu., fix by Jonas Kvarnstrom, patch by drumm
2006-04-06 18:36:57 +00:00
be0b774cbc
- #57523 : Make taxonomy delete vocabulary consistent with other taxonomy hook ops
2006-04-06 04:21:12 +00:00
ec04325bb2
- Make forum_hot_topic scale a bit more logical
2006-04-06 04:18:30 +00:00
603a6618ee
#28625 , Forum vocabulary does not handle standard vocabulary features correctly, removed these features by means of formapi, patch by profix898, with some love by dopry and chx
2006-03-31 06:43:46 +00:00
002fee7aae
#56105 , remove title validation, already enforced by #required, patch by Moshe
2006-03-27 18:02:48 +00:00
0ed9f460dc
#55805 , missing {}, patch by Cvbge
2006-03-25 10:52:40 +00:00
717d6e30c5
#54098 , forum "last post" column show oldest, not most recent, patch by Zen.
2006-03-24 10:13:10 +00:00
d11c07502d
#54910 , Forum and taxonomy term delete work only superficially, patch by Zen
2006-03-23 21:46:35 +00:00
40e2a3b379
#51635 , Moving forum post leaving shadow copy results in warning, patch by Zen/webchick
2006-03-08 22:11:54 +00:00
7add598ee2
- Patch #51850 by chx, webchick et al: fixed various problems with db_rewrite_sql, made db_rewrite_sql slightly more robust.
2006-03-08 15:13:20 +00:00
d2865f2a99
- Patch #52850 by Zen: fapi conversion + minor fixes
...
* converts forum_admin to fapi.
* handles invalid terms in hook_menu
* adds comments, fixes typos etc.
* reorganises functions a little bit - moves hook_menu to the top.. groups hooks together and forms together
2006-03-07 19:03:02 +00:00
d7e9371e94
- Removing whitespace
2006-03-03 08:37:47 +00:00
1d865eb4c4
#51613 , forum.module forms ignore proper form submission path, patch by merlinofchaos
2006-02-28 13:36:59 +00:00
19afd2ceb7
- Patch #45850 : it was impossible to create shadow topic. (Today's critical bugfix #2.)
2006-02-23 12:21:15 +00:00
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
f030164bcb
- Patch #46743 by Morbus: fixed double encoding issue.
2006-02-15 20:47:35 +00:00
91152ba7af
- Patch #46743 by m3avrck: clean up forum topic navigation. Bring it in line with book.module.
2006-02-10 05:05:44 +00:00
88490f6413
- Patch #47691 by Cvbge: quickfix postgresql
2006-02-09 08:52:03 +00:00
a723204ee4
- Patch #47691 by wtanaka: performance improvement for _forum_topics_read.
2006-02-09 08:09:55 +00:00
87f5947e51
- Patch #47868 by wtanaka: performance improvement: active topics block selects an unused column.
2006-02-04 09:56:04 +00:00
31293d5a2e
- Patch #46864 by stmind: fixed problem with node-level permissions and forums.
2006-02-01 14:19:44 +00:00
8c02d4ec93
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
...
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
10d7f7731b
- Patch #45281 by chx: made categories with forum topics work again.
2006-01-19 17:55:54 +00:00
e84a98a22b
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
2006-01-19 08:54:41 +00:00
52507806eb
- Patch #45301 by Morbus: corrected the weight of form item titles of nodes.
2006-01-18 19:29:17 +00:00
92acb92699
- Patch #33747 by Ber and Moshe: bugfix + code improvement: clean up some of the taxonomy loading code.
2006-01-10 12:35:20 +00:00
b170d83d14
- Removed global .
2006-01-09 10:12:30 +00:00
4e35060451
- Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions.
2005-12-31 13:04:40 +00:00
799ceae29b
- Patch #42705 by Cvbge: added missing format_plural().
2005-12-31 11:21:32 +00:00
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
79a193a2d2
- #42234 : Use standardized feed icon for RSS
2005-12-29 04:46:40 +00:00
1ef56e36a0
- Patch #42343 by wulff: added 2 missing t() functions.
2005-12-26 11:26:21 +00:00
544aefad8a
- Modified patch #40534 : improved themability of forum icons (makes it possible to use animated gifs) + removed forum setting.
2005-12-11 12:44:39 +00:00
99e27195e8
- Patch #40664 by Gerhard: assign default forum when adding a forum topic from within a forum.
2005-12-10 19:58:40 +00:00
32d9af4916
- Patch #39598 by Gerhard: fixed problem with taxonomy terms not being selected.
2005-12-06 12:20:24 +00:00
c4c5ce122d
- Patch #31323 by Gerhard: delete extra data when a revision is deleted.
2005-12-05 16:07:18 +00:00
28fdb3975e
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
2005-12-05 09:11:33 +00:00
94f290c8ee
- Patch #38849 by wtanaka: forum icon does not display as locked (aka closed) if comments are "disabled" instead of "read only".
2005-12-03 10:02:23 +00:00
272c6b95fa
- Patch #39667 by killes: fixed typo in function call: _forum_get_vid -> _forum_get_vid().
2005-12-02 15:38:58 +00:00
26bd449860
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
2005-12-02 15:21:01 +00:00
90535c33aa
- Patch #38854 by wtanaka: fixed XHTML validation problem.
2005-11-26 19:45:31 +00:00
d4692d569c
- Patch #35644 by webchick: fixed the sizes of the textareas on the node edit forms.
2005-11-23 16:18:28 +00:00
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
85492ae9a5
#36791 : node_validate was called twice
2005-11-12 02:54:13 +00:00
b4644f8e66
- Patch #36250 by hunmonk: admin batch delete broken, node_delete needs reworked.
...
This commit changes the node_delete() API. A list of affected modules is available at http://drupal.org/node/36250#comment-52963 .
2005-11-04 19:40:28 +00:00
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
da1de1df9f
- Patch #35205 by stefan: removed some deprecated code from forum.module! Yay.
2005-10-28 13:56:26 +00:00
0f37358003
- Patch #35061 by Cvbge/ntosi: fixed SQL query problem on PostgreSQL 8.
2005-10-28 13:40:17 +00:00
9f143557a3
- #35505 : Forum form api typo
2005-10-28 00:42:55 +00:00
6777fdb193
- #26583 : Make forum taxonomy links redirect to forums rather than taxonomy pages.
2005-10-21 11:12:46 +00:00
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
a1ae4da70b
- Removing tabs and trailing whitespaces.
2005-10-07 06:51:43 +00:00
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
9981e4326d
- Patch #32459 by beardedstoat and tostinni: always add a secondary sort order so the newest comments are on top.
2005-10-01 13:30:06 +00:00
cba3391b1f
- Fixed spaces
2005-09-27 15:06:35 +00:00
67e68fc679
- Patch #28786 by Neil: move pagers out of table.
2005-09-24 07:53:26 +00:00
61740bd8ee
- Patch #10056 : allow the node title forms to be customized.
2005-09-23 08:47:13 +00:00
2dddd9e532
- Patch #29102 by menesis: fixed typo/left-over in switch-statement.
2005-09-08 19:22:28 +00:00
16262e03d5
- Patch #28320 by Neil: improved the HTML/CSS of the user login block.
2005-09-07 20:56:00 +00:00
67de4f67d2
- Usablity improvement: check whether the comment module is enabled. If not,
...
show an error message.
2005-09-06 19:38:56 +00:00
d9d6a6e05c
- Patch #7582 by Gerhard: improved node revisions!
...
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.
TODO:
1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions. Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
246274eb16
- Renamed _node() to _node_info()! We reserve _node for _nodeapi.
2005-08-29 19:58:49 +00:00
8f32c39db2
- Patch #29102 by chx: fixed bug in forum module and tidied up the taxonomy_save_*() functions.
2005-08-28 15:58:52 +00:00
c9fc300b1f
- Patch #29785 by Chx: multiple node types were broken so we refactored
...
part of the node system! If you have a module that implements node
types, you'll have to udpate its CVS HEAD version.
We replaced _node_name() and _node_types() by _node(). The new _node()
hook let's you define one or more node types, including their names.
The implementation of the _node() hook needs to:
return array($type1 => array('name' => $name1, 'base' => $base1),
$type2 => array('name' => $name2, 'base' => $base2));
where $type is the node type, $name is the human readable name of the type
and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.
For example, the story module's node hook looks like this:
function story_node() {
return array('story' => array('name' => t('story'), 'base' => 'story'));
}
The page module's node hook module like:
function page_node() {
return array('page' => array('name' => t('page'), 'base' => 'page'));
}
However, more complex node modules like the project module and the
flexinode module can use the 'base' parameter to specify a different base.
The project module implements two node types, proejcts and issues, so it
can do:
function project_node() {
return array(
array('project_project' => array('name' => t('project'), 'base' => 'project'),
array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
}
In the flexinode module's case there can only one base ...
This hook will simplify the CCK, and will make it easy (or easier) to merge
the story and page module.
In addition, node_list() became node_get_types(). In addition, we created
the following functions: node_get_name($type) and node_get_base($type).
2005-08-28 15:29:34 +00:00
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
97bc92f6b9
- Patch #29133 by DriesK: forum vid remains when vocabulary is deleted. Prevents forum topics from getting lost.
2005-08-18 21:53:55 +00:00
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
87e5399a9e
- Patch #19621 by Morbus/drumm: fixed bugs with taxonomy_save_xxx() functions.
...
TODO: update image module too?
2005-07-18 19:31:16 +00:00
58aee8cdad
- Patch #25603 by Stefan: made the sizes of forms consistent.
...
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
f12d5c5347
- Patch #21918 by budda/Robin: forum icons are broken when you change the forum icon path. TODO 1: the forum icons should probably be configurable on a per-site or per-theme basis. TODO 2: I spent 5 minutes looking for this setting.
2005-06-19 08:43:59 +00:00
a597354bcb
- Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags.
2005-05-31 21:14:27 +00:00
f3cbb10d8e
- #19434 : Improved forum admin texts.
2005-05-25 06:41:51 +00:00
0ff0af1601
- #23014 : Only show forum blocks if there are topics to list.
2005-05-25 03:59:38 +00:00
235a39e589
- Removing the /*! USE INDEX */. It actually degrades performance significantly.
2005-05-20 11:04:06 +00:00
89ae34de47
- #19621 : More sensible status messages for forum admin ("created forum" instead of "created term").
2005-05-07 01:48:06 +00:00
85bf4a010b
- Oopsie
2005-05-06 06:41:59 +00:00
0d134850d9
- Missing theme placeholder in forum delete message.
2005-05-06 06:32:13 +00:00
2debcfb1ef
- Patch #15595 by Stefan and Djun: improved status messages.
...
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
2005-05-05 22:22:46 +00:00
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
c9c947619f
- Added missing {}.
2005-04-12 18:55:33 +00:00
d0d5b52ac1
- Patch #19884 by Robin Monks: added help text for ?q=admin/forum/configure
2005-04-11 18:21:59 +00:00
5c56cd5b33
- Patch #19434 by nysus: improved the forum module help texts.
2005-04-11 17:54:13 +00:00
38eef18e98
- Patch #19615 by chx: fixed problem forum container getting lets when editing a forum.
2005-04-08 11:07:57 +00:00
a3e9b35afc
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
2005-04-01 15:55:02 +00:00
7bdcba1720
- Patch #19739 by Uwe: corrected many typo's in the documentation and code comments
2005-03-31 21:18:08 +00:00
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
bbae5e815d
- #18795 : Display message to forum admin if there are no forums yet.
2005-03-27 22:51:47 +00:00
571369c62f
- Patch #18732 by nysus and Morbus: improved the forum module's help texts.
2005-03-23 21:53:10 +00:00
8e1dd1d625
- Added XML-icons on forum listings. Many people will find this useful to track updates/changes.
2005-03-21 19:45:35 +00:00
c3f1f7345e
- #18939 (Stefan): Always use paragraph tags around page help text.
2005-03-18 07:07:04 +00:00
82565266b8
- Patch #18927 by Periastron: as one navigates down through the forum taxonomy, the title used to change to the current term, but now it always just displays the vocabulary name. I have attached a patch that restores the previous behaviour. It looks like the regression may have been introduced in some changes to theme_forum_display.
2005-03-16 21:07:59 +00:00
3b70f0015f
- Patch #18787 by nysus: when trying to delete a forum or container, multiple instances of a Drupal page appear nested inside of each other when the confirmation of deletion page is displayed.
2005-03-13 21:04:43 +00:00
743b10078a
- Patch #18465 by nysus: improved the forum container explanation.
2005-03-09 14:07:24 +00:00
198ec98f75
#18329 : Unify confirmation messages (and make them themable)
2005-03-03 20:51:27 +00:00
749f15e7c0
- Modified patch #18328 by Neil: currently the two forum topic blocks share a number of topics in block setting. This is a bit confusing since configuring one blockshould not affect another block. Fixed some indentation as well.
2005-03-03 20:02:07 +00:00
84b7defc07
- Bugfix: admin/forum tabs should not appear on edit forum/container pages.
2005-03-03 05:10:28 +00:00
39adda1687
- Patch #17747 by Adrian: more PostgreSQL fixes. Committed part of the patch:
...
1. Removed a duplicate line from the changes to update.inc.
2. Excluded the session.inc changes: they did not make sense to me.
3. Excluded the search related changes in the node and search module. According to Steven these are not correct.
2005-02-27 15:40:35 +00:00
fb4b224a37
#16951 : Move forum settings to configure tab (drumm)
2005-02-26 23:53:39 +00:00
f228b1cb9c
- Patch #16829 by kbahey: separated the forum block for sake of consistency with other blocks.
2005-02-10 19:14:50 +00:00
993ea0c6c5
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
2005-01-29 22:02:37 +00:00
92320b2b21
- Patch #10425 by ccourtne and walkah: added admin screens to maintain forums instead of forcing the user to add a taxonomy.
2005-01-28 15:47:03 +00:00
7415e0b1c8
- Patch #16192 by Neil: moved the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module.
2005-01-26 22:59:41 +00:00
cdc4ca816d
- Patch #15977 by Neil: made the forum module suggest a menu item.
2005-01-24 21:01:57 +00:00
aacfec0fc1
- Patch #15978 by Drumm: code improvement: theme_forum_display() has no business calling theme_page(). Lets have it return the output and then forum_page() can put it in a page.
2005-01-22 08:38:25 +00:00
09bd156ba2
- Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
...
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
e7edb55d63
- The real code fixes ;)
2005-01-17 19:00:03 +00:00
971a0e24aa
- Patch #14731 by chx: made it possible to rewrite node queries.
2005-01-16 18:44:49 +00:00
fc143ca3af
- Modified patch #15122 by killes: fixed some PHP5 problems.
2005-01-04 20:54:23 +00:00
2b17b3a966
- Patch #13907 by Neil: less ways to set the page title.
...
* Less logic in theme code.
* Encourages use of the menu system.
* Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
* Very slightly more efficient.
2004-12-15 21:19:42 +00:00
4726c93156
- Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly.
2004-11-24 22:56:21 +00:00
9574766ad8
- Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency.
2004-11-23 22:20:41 +00:00
fa97839088
- Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
...
Read the manual for pg_escape_string: "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
9979aceab0
- Patch #12783 by Stefan: various small consistency/usability improvements.
2004-11-15 11:16:39 +00:00
7a5884cd74
- Patch #11427 : added 'edit own forum topics' permission.
2004-11-07 19:28:24 +00:00
6f7aa2a095
- Patch #11871 by killes: forum topics could be displayed multiple times when node-level permission were used.
2004-11-06 11:59:48 +00:00
1821eb13e6
- Removed some dead code.
2004-11-06 11:54:09 +00:00
b3e3f8ae37
- Updated forum_block() to pass comment_count's to node_title_list(). This eliminates up to 10 SQL queries (sometimes less) for each non-cached page view on drupal.org. Derived from ccourtne's patch.
2004-11-04 21:05:06 +00:00
4fa64b57c2
- Patch #12502 by Axel: fixed typo in SQL query: h.hid -> h.nid
2004-11-03 22:46:53 +00:00
b3adcf05a3
- Patch #11875 by Neil Drumm: block module configuration improvements.
...
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
f1a087e376
- Patch #11879 by Moshe: deprecated the _content hook.
...
TODO:
+ Update Doxygen hook list (if required).
+ Document this in the developer's upgrade section.
2004-10-23 17:18:23 +00:00
10f329c057
- Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.
...
Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
2004-10-19 18:02:31 +00:00
8ce9d2aca4
- Patch #11298 by nato: the function _forum_topics_read was not returning only nodes of type 'forum' resulting in the forum overview listing counting all node types as topics; attached patch modifies queries to return counts of only 'forum' type nodes.
2004-10-12 19:44:16 +00:00
2aae0af5d7
- Patch #11426 : the forum module generated an empty table for forums with no child forums.
2004-10-09 17:15:55 +00:00
5f5b02af92
- Patch #11375 by Robert Douglass: removed redundant 'global $user' from forum_insert().
2004-10-07 19:07:57 +00:00
1298d2b9c9
Modified version of #10230 : Put placement of filter format selector in a module's hands, and move it below the relevant textarea.
2004-09-28 19:13:03 +00:00
ff17aa0b94
- Patch #11045 by Stefan: improved consistency of node modules:
...
+ made the helptext under the 'Explanation or submission guidelines', more the same (blog & story);
+ made the form_set_error() texts consistent when the body of a blog/story does not match or exceeds the specified minimal numer of words.
+ used the $options for form_select() and form_radios() inline like we do in the rest of drupal;
+ made the textarea sizes for the submission pages the same for all node types and also for the 'Explanation or submission guidelines';
2004-09-27 20:15:54 +00:00
7823ee8afd
- Patch #10997 by Philippe: the forum submission guidelines were not always shown.
2004-09-22 17:46:44 +00:00
Gábor Hojtsy
Dries Buytaert
Steven Wittens
Neil Drumm
Gerhard Killesreiter