Commit Graph

544 Commits (279f33c6c5903c9c808e0d63adaf05742a56f7f8)

Author SHA1 Message Date
Dries Buytaert a7f12c0326 - Patch #251263 by catch: fixing up many code style issues in the tests. 2008-04-25 18:26:02 +00:00
Dries Buytaert f42c1f2534 - Patch #251239 by R.Muilwijk: performance improvement. 2008-04-25 17:51:30 +00:00
Dries Buytaert af474609e3 - Added a test framework to Drupal along with a first batch of tests for
Drupal core!  This is an important milestone for the project so enable
  the module and check it out ... :)

  Thanks to Rok Žlender, Károly Négyesi, Jimmy Berry, Kevin Bridges, Charlie
  Gordon, Douglas Hubler, Miglius Alaburda, Andy Kirkham, Dimitri13, Kieran
  Lal, Moshe Weitzman, and the many other people that helped with testing
  over the past years and that drove this home.

  It all works but it is still rough around the edges (i.e. documentation
  is still being written, the coding style is not 100% yet, a number of
  tests still fail) but we spent the entire weekend working on it in Paris
  and made a ton of progress.  The best way to help and to get up to speed,
  is to start writing and contributing some tests ... as well as fixing
  some of the failures.

  For those willing to help with improving the test framework, here are
  some next steps and issues to resolve:

    - How to best approach unit tests and mock functions?
    - How to test drupal_mail() and drupal_http_request()?
    - How to improve the admin UI so we have a nice progress bar?
    - How best to do code coverage?
    - See http://g.d.o/node/10099 for more ...
2008-04-20 18:24:07 +00:00
Dries Buytaert 56d2664a90 - Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators. 2008-04-14 17:48:46 +00:00
Dries Buytaert 79b016d915 - Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php.  The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:

    block-user-0.tpl.php --> block-user-navigation.tpl.php
    block-user-1.tpl.php --> block-user-login.tpl.php

  You get the picture.
2008-04-10 10:28:23 +00:00
Dries Buytaert a5c2ad2178 - Patch #231587 by pwolanin et al: fixed scalability issue in the menu system. 2008-03-14 08:51:37 +00:00
Dries Buytaert 584f3e886a - Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page. 2008-02-20 13:46:43 +00:00
Dries Buytaert b05db1f176 - Patch #221384 by webernet: update core compatibility to Drupal 7. 2008-02-18 19:19:49 +00:00
Dries Buytaert 4b6e9f40bd - Patch #221057 by pwolanin: book module may overwrite another node's link. 2008-02-14 18:32:14 +00:00
Dries Buytaert 4969495e04 - Patch #215858 by pwolanin, goba, catch et al: localized menu link data getting saved back to the database. 2008-02-10 19:49:37 +00:00
Gábor Hojtsy af838aec81 #208492 report and testing by KarenS, patch by myself: book upgrade should not use the book API 2008-01-10 18:13:42 +00:00
Gábor Hojtsy b78a990270 #207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks 2008-01-08 10:35:43 +00:00
Dries Buytaert 4f54a173cc - Patch #206470 by David_Rothstein: fix book permission upgrade. 2008-01-05 22:32:25 +00:00
Gábor Hojtsy 5362c16386 #181125 follow up by beginner: book.js should have been removed earlier in #181125, was a commit mistake 2008-01-02 12:12:21 +00:00
Gábor Hojtsy 5f635b9585 #205075 report by ktabuer, patch by myself, testing by ktauber and Lynn: book block throws notice when used on non-book-node page (with a little bit of code cleanup) 2008-01-02 11:36:19 +00:00
Gábor Hojtsy ac4c8f7ab0 #203274 by Pasqualle: remove excessive witespace from our code (minor) 2007-12-22 23:24:26 +00:00
Gábor Hojtsy 6a95c27147 #202425 by keith.smith: standardize reference to block placement page as 'blocks administration page' to avoid any confusion 2007-12-19 19:13:29 +00:00
Gábor Hojtsy d17b6ad1cf #199336 by JirkaRybka: remove improper t() use in update code (update goes all in English, but there were some mistakes), and add messages to updates where there was no return value otherwise, so users know what happens in each update 2007-12-19 10:34:51 +00:00
Dries Buytaert c8b1ddf26a - Patch #164532 by catch, pwolanin, David Strauss, et al.: improve table indicies for common queries. 2007-12-18 12:59:22 +00:00
Gábor Hojtsy b6532a4fdb #200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed 2007-12-14 18:08:50 +00:00
Gábor Hojtsy c6d841c096 #197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc 2007-12-13 09:34:40 +00:00
Gábor Hojtsy 5622bce2d5 #198579 by webernet and hswong3i: a huge set of coding style fixes, including:
- whitespaces at end of lines
 - indentation
 - control structure usage
 - whitespace in empty lines
 - phpdoc comment formatting
2007-12-08 14:06:23 +00:00
Gábor Hojtsy bbd4a50917 #195576 by webernet: fix broken state of book updates due to my faulty rollback of a patch 2007-11-27 10:29:36 +00:00
Gábor Hojtsy 22a4c039da Rollback the accidentally committed #194310 2007-11-26 19:55:15 +00:00
Dries Buytaert 9a96837b89 - Patch #163246 by keith smith, freso, O Govinda, catch, webchick et al: fixed minor spelling issues and fixed spacing issues. 2007-11-26 16:36:44 +00:00
Dries Buytaert 58852d4b7b - Patch #192736 by quicksketch et al: drag and drop for book module. 2007-11-26 16:19:37 +00:00
Gábor Hojtsy a960d4d618 #120960 by blakehall, JirkaRybka, catch: improve usability of content editing permission names 2007-11-26 11:44:04 +00:00
Gábor Hojtsy 7f85abe0e5 #191360 by chx: allow contributed modules to override the book and menu parent selectors (to improve usability and performance) 2007-11-21 19:08:18 +00:00
Gábor Hojtsy 75a6f4ded4 #160200 by dvessel and chx: better theming support for book module 2007-11-04 14:29:09 +00:00
Gábor Hojtsy 4f5c52e249 #100569 by keith.smith: improve explanation of what a book is about (in book.module) 2007-10-27 13:45:24 +00:00
Dries Buytaert 1cf05b0019 - Patch #89196 by catch, keith, earnie, webchick et al: string massaging. 2007-10-25 15:32:56 +00:00
Dries Buytaert a745b0f68b - Patch #155870 by quicksketch et al: AHAH-ification of the poll module. 2007-10-17 12:34:16 +00:00
Gábor Hojtsy 5915029580 #181125 by quicksketch and dmitrig01: AHAH usability improvements for book module
- book outline form reordering in real-time
 - better context sensitive book parent editing
2007-10-15 19:33:27 +00:00
Gábor Hojtsy 8cf6fefe54 #164983 by multiple contributors: document the core database schemas 2007-10-10 11:39:35 +00:00
Dries Buytaert 39706e3c51 - Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes. 2007-10-05 14:43:26 +00:00
Gábor Hojtsy ac43420be3 #86857 by pwolanin and webchick: autogenerate log message for book page changes when made from the outline view (ie. node title or weight can be changed and is now in the log message) 2007-09-28 15:44:13 +00:00
Gábor Hojtsy 12f771d565 #160043 by chx: array_filter for book admin settings form, which is required based on http://lists.drupal.org/pipermail/development/2006-September/019917.html 2007-09-25 12:50:34 +00:00
Gábor Hojtsy 21ac9f1917 #174708 by multiple contributors: update jQuery to 1.2 2007-09-12 18:29:32 +00:00
Gábor Hojtsy f82029a2d9 #172840 by Crell: break up book module to improve performance 2007-09-11 17:35:58 +00:00
Dries Buytaert ab1715750a - Patch #172961 by webernet: code style cleanup. 2007-09-05 08:42:02 +00:00
Gábor Hojtsy c07305d060 #172149 by dvessel: add semicolons, so the JS aggregator works 2007-09-01 07:08:11 +00:00
Gábor Hojtsy 4e0071fb8a #111127 rollback by chx, slightly extended: roll back node_load cache, it needs more thought and discussion, so postponed until at least Drupal 7 2007-08-30 15:31:46 +00:00
Dries Buytaert 31c357f9c8 - Patch #170004 by pwolanin: removed db_num_rows() in book_update_6000. 2007-08-26 07:20:07 +00:00
Gábor Hojtsy 801756e7e6 #111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op) 2007-08-25 09:25:49 +00:00
Dries Buytaert f2ce877d43 - Patch #145218 by profix898, bennybobw, Crell, forngren et al: use href instead of @import for CSS. 2007-08-23 16:41:19 +00:00
Gábor Hojtsy f4dc86046f #165675 follow up patch by pwolanin: retain menu information on node previews to check, do not use the newly selected values yet, to be consistent with the DB 2007-08-20 17:54:35 +00:00
Dries Buytaert 74292cd062 - Patch #80951 by killes, yched et al: block caching. 2007-08-19 08:08:45 +00:00
Gábor Hojtsy 9361518ce8 #166913 by pwolanin and webernet: fix book outline removal confirm form parameters and improve user documentation 2007-08-18 11:36:40 +00:00
Gábor Hojtsy 115285f30a #165675 by pwolanin: only show allowed parent items in menu/book select fields to avoid going deeper then what is allowed 2007-08-16 12:47:34 +00:00
Dries Buytaert 15c68075d9 - Patch #154470 by pwolanin et al: optimize menu queries and indices. 2007-08-11 14:06:15 +00:00
Gábor Hojtsy 509d570bbd #160039 by prakashp, chx and pwolanin: fix node saving:
- centralize/reuse some node form saving code
 - fix uploads without JS
 - fix reappearing teasers on node save
2007-08-09 11:01:00 +00:00
Gábor Hojtsy 2bfeda7672 #164348 by pwolanin: improve book block performance 2007-08-07 11:43:05 +00:00
Gábor Hojtsy b2ebf5d180 #164545 by pwolanin: fix call time pass by reference warning 2007-08-04 21:24:32 +00:00
Dries Buytaert e7f195bbee - Patch #146425 by pwolanin et al:
* Removes the hard-coded 'book' type and perform all node actions
      equally on any node type via hook_nodeapi.
    * Achieves 100% integration with the menu system.  Improves
      performance of book rendering.
    * All the algorithms have been changed to use the tree data structure
      returned by the menu system.
    * Added support for 'multiple books'.
    * Some UI improvements.

  This is a momumental patch that took 69 iterations. Although there is
  room for improvement, this is a big step forward.  Thanks for the
  persistence, pwolanin.
2007-07-30 18:20:21 +00:00
Dries Buytaert 4bf0b45a22 - Patch #142157 by xqus: fixed problem with l() conversion. 2007-07-03 19:29:32 +00:00
Dries Buytaert e59852d336 - Rollback of patch #147723: delete API. Talked to Steven and Gabor and we
unanimously agreed to rollback the deletion API.  We all support the
  features this patch added, yet not its actual design and implementation.
  After some talk, we decided that it would be better for Drupal -- in the
  long term -- not to go with a solution that isn't 100%. We also recognize
  that in the short term, this patch would have been useful addition. So
  let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Gábor Hojtsy 9e6ef53c2c #154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array 2007-06-30 19:46:58 +00:00
Dries Buytaert afc700a3f6 - Patch #153364 by webernet: notices and RTL issue with book.module. 2007-06-28 08:56:28 +00:00
Steven Wittens 38a1300df2 #147723: Deletion API (by hunmonk). Woop woop. 2007-06-22 05:44:21 +00:00
Gábor Hojtsy c059a6d984 #145737 follow up patch by yhager: include right to left styles for print.css 2007-06-10 08:55:55 +00:00
Dries Buytaert 29eb5a6284 - Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version. 2007-06-08 05:50:58 +00:00
Dries Buytaert 1fe90cba4f - Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments 2007-06-04 07:22:23 +00:00
Dries Buytaert 96926ca047 - Patch #146470 by Eaton et al: standardize form API3 hook parameter order. 2007-05-28 06:08:47 +00:00
Gábor Hojtsy 860947d3c8 #145737 by yhager, documentation cleaned up by myself: add support for RTL CSS overrides and default RTL CSS override files for modules
Note: properties, which are different in the RTL display are marked with /* LTR */ in default CSS files now,
so maintainers remember that changing them should also have an effect on RTL CSS files.

This should open the way for better RTL (right-to-left written) language (such as Arabic and Hebrew) support.
2007-05-27 17:57:48 +00:00
Dries Buytaert 3cafffe63f - Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave. 2007-05-25 12:46:46 +00:00
Dries Buytaert ac65ff9074 - Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :) 2007-05-14 13:43:38 +00:00
Dries Buytaert 7d4f2836ba - Patch #128082 by Goba et al: Allow localization of built-in menu items. 2007-04-30 17:03:29 +00:00
Dries Buytaert f73610bec6 - Patch #76588 by Gabor: made log messages translatable. Yay. 2007-04-24 13:53:15 +00:00
Dries Buytaert e675979091 - Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot. 2007-04-13 08:56:59 +00:00
Dries Buytaert dcbb5fa3f4 - Patch #107061 by Steven et al: add jQuery teaser splitter. 2007-04-09 13:58:03 +00:00
Dries Buytaert 5bbbf10ba8 - Patch #130987 by merlinofchaos: added theme registry for easier themability. 2007-04-06 13:27:23 +00:00
Steven Wittens f7440d4d73 #130971: Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc) 2007-03-27 05:13:55 +00:00
Dries Buytaert 632c09e419 - Patch #114745 by moonray: book module: can't remove top-level node. 2007-03-25 21:02:33 +00:00
Dries Buytaert 4b635f6d0a - Patch #128081 by Eaton: remove #base, paving the path for a simpler form API. 2007-03-17 18:30:14 +00:00
Dries Buytaert a1e6728a46 - Patch #113603 by chx: first crack at re-implementing tabs. 2007-02-11 09:30:51 +00:00
Dries Buytaert 05a708fb06 - Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks. 2007-01-31 15:49:26 +00:00
Dries Buytaert f3e5986a29 - Patch #109010 by O Govinda: fixed CSS for handling of book navigation links. 2007-01-29 18:53:38 +00:00
Dries Buytaert 3b543c18f5 - Rollback of E_ALL patch. Too much extra breakage. 2007-01-25 22:14:06 +00:00
Dries Buytaert fd32b42196 - Patch #112715 by webchick et al: fixed some E_ALL errors. 2007-01-25 21:32:07 +00:00
Dries Buytaert 03752e35a4 - Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet. 2007-01-24 14:48:36 +00:00
Neil Drumm 5c4d5386e2 #107443 by webchick. Proper . placement. 2007-01-09 08:31:22 +00:00
Dries Buytaert b52f2556f5 - Patch #107306 by webernet: fixed incomplete break-tag clean up. 2007-01-07 15:51:24 +00:00
Neil Drumm c2d3944273 #100963 by Eaton. Use new pattern for node rendering in printer-friendly version. 2006-12-29 07:41:44 +00:00
Neil Drumm dca26f5ebd #26552 by Heine. Add child page to unpublished book nodes doesn't work, so remove the link. 2006-11-30 02:04:31 +00:00
Neil Drumm 1fb7148854 #100350 by dvessel. Adda missing <p> tag. 2006-11-29 22:51:03 +00:00
Dries Buytaert 827f064deb - Patch # #98366 by webchick and ac: simplified strings for translators. 2006-11-24 10:18:24 +00:00
Dries Buytaert 6b08f590b1 - Patch #97889 by pwolanin, webchick et al: book documentation improvements. 2006-11-22 09:58:48 +00:00
Dries Buytaert 6ae6dc0d85 - Patch #87298 by webchick, neil, dww et al: show version numbers on modules page. 2006-11-21 20:55:36 +00:00
Dries Buytaert b004f328ee - Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard. 2006-11-21 20:14:19 +00:00
Dries Buytaert e89c6c1da7 - Patch #93678 by chx: book module not updating the database properly. 2006-11-21 19:27:06 +00:00
Neil Drumm 1237159381 #87474 by webernet. Move the log message field from book to node module. 2006-11-16 21:14:44 +00:00
Neil Drumm 392041edf6 #72467 by m3avrck. Better display for long book page and forum topic titles. 2006-11-14 06:30:10 +00:00
Neil Drumm 3a5d412efb #90395 by joshk, mj2308, and kkaefer. Fix book outline saving. 2006-11-07 07:01:05 +00:00
Steven Wittens 36d44fbfb0 #84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc 2006-10-22 08:28:47 +00:00
Dries Buytaert 18b297abf8 - Patch #81740 by merlinofchaos, webchick, moshe, neclimdul et al: added package support to the modules page. 2006-10-05 15:47:57 +00:00
Dries Buytaert 878bb6162c - Patch #84117 by misawie: make book outlining work with PostgreSQL. 2006-09-26 14:14:30 +00:00
Dries Buytaert 5f8027f94c - Patch #83397 by edkwh: -> . Getting rid of super-globals. 2006-09-17 19:14:16 +00:00
Neil Drumm a74f6f0c3f #83494 by edkwh. Fix the book outline. 2006-09-13 01:30:21 +00:00
Dries Buytaert 2f8262e9aa - Patch #75465 by chx: fixed Doxygen of book.module. 2006-09-05 10:01:48 +00:00
Neil Drumm 94098f7e93 #81033 by webchick and neclimdul. Uninstall module API. 2006-09-01 07:40:08 +00:00