Commit Graph

531 Commits (1eb5be733ab7df65ffa1713c6c5dbba1558547ff)

Author SHA1 Message Date
Dries Buytaert dba3e800cd - Patch #38611 by Neil: redo book administration.
The book module's current administration is actually a patchwork of one form per book page crammed into a table with another form at the bottom. This simply didn't work.
2005-11-23 10:22:41 +00:00
Dries Buytaert cba99db42b - Patch #38296 by Ber: generate rel-tags for book pages. Makes it easier to browse in some browsers. 2005-11-22 15:11:40 +00:00
Dries Buytaert aeed4cd8e4 - Patch #35644 by webchick: forms API simplificiations. 2005-11-12 11:26:16 +00:00
Steven Wittens 85492ae9a5 #36791: node_validate was called twice 2005-11-12 02:54:13 +00:00
Dries Buytaert a8b218827a - Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! / 2005-11-01 10:17:34 +00:00
Dries Buytaert ef7d2c8a9f - Patch #34920 by tangent: reorganized the node submission form a bit. 2005-10-28 14:04:20 +00:00
Dries Buytaert cc9a372eae - Patch #34932 by tangent: fixed the placement of the 'log'-textarea on book preview pages. 2005-10-24 19:03:09 +00:00
Dries Buytaert c47d2fcb46 - Patch #33220 by Tobias: improved themeability of book module. 2005-10-23 18:08:06 +00:00
Dries Buytaert 75fe6b6c0a - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. 2005-10-11 19:44:35 +00:00
Dries Buytaert 6f30f02c16 - Patch #27999 by Tobias: made book export functionality configurable. 2005-10-08 14:48:33 +00:00
Dries Buytaert a1ae4da70b - Removing tabs and trailing whitespaces. 2005-10-07 06:51:43 +00:00
Dries Buytaert 7e1527ee61 - Patch #29465: new form API by Adrian et al.
TODO:
  + The contact.module was broken; a new patch for contact.module is needed.
  + Documentation is needed.
  + The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert 7b5b460534 Improved error-handling of book module. 2005-10-06 09:17:17 +00:00
Dries Buytaert f8e2be5fe7 - Patch #32584 by Gerhard: removed reference to node_revision_load() and fixed
input validation error..
2005-09-29 21:56:12 +00:00
Dries Buytaert 61740bd8ee - Patch #10056: allow the node title forms to be customized. 2005-09-23 08:47:13 +00:00
Dries Buytaert fe5f70b61b - Patch #31496 by Goba: added missing $node object in book export. 2005-09-18 11:26:17 +00:00
Dries Buytaert 3be71ac514 - Patch #30308 by gordon: fixed broken SQL query. 2005-09-06 18:55:41 +00:00
Dries Buytaert d9d6a6e05c - Patch #7582 by Gerhard: improved node revisions!
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node.  This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.

TODO:

1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions.  Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
Dries Buytaert 246274eb16 - Renamed _node() to _node_info()! We reserve _node for _nodeapi. 2005-08-29 19:58:49 +00:00
Dries Buytaert c9fc300b1f - Patch #29785 by Chx: multiple node types were broken so we refactored
part of the node system!  If you have a module that implements node
  types, you'll have to udpate its CVS HEAD version.

  We replaced _node_name() and _node_types() by _node().  The new _node()
  hook let's you define one or more node types, including their names.
  The implementation of the _node() hook needs to:

   return array($type1 => array('name' => $name1, 'base' => $base1),
                $type2 => array('name' => $name2, 'base' => $base2));

  where $type is the node type, $name is the human readable name of the type
  and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.

  For example, the story module's node hook looks like this:

    function story_node() {
      return array('story' => array('name' => t('story'), 'base' => 'story'));
    }

  The page module's node hook module like:

    function page_node() {
      return array('page' => array('name' => t('page'), 'base' => 'page'));
    }

  However, more complex node modules like the project module and the
  flexinode module can use the 'base' parameter to specify a different base.

  The project module implements two node types, proejcts and issues, so it
  can do:

    function project_node() {
      return array(
       array('project_project' => array('name' => t('project'), 'base' => 'project'),
       array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
    }

  In the flexinode module's case there can only one base ...

  This hook will simplify the CCK, and will make it easy (or easier) to merge
  the story and page module.

  In addition, node_list() became node_get_types().  In addition, we created
  the following functions: node_get_name($type) and node_get_base($type).
2005-08-28 15:29:34 +00:00
Dries Buytaert 7b8a409675 - Patch #29385 by chx: no ?> add end of files. 2005-08-25 21:14:17 +00:00
Dries Buytaert f99176c9a0 - Patch #25706 by Neil: book 'previous' link does not respect unpublished node setting 2005-07-29 07:13:25 +00:00
Steven Wittens 515f7b41f1 - #27707: Use local tasks for book administration 2005-07-29 03:49:16 +00:00
Steven Wittens 11a4aba9a6 - #26688: Add mbstring support to Drupal and clear up string handling fuzzies. 2005-07-25 20:40:35 +00:00
Steven Wittens a10ab3daa0 - #27108: Columns in ORDER BY clause must be SELECTed on (pgsql) 2005-07-25 09:31:37 +00:00
Dries Buytaert e0158075f6 - Patch #24805 by Ber: removed some dead code. 2005-07-18 09:57:48 +00:00
Dries Buytaert 160a1e0ef8 - Patch #25634 by chx: simplified node_load(). 2005-07-17 18:29:32 +00:00
Dries Buytaert f14cb1ab2b - Patch #25928 by Uwe: 'the the' -> 'the'. 2005-07-03 15:56:04 +00:00
Dries Buytaert 58aee8cdad - Patch #25603 by Stefan: made the sizes of forms consistent.
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert ba233dd3b8 - Patch #25504 by kumo: fixed problem with the weights of book pages not being remembered. 2005-06-22 20:24:11 +00:00
Dries Buytaert c50316212b - Patch #1898 by Djun: more book module improvements including but not limited
to OPML export functionality, better code comments, better help texts, etc.
2005-06-07 19:20:20 +00:00
Steven Wittens 6ba82cc0c0 - book_render() was broken after a faulty commit. Adding back.
See:
http://cvs.drupal.org/viewcvs/drupal/drupal/modules/book.module?r1=1.294&r2=1.295
2005-06-07 08:30:16 +00:00
Dries Buytaert 78cb173247 - Modified version of patch #1482 by Djun:
This patch enables export of books as XML documents.

The XML is DocBook "at the level of structure", but
node contents are wrapped as CDATA, since we
can't be sure that the contents are valid XML.

Several other bugs/feature requests are also
addressed with this patch:

- Fixes bugs

http://drupal.org/node/1898
http://drupal.org/node/1482
http://drupal.org/node/8049
http://drupal.org/node/1899

Should go a long way towards implementing feature request
http://drupal.org/node/2062

It should also be easy to extend this to produce OPML,
for example.

- Adds about 170 lines, of which more than 100 are comments
- Added doxygen comments
- Made doxygen comment format consistent; fixed minor grammatical slips
- A proper Doctype and more informative HTML element is generated
for printer-friendly HTML output.
- Refactored book_print() to use book_recurse().
- Refactored book_recurse(). Applies 'visitor' callback functions to nodes
during weight/title order tree-traversal. The parameterized
visitor callbacks can be used to generate different kinds of output.
There are many other kinds of operations on books which can be implemented
by writing a pre-node/post-node pair of callback functions: word-count/
statistics gathering, comparison, copying, search and replace...
- Introduced book_export() which uses book_recurse() to generate
DocBook-like XML to export book contents in a structured form.
An md5 hash is computed for each node to help import code to
decide if a node needs to be updated or not.
2005-06-05 10:52:04 +00:00
Dries Buytaert 62427644eb - Patch #23320 by Chris Messina: made it easier to theme the printer-friendly book pages. 2005-05-21 09:59:15 +00:00
Dries Buytaert 30da942645 - Patch #22123 by Djun: fixed off by one error in printer-friendly book pages. 2005-05-06 08:43:21 +00:00
Dries Buytaert 2debcfb1ef - Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
        the PHPDoc code of drupal_set_message()!  .
2005-05-05 22:22:46 +00:00
Dries Buytaert df9f93f98a - Modified patch #21441 from puregin + RobinMonks: fixed some bugs surrounding the book administration and beautified some code making it more consistent with the rest of Drupal. :-) 2005-05-05 09:36:51 +00:00
Dries Buytaert bca14f8991 - Patch #21687 by faago: fixed boroken 'delete'-link on the book administration page. 2005-04-30 21:34:41 +00:00
Steven Wittens 3361d9e7e9 - #21195: book admin broken under php5 2005-04-24 20:57:38 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert cb420f7121 - Work by chx and myself: added a site-wide contact form to the contact module. 2005-04-24 08:23:33 +00:00
Dries Buytaert 394fe19ac6 - Patch #20661 by rooey: fixed formatting of book navigation. Added missing '<div id=menu>'. 2005-04-17 16:03:50 +00:00
Dries Buytaert 293daa4820 - Patch #20451 by Moshe: some ancient code was assuming that all apges in a book are of type 'book'. 2005-04-13 18:50:57 +00:00
Dries Buytaert 398ed04670 - Patch #19960 by Gerhard: removed left-over DISTINCT. Spotted by BuddaBoy. 2005-04-04 21:32:21 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Dries Buytaert a7fa9552ca - Patch #19169 by TDobes: allow the book navigation to be themed. 2005-03-22 18:34:20 +00:00
Dries Buytaert 5b7ecb8650 - Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
    - anchor link fix in distributed auth help
    - "my account" link fix in user help
    - spelling correction in tracker.module help

- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
Dries Buytaert de0a0b7a81 - Patch #16462 by Moshe: book pages slighty disobey the node_access system because they always return a value for book_access('update'). This simple patch causes us to use node_access when the user has a chance of being able to update the current page. 2005-02-06 09:37:10 +00:00
Dries Buytaert 9f77077584 - Fixed a misplaced bracket that slipped in due to the db/node_rewrite_sql_patch. 2005-01-30 08:53:05 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert c8ef017446 - Patch #15948 by matteo: the book module should call the nodeapi hook when printing printer-friendly pages. 2005-01-23 22:35:41 +00:00
Dries Buytaert 630dcebf43 - Patch #15843 by Ber: in book-pages node forms we use a delta of fifteen (-15 to +15) but in the book-outline admin we dont dewfine this, resulting in a default delta of ten. This should be consistent and thus both 15. 2005-01-19 22:13:14 +00:00
Steven Wittens e7edb55d63 - The real code fixes ;) 2005-01-17 19:00:03 +00:00
Dries Buytaert 971a0e24aa - Patch #14731 by chx: made it possible to rewrite node queries. 2005-01-16 18:44:49 +00:00
Dries Buytaert 64b100d19a - Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
    watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);

    * Specify a severity in case you are reporting a warning or error.
    * The $link-parameter is now the fourth parameter instead of the third.

  TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert 046536f470 - Patch #12366 by mathias: fixed missing book edit tab. 2004-12-22 20:47:47 +00:00
Dries Buytaert 78c24e67c0 - Bugfix: the book module incorrectly assumed that there is an active revision if n.moderate = 0. We can (and need) to rewrite this when the revision changes hit core. In essence, we need an efficient query to retrieve the 'last puslished revision that is not in the moderation queue'. 2004-12-18 10:27:28 +00:00
Dries Buytaert 2b17b3a966 - Patch #13907 by Neil: less ways to set the page title.
* Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert 6e3eb60aab - Removed some cruft: left-over xxx_help_page() functions. 2004-12-11 14:13:24 +00:00
Dries Buytaert 4726c93156 - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly. 2004-11-24 22:56:21 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Dries Buytaert fa97839088 - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
Dries Buytaert f67c046d40 - Modified patch #8552 by Gerhard: added 'add child page' link to book pages you can edit. 2004-11-15 12:49:59 +00:00
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00
Dries Buytaert bb3df8a1a9 - Patch #10632 by Gerhard: the book permissions in today's cvs are not consistent with the rest of Drupal. We have a "maintain books" and a "edit own book pages" permission. All other modules have a "create foo" permission. Thus the existing "maintain books" permission should be renamed to "create book pages" and a new "maintain books" permission should be introduced that allows editors to update book pages they haven't created themselves even without having "administer nodes" permission. 2004-11-04 22:31:46 +00:00
Dries Buytaert b3adcf05a3 - Patch #11875 by Neil Drumm: block module configuration improvements.
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.

Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.

The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.

An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
Dries Buytaert f1a087e376 - Patch #11879 by Moshe: deprecated the _content hook.
TODO:
   + Update Doxygen hook list (if required).
   + Document this in the developer's upgrade section.
2004-10-23 17:18:23 +00:00
Dries Buytaert a73f63f10c - Patch #11947 by puregin: ensured that a book node's weight is captured when the book node lists returned by book_location() and book_location_down() are generated. This information is required when selecting next page candidates in book_next().
Note that book_location_down() was missing an explicit field b.weight in the SQL SELECT statement, but this value would usually be supplied implicitly because it is used to ORDER the result.
2004-10-23 13:41:37 +00:00
Dries Buytaert 10f329c057 - Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.
Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
2004-10-19 18:02:31 +00:00
Dries Buytaert 1f1a772a11 - Mofified patch #8862 by puregin: improved book module documentation. 2004-10-15 10:56:23 +00:00
Dries Buytaert 6a8e394301 - Fixed bug #11312: menu caching to aggresively. I did not apply the proposed
patch but moved the menu-logic to the $may_cache clause and added some checks
  to avoid SQL overhead.  I think this is the most performant solution.
2004-10-14 21:45:37 +00:00
Steven Wittens 63061bd745 fixing typoes. 2004-10-14 05:34:12 +00:00
Dries Buytaert e769215e2d - Code improvement: removed some redundant code from the book module. 2004-10-10 11:11:38 +00:00
Dries Buytaert cca3c34faa - Patch #11401 by Goba: documentation updates:
+ Made error strings in blog.module consistent.
   + Explained a bit better what the RSD setting is for in the blog module.
   + Removed the notes about PHP content from block module and book module, since everything is handled via the input formats now.
2004-10-09 06:29:16 +00:00
Dries Buytaert af1eb3b9db - Reintroduced the book outline feature: non-book pages now have an outline-tab on their node page, given you have permission to maintain books. Using the outline-tab, nodes can be added to a book's hierarchy. Also added some context sensitive help and fixed some quotes. 2004-10-08 11:17:59 +00:00
Dries Buytaert 014bbd32ee - Fixed SQL query in book module. Patch by killes. 2004-09-29 14:15:44 +00:00
Dries Buytaert f4b076bc01 - Patch #10977 by killes: review node access checks in book module. 2004-09-29 05:42:37 +00:00
Steven Wittens 1298d2b9c9 Modified version of #10230: Put placement of filter format selector in a module's hands, and move it below the relevant textarea. 2004-09-28 19:13:03 +00:00
Dries Buytaert 309b411803 - Modified patch #10904 by JonathanS: fixed book teasers not being check_output'ed. 2004-09-24 05:48:21 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert 7b716e8e77 - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
1) Menu problems with Postgres (this is a highly critical 1 line fix)
  2) Archive module fails with Postgres
  3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
  4) Book module fails with Postgres
  5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
  6) Creating accregator_item_table in PostgreSQL
  7) Postgres - Polls not displayed on Poll Page
  8) Blog module has sql errors with postgres

  This should not affect MySQL users (hopefully).
2004-09-08 15:38:26 +00:00
Dries Buytaert e1d7609710 - Patch #6464 by TDobes: don't enforce book revision -- rely on the default setting. 2004-09-07 21:55:23 +00:00
Steven Wittens cdff29b0ab Book.module: <top-level> item didn't show up in parent selector. 2004-08-24 03:22:26 +00:00
Dries Buytaert cb3a404b75 - Patch #9942 by JonBob: fixed a typo: 'form' -> 'from'. 2004-08-21 16:53:49 +00:00
Dries Buytaert 6b116794d9 - Patch #10084: added 'edit own book page' permission: this makes the book
module consistent with the other node modules.
2004-08-21 15:37:01 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert db548f7579 - Bugfix, spotted by Gerhard: editing a book page did not update the author. 2004-08-18 20:46:28 +00:00
Dries Buytaert 83a739bd89 - Code improvements by Stefan: made all status messages consistent (and easier to translate). 2004-08-18 19:57:27 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Dries Buytaert 4545f798a9 - Patch #10103 by Gerhard: book module cleanup. 2004-08-16 17:54:24 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Steven Wittens 9c1ccbbf54 Getting rid of parameters which were never passed. 2004-08-10 14:32:09 +00:00
Steven Wittens 50717513c2 - Left-over debug statement 2004-08-10 14:16:46 +00:00
Steven Wittens af0be96a62 - #4266: When editing a book page, hide the page and its children from the "Parent" selector to prevent circular relationships in the book hierarchy. 2004-08-10 14:16:01 +00:00
Dries Buytaert c6b1eaa20d - Patch #9775 by TDobes: consistency operation. Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view". 2004-08-05 05:40:53 +00:00
Dries Buytaert f97c3367b0 - Patch #9649 by JonBob: fixed a buglet in the recent book patch. It tried
to set book breadcrumbs for nodes that weren't books.
2004-07-31 16:23:01 +00:00
Dries Buytaert 202eee42a9 - Patch #9543 by JonBob: added node-level access control! 2004-07-31 09:30:09 +00:00
Dries Buytaert aed1b0ca9e - Patch #5347 by JonBob:
Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:

Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.

Advantages of this refactoring:
- I can use it for book.module to remove the extra viewing path.
- The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
- We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
- The attachment.module people could use it to append their attachments in a list after the node.
- Gabor could use it instead of his filter perversion for his "articles in a series" module.
- A little less code in each view hook.
- The content hook is no longer needed, so that means even less code.

Disadvantages:
- Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
- Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).

Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
2004-07-30 13:37:26 +00:00
Dries Buytaert d8d524ffef - Patch #4269 and #4248 by Killes: added missing t()'s to book module. 2004-07-25 14:22:16 +00:00
Dries Buytaert 1c52b145ba - Patch #8080 by TDobes: added teaser support to the book and page module. 2004-07-13 21:52:35 +00:00
Dries Buytaert 898bdeffaf - Marked required fields on the node (story, book, page, blog) and comment
forms using the $required argument of the form_ functions.

- Replaced all Optional's and Required's from the taxonomy forms with proper
  use of the form_ functions.

Please check your contributed modules too!
2004-07-08 15:24:30 +00:00
Dries Buytaert 7bb88809b7 - Patch #9049 by JonBob: fixed a number of tab issues. 2004-07-06 07:33:59 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert 090743bdba - Patch #8670 by asimmonds: more spelling fixes. 2004-06-21 20:05:37 +00:00
Dries Buytaert ad3c6f345e - Patch #8681 by asimmonds: more help text updates 2004-06-21 08:26:20 +00:00
Dries Buytaert c2d7419f23 - Patch #8681 by stefan: fixed some broken URLs and help texts. 2004-06-20 19:49:14 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Kjartan Mannes be59d6a674 - Fixing bug 5845: Root page of book module does use <--break-->. 2004-06-03 11:19:38 +00:00
Dries Buytaert c0b85a5721 - Patch #4950 by Stefan (and Morbus): made watchdog messages translatable. 2004-06-02 19:01:40 +00:00
Dries Buytaert e52c0f5d41 - Code improvements by JonBob. Thanks. 2004-05-17 22:00:06 +00:00
Dries Buytaert a158eca1b0 - Patch #7577 by JonBob: code improvements to the book, forum, page and poll module. 2004-05-09 19:28:43 +00:00
Dries Buytaert 284ed5e4a3 - Patch #7211: changed 'root' to 'top-level' for sake of usability. I took Gerhard's patch and extended it so we did not miss any instances of 'root'. 2004-04-24 16:31:54 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert 142dd6ba43 Patch #5588 by bylund: XHTML improvements: <i> -> <em> and <b> -> <strong>. 2004-03-20 13:29:06 +00:00
Dries Buytaert 4b0b2d02ee - Patch by Steven: removed redundant permission checks. These are no longer
required thanks to the new 404 handling.
2004-02-15 20:09:46 +00:00
Dries Buytaert 02c622dea1 - Patch 4332 by Goba: eliminate compose tips module. 2004-01-27 22:10:47 +00:00
Dries Buytaert 1687dd07c9 - Patch 5049 by JonBob: allow a module to define multiple node types. 2004-01-27 18:47:07 +00:00
Dries Buytaert b85eb11e11 Patch 5287 by Stefan: multiline help texts should become inside a single $output. 2004-01-23 18:42:43 +00:00
Dries Buytaert 24e76c0d6c - Code beautifications: corrected indentation. 2004-01-17 23:34:11 +00:00
Dries Buytaert 860a5cc388 - Removed the $help parameter from the _form hook. The help, typically
submission guidelines, should be emmitted using the _help hook.
2004-01-17 09:07:00 +00:00
Dries Buytaert 36c0e4d745 - Bugfix: display the correct author. Patch by Nick. 2004-01-15 19:12:14 +00:00
Dries Buytaert 6fc8d944d8 - Small bugfix 2004-01-15 09:10:16 +00:00
Dries Buytaert 01e9b5a0f0 - Fixed 5218: book page "administer" removes original author. 2004-01-14 22:17:45 +00:00
Dries Buytaert 59925ef983 - Usability improvement: added a book navigation block. 2004-01-14 19:26:41 +00:00
Dries Buytaert a8b8c247db - Patch #5021: clean up URLs in _help texts. Patch by UnConeD. 2004-01-11 20:31:26 +00:00
Dries Buytaert 5ac59aacd2 - Applied patch #4949: node_prepare() wastes resources. Patch by Goba. 2004-01-11 20:16:26 +00:00
Dries Buytaert a9ef18266e - Patch 4916: improved preparation of $node->teaser and $node->body. Patch by
Goba.
2004-01-02 16:30:09 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert 4e2c0b250e - Introduced a drupal_set_message() and drupal_get_message() function.
Contributed themes and modules need to be updated:
   - modules: status() is no more; use drupal_set_message() instead.
   - themes: use drupal_get_message() to check for status messages and
     visualize them.
2003-12-01 13:45:33 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 875c6e3f77 - Performance improvement: avoid copying/cloning arrays. Patch #155 by anarcat. 2003-11-23 12:13:08 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 4bdac4333b - Patch by JonBob:
Phase 2 of the menu system integration project. This unifies the interface
  used by admin and non-admin pages, and deprecates the _page hook in favor of
  explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
  as a result of this patch; they will return in the phase 3 patch, printed
  by the theme.
2003-11-20 21:51:23 +00:00
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert 92995414b4 - Committed stage 1 of the menu callbacks improvements. Patch by Jonathan. 2003-11-08 09:56:22 +00:00
Dries Buytaert ef0fa006ed - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.
2003-11-07 19:03:35 +00:00
Dries Buytaert eb95d6d7fc - Bugfix: fixed typo in cloud module. Patch by Marky.
- Bugfix: fixed menu glitch in book module.  Patch by Kjartan.
2003-11-03 08:59:39 +00:00
Dries Buytaert 8806f4c564 - Bugfix: fixed problem with book outlines. Reported by Mark Cheverton. 2003-10-23 12:13:51 +00:00
Dries Buytaert d5920c6278 - Bugfix: fixed book module links. Fixed bug #3621. Patch #132 by eafarris. 2003-10-21 16:11:12 +00:00
Dries Buytaert e688dfe6db - Fixed prefix problem with the book module. Patch by Moshe.
- Usability improvements to the user module: removed some redundant menu
  items by taking advantage of the column sorting, added status messages
  and so on.  Patch by Moshe plus some fixes.

- Made the profile module use the table() function.  Patch by Moshe.

- Fixed breadcrumb spacing.  Patch by Moshe.

- Fixed colspan problem with node overview table.  Patch by Stefan.

- Fixed inconsistency with table sorting.  Patch 0122 by Al.
2003-10-13 19:18:39 +00:00
Dries Buytaert c65d1da880 - Fixed some link titles that were no longer correct due to the menu
changes.

- Fixed some broken links.
2003-10-09 21:51:57 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Dries Buytaert 9632b0b00f - Fixed book preview problem. Patch by Kjartan. 2003-10-06 08:53:17 +00:00
Dries Buytaert 058971c33b - Help improvements and translation improvements from Michael. Thanks! 2003-10-03 14:55:27 +00:00
Dries Buytaert a4c84bbe3d - Bugfix: made printer-friendly pages work. They were rendered but never
printed.
2003-10-02 17:58:47 +00:00
Dries Buytaert 32e8d77cd6 - Associate a callback with the menu links! (This callback is not yet being
called but will be as soon the remaining links have been transformed to use
  the menu system.)

- Made sure the menu does not render links with no callback and no children.
  Like this, the 'create content' link is not being shown when the user has
  no permission to add any content.
2003-09-28 17:53:04 +00:00
Dries Buytaert 069e1bb87b - More translation fixes for the menu items. Patch by Gabor. 2003-09-28 17:07:46 +00:00
Dries Buytaert 2fe79310df - Rewrote the most of the menu system; this fixes Al's problem with the
"create content" link.

- Manually merged the user module's new menu items.  Al's patch did not
  apply.

- Added some missing t()s.
2003-09-28 10:51:40 +00:00
Dries Buytaert fe09d5a786 - Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
     menu.
  2) The user module part of the patch did not apply due to Kjartan's earlier
     patch.
2003-09-27 06:00:43 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 00a62647bc - Committed Nick's _content improvements. 2003-09-20 15:11:41 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert 93e6513ebc - Fixed typo. Patch by Nick. 2003-09-16 10:38:34 +00:00
Dries Buytaert d9cb4522bd - Book module improvements. This commit changes the behavior of the "view"
hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.
2003-09-15 15:58:20 +00:00
Dries Buytaert d81f159c63 - Committed Nick's path improvements; you can now control the look and feel
of the breadcrumb navigation.
2003-09-11 17:53:45 +00:00
Dries Buytaert c485b54555 - Fixed a number of small user experience inconsistencies pointed out by
Keith.
2003-08-23 10:11:10 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 5c40037c8e 1) Bugfix: changed INNER JOIN to LEFT JOIN to make forum topics with no comments show on the topic overview page.
2) Beautified the forum module views; rewritten to use the table() rendering functions, X HTML-ified the emitted code, added additional CSS tags, and removed hard-coded markup.  This improves themeabality; it should be able to mimic the view and color scheme of, say, http://www.phpbb.com/.

3) Reorganized forms and links (interactive elements) to improve usability.  Also ensured that the link names and page titles match.

4) Temporary removed container functionality: this simplified the work and eliminated some usability issues.
2003-08-15 15:17:23 +00:00
Dries Buytaert c25bc33181 - Usability improvements based on Keith Instone's suggestions:
* Removed 'handbook' title.

   * Added a 'books' link to the book location bar: the link takes you to
     the book overview page.

   * Renamed a few 'collaborative books' to 'books' so that the links and
     page/box titles match.
2003-08-13 07:24:14 +00:00
Dries Buytaert 4131b785f7 - Help system improvements from Michael. 2003-08-05 18:33:39 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert cd150ba731 - Improvement: made it easier to translate the book outline. Patch #67 by
Stefan.
2003-07-08 09:48:29 +00:00
Dries Buytaert dc15ba06e0 - Improvement: don't perform XSS checks for trusted users. Trusted users
are those that have the "bypass input data check" permission set.  Should
  address bug #2147.

- Improvement: simplified index.php and modules/admin.module.

- Bugfix: fixed broken links in bloggerapi documentation.  Patch by Chris
  Johnson.  Fixes bug #2030.

- Bugfix: fixed the date shown on a book module preview.  Reported as part
  of bug #2097.

- Bugfix: fixed broken URL in the book module documentation.
2003-07-01 17:54:22 +00:00
Dries Buytaert 828ba66500 - Bugfix: fixed utf-8 problem for people that use PHP 4.2.x or below. Patch #33 by Al.
- Bugfix: fixed translation problems in the user module and the block module.  Patch by Stefan.

- Improvement: made it impossible to delete user role #1 and #2.  Patch #38 by Al.

- Improvement: fixed the "Allowed HTML tag" issues.  Makes for better code and improved usability.  Patch #35 by Al.

  NOTE: as soon the compose tips make their way into CVS, most of this code can be removed.
2003-06-19 17:26:27 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert 1a2576036b - Bugfix: charset fixes/clean-up. Patch #52 by Al.
- Improvement: renamed some theme functions of the forum module for sake of consistency/readability.  Patch #2 by Kristjan.

- Improvement: usability improvements to the Xtemplate theme.  Patch #3 by Kristjan.

- Improvement: CSS'ified the book module pages.  Patch #3 by Al.  (I simplified the "l
ocation" part.  Al's approach gave you a bit more power but I'm not sure anyone wants
to change that.  Besides, this will change as soon we integrate the menu system so I kept it easy for now.)
2003-06-12 17:24:06 +00:00
Steven Wittens e1adc0f780 Fixed some typoes... 2003-06-08 01:19:37 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert 7e8aa5268b - Fixed bug in book_prev(). Patch by Andy Colson.
- Book optimizations: updated to use inner joins.  Patch by Andy Colson.
  This should address bug #1373.

  TODO: add index to MSSQL database scheme.
2003-05-18 16:43:56 +00:00
Dries Buytaert 460b902d70 - Added a couple of checks to avoid pg_atoi problems using PostgreSQL.
Reported by Michael Frankowski.
2003-05-13 21:34:39 +00:00
Dries Buytaert bf300292da - Made the teaser work for HTML book pages. Patch by Nick. 2003-05-13 20:17:14 +00:00
Dries Buytaert 0215c5032f - The book_admin_orphan() function is using the table() function to render
the orphan pages.  Patch by Nick.

- The "printer-friendly link" is only shown when the book page is not on
  the main page.  Patch by Nick.
2003-05-13 19:05:02 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert e6cf829ece - Bugfix: show the 'printer-friendly version' link for everybody not just for
people with the update book permission.  Patch by Nick Berendsen.
2003-04-21 07:29:26 +00:00
Dries Buytaert bbab043785 - Made book_tree_recurse() emit code that validates as XHTML. Patch by Nick
Berendsen.
2003-04-14 21:03:59 +00:00
Dries Buytaert cb2d27c78d - Patch by Ax. Fixed some syntax errors:
-    case t("whatever");
    +    case t("whatever"):
2003-04-04 06:17:02 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert df75067205 Patch by Ax:
- the index link ("View this book's table of contents.") which pointed
to http://drupal/book instead of to ... this book's table of contents.
- it doesn't print "previous", "next", "up", "index" if there are no
"previous", "next", "up", "index"
- it doesn't print "index" if "up" /is/ the "index"
- it swaps the order of "up" and "index", ie. "up" is in the row above
"index", between "previous" and "next" now. this is more logical and the
way all tree-browsing apps (python doc, info, ...) do it.
2003-03-13 20:09:47 +00:00
Dries Buytaert 1a647c573b - Committed Ax' book patch to "fix" the "next/prev" navigation. 2003-03-10 20:18:38 +00:00
Kjartan Mannes c2866848d1 - Removing some trailing whitespace I forgot to clean up. 2003-03-09 10:19:16 +00:00
Kjartan Mannes 831ee21303 - Renamed "form.admin" to "form admin".
- Added node_admin_settings() to let users set node defaults.
    * Added _nodeapi("conf")
- Modified form_checkbox() to unset options. (Modified the patch from Ax.)
- Removed the _save() hook.
- Fixed a logical flaw in field_get() and field_set() which would break
  moderation.
- Moved some admin menus around and cleaned up some typos.
2003-03-07 22:11:44 +00:00
Dries Buytaert 55a449f972 - This commit fixes URLs, and makes the "edit book outline" link at the bottom
of an "/admin/node/edit/n" page work properly.  Patch by Al.
2003-03-02 20:50:40 +00:00
Dries Buytaert 8ae2520965 - Removed stripslashes(). See http://lists.drupal.org/pipermail/drupal-devel/2003-February/022233.html. Patch by Ax. 2003-02-26 22:02:46 +00:00
Dries Buytaert 277ceae515 - New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
    * glossary module
    * feed module (Breyten's version)
    * mailhandler module
    * notify module
    * project module
    * smileys module
    * admin module
    * style module
    * taxonomy_dhtml module

  To avoid unexpected problems menu_add() is deprecated (it will print an
  error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Dries Buytaert 37fe442d89 - Moved the filter()s back to the individual node modules as it used to be. 2003-01-23 18:11:19 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert 97f4bdb945 - Made sure all table headers could be translated.
- Made the book module use the new table rendering function.
2003-01-12 09:57:20 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert 5a3d3bfb22 - Fixed rendering bug in book module. Reported by vmole at
http://drupal.org/node.php?id=923.
2002-12-22 11:25:50 +00:00
Dries Buytaert 259f17c573 - Bugfix: printer-friendly book pages were not being displayed in the proper
order.
2002-12-22 11:06:33 +00:00
Dries Buytaert 7ce686c152 o Permission improvements:
+ Removed the "post content" permission and replaced it by more fine-grained permissions such as "maintain static pages", "maintain personal blog", "maintain stories", etc.

o Usability improvements to teasers:

   + Teaser forms are no more.  Teasers are extracted automatically but can also be instructed using a delimiter "---".  Furthermore, when a post it too short for a teaser, the user won't be bother with teaser stuff anymore.

   + Added an option to set the teaser length, or to disable teasers all together.

   + When previewing a post, both the short (if any) and the full version of a post are shown.  This addresses a common complaint; for example, when writing a book page there was no way you could preview the short version of your post.

   + Forum posts can be teasered now.  This is particularly helpful in the context of drupal.org where we promote forum topics.

o Bugfix: replaced all PHP short tags (<?) with long tags (<?php).

o Bugfix: removed hard-coded dependence on comment module.

o Bugfix: when the queue module was disabled, it was not possible to approve updated book pages.

o Bugfix: applied modified version of Marco's node_teaser() fix.
2002-12-10 20:35:20 +00:00
Dries Buytaert 5b39f6767e * Applied slightly modified version of Marco's taxonomy patch:
- Fixed a bug with get_tree and multiple parents.
 - Fixed 3 wrong caches (this will avoid some queries).
 - Extension to taxonomy_term_count_nodes() (feature #159): "currently
   calling taxonomy_term_count_nodes() returns the amount of nodes in each
   term, would it be possible to extend this function so that it would only
   return the amount of nodes of a certain type under each term.
 - Confirm deleting a vocabulary or a term (requested by Moshe).
 - Use form_weight() in vocabulary and term forms.
 - After submitting a term, we end up at the term page (requested by Moshe).
 - Added status messages when adding, editing and deleting vocabularies and
   terms
 - Minor clean ups

* Made sure all modules use the same link delimiter; "|" for now.
2002-12-02 19:14:41 +00:00
Dries Buytaert 5c0558b503 - Applied Natrak's "create PHP content" patch. 2002-11-18 22:19:17 +00:00
Dries Buytaert 9a352343b2 - Made "<root>" translatable. Patch by Stefan. 2002-11-15 18:58:34 +00:00
Dries Buytaert cc7a6b5017 - Some improvements to streamline book maintanance: weights and titles can
now be changed on the book overview page in the admin page.  Editing the
  "Drupal handbook" (100+ pages?) on drupal.org became a time-consuming
  process, hence these improvements ...
2002-11-10 10:36:22 +00:00
Dries Buytaert 29adfb4086 - Added printer-friendly links to the book pages. 2002-11-09 13:43:56 +00:00
Dries Buytaert aa28ec5230 - Applied db_query() fix. Thanks Gerhard and Marco. 2002-10-30 08:02:52 +00:00
Kjartan Mannes c65cfcabb5 - sort books by weight, then title in book_render(). 2002-10-24 15:39:24 +00:00
Dries Buytaert 300e524368 - Updated the book module documentation a bit. 2002-06-09 14:02:35 +00:00
Kjartan Mannes 4a28077f46 - adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
    * security check isn't in effect if the db hasn't been updated.
    * instructions re-organized.
    * fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
2002-06-01 21:57:29 +00:00
Kjartan Mannes 66e1bbfb93 - pending user accounts will not be notified to the site_email.
- fixed access checks on the register form, do this before you enter the
  _save function. If registrations are disabled the register link will
  no longer show (again).
- changed &#187 to &raquo, using the names of entities are better than
  the numbers.
- fixed user information being set when account is registered (properly this
  time, really!)
- reversed the if(!...) commit.
- node_add specifies more defaults.
- added link to blog entries from user page.
2002-05-23 14:14:48 +00:00
Kjartan Mannes 5f6d733b70 - node security fixes.
- fixing the UI to represent what actually happens when you are an admin.
2002-05-22 23:28:48 +00:00
Kjartan Mannes c9871b7814 - updating all nodes to use taxonomy terms.
- updated node modules not to cause errors when taxonomy module is disabled.
- added %date variable to user mail configuration.
- added hyperlinks to admin.php?mod=system (site configuration) for easy access.
- usual coding style and xhtml fixes.
2002-05-19 23:05:05 +00:00
Kjartan Mannes 741a0cc594 - fixing a parse error. 2002-05-13 22:07:26 +00:00
Kjartan Mannes cb2345e9c3 - and I missed one of those l() calls. These things are tricky :) 2002-05-12 18:22:37 +00:00
Kjartan Mannes 17d283799e - messed up the parameters. 2002-05-12 18:20:59 +00:00
Kjartan Mannes b86e23216e - fixed some nav links. 2002-05-12 18:16:50 +00:00
Kjartan Mannes f86a944979 - applied Stevens link patch.
- fixed block permissions.
- fixed user admin page errors: http://www.drupal.org/node.php?id=173.
- cleaned up common.inc a bit: removed format_info, path_img, field_merge.
2002-05-12 15:40:57 +00:00
Kjartan Mannes 69ec1a6996 - making sure the nodes call filter(). 2002-05-04 18:56:43 +00:00
Kjartan Mannes de5b9a168d - bug fixes:
* fixed mails not being parsed properly.
    * tracker now shows user name when you view your own recent
      comments.
    * link to submission queue now points to the right place.
    * fixed jabber module.
    * theme is now activated when changed.
- applied Gerhards coding style patch.
2002-04-22 09:05:36 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Kjartan Mannes 1b573fb0ba - book log is now saved and shown when necessary.
- fixed poll title not showing up.
2002-04-17 10:15:13 +00:00
Kjartan Mannes 5592761620 This is a major change to the system, needs more testing!
Committing Changes by Moshe Weitzman:
- admin_user_account(), user_edit(), and user_view() no longer have any
  hard code for authentication modules. instead authentication modules
  implement the _user hook.
- fixed a couple 'help' typos.
- linked the 'REGISTER' text in the login block to the register page.
  this page now advertises DA better if site employs DA.
- admins may now edit everything about a user account (was a feature
  request).
- user #1 may now login immediately, in addition to receiving his
  password via email.

Other changes:
- modules and themes are now enabled/disabled in the administrative /
  settings / modules | themes pages. Requires SQL update and things must
  be enabled before your site returns to normal. TODO: enable all
  functionality. (For now just do UPDATE system SET status = 1;)
- removed $themes from conf.php.
- added a $theme->system() function where theme can specify settings.
  All themes in the Drupal CVS have been updated to use this.
- added _system hook to modules. TODO: update modules to use this.
- changed strange use of sprintf to the usual strtr. The disadvantage of
  sprintf is that it requires translations to keep the string order,
  which may not be possible in all languages.
- an invalid/nonexisting theme in a user profile will now fallback to the
  BaseTheme instead of crashing.
2002-04-14 19:34:04 +00:00
Kjartan Mannes 1e4308a939 - made the user information block into two different blocks. One for
login and one for user information.
- added link to help in book module (post-patch, see below).
- applied various patches:
  Patch by Greg Tyrelle <greg@tyrelle.net>
  - tracker module now shows usernames next to comments.

  Patch by Moshe Weitzman <moshe@wallaware.com>
  - book module has a more complete help.
  - added administrative link to export book to html
  - fixed non book nodes not showing up in trees.

  Patch by moshe weitzman <weitzman@tejasa.com>
  - links can be defined in the configuration file.
2002-04-02 09:45:57 +00:00
Dries Buytaert 1e8c9d8192 - Included documentation contributed by Moshe. 2002-03-26 21:33:45 +00:00
Kjartan Mannes 2410cf51c8 - changed the access on the menu.create link to post content.
http://www.drupal.org/node.php?id=91
2002-02-28 10:52:23 +00:00
Dries Buytaert c1c612b128 - Made the calendar module accept a $date parameter such that you
can jump directly to a certain date in the archives.  Also made
  the calendar link to itself such that it is self-contained.

- Code beautifications: quoted a lot of arrays, removed dead code
  and simplified a few things.

- Replaced the Calendar class by one function "calendar_display":
  using a class (or class instance, or object) doesn't make sense
  in the archives' case.

- Renamed "calendar.module" to "archive.module".

- Fixed a /problem/ with node settings not always being saved like
  expected.

- Reorganized the user menu: renamed a couple of links for clarity
  and structure.

- Fixed a few typos.
2002-01-31 20:23:44 +00:00
Dries Buytaert 47daf7f006 - Added some more explanations. 2002-01-12 12:51:21 +00:00
Dries Buytaert c71e133958 - Added about 50 title tags. 2002-01-07 22:08:52 +00:00
Dries Buytaert 71da8e0a8c - Fixed a small glitch in book_tree() 2002-01-01 11:26:29 +00:00
Dries Buytaert a95c2a68aa - import.module:
+ Improved input filtering; this should make the news items look
      more consistent in terms of mark-up.

    + Quoted all array indices: converted all instances of $foo[bar]
      to $foo["bar"].  Made various other changes to make the import
      module compliant with the coding style.

- theme.inc:

    + Fixed small XHTML glitch

- comment system:

    + Made it possible for users to edit their comments (when certain
      criteria are matched).

    + Renamed the SQL table field "lid" to "nid" and updated the code
      to reflect this change: this is a rather /annoying/ change that
      has been asked for a few times.  It will impact the contributed
      BBS/forum modules and requires a tiny SQL update:

        sql> ALTER TABLE comments CHANGE lid nid int(10) NOT NULL;

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

    + Added a delete button to the comment admin form and made it so
      that Drupal prompts for confirmation prior to deleting a comment
      from the database.  This behavior is similar to that of deleting
      nodes.

    + Disabled comment moderation for now.

    + Some of the above changes will make it easier to integrate the
      upcomcing mail-to-web and web-to-mail gateways.  They are part
      of a bigger plan.  ;)

- node system:

    + Made it so that updating nodes (like for instance updating blog
      entries) won't trigger the submission rate throttle.

    + Fixed a small glitch where a node's title wasn't always passed
      to the $theme->header() function.

    + Made "node_array()" and "node_object()" more generic and named
      them "object2array()" and "array2object()".

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

- misc:

    + Applied three patches by Foxen.  One to improve performance of
      the book module, and two other patches to fix small glitches in
      common.inc.  Thanks Foxen!
2001-12-30 16:16:38 +00:00
Dries Buytaert 4e25543a3d - "fixed" the code's indentation. 2001-12-27 15:20:20 +00:00
Dries Buytaert 267044f0b3 - Back-ported Foxen/Revar's improved book_toc() function. 2001-12-17 19:45:47 +00:00
Dries Buytaert bf810154f6 - Added a "queue for moderation"-toggle to a node's admin form and
updated the node modules to support this.
2001-12-09 15:15:10 +00:00
Dries Buytaert 7a972daeab - node system:
+ made a small change in the node overview page in the admin section
     such that it lists both new and updated pages by default.

   + reworked the filter-mechanism: it is not 100% finished yet but it
     sure is taking shape.
2001-12-08 13:11:33 +00:00
Dries Buytaert 7962b6cc90 - Fixed small form glitches. 2001-12-08 11:41:35 +00:00
Dries Buytaert 20b4b7166f - book.module:
+ Added (1) support for "PHP pages" (dynamic pages), and (2) made
     it possible to link other node types into the book's tree/outline.
     It works just fine, yet the only (obvious) downside of (2) is
     that the navigation tree/links gets "interrupted" when you view
     non-book pages in the book.
       [SQL update required, see update.php]

   + Tidied up the book table.
       [SQL update required, see update.php]

- various updates:
    + Fine-tuned the new node system.
    + Updated the inline/code documentation.
    + Improved teaser handling of all node types.
    + Made several small usability improvements to the node admin
      pages.
2001-12-06 17:33:05 +00:00
Dries Buytaert 9cb3430e8b - Added "add new comment"-link (derived from a patch by Axel) 2001-12-02 21:11:18 +00:00
Dries Buytaert 53e128807a - Added "add new comment"-link (derived from a patch by Axel) 2001-12-02 21:05:31 +00:00
Dries Buytaert d852a999de Node and book updates:
- Fixed a glitch in the book overview in the admin section.
  - When updating a book page through the admin section, no new revision
    is created unless explictely specified.
  - Improved the usability of the node and book pages a little.
2001-12-01 15:20:48 +00:00
Kjartan Mannes 7d0c316f82 - fixed pass by reference errors. PHP only allows declaration of &$vars, not
passing them that way.
  For more info: http://no.php.net/manual/en/language.references.pass.php
2001-11-26 18:27:34 +00:00
Dries Buytaert 3c90763607 - Fixed a bug in node_submit() in that the user name was not always
correctly updated.
2001-11-25 15:58:08 +00:00
Dries Buytaert 297a5b017f - Improvement/bugfix: added a function called "book_revision_load()" to
load the most recent revision that matches the specified conditions.
  Like that we can load the last good revision of a book page using the
  line: book_revision_load($page, array("moderate" => 0, "status" => 1)).
2001-11-25 09:55:00 +00:00
Kjartan Mannes 17f19582f7 - fixed new book pages in the queue showing up in the collaborative book. 2001-11-24 15:50:18 +00:00
Dries Buytaert eb7c5f60b9 - Bugfix: when updating a book page, the name of the author did not change.
- Bugfix: the "Edit comments" part of the node administration pages did not
  display the correct comments.

- Bugfix: somethimes, update in a book page would mess up the book.

- Improvement: when "node administrators" update a book page through the
  "update this book page"-link (like regular users do), their update will
  be subject to moderation.

- Improvement: made some intermediate changes to the filter mechanism. Needs
  more work.
2001-11-24 15:10:36 +00:00
Dries Buytaert 0222ee6666 - book.module:
+ Re-introduced and re-wrote the book admin pages; there is a separate
     page for every book and a page with all "orphan pages" (= pages that
     got de-linked).
2001-11-18 12:30:08 +00:00
Dries Buytaert ebb14ab94a - A couple of new node updates 2001-11-12 22:17:52 +00:00
Dries Buytaert b29af16bf5 - updated the "update help"-text 2001-11-11 23:23:41 +00:00
Dries Buytaert 234b40b253 - node system:
+ Added the "delete node"-link: apparently it got lost during the last
     commit.  Odd.

   + Changed "Edit node" to "Edit <node_name>" on the 'edit node'-page of
     the admin section.  (There a 4 "Node"s that still need to be removed
     though.)

   + Updated the initial submission page (the old submit.php) to include
     some descriptions.
2001-11-07 18:14:46 +00:00