5e771fa917
#171461 by chx, ejhildreth and dvessel: empty tbody fails validation
2007-10-04 17:53:56 +00:00
f1023e6492
#177421 by malex, Desbeers and chx: proper value of mission statement variable for themes
2007-09-25 12:43:18 +00:00
e270cd093b
#176084 by Stefan Nantegaal and dvessel: fix notices in theme.inc, when specific sidebars are not set
2007-09-17 11:11:57 +00:00
6da81e1f3f
#171951 by dvessel: fix account specific theme selection form
2007-09-17 08:06:52 +00:00
af48df1ca5
#166681 by dvessel: fix behavior of theme 'override preprocess functions'
2007-09-10 13:28:22 +00:00
67e5859a7f
#172376 by ChrisKennedy: fix 8 E_ALL issues in comment module and fix approval queue
2007-09-06 12:21:39 +00:00
2db2c039fb
- Patch #172950 by webernet: code style fixes.
2007-09-04 21:10:45 +00:00
f7ee91227e
#160395 follow up patch by dvessel: fix array initialization
2007-09-01 11:32:07 +00:00
fb1948cbf7
- Patch #171652 by dvessel et al: cleanup some old cruft. Dvessel is on a patch spree ...
2007-09-01 05:42:49 +00:00
ff61e73a30
- Patch #160395 by dvessel and merlinofchaos: allow theme engine to register theme variable functions.
2007-09-01 05:35:15 +00:00
00181ecb39
- Removing whitespace.
2007-08-30 19:54:22 +00:00
40ac96eb94
#103391 follow up patch by bdragon: fix E_NOTICE by checking if href is set
2007-08-30 15:50:58 +00:00
327e1c2919
#165343 by merlinofchaos and dvessel: include path history in theme discovery suggestions, so we find subtheme files properly
2007-08-29 16:56:13 +00:00
ffdfe04858
#103391 by m3avrck, RobRoy and dvessel: cleanup active list item classes
2007-08-29 16:16:50 +00:00
43d73f81c9
#166071 by jjeff and dvessel: move default template preprocess code to template_preprocess, and add *lots* of documentation to template files and functions
2007-08-28 11:35:34 +00:00
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
f2ce877d43
- Patch #145218 by profix898, bennybobw, Crell, forngren et al: use href instead of @import for CSS.
2007-08-23 16:41:19 +00:00
6721bc580a
#166593 by hswong3i: move literal values out of some core queries to support cross-database compatibility (ie. better SQL parsing and altering options)
2007-08-22 08:36:34 +00:00
6eaaa3c1b3
#160168 by kkaefer and pwolanin: restore lost Drupal 5 functionality of being able to set primary and secondary links differently
2007-08-20 18:26:41 +00:00
37bafeaf5f
#168587 by jjeff: add rel=nofollow attribute to anonymous comment home page links to counter some spamming
2007-08-19 11:02:35 +00:00
0321a2e975
#164122 by merlinofchaos: properly convert underscored to dashes, when constructing template file names matching hook names
2007-08-16 13:59:41 +00:00
c70b19a91b
- Patch #163723 by Eaton and Frando: fix default page.tpl markup (and removed some whitespace).
2007-08-02 20:08:53 +00:00
71f1192f48
#159804 by myself: closure should be filled last, so we have a predictable place to collect queries and strings used on the page
2007-07-18 07:05:49 +00:00
435f3154f9
- Patch #141730 by Earl: allow theming system to use wildcards. I promised in the issue that this patch would still go in, so here goes.
2007-07-03 18:48:41 +00:00
ee701b3336
- Patch #155986 by Uwe: fixed typos.
2007-07-02 14:41:37 +00:00
5e5a07f513
#141725 by Crell and dvessel: allow themes to define multiple CSS and JS files in their .info files, which can be clearly overriden
2007-07-01 23:27:32 +00:00
3409019929
#146386 by kbahey: refactor 'submitted by user - date' themeing and make it more verbose to translate
2007-07-01 23:15:41 +00:00
2fe9f45846
- Patch #153535 by traxer: according to the XHTML1 Strict specification, it is not allowed to generate empty <tr></tr> tags.
2007-06-28 09:11:06 +00:00
57c9a13e1f
#118026 by kkaefer with fixes from myself: JavaScript translation support and script.js as a default theme JS file to use, if found
2007-06-08 12:51:59 +00:00
41542ef053
- Patch #101268 by webernet et al: improve the usability of feed icons.
2007-05-31 12:14:04 +00:00
d81bfb45a0
- Patch #137724 by JohnAlbin: empty favicon causes duplicate page requests.
2007-05-22 19:56:00 +00:00
e66371cac1
- Patch #137211 by merlinofchaos: move theme information to .info files and improved theme inheritance.
2007-05-06 05:47:52 +00:00
c740ac7fd5
#127539 : progressive operation support, refactoring update.php code to a generic batch API to support runnning operations in multiple HTTP requests
...
- update.php is already on the batch API
- node access rebuilding is in the works
- automatic locale importing is in the works
Thanks to Yves Chedemois (yched) for the good code quality, very wide awareness of issues related to batches,
and the fantastic turnaround times. Hats off.
2007-05-04 09:41:37 +00:00
ad67a17f8b
- Patch #130987 by alienbrain: fixed problem with theme registry patch.
2007-04-29 16:13:12 +00:00
29055d34d6
- Patch #137236 by merlinofchaos: provide a way to secure the theme variables system.
2007-04-27 07:42:54 +00:00
dbfcd7d137
- Patch #137415 by slantview: simplified the cache API/usages, and made it a tad smarter. Makes it easier to program for, and easier to replace. Will need to be documented.
2007-04-25 21:34:32 +00:00
03b4b58e9a
- Patch #132018 by Steven et al: add .info files to themes.
2007-04-17 07:19:39 +00:00
f4cbd7c63d
- Patch #118660 by agentrickard: re-order arguments of cache_set() to match PHP/Drupal conventions.
2007-04-15 15:36:10 +00:00
e675979091
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
2007-04-13 08:56:59 +00:00
96c3009178
- Patch #134697 by hunmonk: make table row coloring work in absence of numeric IDs.
2007-04-09 13:43:57 +00:00
b0676cf351
- Patch #134161 by chx: no menu tabs for themes.
2007-04-06 14:31:51 +00:00
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
ba0ff1a9b7
#117018 : Use Garland theme for installer/maintenance pages, and add task list in the sidebar.
...
- Refactor partial-page handling for the maintenance page. It's an exotic quirk for update.php and belongs there.
2007-03-02 09:40:27 +00:00
dc5843bd30
- Patch #111347 by Steven: refactor url() and l().
2007-02-15 11:40:19 +00:00
f996fd9568
- Patch #112605 by Steven: sticky table headers.
2007-02-06 08:35:13 +00:00
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
3b543c18f5
- Rollback of E_ALL patch. Too much extra breakage.
2007-01-25 22:14:06 +00:00
fd32b42196
- Patch #112715 by webchick et al: fixed some E_ALL errors.
2007-01-25 21:32:07 +00:00
fcbae4572c
#108310 : Minor speed up, cache theme functions in theme_get_function().
2007-01-11 03:36:06 +00:00
dfd86399c0
#106232 by chx. Add spaces for code style.
2007-01-02 05:05:38 +00:00
7d706a562d
#105726 by moshe weitzman. Remove necessity to hard-code theme engine directories since they can change.
2006-12-30 20:59:11 +00:00
b1c11d267f
#90738 by jjeff and ChrisKennedy. first and last are not mutually exclusive.
2006-12-29 08:18:28 +00:00
613b561668
#105303 by Gábor Hojtsy. Improve translation converage for installation.
2006-12-27 13:02:34 +00:00
57c5355a4b
#103280 : Fix styles for maintenance pages.
2006-12-15 01:06:33 +00:00
b9034559db
- Patch #93079 by chx: not able to select database.
2006-12-14 13:28:11 +00:00
b86f45b1e6
#100516 : CSS preprocessor to cache and compress all .css files. Benchmarks show up to 40% faster page loads.
2006-12-10 09:54:35 +00:00
b9d8f023a0
- Patch #101738 by webchick: phpdoc improvement.
2006-12-08 16:20:09 +00:00
213b0cd7a5
Proper checking for a variable existing.
2006-11-29 20:39:37 +00:00
36430b4c64
#87090 by kkaefer. Render blocks before page content so they may insert headers.
2006-11-29 06:36:12 +00:00
08d5e0f1c5
- Patch #50505 by chx and profix: path_to_theme() silently fails if init_theme() hasn't been called yett
2006-11-28 10:13:11 +00:00
69ea16f669
#84189 by webchick. Properly initialize variables.
2006-11-26 23:14:59 +00:00
d721a4f0d9
- Patch #98365 by webchick and RobRoy: added missing t() functions.
2006-11-24 09:01:57 +00:00
e66c520aa4
- Patch #93410 by bjaspan: theme_links() generated invalid XHTML in absence of links.
2006-11-21 19:41:57 +00:00
001d54f663
#84961 : Add 'select all' and range select feature to admin tables.
2006-11-21 08:16:39 +00:00
4f0f376430
- Rollback of #94058 : see issue.
2006-11-17 06:53:31 +00:00
761b0c7ffb
#94058 by hunmonk. Allow for multiple sortable tables on a page.
2006-11-17 01:03:59 +00:00
9321ee109d
- Patch #93536 by Gabor: eliminate remaining bluemarine traces from core code.
2006-11-08 19:24:11 +00:00
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
8306444494
- Patch #78399 by Eaton and chx: don't allow HTML in the title.
2006-10-18 18:00:40 +00:00
a13d829c33
#83853 by myself. Add whitespace between link list items.
2006-10-17 08:38:16 +00:00
fb97d9eca2
- Patch #58671 by Tobias: theme_closure -> theme('closure').
2006-09-05 10:11:29 +00:00
dd4f143df6
#75002 : Install-time and run-time requirements checking + status report page
2006-09-01 08:44:53 +00:00
e57fac565a
#65151 by m3avrck. theme_links() is now marked up as a list.
2006-08-30 07:37:14 +00:00
849a10fbba
Allow absolute urls for theme('image'), needed for user pictures to work properly.
2006-08-24 00:04:44 +00:00
a58d877108
#66569 by m3avrck. Put all the feed icons in the same place.
2006-08-23 05:55:38 +00:00
a8de1e92d7
- Patch #76637 by timnc: streamline JavaScript addition and add settings storage.
2006-08-22 09:00:31 +00:00
55eec8f66f
#79601 : module_exist() -> module_exists()
2006-08-20 05:57:41 +00:00
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
28f7908f8c
#2039 by Boris Mann ("My first diff to the list"), moshe weitzman, and David Lesieur, nested lists.
2006-08-17 06:55:26 +00:00
9709598a52
Fixing the CSS for theme maintainence and install pages.
2006-08-05 22:17:31 +00:00
3ffb612aea
#76741 : Allow <th> tags for theme_table cells
2006-08-03 20:37:52 +00:00
2c0571b894
- Patch #73961 by m3avrck, timcn, et al: simplify adding CSS in Drupal.
2006-08-03 07:06:36 +00:00
1c75a210bd
- Patch #68926 by chx, jeremy, steven, eaton, webchick, amazon, neil, nedjo et al: an initial install system for Drupal core.
2006-07-13 13:14:25 +00:00
e93f8be871
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
2006-07-05 11:45:51 +00:00
59aa2ae8e8
#71925 by Steven, remove # prefix from link array keys.
2006-07-04 08:59:05 +00:00
efb10dfd17
#52059 by Crell, allow attributes for items in theme_item_list().
2006-07-02 00:25:40 +00:00
13c32bab15
- Patch #71454 by moshe: removed redundant module_invoke. Committing from the Google campus.
2006-06-29 20:40:26 +00:00
963dc77bb7
#68170 by xtony and Heine, Use basename not pretty name in theme_get_settings().
2006-06-23 07:54:00 +00:00
168a3dcd8e
#63485 by fgm, theme_item_list should receive an attributes parameter
2006-05-20 01:24:30 +00:00
1b291a2917
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
2006-05-18 14:58:57 +00:00
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
6411e09dc9
#56508 by chx (modified), Remove notices from form.inc and move theme_form_element from theme.inc to form.inc.
2006-05-02 09:26:33 +00:00
130c1492c5
#61304 by fgm, use t() for a string.
2006-05-02 09:01:23 +00:00
d071f99172
- Removing trailing whitespace.
2006-04-17 20:48:26 +00:00
8b04c7f0db
#51002 : Admins could not see unpublished comments (plus minor usability enhancements for previewing/unpublished)
2006-04-15 04:07:18 +00:00
70aae83c8e
#58166 , fixes for typos, patch by Uwe Herrmann
2006-04-11 11:33:15 +00:00
9814b832b2
- Remove trailing whitespace
2006-04-07 10:40:55 +00:00
b3c245c08c
#57519 : Custom favicon did not use base_path()
2006-04-06 02:35:57 +00:00
6ab6b8abcd
#57333 : Only set logo image path if it exists
2006-04-04 23:31:04 +00:00
cb49e19e9e
#54003 , Watchdog not logging update errors, patch by Steven
2006-03-28 09:29:23 +00:00
16fd8c89a5
- sa-2006-002: XSS issues with username log and mission
2006-03-13 21:42:35 +00:00
6d9e5084d8
- Patch #52508 by TDobes: fixed theme system regressions.
2006-03-07 11:28:22 +00:00
15590cdc06
- #48036 : Don't show search box in theme if you have no search permission
2006-02-05 19:08:11 +00:00
048bec139e
- Patch #13148 by Morbus: less globals.
2006-02-02 12:44:57 +00:00
4ffb77baae
- Patch #13148 by Morbus: further base path fixes / clean-ups.
2006-01-30 21:32:09 +00:00
81660bc662
- Patch #13148 : fix problems with using relative path names! (Please document this change.)
2006-01-29 07:36:29 +00:00
55c88ae09c
- Added .
2006-01-20 09:30:12 +00:00
e38f0403a3
- Patch #45451 by wtanaka: added explanation for the red star.
2006-01-20 09:19:21 +00:00
56d0d76f0f
- Patch #27884 by gordon: js addLoadEvent not working.
2006-01-20 08:54:07 +00:00
5f829187e6
- Patch #45209 by markus et al: added some missing t() functions.
2006-01-18 19:40:18 +00:00
6048d282cc
- Modified patch #45214 by markus: don't generate empty breadcrumb div.
2006-01-18 19:02:34 +00:00
1d9b81d3b8
- Patch #44976 by m3avrck: cleaned up some CSS.
2006-01-16 20:57:53 +00:00
57447dc571
- Patch #42105 by chx / merlinofchaos: made form elements themable.
2006-01-10 19:37:27 +00:00
303720fb62
- Patch #15609 by m3avrck: get rid of forced <br />-tag after <label>-tags. Makes it easier to theme forms.
2006-01-06 07:32:54 +00:00
6c20d333d2
- Patch #35667 by Crell: bug fix: on ?q=admin/block style.css was imported twice.
2006-01-06 07:25:44 +00:00
9385794e23
- Patch #41548 by Neil: critical bugfix: theme didn't load when styles are used.
2006-01-04 09:32:28 +00:00
79a193a2d2
- #42234 : Use standardized feed icon for RSS
2005-12-29 04:46:40 +00:00
b362985de5
- Patch #41118 by Goba: various upgrade script fixes.
2005-12-26 17:20:23 +00:00
a19acb219e
- Patch #35924 by Neil: improved the update system.
2005-12-06 09:25:22 +00:00
5f36738a11
- Patch #38279 by paddy_deburca: fixed theme_item_list() not to generate an empty <ul></ul> tag when $items is empty.
2005-11-24 20:08:54 +00:00
ea53aad7c8
- Patch #22215 by Richard Archer: refactored primary and secondary links.
...
Deprecates the primary_links module.
This patch was much needed. Thanks Richards!
NOTE: if some themers could investigate if there is room for improvement
with regard to theming, that would be awesome.
2005-11-03 19:33:37 +00:00
f6764cfbd8
- Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.
2005-10-22 15:14:46 +00:00
8d460b406d
- Patch #32573 by Moshe: added support for ordered lists to theme_item_list().
2005-10-18 14:45:09 +00:00
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
cec8db72dd
- add some space
2005-09-29 08:02:55 +00:00
5971f1e645
- Patch #28777 by Neil: use <thead> and <tbody> in theme_table().
2005-09-15 20:58:17 +00:00
013b73e6ec
- Patch #30122 by m3verick: changed include_once()'s to include "./$file"
...
for performance's sake.
2005-09-08 19:19:01 +00:00
3b1e763d03
- Patch #30423 by Crell: added support for table <captions>.
...
TODO: look into http://drupal.org/node/28777 ?
2005-09-06 20:32:53 +00:00
c9fc300b1f
- Patch #29785 by Chx: multiple node types were broken so we refactored
...
part of the node system! If you have a module that implements node
types, you'll have to udpate its CVS HEAD version.
We replaced _node_name() and _node_types() by _node(). The new _node()
hook let's you define one or more node types, including their names.
The implementation of the _node() hook needs to:
return array($type1 => array('name' => $name1, 'base' => $base1),
$type2 => array('name' => $name2, 'base' => $base2));
where $type is the node type, $name is the human readable name of the type
and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.
For example, the story module's node hook looks like this:
function story_node() {
return array('story' => array('name' => t('story'), 'base' => 'story'));
}
The page module's node hook module like:
function page_node() {
return array('page' => array('name' => t('page'), 'base' => 'page'));
}
However, more complex node modules like the project module and the
flexinode module can use the 'base' parameter to specify a different base.
The project module implements two node types, proejcts and issues, so it
can do:
function project_node() {
return array(
array('project_project' => array('name' => t('project'), 'base' => 'project'),
array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
}
In the flexinode module's case there can only one base ...
This hook will simplify the CCK, and will make it easy (or easier) to merge
the story and page module.
In addition, node_list() became node_get_types(). In addition, we created
the following functions: node_get_name($type) and node_get_base($type).
2005-08-28 15:29:34 +00:00
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
1836d3b365
- Patch #29002 by Neil: list_themes() currently returns all themes, not just enabled themes. This functionality is only used in one place- configuration for disabled themes. These configuration pages can be removed with a usability improvement since you shouldn't be able to configure things which are disabled. Additionally, this allows us to remove some extra logic in system_user(). And it it more consistent with the module API which only lists enabled modules.
...
list_themes() sorts the results by name. This uses filesort in MySQL since there aren't any indexes. Sorting is not used except in system_user(). This one use can be handled with ksort since it is not often executed (only on the user edit screen when multiple themes are enabled).
And a one line fix to remove a variable in system_user() is in here too.
2005-08-18 22:07:14 +00:00
26fa7c730f
- Patch #16216 by nedjo: multiple block regions!
2005-08-16 18:06:18 +00:00
b69b43d1ec
- Patch #28482 by Uwe: add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s.
...
Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?).
2005-08-11 12:57:41 +00:00
8660655a9a
- #27981 : Add media parameter to theme_add_style
2005-08-05 00:22:03 +00:00
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
c81bbf4aa1
- #24673 : Fix deprecated usage of implode
2005-07-30 12:52:54 +00:00
3084036576
- #27231 : (fix) Pretty db error screens.
2005-07-29 07:49:43 +00:00
d9d4b9bdab
- #27231 : Friendly DB error screens.
2005-07-27 01:58:43 +00:00
ba1660168f
- Patch #27003 by Neil: use named constants instead of strings
2005-07-23 05:57:27 +00:00
db3a2cc175
- Patch #11927 by stefan/Robin: improved theming of tablesort icons.
2005-07-02 12:32:09 +00:00
5c8843704c
- Patch #18213 by chx: boostrap system. Modified to work with HEAD, tidied
...
up the documentation a little.
chx: can you double-check whether the global $conf variable is secure?
(That is, make sure it can't be send using the URL or something.)
2005-06-22 20:19:58 +00:00
eb536bf5ec
- Patch #24157 by chx/Robin/...: changed file_exists() to is_file() to fix several problems with modules using theimage toolkit.
2005-06-19 08:59:06 +00:00
abc16b1d6d
- Patch #25067 by Thox: renamed 'light' and 'dark' to 'odd' and 'even'.
...
TODO: update the "Migrating themes from Drupal 4.6 to Drupal HEAD"-page in
the Drupal handbook!
TODO: update the themes in the contributions repository.
2005-06-19 08:50:46 +00:00
a7af266b6d
- Patch #25143 by Robin: use count() instead of is_array() so we don't render code for empty arrays, and such you don't get warnings using PHP5.
2005-06-19 08:13:14 +00:00
a597354bcb
- Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags.
2005-05-31 21:14:27 +00:00
0250938e2b
- Patch #17028 by Ber: theme xml_icon should allow inline XML icons.
2005-05-26 19:08:14 +00:00
6be2c61896
- #20809 : User-configurable, per-theme, optional favicons.
2005-05-25 06:03:18 +00:00
a52bb9b1dd
- #23516 : Remove ][ from form item id's.
2005-05-25 03:50:25 +00:00
5154c3aca4
- Fixing some plain/url check calls.
2005-05-18 21:12:17 +00:00
03250bd3e3
- Patch #21397 by jjeff: fixed behavior of theme_image with regard to attributes.
2005-05-06 09:01:46 +00:00
2debcfb1ef
- Patch #15595 by Stefan and Djun: improved status messages.
...
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
2005-05-05 22:22:46 +00:00
6658273b36
- Patch #21855 by TDobes: the recent commit of phptemplate caused a number of problems for non-phptemplate themes. A patch is attached to address these issues.
...
Changes include:
* parsing of the primary/secondary links has been moved out of phptemplate and into theme_get_setting.
* unnecessary and XHTML-invalidating duplicate div#help removed from themes/bluemarine/page.tpl.php (this is already generated by theme_help)
* weird generation of the "edit primary/secondary links" messages removed from bluemarine and placed in theme.inc
* unnecessary changes to themes/bluemarine/style.css rolled back (the phptemplate bluemarine had an older version of style.css than the one in core)
* chameleon updated to work with new link scheme (passes links through theme_links)
2005-05-05 07:35:58 +00:00
e274f97c87
- Removed the Xtemplate engine and added the PHPTemplate engine.
...
- Converted the Bluemarine theme from XTemplate to PHPTemplate.
- Moved the the Pushbutton theme and the Xtemplate engine to the contributions repository.
2005-05-04 18:12:18 +00:00
a10eac3291
- Patch #21517 by Stefan and TDobes: theme system improvements.
2005-04-30 17:47:57 +00:00
79a5700c57
- Usability improvement: made the markers easier to understand.
2005-04-24 16:22:30 +00:00
495a03ae9d
- Patch #12794 by assimonds: make sure the node module is optional.
2005-04-13 17:59:39 +00:00
7bdcba1720
- Patch #19739 by Uwe: corrected many typo's in the documentation and code comments
2005-03-31 21:18:08 +00:00
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
99233a9c99
- Patch #19590 by Moshe: lazy initialization of the theme system. Improves
...
performance of pages that don't need the theme system (such as RSS feeds)
and makes it easier to set a custom theme.
2005-03-29 21:01:47 +00:00
97ae6568e6
- Patch #13738 by TDobes: theme system fixes:
...
* Fix a bug which would cause the "configure" link for styles to be broken.
* Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
* Correct an inaccurate comment in theme.inc
* Populate the default primary links with an "edit primary links" link for consistency with the secondary links
* remove some unnecessary variables in the theme administration which had misleading and confusing names
* replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
* usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
2005-03-16 19:41:12 +00:00
198ec98f75
#18329 : Unify confirmation messages (and make them themable)
2005-03-03 20:51:27 +00:00
59c2208ea6
- Patch #16253 by Goba: incremental improvements to the new content markers.
...
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
467dbdc4a1
- Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though.
2005-01-27 12:57:08 +00:00
2b17b3a966
- Patch #13907 by Neil: less ways to set the page title.
...
* Less logic in theme code.
* Encourages use of the menu system.
* Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
* Very slightly more efficient.
2004-12-15 21:19:42 +00:00
cc508ad2f0
- Patch 13738 by TDobes: there was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all).
2004-12-01 22:41:19 +00:00
4e4e2aa777
- Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly.
2004-11-24 22:50:25 +00:00
30110a8770
- Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
...
TODO:
1. Update theme upgrade instructions in the handbook: node_link() is gone.
2. Remove page_link() just like we removed node_link().
2004-11-23 23:11:59 +00:00
583e63c136
Theme system bug: only show search box if search.module is enabled.
2004-10-14 02:38:33 +00:00
9c9905d9a0
#10648 : Fix watchdog-related tablesort coloring bug in IE, add support for <tr> attributes to theme_table() and reduce specificy of watchdog coloring CSS rules.
2004-09-14 20:01:00 +00:00
b84b6e42cf
- Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
2004-09-09 05:51:08 +00:00
98a9d5ee2d
- #9576 : Patch by TDobes, only allow the user to choose between enabled themes.
2004-08-22 14:43:49 +00:00
6881cc9ad6
- Patch #10202 by Ax: don't emit an erroneous whitespace when no table headers are provided. Makes for clean XHTML.
2004-08-21 16:21:56 +00:00
03fa966c1f
- Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes.
2004-08-21 10:16:13 +00:00
9f2d6f0e51
- Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
...
- Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
- Fixing missing class on screenshots.
- Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().
2004-08-20 17:21:37 +00:00
81861a8e91
- Removing some DOS-style line endings. Thanks TDobes.
2004-08-20 09:34:53 +00:00
6ea5c56ded
- Theme system changes. Please consult http://drupal.org/node/view/9576 for details.
2004-08-20 07:51:27 +00:00
9cb5f7cdf8
Avatar/picture fixes:
...
- Changing theme('image') so the automatic image size fetching can be toggled independently from attributes. Specifying attributes and autosizing are 2 different things.
- Suppressing PHP errors from getimagesize() using @. drupal_set_message() is used to report these errors already and in a much prettier way.
- #9958 : Fixing broken displaying of avatars.
- Don't show the default avatar in 'edit my account' if the user has no avatar of his/her own.
- Added ability to delete avatars (without having to replace them).
2004-08-20 04:35:33 +00:00
d5e1e83e77
- Patch #9900 by Al: bugfix: don't display two <hr />'s.
2004-08-16 21:27:39 +00:00
f99830a498
- Patch by Al: improved the admin/help pages (first step).
2004-08-10 05:44:17 +00:00
9bbdb71ee4
- Patch #9330 : ucfirst() gives problem when used with multibyte charset.
...
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
c71bfded3d
- Patch #9657 : more intelligent theme() function. Hopefully, Adrian will be
...
able to use this patch too.
2004-08-04 20:40:01 +00:00
edc2f13d82
- #9287 : More doxygen/documentation fixes by JonBob
2004-07-22 16:06:54 +00:00
56fa37cb8e
- Made the example theme display status messages. Not sure why it wasn't.
2004-07-08 16:08:21 +00:00
5b73def39b
- Changed the way status messages are printed as per Kristjan's suggestion:
...
http://drupal.org/files/issues/error_messages_list.png (issue #9138 ).
drupal_set_message() has been changed to group message by type and a
helper function, theme_status_message(), is added to display the messages.
Chameleon and Xtemplate have been updated to use this new function.
- Updated CHANGELOG.txt.
2004-07-08 16:04:07 +00:00
9986cb36b5
- Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
2004-07-02 18:46:42 +00:00
090743bdba
- Patch #8670 by asimmonds: more spelling fixes.
2004-06-21 20:05:37 +00:00
b713e3d489
- Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
...
to get of proprietary formats).
- Added forum-sticky.png. Made by Steven.
2004-06-20 20:04:28 +00:00
54b77d6435
Tabs patch!
...
CHANGES
-------
+ Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
+ Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
+ Grouped settings. All settings have been grouped under 'administer > settings'.
TODO
----
+ Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help.
+ Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
cd48e69b29
- Patches #6863 by Kristjan and Moshe: implemented pretty tables and fixed some tablesort glitches.
2004-06-02 05:35:51 +00:00
7f08110a5e
- Improved form handling.
...
+ Introduced two new functions:
1. form_set_error($name, $message): files an error against the form
element with the specified $name.
2. form_has_errors(): returns true if errors has been filed against
form elements.
+ Updated the form handling:
1. The form_ functions will add 'class="error"' when a form field
has been found to be erroneous.
2. The error message is passed to theme_form_element() when the
particular form field has been found to be erroneous.
+ I updated the user and profile module to take advantage of these new
functions.
+ IMPORTANT: the _user() hook changed. The 'validate' case should no
longer retun an error message when something goes wrong but should
set it with form_set_error().
2004-05-31 09:40:56 +00:00
5cd371578e
- Patch #6863 by Moshe: add 'class="active"' to the table elements of
...
the active column.
2004-05-29 17:38:54 +00:00
01f08e86dd
- Patch #7966 by Goba: The box has it's content wrapped in a paragraph now, which is not suitable for the purposes the box is used in. Boxes are used to wrap tables or forms with titles. The comment module uses theme(box, ...) to wrap forms into boxes for example. Therefore using a paragraph does not make the output valid XHTML and a div is needed.
2004-05-24 05:10:32 +00:00
dc8a68ea28
- Patch #6791 : mark required fields. Modified patch by Michelangelo.
2004-04-24 15:39:31 +00:00
8fa7d74d4d
- Patch #6498 by jhriggs: <label> requires opening and closing tags.
2004-04-21 20:11:22 +00:00
8145c7695c
- Tracker and forum module improvements!
...
Note: the CSS of the tracker page has changed. Some CSS files still have
to be updated.
2004-03-20 13:23:34 +00:00
38e89dd03f
- Patch 5775 by Goba: fixes the only error currently reported by the doxygen
...
parser in Drupal core, plus fixes some errorneous (copy-pasted) doxygen docs.
2004-02-10 19:28:39 +00:00
8239dd0711
- Changed some double quotes to single quotes.
2004-02-08 21:04:08 +00:00
294286687a
- Patch #5163 by mattias: allow theme_table to accept a html attributes
...
parameter array.
2004-01-31 21:07:54 +00:00
c8daca07d2
- Patch #5448 by pz: removed code duplication from theme.inc.
2004-01-29 06:47:19 +00:00
Gábor Hojtsy
Dries Buytaert
Steven Wittens
Neil Drumm
Gerhard Killesreiter
