Commit Graph

143 Commits (1c2fc43b51455e4895455798919e4c77e2b1bf21)

Author SHA1 Message Date
Dries Buytaert f7a6c42eba - Bugfix: do not escpae slashes in block path. Patch #50 by Gerhard.
(This accompanies the recent block module documentation update, right?)
2003-06-26 19:26:27 +00:00
Dries Buytaert ef8735614f - Improvements: XHTML-ifications. Patch by GmbH. See feature #1813. 2003-06-16 17:09:23 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 7f2ce4acea - Fixed the order in which the CSS gets loaded. Patch by Al. 2003-05-30 05:10:35 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert 9a62873a4b - Added <base href=""> to default theme. Patch by Al, though I had to add
a 'global $base_url;'.  Fixes bug #1533.
2003-05-07 20:39:27 +00:00
Dries Buytaert 31d8b14969 - A one line patch to theme.inc which adds a missing page title variable to
the header() function.  Patch by Moshe.
2003-04-25 20:10:36 +00:00
Dries Buytaert b505b5ab65 - Committed Gordon's htmlarea patch. 2003-04-21 13:56:09 +00:00
Dries Buytaert 7a88330d9d - Committed slightly modified version of Kjartan's theme.inc patch: Drupal
will now barf when trying to instantiate a non-existing theme class.
  This should help to identify broken themes, and to track down theme system
  related bugs.
2003-03-11 23:08:01 +00:00
Dries Buytaert f21742c772 - Patch by Ax: "The $block->path setting, which <cite>lets you define regular expressions to specify on which pages you want the specific blocks to be shown</cite> [1], has been disfunctional for some time (did it ever work at all?). one reason was the magic_quotes_gpc / stripslashes issue [2] - luckily, this got solved today. the other reason is a buggy implementation that a) compares the path to $PHP_SELF (which is the script name only, without any url params like "?op=view&id=13"; in the case of clean urls, worse, it is index.php always ...) instead of request_uri() (which does have these params and the proper value), and b) doesn't properly escape the regexp delimiter character in the expression ("/back\/slash/")." 2003-02-27 22:48:32 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert 9281d0cdd7 - Applied Alastair's date patch.
- Removed all instances of '$user->nodes'.

- Committed Moshe's taxonomy patch - minus the node_compact_list() bit.  It needs a bit more thought/work.  This patch changes the links of taxonomy pages/feeds so update your custom code and themes accordingly!

Themes should now use "taxonomy_link("taxonomy terms", $node)" to get an array of taxonomy term links.  The old construct is deprecated and should be changed.

// old theme blob:
if (function_exists("taxonomy_node_get_terms")) {
  foreach (taxonomy_node_get_terms($node->nid) as $term) {
    $terms[] = l($term->name, NULL, array(), "or=$term->tid");
  }
}

// new theme blob:
if (module_exist("taxonomy")) {
  $terms = taxonomy_link("taxonomy terms", $node);
}

// old URL:
http://foo.com/index.php?or=1,2

// new URL:
http://foo.com/?q=taxonomy/page/or/1,2
2003-02-09 17:39:40 +00:00
Dries Buytaert cfd31c93f1 Patch by Ax:
- Bad usage of css ID's: they may be used for a single element only,
but were used as #node, #block, which can occur multiple times in a
single page.

- Moved HTML from theme to template - thats what templates are all
about!

- Added support for head() hook

- Added support for diffentiating between boxes and blocks.

- Typo: secundary -> secondary
2003-02-01 19:54:19 +00:00
Dries Buytaert 4dac201e7c - Patch by Ulf: XHTML-ified the code. 2003-01-21 22:57:43 +00:00
Dries Buytaert 56d0434f82 - Fixed bug in update of taxonomy links. 2003-01-06 21:43:07 +00:00
Dries Buytaert 2647a943f0 - Forgot to update the taxonomy links. Reported by Adam. 2003-01-06 21:24:21 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Kjartan Mannes 15f1a61197 - changing theme patch. Now Drupal will init the $this->path automatically. 2002-11-17 16:32:03 +00:00
Kjartan Mannes 64f8781f78 - made the themes path aware. If your theme creates a constructor function it
will now be passed the filename as the first parameter.
2002-11-16 18:06:32 +00:00
Dries Buytaert 99fd26db08 - Small cosmetic change. Patch by Natrak. 2002-11-10 21:16:58 +00:00
Dries Buytaert 2fc257a076 - Oops. Braino. 2002-11-09 20:50:50 +00:00
Dries Buytaert 6d1ffea494 - Added check to see whether $items is initiliazed. Thanks James. 2002-11-09 20:12:03 +00:00
Dries Buytaert a6a47a3257 - Applied Moshe's "theme head" patch:
"This patch to theme.inc adds the ability for modules to insert HTML
   into the <HEAD> section of all web pages. The additional modules in
   this directory [ed: blog.module] demonstate possible uses for the
   new _head() hook."
2002-11-09 16:24:46 +00:00
Dries Buytaert 562df8fe43 * Added Jeremy's pager:
"This is a simple, generic pager for Drupal-CVS.  It is designed to be
  easily themeable and expandable.  The code is highly-commented to
  enhance readability."

 "Pagers are constructed by combining the provided pieces (all of which
  can be easily modified to display the text or image you prefer) into
  your custom pager."

* Statistics module fixes by Jeremy:

 - removed superfluous check for existence of watchdog()
 - saving changes in admin page displays status and returns same page
 - no longer return 1971/01/01 in "view statistics" table
 - switched from "!=" to "<>" in SQL queries for ANSI-SQL compliance
 - switched from "MAX(timestamp) as timestamp" to "MAX(timestamp) as
   max_timestamp" moving towards ANSI-SQL compliance.

* Added a "theme_item_list" function to format itemized lists.  Also
  changed a couple of modules to take advantage of it.  Makes for a
  more consistent UI.
2002-11-09 13:59:36 +00:00
Dries Buytaert 8d103a0898 - Committed Marco's block rewrite:
+ Blocks are not longer called if not rendered: major performance
     improvement.
   + Fixed some bugs (preview option was broken, path option was broken).
   + Removed "ascii"-type blocks.
   + Added permission to for "PHP blocks"
   + ...

  NOTES:

   + You'll want to run "update.php":

       ALTER TABLE blocks DROP remove;
       ALTER TABLE blocks DROP name;

   + You'll want to update your custom modules as well as the modules in
     the contrib repository.  Block function should now read:

       function *_block($op = "list", $delta = 0) {
         if ($op == "list") {
           return array of block infos
         }
         else {
           return subject and content of $delta block
         }
       }
2002-10-26 15:17:26 +00:00
Dries Buytaert 66c5b70736 - Wrapped some hardcoded colors in "theme_invoke()"s; we can still create
a drupal_error() later on but I think we better get used to theme_invoke().

- Fixed translation bug.  Patch by Moshe.

- Fixed PHP warning.  Patch by ax.
2002-10-22 18:46:43 +00:00
Dries Buytaert 92326261d1 - Commited Marco's new comment module and forum module!!! 2002-09-15 13:00:12 +00:00
Kjartan Mannes 3f61d1a354 - adding doctype to basic theme.
- some minor changes to clean up var initialization.
2002-09-11 15:17:49 +00:00
Kjartan Mannes ff801dd111 - removing the "No valid themes enabled" warning. 2002-09-08 18:35:27 +00:00
Dries Buytaert 08b82913d4 - Added the theme_invoke() function from Moshe's sandbox. 2002-06-23 13:31:30 +00:00
Dries Buytaert 3dbccfa7cf - Let the blocks itself take care of translating their titles. Patch by
Marco.
2002-06-20 18:52:32 +00:00
Kjartan Mannes 7c58daf7c3 - adding missing $bacground/$foreground variables. 2002-06-12 12:33:27 +00:00
Dries Buytaert e426775fd5 - Bugfix. When a theme does no longer exist on disk, it should not be
returned by theme_list() as it breaks the site ...  The attached patch
  prevents this from happening but does not remove the theme from the system
  table in the SQL database - if the theme is removed from the database upon
  viewing the themes administration page (or another trigger), I guess that
  is fine.

Kjartan: my fix is the right thing to apply because theme_list() is used
         elsewhere where it requires to return a list of existing themes.
         Maybe it's a little sad but the current theme loading code might
         be slower and more complex than the old Drupal 3 theme loading
         code ... ?
2002-05-25 06:47:47 +00:00
Kjartan Mannes 12713beea4 - added taxonomy output to BaseTheme. 2002-05-20 18:00:59 +00:00
Dries Buytaert f3c8757179 - Ran the code through 'scripts/code-clean.sh': removed trailing whitespace
(and possibly tabs).
2002-05-20 07:34:38 +00:00
Kjartan Mannes a4b5005640 - merged block and box modules. modules/box.module should be removed
or disabled as it will cause errors otherwise.

  - split status into status and custom. Status will turn the block
    on/off, and custom defined if the user can change the status.
    Requires sql update.

  - reintroduced user page to configure blocks.
2002-05-02 19:13:45 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Kjartan Mannes 7e6acb5bbd - fixing bug reported by Remco. 2002-04-15 15:10:06 +00:00
Kjartan Mannes 5592761620 This is a major change to the system, needs more testing!
Committing Changes by Moshe Weitzman:
- admin_user_account(), user_edit(), and user_view() no longer have any
  hard code for authentication modules. instead authentication modules
  implement the _user hook.
- fixed a couple 'help' typos.
- linked the 'REGISTER' text in the login block to the register page.
  this page now advertises DA better if site employs DA.
- admins may now edit everything about a user account (was a feature
  request).
- user #1 may now login immediately, in addition to receiving his
  password via email.

Other changes:
- modules and themes are now enabled/disabled in the administrative /
  settings / modules | themes pages. Requires SQL update and things must
  be enabled before your site returns to normal. TODO: enable all
  functionality. (For now just do UPDATE system SET status = 1;)
- removed $themes from conf.php.
- added a $theme->system() function where theme can specify settings.
  All themes in the Drupal CVS have been updated to use this.
- added _system hook to modules. TODO: update modules to use this.
- changed strange use of sprintf to the usual strtr. The disadvantage of
  sprintf is that it requires translations to keep the string order,
  which may not be possible in all languages.
- an invalid/nonexisting theme in a user profile will now fallback to the
  BaseTheme instead of crashing.
2002-04-14 19:34:04 +00:00
Kjartan Mannes a6f0fd4dae - removed some warnings caused by implode. 2002-02-19 22:58:33 +00:00
Kjartan Mannes 9062b566b2 - applying patches from Axel Kollmorgen. See
http://list.drupal.org/drupal-devel/2002-February/thread.html#6678
  http://list.drupal.org/drupal-devel/2002-February/thread.html#6629
- removed references to $this->user() from themes.
- removed $BaseTheme->user(). It was deprecated a while back.

NOTE: this update will break custom themes, so make sure you update your
themes before updating!
2002-02-17 13:04:50 +00:00
Kjartan Mannes 8c672011a2 - moved user block from theme.inc to user.module.
* only problem is that the admin.php link is not available until the
      admin enables the block.
    * $theme->user is obsolete, will patch the themes properly in a
      later patch.
- moved moderation block from theme.inc to queue.module.
    * removed theme_moderation_results().
- updated database/database.mysql.
2002-01-21 17:31:13 +00:00
Dries Buytaert 7e50326274 - Fixed a typo in the example theme. (Patch by Mark) 2002-01-12 21:35:13 +00:00