Commit Graph

1681 Commits (1bb050cad7a62786270a92ccb658348b66466a64)

Author SHA1 Message Date
Dave Long 1bb050cad7
Issue #3219475 by quietone, adeshsharma, ravi.shankar, lucienchalom, Akram Khan, Prem Suthar, Ratan Priya, andregp, murilohp, karishmaamin, longwave, smustgrave, xjm: Fix spelling for words used once, beginning with 'j' -> 'm', inclusive 2023-07-23 17:21:30 +01:00
Dave Long b9d2e85583
Issue #3368145 by Spokje: Use constants when calling CommentTestBase::setCommentAnonymous 2023-07-22 15:40:31 +02:00
Kostia Bohach c44d89e37d Issue #3364659 by Utkarsh_33, lauriii, sakthi_dev, bnjmnm, tim.plunkett, fadilraj, Chris Matthews, longwave, smustgrave, ckrina: Give display modes a description 2023-07-21 14:48:24 +00:00
Dave Long 023898d3f9
Issue #2587415 by lauriii, LoMo, hooroomoo, longwave: Comment types UI confusing and inconsistent 2023-07-19 17:56:34 +02:00
Dave Long 95dcdb3f58
Issue #3374626 by lauriii, penyaskito, smustgrave, longwave: Comment type form title is confusing 2023-07-19 15:37:18 +02:00
Dave Long 69333763c3
Issue #3224941 by andypost, Akram Khan, ravi.shankar, SandeepSingh199, Spokje, catch, xjm, alexpott: Remove usage of setAccessible() when core requires PHP 8.1 2023-07-18 16:45:43 +01:00
catch f680053507 Issue #3373938 by lauriii, keshav.k: Comment settings are confusing 2023-07-14 11:19:03 +01:00
catch 9028e6c0ae Issue #3373867 by lauriii, Eric_A, smustgrave: [regression] "Comments field is required" when creating content for types with a comment field configured as hidden 2023-07-14 10:12:00 +01:00
Lauri Eskola 64e10dfa1c
Issue #3365229 by narendraR, lauriii, bnjmnm, Chris Matthews, yoroy, ckrina, hooroomoo: Add separate 'Save' and 'Save and add fields' to Add Content, Comment, Media and Block Type Forms 2023-07-06 15:37:18 +03:00
catch e9a09ddd8e Issue #3371464 by larowlan, Berdir, benjifisher, andypost, dokumori, greggles, smustgrave, zviryatko, Wim Leers, longwave: CommentAccessControlHandler::checkCreateAccess() does not check commented entity's comment field's status property 2023-07-05 09:50:04 +01:00
Lee Rowlands 0a7c3372a2
Issue #2920678 by phenaproxima, Wim Leers, dawehner, Gogowitsch, Sam152, dww, longwave, yogeshmpawar, alexpott, borisson_, tstoeckler, jibran, amateescu, larowlan, tedbow: Add config validation for the allowed characters of machine names 2023-07-03 16:51:23 +10:00
hooroomoo 9d522de054 Issue #3356894 by hooroomoo, lauriii, srishtiiee, Rajeshreeputra, Utkarsh_33, bnjmnm, narendraR, tim.plunkett, smustgrave, ckrina, yoroy, amateescu, Wim Leers: Make field selection less overwhelming by introducing groups 2023-06-30 19:27:14 +00:00
Lee Rowlands 13955d6bfd
Issue #3332546 by fjgarlin, Berdir, djsagar, larowlan, smustgrave: CommentSelection::entityQueryAlter() fails on validate when referencing entity is not a comment 2023-06-27 06:32:41 +10:00
catch 61edc1b137 Issue #2980750 by Spokje, Krzysztof Domański, tacituseu: [random test failure] Random failure in CommentStatisticsTest 2023-06-22 17:56:32 +01:00
catch b83467eabc Issue #3325557 by longwave, mondrake, kim.pepper: Enable more service autowiring by adding interface aliases to core modules 2023-06-14 13:59:48 +01:00
catch 6204ba9c59 Issue #2665216 by andypost, gidarai, daffie, mondrake, _utsavsharma, dawehner, catch, longwave, alexpott, Charlie ChX Negyesi: Deprecate Drupal\Core\Database\Connection::nextId() and the {sequences} table and schema 2023-06-08 12:59:56 +01:00
catch 98217b5bbe Issue #2986372 by ranjith_kumar_k_u, robertom, _utsavsharma, smustgrave, penyaskito, catch, larowlan: "Comments per page" setting cannot be configured to "all comments" 2023-05-04 09:34:31 +01:00
Lee Rowlands 6af88f6d6e
Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, Berdir, alexpott, marcelovani, catch, Lendude, mstrelan, tar_inet, Honza Pobořil, seanB, andrewbelcher, danflanagan8, susgo, sylus, sjpeters79, yogeshmpawar, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD 2023-04-27 07:58:01 +10:00
Dave Long 596b3d38f1
Issue #3351236 by Spokje, mondrake, smustgrave: Fix PHPStan L1 errors "Missing call to parent::setUp()/tearDown() method." 2023-04-16 22:50:09 +01:00
catch 2b6fade769 Issue #3338844 by Rassoni, dpi, smustgrave, longwave: Remove mention of removed function entity_view() 2023-04-14 16:02:10 +01:00
Dave Long 6629a1634d
Issue #3268838 by quietone, TR, smustgrave, xjm: Fix functions and test modules for Drupal.Commenting.DocComment.ShortSingleLine 2023-04-12 16:30:41 +01:00
Dave Long 7710bd6098
Issue #3268809 by quietone, Spokje, Rishabh Vishwakarma, ravi.shankar, mrinalini9, Medha Kumari, JatinGupta40, smustgrave, xjm, longwave, catch: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine' 2023-04-12 15:50:34 +01:00
catch c0cc344fb6 Issue #3336780 by diegors, schlaukopf, xjm, fabiansierra5191: Correctly capitalize "url" in documentation only, part 2 2023-04-12 15:28:50 +01:00
catch f88694094f Revert "Issue #3268809 by quietone, Rishabh Vishwakarma, ravi.shankar, Medha Kumari, mrinalini9, JatinGupta40, smustgrave, xjm, longwave: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine'"
This reverts commit b4829d2ff7.
2023-04-05 11:25:49 +01:00
Dave Long b4829d2ff7
Issue #3268809 by quietone, Rishabh Vishwakarma, ravi.shankar, Medha Kumari, mrinalini9, JatinGupta40, smustgrave, xjm, longwave: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine' 2023-04-05 09:56:11 +01:00
Lee Rowlands 40b09f3b48
Revert "Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD"
This reverts commit 7ea52649ec.
2023-04-05 08:21:03 +10:00
Lee Rowlands 7ea52649ec
Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD 2023-04-04 14:37:06 +10:00
bnjmnm 500a634eff Issue #3347296 by lauriii, smustgrave, ckrina: Conditionally show default value fields 2023-03-30 09:24:01 -04:00
catch 336c3ef206 Issue #3351060 by Spokje: Fix PHPStan L1 errors "You should use assertNull() instead of assertSame(null, $actual)." 2023-03-29 23:46:03 +01:00
catch b3fac4a09f Issue #3328454 by xjm, Bhanu951, jidrone, smustgrave: Replace most strpos() !== FALSE or === FALSE with str_contains() 2023-03-18 11:30:09 +00:00
Dave Long ba8126bd3b
Issue #2937514 by Spokje, quietone, dhirendra.mishra, Sparrow_1601, daffie, longwave: Fix Drupal.NamingConventions.ValidVariableName.LowerCamelName in tests 2023-03-12 20:39:40 +00:00
Alex Pott 6bbb08f95e
Issue #3210064 by mfb, TanujJain-TJ, maosmurf, smustgrave, xjm, samuel.mortenson: EntityChangedTrait return type mismatch 2023-03-07 23:36:18 +00:00
catch 2c3f5743df Issue #2921810 by claudiu.cristea, nod_, seanB, yogeshmpawar, dww, Wilfred Waltman, joelpittet, askibinski, ankithashetty, ravi.shankar, jonathanshaw, alexpott, kostyashupenko, webchick, danflanagan8, catch, droplet, larowlan, mpdonadio, jhedstrom, AaronMcHale, dawehner, Wim Leers, ckrina, worldlinemine: Allow TimestampFormatter to show as a fully cacheable time difference with JS 2023-03-03 16:35:58 +00:00
catch b4f9387139 Issue #3336491 by Spokje: Link to correct issue in @todo in CommentManager 2023-02-23 11:18:38 +00:00
Dave Long 3789efb326
Issue #3265616 by jungle, lucassc, xjm, nicrodgers, kkalashnikov, Akram Khan, Rishabh Vishwakarma, mrinalini9, jidrone, smustgrave, catch, longwave: Re-word "An illegal choice has been detected" message to remove legality suggestion 2023-02-17 16:31:59 +00:00
Dave Long 3966592061
Issue #3151019 by catch, andypost: Only allow route names, deprecate support for route objects in UrlGenerator methods 2023-02-17 16:29:57 +00:00
catch a386abdf41 Revert "Issue #3265616 by jungle, lucassc, xjm, nicrodgers, kkalashnikov, Akram Khan, Rishabh Vishwakarma, jidrone, smustgrave: Re-word "An illegal choice has been detected" message to remove legality suggestion"
This reverts commit 66c8012275.
2023-02-17 10:14:32 +00:00
catch 66c8012275 Issue #3265616 by jungle, lucassc, xjm, nicrodgers, kkalashnikov, Akram Khan, Rishabh Vishwakarma, jidrone, smustgrave: Re-word "An illegal choice has been detected" message to remove legality suggestion 2023-02-17 09:54:10 +00:00
Dave Long c187cc6339
Issue #3153468 by mondrake, mohrerao, mallezie, smustgrave, meena.bisht, naresh_bavaskar, hash6, ravi.shankar, Hardik_Patel_12, longwave, xjm: Strip HTML tags when using assertEquals() to compare markup 2023-02-07 14:48:42 +00:00
xjm 00bcd1740c
Issue #2574981 by Manjit.Singh, dimaro, wengerk, darol100, izus, pguillard, vsujeetkumar, Himanshu5050, snehi, paulocs, rakesh.gectcr, jofitz, _utsavsharma, charginghawk, rajeshwari10, sdstyles, quietone, benjifisher, marcusvsouza, LoMo, joelpittet, justAChris, cilefen, YesCT, mradcliffe, spitzialist, annajl, jhodgdon, catch, alexpott, Sabbi0612, kattekrab, Mile23, antojose, leanderl, rodrigoac: Fix grammar ("an URL" should be "a URL") and consistent use of URL (not "url" / "Url") in documentation only 2023-01-26 16:06:23 -06:00
Alex Pott 7347556c05
Issue #3294619 by mohit_aghera, Kasey_MK, smustgrave, alexpott: Missing schema for comment_link_approve views field configuration 2023-01-25 09:13:49 +00:00
catch c6babbb64e Issue #3324384 by Spokje, joachim, elber, znerol, longwave, mondrake: resolve differing createUser() test methods 2023-01-06 11:14:45 +00:00
Dave Long 85eeb1bde1
Issue #3324801 by Spokje, mondrake: Fix PHPStan L2 error "Property Foo::$bar has unknown class Baz as its type." 2022-12-07 11:22:31 +00:00
bnjmnm adfa35d41f Issue #3324150 by phenaproxima, Wim Leers, Gábor Hojtsy: Add validation constraints to config_entity.dependencies 2022-12-02 13:01:44 -05:00
Alex Pott eec3210128
Issue #3268818 by ravi.shankar, quietone: Fix class comment doc blocks in non tests 'Drupal.Commenting.DocComment.ShortSingleLine' 2022-11-29 12:13:59 +00:00
Alex Pott e2d4dcfdf2
Issue #3319582 by mondrake, Spokje, longwave, mallezie: Fix calls to methods with too many parameters passed in 2022-11-29 11:38:06 +00:00
catch 9baae1bea8 Issue #2254175 by smustgrave, pooja saraah, larowlan, sun: Fix test performance of Drupal\comment\Tests\CommentPreviewTest 2022-11-15 11:10:54 +00:00
catch 4c0f50772e Issue #3254986 by Matroskeen, paulocs, mikelutz, benjifisher, danflanagan8, quietone: Remove requirements array from RequirementsException message 2022-10-28 10:30:37 +01:00
Alex Pott c900c8d35c
Issue #3265574 by mondrake: Convert remaining assertions involving use of xpath to WebAssert, where possible 2022-10-05 22:56:32 +01:00
Alex Pott fdaf5636e4
Issue #3295880 by Spokje, longwave: ->willReturn(...) would make more sense here 2022-10-03 15:41:01 +01:00