d9c682e6af
- Patch #66264 by boombatower: fixed typo in title.
2008-08-14 19:42:26 +00:00
6f167edd7c
- Patch #187061 by Rob Loach: give feedback when a comment was posted.
2008-08-03 18:52:27 +00:00
aade5fbf24
- Patch #237636 by marcingy: comment status field should match node status field.
2008-08-02 20:29:43 +00:00
57fe5103da
- Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value.
2008-07-16 21:59:29 +00:00
1415340ce3
- Patch #191499 by catch: remove display order settings and cleaned up some white space.
2008-07-03 17:57:03 +00:00
81c71bc891
- Patch #216515 by chx, Damien Tournoud, et al: fixed form API glitch with caching.
2008-06-24 17:01:33 +00:00
928822d0a9
- Patch #272054 by David Rothstein: fixed code comment for comment_form().
2008-06-20 16:52:55 +00:00
95c66fa9fb
- Patch #272848 by catch: update comment settings form help text.
2008-06-20 16:45:27 +00:00
61cc35f2b0
- Patch #255918 by R.Muilwijk: performance improvement: comment_link querying for already retrieved data.
2008-06-18 16:06:42 +00:00
6e2358b232
- Patch #270045 by drewish, Susurrus: clean up return values.
2008-06-18 03:36:24 +00:00
d8ff9967e6
- Patch #250729 by R.Muilwijk: fixed typo.
2008-06-17 00:52:00 +00:00
cf42d0c25a
- Patch #250729 by R.Muilwijk: removed unnecessary SQL query.
2008-06-14 16:02:50 +00:00
201e1dd356
- Patch #268449 by catch: fixed some tests that failed due to invalid permissions.
2008-06-09 16:33:20 +00:00
5ed9cf76a0
- Patch #253577 by Morbus Iff: allow new comment timestamp to be passed.
2008-06-09 07:07:36 +00:00
dc613626d4
- Patch #266465 by R.Muilwijk: fixed the comment module tests.
2008-06-05 17:57:04 +00:00
3f052180dc
- Patch #66264 by boombatower: comment approval displayed on node view of comment. Comes with tests and everything.
2008-06-03 16:30:20 +00:00
c6c26b5e23
- Patch #247423 by boombatower: code style fixes for the tests.
2008-05-30 07:30:53 +00:00
8cc4aaeeae
- Patch #258171 by Senpai: code cleanup.
2008-05-14 13:12:41 +00:00
11aeff6016
- Patch #145242 by douggreen et al: refactor node_rank to modules can add scoring factors.
2008-05-14 11:10:54 +00:00
2e18cb8924
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit
...
et al. Can you say 'registry'? Drupal now maintains an internal registry of
all functions or classes in the system, allowing it to lazy-load code files as
needed (reducing the amount of code that must be parsed on each request). The
list of included files is cached per menu callback for subsequent loading by
the menu router. This way, a given page request will have all the code it needs
but little else, minimizing time spent parsing unneeded code.
2008-05-06 12:18:54 +00:00
d1bc889242
- Patch #227830 by JohnAlbin: link attributes added to l() incorrectly.
2008-05-02 15:11:05 +00:00
159bb6dd08
- Rollback.
2008-04-25 18:34:05 +00:00
d7f3c18d17
- Patch #250729 by R.Muilwijk: performance improvement.
2008-04-25 17:59:36 +00:00
21576021bf
- Patch #249546 by pwolanin: rip menu access inheritance -- was already committed to D6.
2008-04-23 20:01:56 +00:00
d1779405d2
- Patch #249941 by John Morahan: fixed incorrect parameters of watchdog() calls.
2008-04-23 18:05:58 +00:00
af474609e3
- Added a test framework to Drupal along with a first batch of tests for
...
Drupal core! This is an important milestone for the project so enable
the module and check it out ... :)
Thanks to Rok Žlender, Károly Négyesi, Jimmy Berry, Kevin Bridges, Charlie
Gordon, Douglas Hubler, Miglius Alaburda, Andy Kirkham, Dimitri13, Kieran
Lal, Moshe Weitzman, and the many other people that helped with testing
over the past years and that drove this home.
It all works but it is still rough around the edges (i.e. documentation
is still being written, the coding style is not 100% yet, a number of
tests still fail) but we spent the entire weekend working on it in Paris
and made a ton of progress. The best way to help and to get up to speed,
is to start writing and contributing some tests ... as well as fixing
some of the failures.
For those willing to help with improving the test framework, here are
some next steps and issues to resolve:
- How to best approach unit tests and mock functions?
- How to test drupal_mail() and drupal_http_request()?
- How to improve the admin UI so we have a nice progress bar?
- How best to do code coverage?
- See http://g.d.o/node/10099 for more ...
2008-04-20 18:24:07 +00:00
46546ef478
- Patch #175841 by catch et al: remove comment controls for users. Yowza.
2008-04-16 11:26:29 +00:00
56d2664a90
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
2008-04-14 17:48:46 +00:00
79b016d915
- Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
...
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php. The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:
block-user-0.tpl.php --> block-user-navigation.tpl.php
block-user-1.tpl.php --> block-user-login.tpl.php
You get the picture.
2008-04-10 10:28:23 +00:00
23602afbe1
- Patch #195072 by webchick and coltrane: make _comment_load() a public API function by renaming it to comment_load().
2008-04-10 10:13:57 +00:00
91824358be
- Patch #216504 by webchick et al: added missing table alias in comment_render function.
2008-04-10 01:45:38 +00:00
1dfd1717c1
- Patch #240387 by matt2000 et al: move 'content types' to 'site building' per the UMN usability study results.
2008-04-06 18:50:12 +00:00
f5d4287cd5
- Patch #214271 by recidive: improved schema identation.
2008-03-15 12:31:29 +00:00
33853f6d9c
- Patch #228120 by jvandyk: fixed code comment.
2008-03-10 18:25:48 +00:00
6030a5b2e4
- Patch #81931 by keith.smith: improved wording of help text.
2008-02-23 08:02:48 +00:00
657935c263
- Patch #81931 by webchick et al: made the recent comments block configurable. Somme minor changes by me.
2008-02-21 19:38:07 +00:00
584f3e886a
- Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page.
2008-02-20 13:46:43 +00:00
b05db1f176
- Patch #221384 by webernet: update core compatibility to Drupal 7.
2008-02-18 19:19:49 +00:00
b8a1eab1fb
- Patch #210131 by dvessel, catch, John, et al: updated jQuery library.
2008-02-06 19:38:28 +00:00
85cae0d01a
#204411 by chx, slightly modified: heal a possible MySQL import error when the anonymous user becomes broken
2008-01-25 16:19:13 +00:00
7f85bc5bc4
#208938 by bjaspan, scor: use schema PI for index updates instead of database dependent code
2008-01-16 21:45:30 +00:00
c5aa55b38e
#204705 by pwolanin: abort user_save on SQL errors, to avoid data corruption
2008-01-10 15:03:53 +00:00
b78a990270
#207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks
2008-01-08 10:35:43 +00:00
7127adabb0
- Patch #205465 by jvandyk: add missing index on comment table.
2008-01-05 22:45:40 +00:00
258b576020
#199809 by theborg: comment templates were not checking status properly (fix notice, allows themes to theme in-preview comments differently)
2008-01-04 19:24:24 +00:00
a555202276
#195161 follow up by keith.smith: fix typo in code comment
2008-01-04 15:11:59 +00:00
9bc7c07cb7
#195161 by mcarbone with some modifications: only show 'login to post comments' if logging in actually lets you post comments
2008-01-04 11:34:19 +00:00
a88c178b91
- Patch #204221 by webernet: code style fixes.
2007-12-28 12:02:52 +00:00
1d4fc1b1af
#202473 by keith.smith: pre-RC1 spell checking on hopefully final text
2007-12-19 21:40:05 +00:00
fcbd175337
#189878 by O Govinda, keith.smith: comment module help updates, removing help on features which are not there, and adding help on Drupal 6's new per content type comment settings
2007-12-19 19:17:20 +00:00
d17b6ad1cf
#199336 by JirkaRybka: remove improper t() use in update code (update goes all in English, but there were some mistakes), and add messages to updates where there was no return value otherwise, so users know what happens in each update
2007-12-19 10:34:51 +00:00
b339b47fc0
- Patch #199510 by Pancho: fixed form API conversions.
2007-12-18 22:16:55 +00:00
c8b1ddf26a
- Patch #164532 by catch, pwolanin, David Strauss, et al.: improve table indicies for common queries.
2007-12-18 12:59:22 +00:00
191beee5fa
#194310 follow up by chx and myself: only load comment module when we can actually do it, and when we need it in comment.install
2007-12-17 16:26:12 +00:00
dfe1225147
#194310 by chx, catch, KarenS: run updates for disabled but previously installed modules, if they are compatible with the current system
2007-12-17 12:23:01 +00:00
b7a2becd15
#197314 by vitezslav.smid (as GHOP 39): improve/add/update phpdoc in aggregator, comment and system modules
2007-12-16 21:01:45 +00:00
b6532a4fdb
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
2007-12-14 18:08:50 +00:00
c6d841c096
#197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc
2007-12-13 09:34:40 +00:00
5622bce2d5
#198579 by webernet and hswong3i: a huge set of coding style fixes, including:
...
- whitespaces at end of lines
- indentation
- control structure usage
- whitespace in empty lines
- phpdoc comment formatting
2007-12-08 14:06:23 +00:00
d83289f857
#196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions
2007-12-06 09:58:34 +00:00
259e2f5c7e
#195678 by catch: standardise on Save and Preview button terminology (for comments) and button placement for comments and nodes, so Save is always the leftmost button, and there is no guessing to find it
2007-11-29 11:54:37 +00:00
f77b60f291
#195543 by hass and yhager: CSS inherit was completely misused in RTL CSS files
2007-11-27 12:09:27 +00:00
22a4c039da
Rollback the accidentally committed #194310
2007-11-26 19:55:15 +00:00
e6a88be5d1
#193333 by quicksketch et al: taxonomy drag and drop support
2007-11-26 19:46:52 +00:00
c856eac135
#191104 by keith.smith: (usability) change occurances of node to 'post' and 'content' as appropriate
2007-11-12 19:06:33 +00:00
beb7cfa80e
- Patch #190483 by webernet et al: tiny code cleanup.
2007-11-09 07:46:10 +00:00
678773e364
#189837 by chx: remove temporary table usage from comment_enable(). Now we require MySQL 4.1 and it has constructs which make this unnecessary.
2007-11-07 15:54:49 +00:00
e9f7072edd
#186749 by Rob Loach and myself: (regression) only override comment submitter name with anonymous name, if it was not provided already
2007-11-05 14:25:58 +00:00
d1c46eadeb
#187391 by jrbeeman, catch: redirect user to proper node comment page after submitting a new comment
2007-11-04 16:11:33 +00:00
510bb1a42f
#93425 by bjaspan: remove pre-Drupal 4.6 era destination handling cruft carried over in comment module
2007-11-04 15:15:47 +00:00
91e980a271
#187881 by mooffie: fix misnamed database table names in schema documentation
2007-11-04 14:33:07 +00:00
b99aab8381
- Patch #163499 by Crell et al: split up comment module.
2007-10-31 17:50:47 +00:00
b036bef620
#185867 by hunmonk: (usability) add node title to comment overview page for easier identification
2007-10-25 10:28:05 +00:00
4e187261ab
#177497 by chx and Desbeers: revive Drupal 5's menu_set_location() functionality by introducing menu_set_item() (for consistency in function naming), thus fixing a regression in the current development code. Also fixing some misuse of menu_set_location() by using drupal_set_breadcrumb() instead.
2007-10-25 08:24:43 +00:00
b94f2716cf
#184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed
2007-10-21 18:59:02 +00:00
b64adf07c8
#182645 by scor: clean up concatenations to be in line with core coding standards
2007-10-19 10:19:03 +00:00
6417a6ade4
#55277 by catch and JirkaRybka: when flat comment view is used, order comments by cid (ie. original submission order) instead of timestamp (ie. last editing time order) to avoid comments jumping around when being edited
2007-10-16 14:22:00 +00:00
0a61aff251
#183390 by hunmonk: forms should use form_state['redirect'] for redirection, not drupal_goto() - fix this in comment_admin_overview_submit()
2007-10-15 15:57:15 +00:00
b274bf87f3
- Patch #182950 : fieldset massaging for usability.
2007-10-12 14:10:18 +00:00
09e2701892
#181088 by fajerstarter, catch and JirkaRybka: rename 'access control' to 'permissions' for usability reasons
2007-10-12 10:41:48 +00:00
8cf6fefe54
#164983 by multiple contributors: document the core database schemas
2007-10-10 11:39:35 +00:00
1a2bf588e6
#63990 by several people: fix comment submission on nodes where a form is displayed
2007-10-08 14:22:31 +00:00
ca8e9a1e18
- Patch #180432 by hunmonk, sun, et al: make comment settings per node type. This is a new feature that slipped in because it is required for the project module on drupal.org.
2007-10-07 19:25:57 +00:00
39706e3c51
- Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes.
2007-10-05 14:43:26 +00:00
071d4b010e
#180559 by hunmonk: do not try to display the comment addition form at th end of comments, if we are already on the page, so it is displayed anyway
2007-10-03 17:59:50 +00:00
b03af772d7
#174233 by webernet: fix notices when editing comments and also fix a moderation bug along the way
2007-09-28 17:15:04 +00:00
be091880f4
- Patch #124979 by chx: remove the auto_increment.
2007-09-26 18:31:34 +00:00
cd517f16e9
#177927 by chx: use path=/ in PHP comment settings cookie creation, so cookies set around the site are available in other 'directories'
2007-09-25 14:58:43 +00:00
21ac9f1917
#174708 by multiple contributors: update jQuery to 1.2
2007-09-12 18:29:32 +00:00
ac7637bc9b
#172773 by numerous contributors: Make the actions interface usable by mere mortals (including rename of actions.module to trigger, but keeping the actions themselfs).
...
Complete previous history of actions module:
- #148410 by jvandyk: added rewrite of the actions module!
- #155986 by Uwe: fixed typos.
- #155828 by Eaton, pwolanin and jvandyk: let actions live even if actions.module is not turned on
2007-09-11 14:50:05 +00:00
67e5859a7f
#172376 by ChrisKennedy: fix 8 E_ALL issues in comment module and fix approval queue
2007-09-06 12:21:39 +00:00
ab1715750a
- Patch #172961 by webernet: code style cleanup.
2007-09-05 08:42:02 +00:00
2db2c039fb
- Patch #172950 by webernet: code style fixes.
2007-09-04 21:10:45 +00:00
e310d9e4a4
#6162 by various people: actually point new anchors to the page the first new comment is displayed (in a multipage comment view)
2007-09-02 14:56:18 +00:00
c07305d060
#172149 by dvessel: add semicolons, so the JS aggregator works
2007-09-01 07:08:11 +00:00
00181ecb39
- Removing whitespace.
2007-08-30 19:54:22 +00:00
4e0071fb8a
#111127 rollback by chx, slightly extended: roll back node_load cache, it needs more thought and discussion, so postponed until at least Drupal 7
2007-08-30 15:31:46 +00:00
d8b17c9f19
#156475 by Christoph C. Cemper and greggles: actually call the publish op on hook_comment when a comment is first (automatically) published
2007-08-29 17:01:33 +00:00
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
801756e7e6
#111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op)
2007-08-25 09:25:49 +00:00
c17499b6fe
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement. (Correct version this time.)
2007-08-12 16:12:00 +00:00
b134b023e1
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement.
2007-08-12 15:55:36 +00:00
a5fcb369fb
- Patch #166205 by hswong3i: improved database compatibility of db_result(). Makes it work with DB2, Oracle, etc.
2007-08-11 14:14:46 +00:00
f23c24c8a3
#164935 by Ralf Stamm: standardize CVS Id tags in files:
...
- always include CVS Id tags in all files
- add a new line after the CVS Id, if more code or phpdoc follows in the same code block
- fix bogus Id tags previously added
2007-08-07 08:39:36 +00:00
d746d35a8f
- Patch #163073 by Robert Douglas: removing dead code.
2007-07-30 21:27:34 +00:00
f180790bb7
#161979 noticed by bboyjay, patch by myself: kill noticedisplayed when no comments were selected for the mass operation
2007-07-25 14:57:58 +00:00
e3fa6893c2
#124485 by Wesley Tanaka: move some remaining node.css comment styles to the actual comment.css
2007-07-24 21:33:53 +00:00
7d0cf742f7
- Patch #160589 by dvessel: tpl-ify the comment module's theme functions.
2007-07-20 08:51:13 +00:00
0ddff5ee26
- Patch #160491 by dvessel: fixed E_NOTICE warnings.
2007-07-20 08:39:00 +00:00
08c059ec77
- Rollback of patch #147947 : lacks proper upgrade path.
2007-07-15 10:09:21 +00:00
a771c6c45a
- Patch #57106 by Steven et al: future timestamps break search indexing.
2007-07-15 10:05:18 +00:00
51b789c0d3
#156778 by asimmonds: revert node and comment deletions to the pre-deletion API state
2007-07-13 20:04:47 +00:00
4ff46202cb
- Patch #157773 by pwolanin: remove node/%/% from comment_menu.
2007-07-09 17:05:49 +00:00
806d0a3dee
#156910 by asimmonds: fix code indentation problems introduced with new code in this development cycle; only whitespace changes
2007-07-05 08:48:58 +00:00
1b503eaac9
#128165 by joshk and webchick: missing db_rewrite_sql() calls in comment queries
2007-07-04 22:24:40 +00:00
ee701b3336
- Patch #155986 by Uwe: fixed typos.
2007-07-02 14:41:37 +00:00
3409019929
#146386 by kbahey: refactor 'submitted by user - date' themeing and make it more verbose to translate
2007-07-01 23:15:41 +00:00
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
c11cb4ec24
- Patch #120360 by nedjo: enable AJAX by making all behaviours reattachable.
2007-07-01 15:37:10 +00:00
9e6ef53c2c
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
2007-06-30 19:46:58 +00:00
2348e7de6f
- Patch #148410 by jvandyk: added rewrite of the actions module!
...
This is a very important patch, but one that is merely an enabler.
Hopefully we'll see more people submitting "action patches" in the
near future.
Thanks for the hard work and persistence, John. *If* you decide
to update the Drupal Pro Development book to Drupal 6, make sure
to add a chapter on actions. ;)
2007-06-29 18:06:51 +00:00
7093495f7c
#154046 : Optimize confirm_form syntax for common usage (and fix some $form_state bugs).
2007-06-24 10:09:53 +00:00
028c8e6050
#148678 : Fix notices/warnings on invalid paths like 'node/zzz'. (chx/pwolanin/webernet)
2007-06-24 00:38:40 +00:00
38a1300df2
#147723 : Deletion API (by hunmonk). Woop woop.
2007-06-22 05:44:21 +00:00
ae0392b2eb
- Patch #147947 by hswong3i: some files shouldn't defined as text:big for Oracle compatibility.
2007-06-15 07:15:25 +00:00
0d5e968823
- Patch #82526 by Moshe: simplified APIs -- use form_alter now.
2007-06-15 07:10:47 +00:00
42667a6328
- Patch #142829 by webchick and gurpartap singh: pave the path to allow comment-.tpl.php.
2007-06-11 14:56:40 +00:00
29eb5a6284
- Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version.
2007-06-08 05:50:58 +00:00
27388f6655
- Patch #149176 by chx, David et al: getting rid of the sequences table, using db_last_insert_id() instead of db_next_id().
2007-06-05 12:13:23 +00:00
2a3744c572
- Patch #149339 by Ted: removed unnecessary heavy query.
2007-06-05 09:22:22 +00:00
e629deb94d
- Patch #146667 by Jeff Eaton: form API fixes.
2007-06-04 15:56:34 +00:00
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
556ef56c52
- Patch #147417 by robertDouglas: only save cookie for anonymous users.
2007-05-29 06:27:37 +00:00
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
860947d3c8
#145737 by yhager, documentation cleaned up by myself: add support for RTL CSS overrides and default RTL CSS override files for modules
...
Note: properties, which are different in the RTL display are marked with /* LTR */ in default CSS files now,
so maintainers remember that changing them should also have an effect on RTL CSS files.
This should open the way for better RTL (right-to-left written) language (such as Arabic and Hebrew) support.
2007-05-27 17:57:48 +00:00
4a6f5869e5
- Patch #142773 by kbahey: made Drupal work correctly when behind a reverse proxy.
2007-05-25 15:04:42 +00:00
3cafffe63f
- Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave.
2007-05-25 12:46:46 +00:00
2934a3d9bd
- Patch #144859 by dww: added optional e-mail notifications when user are approved, blocked, or deleted.
2007-05-20 12:34:48 +00:00
b86d106e0e
- Patch #141131 by mfer: fixed UTF-8 problem.
2007-05-20 07:30:03 +00:00
da7f952a45
- Patch #141131 by mfer: remember anonyous comment posters.
2007-05-17 21:05:38 +00:00
d1e28d4273
- Patch #141131 by mfer: remember anonyous comment posters.
2007-05-17 20:57:19 +00:00
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00
7d4f2836ba
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
2007-04-30 17:03:29 +00:00
29055d34d6
- Patch #137236 by merlinofchaos: provide a way to secure the theme variables system.
2007-04-27 07:42:54 +00:00
359ace36e6
#76588 patch by alienbrain: some localization-unfriendly watchdog() calls
2007-04-24 18:23:48 +00:00
e675979091
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
2007-04-13 08:56:59 +00:00
083a6a274d
- Patch #134185 by Ralf Stamm: missing CVS IDs in files.
2007-04-13 07:33:24 +00:00
b9b015ff19
- Patch #130366 by webchick and Steven: make signatures pretty.
2007-04-09 13:41:10 +00:00
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
f3cd2da113
#130991 : Custom menu items, part 1
2007-04-06 04:39:51 +00:00
a2baa44499
#130366 : Better styling for signature separator (thanks webchick).
2007-04-01 05:04:20 +00:00
9e94bb6101
- Patch #130366 by webchick and steven: improved signature handling. Step 1 of 2.
2007-03-30 07:45:20 +00:00
630277cc89
- Patch #110888 by Heine: fixed drupal_alter glitch().
2007-03-29 23:19:33 +00:00
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
eb6b848de6
- Patch #110888 by Eaton: unify hook _alter()
2007-03-26 00:35:59 +00:00
69eb6a883d
- Patch #123940 by Gman: anchor to comment form is mis-labeled.
2007-03-12 13:08:02 +00:00
273a653f56
- Patch #111830 by pwolanin: comment block sql incompatible with db_rewrite_sql.
2007-03-06 16:15:19 +00:00
1e9c517796
- Patch #124742 by ChrisKennedy: fixed comments in CVS HEAD.
2007-03-06 16:14:04 +00:00
b95f496bbc
- Backporting comment module validation fixes. Already went into DRUPAL-5.
2007-03-01 19:53:04 +00:00
dc5843bd30
- Patch #111347 by Steven: refactor url() and l().
2007-02-15 11:40:19 +00:00
a1e6728a46
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-02-11 09:30:51 +00:00
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
03752e35a4
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
2007-01-24 14:48:36 +00:00
301d377986
- Patch #107440 by webchick and add1sum: code cleanup.
2007-01-23 19:11:18 +00:00
1ec2b45be7
- Patch #104156 by chromeyellow and Heine: avoid redundant SQL queries.
2007-01-03 11:32:38 +00:00
dbcf525d42
- Patch #106351 by hickory: fixed comment forms.
2007-01-03 11:04:50 +00:00
36fce2f001
#18870 by zen. Only allow the new comment anchor to be output forthe first new comment.
2006-12-30 21:20:38 +00:00
8b9a3326c3
#60664 by Heine. Only check if new comments are duplicates.
2006-12-25 22:39:08 +00:00
f4ed6e1a14
#69111 by robertDouglass. Speed up the new comments block.
2006-12-19 09:02:28 +00:00
46392b264c
#92242 : Don't indent when comment view is flat.
2006-12-15 01:33:00 +00:00
17b8327efc
#102353 : More efficient query for comment.module fix
2006-12-13 22:44:54 +00:00
a043194e3f
#102353 : Fix comment tracking when comment module has been disabled.
2006-12-13 10:24:58 +00:00
a10ca909a0
#93897 : Fix comment de-indenting multiple levels at a time.
2006-12-12 09:20:17 +00:00
27db2cb8b5
#102606 : More documentation for constants (webchick)
2006-12-12 06:14:21 +00:00
fcde99a4dd
#60916 : Fix comment subject being empty when comment only contains HTML tags.
2006-12-12 06:06:41 +00:00
59fe44368f
#102783 : link to right permissions section in comment help
2006-12-12 05:39:45 +00:00
711378019d
-Patch
2006-12-11 17:13:45 +00:00
cbb4504574
- Patch #102026 by robert douglas: improved PHPdoc comments.
2006-12-08 16:16:30 +00:00
eade0808a3
- Patch #102151 by robert douglass: removed unneeded 'GROUP BY' clause in thread-building code.
2006-12-08 15:32:10 +00:00
627d426735
- Patch #100836 by webernet: make collapsed comments work again.
2006-12-06 15:44:09 +00:00
00758e24dc
- Patch #92149 by Chris Kennedy: more sentence capitalization.
2006-12-05 17:48:03 +00:00
46a6e08cea
- Patch #51314 by kjartan, eafarris, et al: hide the last comment block if there are no comments.
2006-12-01 16:50:36 +00:00
a2dbfc9034
#99579 by Heine. Don't placeholder the number of comments per page.
2006-11-27 02:14:33 +00:00
760e495554
#97824 by webchick. Move enclosing elements out of t().
2006-11-26 23:10:29 +00:00
8bf48bf999
#99645 by chx. Reshuffle some comments.
2006-11-26 22:35:20 +00:00
8b1e5d0505
#97231 by pwolanin. Keep the node type in a property and use it consistently.
2006-11-26 02:43:48 +00:00
827f064deb
- Patch # #98366 by webchick and ac: simplified strings for translators.
2006-11-24 10:18:24 +00:00
d721a4f0d9
- Patch #98365 by webchick and RobRoy: added missing t() functions.
2006-11-24 09:01:57 +00:00
6ae6dc0d85
- Patch #87298 by webchick, neil, dww et al: show version numbers on modules page.
2006-11-21 20:55:36 +00:00
b004f328ee
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
2006-11-21 20:14:19 +00:00
001d54f663
#84961 : Add 'select all' and range select feature to admin tables.
2006-11-21 08:16:39 +00:00
7f25862f95
#93821 by lyricnz. Fix an undefined variable.
2006-11-12 00:11:15 +00:00
337c2f9b5d
#92149 by Egon Bianchet. Fix an uncapitalized link.
2006-11-10 08:37:20 +00:00
87f1359158
- Patch #82938 by edkwh and natrak: error in comments admin page after clicking on Update without selecting any comments.
2006-10-24 20:31:25 +00:00
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
8306444494
- Patch #78399 by Eaton and chx: don't allow HTML in the title.
2006-10-18 18:00:40 +00:00
ea38bae2a7
#84443 by Shakur. Do not depend on a url argument being defined.
2006-10-17 08:45:51 +00:00
8d74e4c132
- Patch #87995 by merlinofchaos: added missing css.
2006-10-15 19:57:06 +00:00
7cb0c537c1
- Patch #87995 by merlinofchaos: cleaned up CSS and simplified the code.
2006-10-11 13:17:23 +00:00
6e8a0a1602
- Patch #87755 by kjartan: anonymous comments can't save names.
2006-10-09 06:59:01 +00:00
18b297abf8
- Patch #81740 by merlinofchaos, webchick, moshe, neclimdul et al: added package support to the modules page.
2006-10-05 15:47:57 +00:00
cb8201c337
- Patch #83007 by edkwh: fixed multi-comment delete.
2006-09-17 19:09:34 +00:00
d48100eb88
#73584 by keve an flk. Properly check if a variable is set.
2006-09-09 00:23:11 +00:00
6f0e54b037
- Patch #82465 by webchick: renamed variables in hooks for consistency.
2006-09-08 16:33:02 +00:00
208090eeb0
#82336 by jvandyk. Set the default input format if we don't have one.
2006-09-05 02:36:02 +00:00
49fa25fb76
- Rollback of patch #68418 : clean up node submit hooks. Needs more thinkering.
...
Restores the old node API.
2006-08-31 21:58:36 +00:00
c64db1da29
- Patch #80952 by earl, webchick, neclimdul et al: .info files
2006-08-31 20:22:37 +00:00
e051f5bd90
#81481 by erdemkose. Show the comment subject on delete confirmation.
2006-08-31 08:55:45 +00:00
5524604a95
- Patch #68418 by Moshe et al: clean up node submit hooks.
2006-08-29 18:43:26 +00:00
bceaf8f0da
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
2006-08-29 09:12:03 +00:00
f8534504b3
- Patch #80895 by webchick et al: make it easier to disable form elements.
2006-08-27 12:54:01 +00:00
c4f1e4ba13
- Patch #76444 by chx, moshe, eaton, angie et al: make it possible to control access to form elements.
2006-08-22 11:13:04 +00:00
e14c3aa6c0
- Patch #79498 by Eaton: fixed editing comments and nodes.
2006-08-19 21:40:58 +00:00
7de41539df
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
2006-08-18 18:58:47 +00:00
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
ce85b7c7f8
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
...
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
d2eb90c45e
- Patch #77896 by killes: don't clear cache inside loop.
2006-08-10 05:47:37 +00:00
729fa6c11b
- Patch #77422 by timcn: corrected various paths in the documentation.
2006-08-07 15:04:16 +00:00
129c8eb18c
#62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types.
2006-08-06 23:00:42 +00:00
cd430165d7
#73884 by RobRoy, various code cleanup.
2006-08-05 00:26:36 +00:00
b138793b68
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
2006-07-31 11:25:55 +00:00
c11c1c2800
#73605 by RobRoy, make hook_link() implementations consistent with documentation.
2006-07-19 07:15:35 +00:00
e616f2b580
#73748 by RobRoy, add a themeable wrapper for comments
2006-07-19 06:19:17 +00:00
dafb146b27
#74070 : urlencode to drupal_urlencode()
2006-07-18 10:44:45 +00:00
e4e416d1f7
- Patch #73351 by Kris, Goba et al: only display comment link in RSS, if applicable.
2006-07-13 12:29:15 +00:00
58752cfaa2
- Patch #72284 by me:
...
+ reorganized ?q=admin/settings
+ deprecated the _settings hook
2006-07-10 19:27:52 +00:00
84bad29516
#72865 by AjK, use more standard is_numeric() instead of ctype_digit().
2006-07-10 18:00:37 +00:00
59aa2ae8e8
#71925 by Steven, remove # prefix from link array keys.
2006-07-04 08:59:05 +00:00
d048681f03
#63990 by Heine and chx, allow commenting on nodes containing forms
2006-07-02 20:24:17 +00:00
2a89ab89f9
#67745 by AjK, handle deleting non-existant comments better.
2006-07-02 02:59:21 +00:00
4f078eb274
#51556 by greggles, Fixing an inaccurate comment.
2006-05-20 08:14:09 +00:00
1b291a2917
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
2006-05-18 14:58:57 +00:00
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
79598dc723
#61678 by Zen, Comment body validation should rely on fapi
2006-05-04 09:34:56 +00:00
546f5930a4
#58953 : Flat collapsed mode and newest first order broken
2006-04-27 22:03:20 +00:00
326f49b646
- Patch #58953 by tenrapid: critical bugfix: Flat Collapsed mode and Newest First order broken.
2006-04-24 18:42:53 +00:00
297ed741f8
#58221 , Turn #after_build into a functions array in order to make validation of date fields possible. Patch by yched, tenrapid
...
Also makes forms API more consistent (see #pre_render)
2006-04-20 07:11:37 +00:00
0484fcd1ed
- Patch #58921 by markus_petrux: critical bug: database error when rendering comments in PostgreSQL.
...
Tested with MySQL only!
2006-04-17 20:45:00 +00:00
8b04c7f0db
#51002 : Admins could not see unpublished comments (plus minor usability enhancements for previewing/unpublished)
2006-04-15 04:07:18 +00:00
d6a164c400
#5371 , drupal_get_destination, pager and tablesort array handling, patch by Steven
2006-04-13 08:25:27 +00:00
70aae83c8e
#58166 , fixes for typos, patch by Uwe Herrmann
2006-04-11 11:33:15 +00:00
4c3fe45fe9
#56942 : Comment cids should belong to the associated nid
2006-04-04 07:07:45 +00:00
57be840338
#57133 : admin/comment needs to remember sort order in page
2006-04-04 01:26:05 +00:00
b3cb4f0d9b
#56346 : XHTML validation error due to comment.module links
2006-03-30 17:23:29 +00:00
a76ee6c9ed
#34132 , remove remnants of nodeapi('fields'), patch by myself
2006-03-28 06:12:15 +00:00
d6f15f3051
- #55666 : Comment reply form anchor fixes
2006-03-27 08:08:31 +00:00
5885925b0d
#53348 , Handling of deleted/blocked user accounts, patch by jreyero and Zen
2006-03-26 19:31:00 +00:00
0fad496ca0
#55622 , Security threat -- any user can delete comments, patch by robertgarrigos
2006-03-24 11:38:00 +00:00
63b3fea2b3
#54687 , Typo with page redirection upon login, patch by matt westgate
2006-03-20 16:40:06 +00:00
f51bc544f2
- Patch #51142 by markus: hook_comment not called for all update operations.
2006-03-06 20:52:55 +00:00
c54a0f575f
- Patch #51543 by wtanaka: clicking on 'add new comment' takes you to the wrong place.
2006-03-06 18:09:17 +00:00
5de716f100
- Patch #50835 by markus: print message when replying to non-existing comment.
2006-03-04 18:01:54 +00:00
784202418f
#50771 , Wrong user name in admin/comment, patach by Markus Petrux
2006-02-27 14:54:24 +00:00
66576708a0
- Patch #51347 by eafarris: fixed typo: coment -> comment.
2006-02-26 19:52:09 +00:00
3489651659
- Patch #46690 by Zen: 'user comments' -> 'comment settings'.
2006-02-26 19:47:55 +00:00
c94a2dabb0
- Patch #50755 by markus: = -> ==.
2006-02-22 19:02:58 +00:00
cb05945caf
- Patch #47699 by wtanaka: performance improvement.
2006-02-22 10:05:06 +00:00
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
7489c87476
- Patch #43572 by Tobias: don't accept spaces.
2006-02-14 19:17:00 +00:00
583d5a4ee9
- Patch #48622 by adrian: remove drupal_goto from _submit functions.
2006-02-10 05:25:57 +00:00
1819de963f
- #48518 : Editing own comment broken under postgresl
2006-02-09 09:09:03 +00:00
c9a19e3084
- #48239 : Comment thread coding inefficient
2006-02-09 08:33:36 +00:00
91e152b8b8
- Patch #47705 by DriesK: comment moderation/approval wasn't working due to a bug with its forms.
2006-02-04 09:54:16 +00:00
baa2ecc81c
- Patch #47045 by Cvbge: fixed problem with deleting comments.
2006-02-01 14:04:50 +00:00
a6dac9d2ab
- Modified patch #46227 by chx: comment token is broken.
2006-01-31 15:26:39 +00:00
20154df528
- Modified patch #45723 by wtanaka: creating a comment, editing a comment, or anything that validates a comment fails on PHP5.
2006-01-26 08:48:57 +00:00
5d43619ca7
- Patch #40752 by moshe/wtanaka: login and regsiter links on each comment don't redirect back to the topic.
2006-01-26 08:27:58 +00:00
b8832d76a0
- Patch #40753 by wtanaka/killes: #comment-form has disappeared from comment.module
2006-01-25 08:54:40 +00:00
b6b98bb60d
- Patch #44101 by Cvbge: deleting a comment creates incorrect entry in node_comment_statistics.
2006-01-22 07:26:33 +00:00
4da1540a9f
- Patch #45380 by Neil: usability improvement: disable anonymous commenting options when anonymous people can't comment.
2006-01-20 09:33:03 +00:00
8c02d4ec93
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
...
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
e84a98a22b
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
2006-01-19 08:54:41 +00:00
47dd0142e6
- Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing comments work.
2006-01-18 15:09:39 +00:00
cb45cf58fb
- Patch #40755 by wtanaka: make the comment block themable.
2006-01-17 18:02:23 +00:00
226a26a556
- Removed reference to comment moderation.
2006-01-10 19:41:15 +00:00
49e5e1cd47
- #43097 : restore admin/comment tablesort
2006-01-08 00:29:37 +00:00
030fd1798a
- Comment bug: anchor links should be specified using $fragment in url() and drupal_goto().
2006-01-06 01:14:17 +00:00
24899dba42
- Patch #40563 by chx, merlingofchaos, et al: bug fix: fixed the default comment settings on node sumbission forms.
2006-01-05 14:35:55 +00:00
8d7ff5aea2
- Patch #39743 by merlinofchaos: critical bugfix: fixed comment ordering setting.
2006-01-05 10:53:47 +00:00
72ed68d48b
- Patch #42971 by markus_petrux: input format not correctly shown when editing a comment.
2006-01-03 23:04:23 +00:00
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
6164074655
- Patch #38999 by saerdna: There's no need that users with the "administer comments" role has to go via admin/comments to delete comments. this patch simply adds the delete link on each comment if you have administer comments role. "access administration pages" not needed; because if they not have it they can still delete from admin/comments.
2005-12-19 10:12:52 +00:00
21a9442bbb
- Patch #41081 by billturner: fixed problem with the comment settings form.
2005-12-15 16:31:01 +00:00
922a46d281
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
2005-12-15 16:24:40 +00:00
5accfa08f5
- Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on failure instead of -1.
...
Changed code to be compatible with all versions.
2005-12-15 16:02:50 +00:00
764f1177ef
- Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().
2005-12-14 20:10:45 +00:00
3ae534a64e
- Patch #28595 by Cvbge: fixed problems with bulk comment operations.
2005-12-08 09:11:32 +00:00
e019ce5107
- Patch #28595 by Jeremy: added support for bulk operations on comments.
2005-12-07 05:35:02 +00:00
28fdb3975e
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
2005-12-05 09:11:33 +00:00
80e02e6e73
- Patch #36434 by assimonds: fixed problem with editing signatures.
2005-12-03 19:39:15 +00:00
26bd449860
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
2005-12-02 15:21:01 +00:00
8784a7d13a
- Patch #39024 by Zen: comments that should be in the moderation queue get published.
2005-11-27 11:45:03 +00:00
c647b39c2c
- Patch #37798 by Neil: fixed problem with node settings.
2005-11-27 11:11:46 +00:00
247e012c35
- Patch #39013 by drumm: more logical naming of themeable functions
2005-11-27 11:07:02 +00:00
b1b1e2045f
- Patch #37798 by Neil: allow non-workflow form elements on the node type settings page.
2005-11-25 10:11:59 +00:00
bd2d91807e
- Patch #38575 by Neil: fixed infinite loop in comment.module.
2005-11-23 08:23:45 +00:00
62e5c58777
- Patch #38491 by Neil: refactor comment viewing controls to _execute model.
2005-11-22 15:48:46 +00:00
9f8fcab8db
- Patch #35726 by asimmonds: post_process -> build_after
2005-11-22 15:13:15 +00:00
28f973a986
- Patch #35726 by asimmonds/chx: converted the comment module to the forms API's _execute model.
2005-11-21 08:32:31 +00:00
e900d28640
- Patch #34295 by assimonds: added missing defines to comment.module. Improves
...
readability of the code.
2005-11-15 07:29:47 +00:00
d5d0149abe
- Patch #34295 by DrupalJapan and chx:
...
+ Fixed problem with configuration of comment display options.
+ Introduced defines for the various comment settings.
2005-11-13 09:05:38 +00:00
21bed11e66
- Add missing url()s around form actions (these would break without clean URLs)
2005-11-13 02:32:18 +00:00
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
3d13a38502
- Patch #36727 by Goba: fixed incorrect use of drupal_goto().
2005-11-08 20:57:41 +00:00
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
3fad92fc59
- #34645 : Make $links in theme_comment consistent with theme_node (Stefan)
2005-10-20 09:27:36 +00:00
e83b00d526
- Typo
2005-10-20 08:56:34 +00:00
8164ec2f49
- Code style
2005-10-20 08:53:59 +00:00
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
7863be5e82
- Patch #33433 by chx: fixed a number of form API problems.
...
* Default form value
* Leftover debug function in form.inc
* PHP5 issue with comment date (I got this patch from another issue)
* Validation error fix (was calling legacy form validate)
* Lots o' warnings on comment preview
* Filter tips plus argument (gremlins. I swear this was not there.)
* Message to clear what's going on with system settings
* Non-freetagging taxonomies fixed
2005-10-08 12:21:47 +00:00
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
0200ccf4da
- Patch by chx: fixed validation check.
2005-10-01 08:43:51 +00:00
1d94bb4a87
- Add some extra options.
2005-09-29 08:04:51 +00:00
45f4bcaa7d
- Patch #26031 by leafish_dylan: fixed comment pager (broken SQL query).
2005-09-27 18:34:59 +00:00
dff2df4809
- Patch #28786 by Neil: moved pagers out of table.
2005-09-27 18:10:19 +00:00
67e68fc679
- Patch #28786 by Neil: move pagers out of table.
2005-09-24 07:53:26 +00:00
2b3126b2cc
Patch #19934 by Morbus, chx: conf_init() should strip out port numbers in bootstrap.inc.
2005-09-19 19:13:35 +00:00
06af3e60e5
- Patch #29866 by Florian, Uwe: made the recent comments block only show comments on public nodes.
2005-09-19 15:11:05 +00:00
dec4ddd3a5
- Patch #28420 by Jeremy: provide a more generic interface that can be used
...
to validate other form submissions, not just comments. Two new functions
are introduced, form_token() and form_validate(). The first function uses
a private key and a public key to set a token in a hidden field. The second
function validates the token. The comment and contect module are updated to
use these functions.
2005-09-18 12:04:10 +00:00
1dc53d9761
- Patch #3986 by James (and Boris :)):consolidated all feed-related settings in one place.
...
* adds a "feed settings" section to admin/settings where 2 new settings are introduced:
* number of items per feed
* default length of feed descriptions (title only, teaser, full)
* patches all of core to obey the above - including the new aggregator (out) feeds
* adds support for adding namespaces in _nodeapi('rss item') - which means things like iTunes RSS and yahoo's media rss can be implemented by the appropriate modules (i.e. audio.module)
* includes some additional info in the default node feed - specifically the element (links directly to comments) - and dc:creator - to show node author information.
2005-09-18 10:37:57 +00:00
57a734a989
- Patch #16140 by Gerhard: cure array_merge() warning due to invalide menu callback.
2005-09-07 20:45:53 +00:00
d9d6a6e05c
- Patch #7582 by Gerhard: improved node revisions!
...
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.
TODO:
1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions. Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
494e5ab97c
- Renamed 'user comments' to 'comment options' for consistency.'
2005-08-28 15:16:58 +00:00
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
29d6660149
- Patch #23620 by Robin: don't hard code forms into comment.module. Will be
...
depricated by form API patch though. Hopefully helps migration.
2005-08-17 20:07:35 +00:00
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
e4096e1418
- #27551 : Rename check_output() to check_markup(). Needs contrib updates!
2005-07-29 21:06:33 +00:00
aa2de74fa2
- #27624 , #27614 , #27627 : dead code
2005-07-29 08:18:20 +00:00
bd055961cd
- #25285 : Use correct permission for node form comment admin
2005-07-25 09:41:29 +00:00
50dac6f671
- Fixed typo reported by Stefan: theem -> theme
2005-07-20 15:13:12 +00:00
13954f90dd
- Modified patch #18656 by Moshe: unifies the admin comment form and the usual comment form, similar to what we did for nodes. This resulted lots of duplicate code removal. Also gave administrators the ability to change the author and timestamp of a comment. Also removed comment links from the bottom of the comment preview box (as we did for nodes)
...
Modifications: fixed breadcrumbs, tidied up delete confirmation page to be consistent with node deletions..
2005-07-19 17:51:59 +00:00
160a1e0ef8
- Patch #25634 by chx: simplified node_load().
2005-07-17 18:29:32 +00:00
02460ed9d8
- Removed tab.
2005-07-05 19:31:36 +00:00
2c10ff4b5f
- Fixed problems with filter formats and problem with XML-RPC server.
2005-06-29 19:53:14 +00:00
58aee8cdad
- Patch #25603 by Stefan: made the sizes of forms consistent.
...
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
e550f84162
- Patch #16204 by Thox: committed the collapsible form elements patch.
...
NOTE: this patch works well, but the improved node edit form still has
some rough edges. It is important that we continue to improve
usability. Give it a try.
2005-06-21 09:45:45 +00:00
21274fbb94
- #23285 : Allow theming of comment previews, like node previews.
2005-05-22 21:14:59 +00:00
e5ecab0797
- Patch #22804 by Cvbge: fixed typo in documentation.
2005-05-14 17:23:18 +00:00
381853c6b9
- Patch #21221 by Robert: make status values in comment.module defined constants for readability.
2005-05-05 20:12:49 +00:00
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
8f1e9cd720
- Modified patch #18215 by ankur: make sure the comment statistics update after approval in the moderation queue.
2005-04-08 13:34:10 +00:00
a21f084160
- Patch by Drumm: change the wording for clarity.
2005-04-08 13:06:37 +00:00
961cf7af44
- By default, do not show comment controls.
2005-04-07 05:24:08 +00:00
29f6541c5e
- Patch #20103 by Neil: Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway.
2005-04-07 05:21:30 +00:00
a3e9b35afc
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
2005-04-01 15:55:02 +00:00
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
5ad5f28cda
- Patch #19009 by chx: fixed a bug with comment replies letting one access nodes.
2005-03-20 19:42:14 +00:00
c3f1f7345e
- #18939 (Stefan): Always use paragraph tags around page help text.
2005-03-18 07:07:04 +00:00
332a56334d
- Patch #17161 by Morbus: increase 40-character limit in URL field for comments.
2005-03-16 22:14:15 +00:00
3b5589f436
- Patch #14109 by wulff/Morbus: added missing t() funciton
2005-03-16 19:31:47 +00:00
a16e5d2492
- Patch #18692 by Goba: old comments (comments for nodes having no entry in the history table anymore) are counted as new comments, since the timestamp retrieved from the history table is used to check for new comments (which is 0, if an entry was not found). This patch sets the timestamp used to check for new comments to the NODE_NEW_LIMIT value at least (which is when the history table was/should have been pruned).
2005-03-12 08:52:29 +00:00
2ec787df34
- Patch #18676 by frjo: When anonymuos users are allowed to add comments there are a required e-mail field. This field are, as far as i can see, not shown publicly. A user asked me about this and after confirming that it is not shown publicly I added a description that inform the users of this. I have included a patch that add the description "The content of this field is kept private and will not be shown publicly". This is the same description that is used by the profile module.
2005-03-10 18:28:21 +00:00
198ec98f75
#18329 : Unify confirmation messages (and make them themable)
2005-03-03 20:51:27 +00:00
a794dd4419
- #17877 : Auto-fill comment subject during _validate rather than _save.
2005-02-27 02:56:12 +00:00
5b7ecb8650
- Patch #17208 by asimmonds: help text fixes:
...
- permissions menu link updates in a number of modules help
- anchor link fix in distributed auth help
- "my account" link fix in user help
- spelling correction in tracker.module help
- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
9c5646288c
- Patch #11366 by Junyor: fixed twin comment problem in HEAD.
2005-02-11 19:01:53 +00:00
fbec279e4c
- Patch #16246 by Moshe: added mechanism to direct the user back to the referring page after completing a form.
...
(Moshe: the patch against node.module failed to apply.)
2005-02-01 19:45:58 +00:00
7ae04af1e0
- Patch by Jose A Reyero: fixed probem with db_rewriste_sql() in the comment.module.
2005-01-31 19:30:13 +00:00
59c2208ea6
- Patch #16253 by Goba: incremental improvements to the new content markers.
...
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
993ea0c6c5
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
2005-01-29 22:02:37 +00:00
467dbdc4a1
- Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though.
2005-01-27 12:57:08 +00:00
173f528f59
- Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
...
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
09bd156ba2
- Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
...
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
e7edb55d63
- The real code fixes ;)
2005-01-17 19:00:03 +00:00
971a0e24aa
- Patch #14731 by chx: made it possible to rewrite node queries.
2005-01-16 18:44:49 +00:00
b8b36bd941
- Fix comment pager counting unpublished comments.
2005-01-12 16:02:42 +00:00
bf12368205
- Fix comment pager counting unpublished comments.
2005-01-12 16:02:20 +00:00
df6fe90286
- Updated two watchdog calls.
2005-01-09 10:06:26 +00:00
64b100d19a
- Patch #13260 by UnConeD: watchdog module improvements.
...
We added a 'severity' column to watchdog():
watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);
* Specify a severity in case you are reporting a warning or error.
* The $link-parameter is now the fourth parameter instead of the third.
TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
1dbe0dc2ee
- Patch #14917 by UnConeD/Steven:
...
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.
2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.
3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
09c55017f6
- Patch #14882 by Jeremy: removed some cruft: status = 2 is no more.
2004-12-29 18:41:52 +00:00
b2e04ead89
- Patch #14710 by tangent: only show post button if preview is optional or if we are in preview mode. We show the post button in preview mode even if there are form errors so that optional form elements (e.g., captcha) can be updated in preview mode.
2004-12-23 06:47:24 +00:00
e7b0b227b9
Making comment moderation query PGSQL/ANSI compatible.
2004-12-20 02:05:00 +00:00
2b17b3a966
- Patch #13907 by Neil: less ways to set the page title.
...
* Less logic in theme code.
* Encourages use of the menu system.
* Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
* Very slightly more efficient.
2004-12-15 21:19:42 +00:00
260f886699
- Fixed typo: db_queryd() -> db_query()
2004-12-11 12:26:40 +00:00
d61e7a663e
- Bugfix: make sure to update the node_comment_statistics table when a node is updated.
2004-12-11 11:41:17 +00:00
60352821bf
- Refactored the queue module: removed the queue module's field from the node table. With help from Gerhard.
...
- Slight addition to INSTALL.txt with regard to PHP versions.
- Updated/reworded some node type descriptions as per Boris' suggestions.
- Adding missing {} around a table name in update.php.
2004-12-07 16:55:38 +00:00
e4a3b6f89f
- Patch #13816 by Neil: tidied up the comment module code a bit.
2004-12-02 20:24:53 +00:00
95610bdd6c
- Patch #13647 by Goba:
...
1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
2. Removed t() functions from user contributed content.
2004-11-29 17:52:35 +00:00
e35137a5ad
- Patch #12555 by svemir: fixed problem with the 'Preview comment' button not being present when previews are optional.
2004-11-29 12:59:21 +00:00
b442fad027
- Patch #13263 and #13265 by arnab: added word-based truncation and made the comment module use it to extract subjects.
2004-11-21 20:17:44 +00:00
fa97839088
- Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
...
Read the manual for pg_escape_string: "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
9979aceab0
- Patch #12783 by Stefan: various small consistency/usability improvements.
2004-11-15 11:16:39 +00:00
b3adcf05a3
- Patch #11875 by Neil Drumm: block module configuration improvements.
...
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
8daed9cbf3
- Patch #12232 by Steven/UnConed: search module improvements.
...
1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
2004-10-31 03:03:27 +00:00
3e406e8f40
#12128 : Change label for comment subject settings to match behaviour;
2004-10-28 23:56:14 +00:00
b2f8787c90
Comment deleting broken
2004-10-18 20:10:18 +00:00
a423eefe95
- Patch #11670 by TDobes: comment.module did not properly set a breadcrumb for creating/previewing new comments. The node on which your commenting and its location within the menu is not displayed. Instead, there is only a "Home" link. This is especially apparent when the "add new comment" form is set up to display on a separate page.
2004-10-17 19:09:09 +00:00
7ebd772f41
- Patch #10664 by TDobes: fixed collapsed comments + updated the code comments.
2004-10-16 07:22:26 +00:00
7cf0e9af33
- Patch #9252 by TDobes: admins should be able to edit anonymous commenters' names.
2004-10-15 16:57:20 +00:00
49dcf84fdf
- Patch #11605 by TDobes: if a user happens to have uid=0 defined in their database, the name assigned to that user will always override any name submitted by an anonymous commenter. Checking against $user->uid instead of $user->registered_name fixes this problem.
2004-10-15 11:13:11 +00:00
dfb3c3aec4
- Patch #11577 by drumm: changed t('ago') -> t('%time ago', ...) to make it
...
translatable in languages such as Spanish.
2004-10-15 05:10:35 +00:00
9e4399aae8
#10677 : Confirmation when deleting a block + unifying confirmation screens.
2004-10-14 15:28:24 +00:00
b5806c7595
#11503 : Fixing bad t()
2004-10-13 20:29:12 +00:00
a185443ed3
#11503 : consistency improvements by Stefan
2004-10-12 16:16:22 +00:00
2c4a82bda2
#11503 : (more) missing t()
2004-10-12 16:10:54 +00:00
5407b630e3
- Orphaned the node_link() hook as per #9769 .
2004-10-10 11:12:57 +00:00
bc5ec8ea09
- Fixed critical bug #10664 : made comment in collapsed mode work. One more down.
2004-10-10 10:56:59 +00:00
f8e532f714
- Patch #4925 by erikhopp: comment module emits too many id="comment"s, so the comment form's one has been renamed to 'comment-form'. This is also more consistent with the 'node-form' one.
2004-10-09 06:43:50 +00:00
bd7d38bd5b
Hopefully fixing all filter issues with comments.
2004-10-07 14:33:54 +00:00
Dries Buytaert
Gábor Hojtsy
Steven Wittens
Neil Drumm
Gerhard Killesreiter