Gábor Hojtsy
b7a2becd15
#197314 by vitezslav.smid (as GHOP 39): improve/add/update phpdoc in aggregator, comment and system modules
2007-12-16 21:01:45 +00:00
Gábor Hojtsy
b6532a4fdb
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
2007-12-14 18:08:50 +00:00
Gábor Hojtsy
c6d841c096
#197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc
2007-12-13 09:34:40 +00:00
Gábor Hojtsy
5622bce2d5
#198579 by webernet and hswong3i: a huge set of coding style fixes, including:
...
- whitespaces at end of lines
- indentation
- control structure usage
- whitespace in empty lines
- phpdoc comment formatting
2007-12-08 14:06:23 +00:00
Gábor Hojtsy
d83289f857
#196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions
2007-12-06 09:58:34 +00:00
Gábor Hojtsy
259e2f5c7e
#195678 by catch: standardise on Save and Preview button terminology (for comments) and button placement for comments and nodes, so Save is always the leftmost button, and there is no guessing to find it
2007-11-29 11:54:37 +00:00
Gábor Hojtsy
f77b60f291
#195543 by hass and yhager: CSS inherit was completely misused in RTL CSS files
2007-11-27 12:09:27 +00:00
Gábor Hojtsy
22a4c039da
Rollback the accidentally committed #194310
2007-11-26 19:55:15 +00:00
Gábor Hojtsy
e6a88be5d1
#193333 by quicksketch et al: taxonomy drag and drop support
2007-11-26 19:46:52 +00:00
Gábor Hojtsy
c856eac135
#191104 by keith.smith: (usability) change occurances of node to 'post' and 'content' as appropriate
2007-11-12 19:06:33 +00:00
Dries Buytaert
beb7cfa80e
- Patch #190483 by webernet et al: tiny code cleanup.
2007-11-09 07:46:10 +00:00
Gábor Hojtsy
678773e364
#189837 by chx: remove temporary table usage from comment_enable(). Now we require MySQL 4.1 and it has constructs which make this unnecessary.
2007-11-07 15:54:49 +00:00
Gábor Hojtsy
e9f7072edd
#186749 by Rob Loach and myself: (regression) only override comment submitter name with anonymous name, if it was not provided already
2007-11-05 14:25:58 +00:00
Gábor Hojtsy
d1c46eadeb
#187391 by jrbeeman, catch: redirect user to proper node comment page after submitting a new comment
2007-11-04 16:11:33 +00:00
Gábor Hojtsy
510bb1a42f
#93425 by bjaspan: remove pre-Drupal 4.6 era destination handling cruft carried over in comment module
2007-11-04 15:15:47 +00:00
Gábor Hojtsy
91e980a271
#187881 by mooffie: fix misnamed database table names in schema documentation
2007-11-04 14:33:07 +00:00
Dries Buytaert
b99aab8381
- Patch #163499 by Crell et al: split up comment module.
2007-10-31 17:50:47 +00:00
Gábor Hojtsy
b036bef620
#185867 by hunmonk: (usability) add node title to comment overview page for easier identification
2007-10-25 10:28:05 +00:00
Gábor Hojtsy
4e187261ab
#177497 by chx and Desbeers: revive Drupal 5's menu_set_location() functionality by introducing menu_set_item() (for consistency in function naming), thus fixing a regression in the current development code. Also fixing some misuse of menu_set_location() by using drupal_set_breadcrumb() instead.
2007-10-25 08:24:43 +00:00
Gábor Hojtsy
b94f2716cf
#184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed
2007-10-21 18:59:02 +00:00
Gábor Hojtsy
b64adf07c8
#182645 by scor: clean up concatenations to be in line with core coding standards
2007-10-19 10:19:03 +00:00
Gábor Hojtsy
6417a6ade4
#55277 by catch and JirkaRybka: when flat comment view is used, order comments by cid (ie. original submission order) instead of timestamp (ie. last editing time order) to avoid comments jumping around when being edited
2007-10-16 14:22:00 +00:00
Gábor Hojtsy
0a61aff251
#183390 by hunmonk: forms should use form_state['redirect'] for redirection, not drupal_goto() - fix this in comment_admin_overview_submit()
2007-10-15 15:57:15 +00:00
Dries Buytaert
b274bf87f3
- Patch #182950 : fieldset massaging for usability.
2007-10-12 14:10:18 +00:00
Gábor Hojtsy
09e2701892
#181088 by fajerstarter, catch and JirkaRybka: rename 'access control' to 'permissions' for usability reasons
2007-10-12 10:41:48 +00:00
Gábor Hojtsy
8cf6fefe54
#164983 by multiple contributors: document the core database schemas
2007-10-10 11:39:35 +00:00
Gábor Hojtsy
1a2bf588e6
#63990 by several people: fix comment submission on nodes where a form is displayed
2007-10-08 14:22:31 +00:00
Dries Buytaert
ca8e9a1e18
- Patch #180432 by hunmonk, sun, et al: make comment settings per node type. This is a new feature that slipped in because it is required for the project module on drupal.org.
2007-10-07 19:25:57 +00:00
Dries Buytaert
39706e3c51
- Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes.
2007-10-05 14:43:26 +00:00
Gábor Hojtsy
071d4b010e
#180559 by hunmonk: do not try to display the comment addition form at th end of comments, if we are already on the page, so it is displayed anyway
2007-10-03 17:59:50 +00:00
Gábor Hojtsy
b03af772d7
#174233 by webernet: fix notices when editing comments and also fix a moderation bug along the way
2007-09-28 17:15:04 +00:00
Dries Buytaert
be091880f4
- Patch #124979 by chx: remove the auto_increment.
2007-09-26 18:31:34 +00:00
Gábor Hojtsy
cd517f16e9
#177927 by chx: use path=/ in PHP comment settings cookie creation, so cookies set around the site are available in other 'directories'
2007-09-25 14:58:43 +00:00
Gábor Hojtsy
21ac9f1917
#174708 by multiple contributors: update jQuery to 1.2
2007-09-12 18:29:32 +00:00
Gábor Hojtsy
ac7637bc9b
#172773 by numerous contributors: Make the actions interface usable by mere mortals (including rename of actions.module to trigger, but keeping the actions themselfs).
...
Complete previous history of actions module:
- #148410 by jvandyk: added rewrite of the actions module!
- #155986 by Uwe: fixed typos.
- #155828 by Eaton, pwolanin and jvandyk: let actions live even if actions.module is not turned on
2007-09-11 14:50:05 +00:00
Gábor Hojtsy
67e5859a7f
#172376 by ChrisKennedy: fix 8 E_ALL issues in comment module and fix approval queue
2007-09-06 12:21:39 +00:00
Dries Buytaert
ab1715750a
- Patch #172961 by webernet: code style cleanup.
2007-09-05 08:42:02 +00:00
Dries Buytaert
2db2c039fb
- Patch #172950 by webernet: code style fixes.
2007-09-04 21:10:45 +00:00
Gábor Hojtsy
e310d9e4a4
#6162 by various people: actually point new anchors to the page the first new comment is displayed (in a multipage comment view)
2007-09-02 14:56:18 +00:00
Gábor Hojtsy
c07305d060
#172149 by dvessel: add semicolons, so the JS aggregator works
2007-09-01 07:08:11 +00:00
Dries Buytaert
00181ecb39
- Removing whitespace.
2007-08-30 19:54:22 +00:00
Gábor Hojtsy
4e0071fb8a
#111127 rollback by chx, slightly extended: roll back node_load cache, it needs more thought and discussion, so postponed until at least Drupal 7
2007-08-30 15:31:46 +00:00
Gábor Hojtsy
d8b17c9f19
#156475 by Christoph C. Cemper and greggles: actually call the publish op on hook_comment when a comment is first (automatically) published
2007-08-29 17:01:33 +00:00
Dries Buytaert
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
Gábor Hojtsy
801756e7e6
#111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op)
2007-08-25 09:25:49 +00:00
Dries Buytaert
c17499b6fe
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement. (Correct version this time.)
2007-08-12 16:12:00 +00:00
Dries Buytaert
b134b023e1
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement.
2007-08-12 15:55:36 +00:00
Dries Buytaert
a5fcb369fb
- Patch #166205 by hswong3i: improved database compatibility of db_result(). Makes it work with DB2, Oracle, etc.
2007-08-11 14:14:46 +00:00
Gábor Hojtsy
f23c24c8a3
#164935 by Ralf Stamm: standardize CVS Id tags in files:
...
- always include CVS Id tags in all files
- add a new line after the CVS Id, if more code or phpdoc follows in the same code block
- fix bogus Id tags previously added
2007-08-07 08:39:36 +00:00
Dries Buytaert
d746d35a8f
- Patch #163073 by Robert Douglas: removing dead code.
2007-07-30 21:27:34 +00:00
Gábor Hojtsy
f180790bb7
#161979 noticed by bboyjay, patch by myself: kill noticedisplayed when no comments were selected for the mass operation
2007-07-25 14:57:58 +00:00
Gábor Hojtsy
e3fa6893c2
#124485 by Wesley Tanaka: move some remaining node.css comment styles to the actual comment.css
2007-07-24 21:33:53 +00:00
Dries Buytaert
7d0cf742f7
- Patch #160589 by dvessel: tpl-ify the comment module's theme functions.
2007-07-20 08:51:13 +00:00
Dries Buytaert
0ddff5ee26
- Patch #160491 by dvessel: fixed E_NOTICE warnings.
2007-07-20 08:39:00 +00:00
Dries Buytaert
08c059ec77
- Rollback of patch #147947 : lacks proper upgrade path.
2007-07-15 10:09:21 +00:00
Dries Buytaert
a771c6c45a
- Patch #57106 by Steven et al: future timestamps break search indexing.
2007-07-15 10:05:18 +00:00
Gábor Hojtsy
51b789c0d3
#156778 by asimmonds: revert node and comment deletions to the pre-deletion API state
2007-07-13 20:04:47 +00:00
Dries Buytaert
4ff46202cb
- Patch #157773 by pwolanin: remove node/%/% from comment_menu.
2007-07-09 17:05:49 +00:00
Gábor Hojtsy
806d0a3dee
#156910 by asimmonds: fix code indentation problems introduced with new code in this development cycle; only whitespace changes
2007-07-05 08:48:58 +00:00
Gábor Hojtsy
1b503eaac9
#128165 by joshk and webchick: missing db_rewrite_sql() calls in comment queries
2007-07-04 22:24:40 +00:00
Dries Buytaert
ee701b3336
- Patch #155986 by Uwe: fixed typos.
2007-07-02 14:41:37 +00:00
Gábor Hojtsy
3409019929
#146386 by kbahey: refactor 'submitted by user - date' themeing and make it more verbose to translate
2007-07-01 23:15:41 +00:00
Dries Buytaert
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Dries Buytaert
c11cb4ec24
- Patch #120360 by nedjo: enable AJAX by making all behaviours reattachable.
2007-07-01 15:37:10 +00:00
Gábor Hojtsy
9e6ef53c2c
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
2007-06-30 19:46:58 +00:00
Dries Buytaert
2348e7de6f
- Patch #148410 by jvandyk: added rewrite of the actions module!
...
This is a very important patch, but one that is merely an enabler.
Hopefully we'll see more people submitting "action patches" in the
near future.
Thanks for the hard work and persistence, John. *If* you decide
to update the Drupal Pro Development book to Drupal 6, make sure
to add a chapter on actions. ;)
2007-06-29 18:06:51 +00:00
Steven Wittens
7093495f7c
#154046 : Optimize confirm_form syntax for common usage (and fix some $form_state bugs).
2007-06-24 10:09:53 +00:00
Steven Wittens
028c8e6050
#148678 : Fix notices/warnings on invalid paths like 'node/zzz'. (chx/pwolanin/webernet)
2007-06-24 00:38:40 +00:00
Steven Wittens
38a1300df2
#147723 : Deletion API (by hunmonk). Woop woop.
2007-06-22 05:44:21 +00:00
Dries Buytaert
ae0392b2eb
- Patch #147947 by hswong3i: some files shouldn't defined as text:big for Oracle compatibility.
2007-06-15 07:15:25 +00:00
Dries Buytaert
0d5e968823
- Patch #82526 by Moshe: simplified APIs -- use form_alter now.
2007-06-15 07:10:47 +00:00
Dries Buytaert
42667a6328
- Patch #142829 by webchick and gurpartap singh: pave the path to allow comment-.tpl.php.
2007-06-11 14:56:40 +00:00
Dries Buytaert
29eb5a6284
- Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version.
2007-06-08 05:50:58 +00:00
Dries Buytaert
27388f6655
- Patch #149176 by chx, David et al: getting rid of the sequences table, using db_last_insert_id() instead of db_next_id().
2007-06-05 12:13:23 +00:00
Dries Buytaert
2a3744c572
- Patch #149339 by Ted: removed unnecessary heavy query.
2007-06-05 09:22:22 +00:00
Dries Buytaert
e629deb94d
- Patch #146667 by Jeff Eaton: form API fixes.
2007-06-04 15:56:34 +00:00
Dries Buytaert
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
Dries Buytaert
556ef56c52
- Patch #147417 by robertDouglas: only save cookie for anonymous users.
2007-05-29 06:27:37 +00:00
Dries Buytaert
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
Gábor Hojtsy
860947d3c8
#145737 by yhager, documentation cleaned up by myself: add support for RTL CSS overrides and default RTL CSS override files for modules
...
Note: properties, which are different in the RTL display are marked with /* LTR */ in default CSS files now,
so maintainers remember that changing them should also have an effect on RTL CSS files.
This should open the way for better RTL (right-to-left written) language (such as Arabic and Hebrew) support.
2007-05-27 17:57:48 +00:00
Dries Buytaert
4a6f5869e5
- Patch #142773 by kbahey: made Drupal work correctly when behind a reverse proxy.
2007-05-25 15:04:42 +00:00
Dries Buytaert
3cafffe63f
- Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave.
2007-05-25 12:46:46 +00:00
Dries Buytaert
2934a3d9bd
- Patch #144859 by dww: added optional e-mail notifications when user are approved, blocked, or deleted.
2007-05-20 12:34:48 +00:00
Dries Buytaert
b86d106e0e
- Patch #141131 by mfer: fixed UTF-8 problem.
2007-05-20 07:30:03 +00:00
Dries Buytaert
da7f952a45
- Patch #141131 by mfer: remember anonyous comment posters.
2007-05-17 21:05:38 +00:00
Dries Buytaert
d1e28d4273
- Patch #141131 by mfer: remember anonyous comment posters.
2007-05-17 20:57:19 +00:00
Dries Buytaert
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00
Dries Buytaert
7d4f2836ba
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
2007-04-30 17:03:29 +00:00
Dries Buytaert
29055d34d6
- Patch #137236 by merlinofchaos: provide a way to secure the theme variables system.
2007-04-27 07:42:54 +00:00
Gábor Hojtsy
359ace36e6
#76588 patch by alienbrain: some localization-unfriendly watchdog() calls
2007-04-24 18:23:48 +00:00
Dries Buytaert
e675979091
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
2007-04-13 08:56:59 +00:00
Dries Buytaert
083a6a274d
- Patch #134185 by Ralf Stamm: missing CVS IDs in files.
2007-04-13 07:33:24 +00:00
Dries Buytaert
b9b015ff19
- Patch #130366 by webchick and Steven: make signatures pretty.
2007-04-09 13:41:10 +00:00
Dries Buytaert
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
Steven Wittens
f3cd2da113
#130991 : Custom menu items, part 1
2007-04-06 04:39:51 +00:00
Steven Wittens
a2baa44499
#130366 : Better styling for signature separator (thanks webchick).
2007-04-01 05:04:20 +00:00
Dries Buytaert
9e94bb6101
- Patch #130366 by webchick and steven: improved signature handling. Step 1 of 2.
2007-03-30 07:45:20 +00:00
Dries Buytaert
630277cc89
- Patch #110888 by Heine: fixed drupal_alter glitch().
2007-03-29 23:19:33 +00:00
Steven Wittens
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
Dries Buytaert
eb6b848de6
- Patch #110888 by Eaton: unify hook _alter()
2007-03-26 00:35:59 +00:00