Commit Graph

5208 Commits (02938481995664b80b8711a5e1b74f7e9f3e65f9)

Author SHA1 Message Date
Dries Buytaert 0293848199 - Patch by chx: made form tokens work. 2006-01-25 13:59:05 +00:00
Dries Buytaert b8832d76a0 - Patch #40753 by wtanaka/killes: #comment-form has disappeared from comment.module 2006-01-25 08:54:40 +00:00
Dries Buytaert 53a2ca41b4 - Patch #23538 by Zen: mark required fields are being required. The new forms API will enforce this too. :) 2006-01-25 08:52:47 +00:00
Dries Buytaert 552b5e5e7a - Patch #46227 by yogadex: fixed problem with form validation. 2006-01-25 08:40:53 +00:00
Dries Buytaert d20ed7e3be - Patch #45665 by wtanaka/moshe: removed dead code! w00t! 2006-01-24 18:32:20 +00:00
Dries Buytaert 42c5683d41 - Patch #45845 by jaza/chx: set default value of weight-selectors to 0 for consistency with Drupal 4.6. 2006-01-24 18:27:29 +00:00
Dries Buytaert 8a59ab233e - Patch #46076 by markus: add CVS ids to database schemas. 2006-01-24 18:23:41 +00:00
Dries Buytaert 4dd63e0385 - Patch #46183 by chx: made maintenance mode work again. 2006-01-24 18:18:41 +00:00
Dries Buytaert 6f978a04f9 - Patch #45793 by chx: fixed bug in user.module that results in storing plain text passwords. 2006-01-24 10:15:03 +00:00
Dries Buytaert 4c83a0347a - Patch #36591 by chx: use session id to check form submissions, rather than the IP address. 2006-01-24 10:13:27 +00:00
Dries Buytaert 2fa3490ebf - Patch #46106 by markus: usability improvement: moved the block description textfield up. 2006-01-24 08:38:29 +00:00
Dries Buytaert ba0219e403 - Patch #21719 by rkerr: made db passwords with special characters work. 2006-01-24 08:29:33 +00:00
Dries Buytaert 576399c1f4 - Modified patch #37754 by Thomas: made the status message show up. 2006-01-24 08:26:21 +00:00
Dries Buytaert 3c6066cffa - Patch #45706 by markus: keep up with CSS improvements. 2006-01-24 08:22:12 +00:00
Dries Buytaert b9f6b72a58 - Patch #45834 by jvandyk: removed forms API warnings. 2006-01-24 08:20:45 +00:00
Dries Buytaert af43886456 - Patch #33861 by Morbus et al: clean up the watchdog view. 2006-01-24 08:18:26 +00:00
Dries Buytaert 100db62511 - Patch #44828 by chx: fixed incorrect return value. 2006-01-23 11:15:54 +00:00
Dries Buytaert bc9cbefa30 - Patch #45729 by markus, jvandyk, moshe: fixed problem with permission checking. 2006-01-23 08:06:43 +00:00
Dries Buytaert 1766d40093 - Patch #44828 by chx/Crell: make sure the url/path is properly initialized in statistics_exit(). 2006-01-23 07:54:08 +00:00
Dries Buytaert ca9f0fab45 - Patch #45854 by Jaza: fixed problem with menu_rebuild(). 2006-01-23 07:27:18 +00:00
Steven Wittens 87da28f8d4 - #40515: PHP 5.1.1+ does not recognize \{ 2006-01-23 01:36:09 +00:00
Steven Wittens c4e6137901 - Remove left-over moderation tables from UTF-8 update 2006-01-22 18:38:34 +00:00
Steven Wittens a1e4655bbc - #44939: Fix Unicode autocomplete in IE 2006-01-22 17:37:41 +00:00
Dries Buytaert 14ae238973 - Patch #45320 by Zen: improved usability of off-line mode. 2006-01-22 07:51:06 +00:00
Dries Buytaert 30acded344 - Patch #45697 by fgm: removed some useless global. 2006-01-22 07:43:19 +00:00
Dries Buytaert 542e6e0d22 - Patch #33102 by Kobus et al: show dates properly. 2006-01-22 07:37:17 +00:00
Dries Buytaert 5651357117 - Patch #44379 by Cvbge: removed default roles. 2006-01-22 07:34:41 +00:00
Dries Buytaert 4267ab5ea9 - Patch #45706 by markus: keeping up with CSS improvements. 2006-01-22 07:32:55 +00:00
Dries Buytaert b9240f63d7 - Patch #45684 by wtanaka: added missing ''s 2006-01-22 07:31:38 +00:00
Dries Buytaert e21b5be8d8 - Patch #45747 by Cvbge: documentation improvement + added primary key that got lost 2006-01-22 07:30:47 +00:00
Dries Buytaert b6b98bb60d - Patch #44101 by Cvbge: deleting a comment creates incorrect entry in node_comment_statistics. 2006-01-22 07:26:33 +00:00
Dries Buytaert 25f13a64c4 - Patch #45843 by markus: roles are no longer required. 2006-01-22 07:23:58 +00:00
Steven Wittens da6983ca2a - #40515: Make utf-8 update PHP5 compatible 2006-01-21 11:55:53 +00:00
Dries Buytaert 4be34db2c1 - Patch #45228 by m3avrck: fixed aggregator CSS. 2006-01-21 08:29:28 +00:00
Dries Buytaert 4da4f4c1af - Patch #44379 by Moshe: code improvements: always grant the 'authenticated user' role to authenticated users. Fixed glitch with udpate path. 2006-01-21 08:28:55 +00:00
Steven Wittens 7914ad0f3f - #40515: Ensure UTF-8 character set on the database side (and include upgrade path for incorrectly set up databases) 2006-01-21 01:42:52 +00:00
Dries Buytaert 0ff0c4beaa - Patch #42137 by Richard: deleting non existent user blocks the whole drupal site. 2006-01-20 09:37:00 +00:00
Dries Buytaert 4da1540a9f - Patch #45380 by Neil: usability improvement: disable anonymous commenting options when anonymous people can't comment. 2006-01-20 09:33:03 +00:00
Dries Buytaert 55c88ae09c - Added . 2006-01-20 09:30:12 +00:00
Dries Buytaert e38f0403a3 - Patch #45451 by wtanaka: added explanation for the red star. 2006-01-20 09:19:21 +00:00
Dries Buytaert a177c29622 - Patch #40849 by wtanaka and Richard: killed some menu.inc warnings/notices. 2006-01-20 09:12:26 +00:00
Dries Buytaert 9c4d4fe7b2 - Patch #45228 and patch #45025 by m3avrck and Uwe: aggregator module HTML/CSS cleanups. 2006-01-20 09:09:18 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert 4a7abb95b6 - Patch #45312 by Robin and Zen: made theme_user_list() more like theme_item_list(), made it robust for empty lists. 2006-01-20 08:58:09 +00:00
Dries Buytaert 56d0d76f0f - Patch #27884 by gordon: js addLoadEvent not working. 2006-01-20 08:54:07 +00:00
Dries Buytaert 10d7f7731b - Patch #45281 by chx: made categories with forum topics work again. 2006-01-19 17:55:54 +00:00
Dries Buytaert 616544667f - Patch #45281 by flevour/chx: fixed problem with categories not being set properly validated. 2006-01-19 17:53:53 +00:00
Dries Buytaert 630e820ed0 - Patch #45446 by jakeg: don't generate empty >> 2006-01-19 10:29:12 +00:00
Dries Buytaert 4c1522e962 - Patch #45336 by Ber: bugfix: removed obsolete check_plain() check causing & problems. 2006-01-19 09:26:15 +00:00
Dries Buytaert 7b87ff1a6f - Patch #45365 by chx: critical bugfix: Fix and simplify selection options. 2006-01-19 09:22:16 +00:00