ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
mbed-os/libraries/mbed/targets/hal/TARGET_NXP/TARGET_LPC13XX
History
Adam Green 5d27f98c7b serial_putc() can cause rx bytes to be dropped 
While fixing this issue in the various LPC* ports, I noticed a comment
pointing to this mbed forum post which summarizes this bug quite well:
  https://mbed.org/forum/bugs-suggestions/topic/4473/

This bug was introduced in the following commit:
2662e105c4

The following code was added to serial_putc() as part of this commit:
    uint32_t lsr = obj->uart->LSR;
    lsr = lsr;
    uint32_t thr = obj->uart->THR;
    thr = thr;

As the forum post indicates, this causes the serial_putc() routine to
actually eat an inbound received byte if it exists since reading THR is
really reading the RBR, the Receiver Buffer Register.  This code looks
like code that was probably added so that the developer could take a
snapshot of these registers and look at them in the debugger.  It
probably got committed in error.
 		2013-09-07 00:44:44 -07:00
..
PeripheralNames.h Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
PinNames.h [LPC1347] Change LED pin names 2013-07-17 15:27:10 +03:00
PortNames.h Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
analogin_api.c [LPC1347]: first implementation of analogIn (not tested) 2013-07-17 15:17:19 +03:00
device.h [LPC1347] Added GPIO interrupts 2013-07-17 15:17:20 +03:00
gpio_api.c Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
gpio_irq_api.c [LPC1347] Added GPIO interrupts 2013-07-17 15:17:20 +03:00
gpio_object.h Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
i2c_api.c Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
objects.h [LPC1347] Added GPIO interrupts 2013-07-17 15:17:20 +03:00
pinmap.c Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
port_api.c Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
pwmout_api.c [LPC1347]: first implementation of PWMOut (not tested) 2013-07-17 15:17:09 +03:00
serial_api.c serial_putc() can cause rx bytes to be dropped 2013-09-07 00:44:44 -07:00
sleep.c The LPC1347 board does not have an interface chip 2013-08-06 16:36:03 +01:00
spi_api.c Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00
us_ticker.c Preliminary support for LPC13XX 2013-07-17 14:57:02 +03:00