835 lines
29 KiB
Go
835 lines
29 KiB
Go
/*
|
|
Copyright 2017, 2019 the Velero contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package controller
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"io/ioutil"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/require"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
core "k8s.io/client-go/testing"
|
|
"k8s.io/client-go/tools/cache"
|
|
|
|
api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
|
|
"github.com/vmware-tanzu/velero/pkg/builder"
|
|
"github.com/vmware-tanzu/velero/pkg/generated/clientset/versioned/fake"
|
|
informers "github.com/vmware-tanzu/velero/pkg/generated/informers/externalversions"
|
|
listers "github.com/vmware-tanzu/velero/pkg/generated/listers/velero/v1"
|
|
"github.com/vmware-tanzu/velero/pkg/metrics"
|
|
"github.com/vmware-tanzu/velero/pkg/persistence"
|
|
persistencemocks "github.com/vmware-tanzu/velero/pkg/persistence/mocks"
|
|
"github.com/vmware-tanzu/velero/pkg/plugin/clientmgmt"
|
|
pluginmocks "github.com/vmware-tanzu/velero/pkg/plugin/mocks"
|
|
"github.com/vmware-tanzu/velero/pkg/plugin/velero"
|
|
pkgrestore "github.com/vmware-tanzu/velero/pkg/restore"
|
|
velerotest "github.com/vmware-tanzu/velero/pkg/test"
|
|
"github.com/vmware-tanzu/velero/pkg/util/logging"
|
|
"github.com/vmware-tanzu/velero/pkg/volume"
|
|
)
|
|
|
|
func TestFetchBackupInfo(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
backupName string
|
|
informerLocations []*api.BackupStorageLocation
|
|
informerBackups []*api.Backup
|
|
backupStoreBackup *api.Backup
|
|
backupStoreError error
|
|
expectedRes *api.Backup
|
|
expectedErr bool
|
|
}{
|
|
{
|
|
name: "lister has backup",
|
|
backupName: "backup-1",
|
|
informerLocations: []*api.BackupStorageLocation{builder.ForBackupStorageLocation("velero", "default").Provider("myCloud").Bucket("bucket").Result()},
|
|
informerBackups: []*api.Backup{defaultBackup().StorageLocation("default").Result()},
|
|
expectedRes: defaultBackup().StorageLocation("default").Result(),
|
|
},
|
|
{
|
|
name: "lister does not have a backup, but backupSvc does",
|
|
backupName: "backup-1",
|
|
backupStoreBackup: defaultBackup().StorageLocation("default").Result(),
|
|
informerLocations: []*api.BackupStorageLocation{builder.ForBackupStorageLocation("velero", "default").Provider("myCloud").Bucket("bucket").Result()},
|
|
informerBackups: []*api.Backup{defaultBackup().StorageLocation("default").Result()},
|
|
expectedRes: defaultBackup().StorageLocation("default").Result(),
|
|
},
|
|
{
|
|
name: "no backup",
|
|
backupName: "backup-1",
|
|
backupStoreError: errors.New("no backup here"),
|
|
expectedErr: true,
|
|
},
|
|
}
|
|
|
|
formatFlag := logging.FormatText
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
var (
|
|
client = fake.NewSimpleClientset()
|
|
restorer = &fakeRestorer{}
|
|
sharedInformers = informers.NewSharedInformerFactory(client, 0)
|
|
logger = velerotest.NewLogger()
|
|
pluginManager = &pluginmocks.Manager{}
|
|
backupStore = &persistencemocks.BackupStore{}
|
|
)
|
|
|
|
defer restorer.AssertExpectations(t)
|
|
defer backupStore.AssertExpectations(t)
|
|
|
|
c := NewRestoreController(
|
|
api.DefaultNamespace,
|
|
sharedInformers.Velero().V1().Restores(),
|
|
client.VeleroV1(),
|
|
client.VeleroV1(),
|
|
restorer,
|
|
sharedInformers.Velero().V1().Backups(),
|
|
sharedInformers.Velero().V1().BackupStorageLocations(),
|
|
sharedInformers.Velero().V1().VolumeSnapshotLocations(),
|
|
logger,
|
|
logrus.InfoLevel,
|
|
func(logrus.FieldLogger) clientmgmt.Manager { return pluginManager },
|
|
"default",
|
|
metrics.NewServerMetrics(),
|
|
formatFlag,
|
|
).(*restoreController)
|
|
|
|
c.newBackupStore = func(*api.BackupStorageLocation, persistence.ObjectStoreGetter, logrus.FieldLogger) (persistence.BackupStore, error) {
|
|
return backupStore, nil
|
|
}
|
|
|
|
if test.backupStoreError == nil {
|
|
for _, itm := range test.informerLocations {
|
|
sharedInformers.Velero().V1().BackupStorageLocations().Informer().GetStore().Add(itm)
|
|
}
|
|
|
|
for _, itm := range test.informerBackups {
|
|
sharedInformers.Velero().V1().Backups().Informer().GetStore().Add(itm)
|
|
}
|
|
}
|
|
|
|
if test.backupStoreBackup != nil && test.backupStoreError != nil {
|
|
panic("developer error - only one of backupStoreBackup, backupStoreError can be non-nil")
|
|
}
|
|
|
|
if test.backupStoreError != nil {
|
|
// TODO why do I need .Maybe() here?
|
|
backupStore.On("GetBackupMetadata", test.backupName).Return(nil, test.backupStoreError).Maybe()
|
|
}
|
|
if test.backupStoreBackup != nil {
|
|
// TODO why do I need .Maybe() here?
|
|
backupStore.On("GetBackupMetadata", test.backupName).Return(test.backupStoreBackup, nil).Maybe()
|
|
}
|
|
|
|
info, err := c.fetchBackupInfo(test.backupName, pluginManager)
|
|
|
|
require.Equal(t, test.expectedErr, err != nil)
|
|
assert.Equal(t, test.expectedRes, info.backup)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestProcessQueueItemSkips(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
restoreKey string
|
|
restore *api.Restore
|
|
expectError bool
|
|
}{
|
|
{
|
|
name: "invalid key returns error",
|
|
restoreKey: "invalid/key/value",
|
|
},
|
|
{
|
|
name: "missing restore returns error",
|
|
restoreKey: "foo/bar",
|
|
expectError: true,
|
|
},
|
|
{
|
|
name: "restore with phase InProgress does not get processed",
|
|
restoreKey: "foo/bar",
|
|
restore: builder.ForRestore("foo", "bar").Phase(api.RestorePhaseInProgress).Result(),
|
|
},
|
|
{
|
|
name: "restore with phase Completed does not get processed",
|
|
restoreKey: "foo/bar",
|
|
restore: builder.ForRestore("foo", "bar").Phase(api.RestorePhaseCompleted).Result(),
|
|
},
|
|
{
|
|
name: "restore with phase FailedValidation does not get processed",
|
|
restoreKey: "foo/bar",
|
|
restore: builder.ForRestore("foo", "bar").Phase(api.RestorePhaseFailedValidation).Result(),
|
|
},
|
|
}
|
|
|
|
formatFlag := logging.FormatText
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
var (
|
|
client = fake.NewSimpleClientset()
|
|
restorer = &fakeRestorer{}
|
|
sharedInformers = informers.NewSharedInformerFactory(client, 0)
|
|
logger = velerotest.NewLogger()
|
|
)
|
|
|
|
c := NewRestoreController(
|
|
api.DefaultNamespace,
|
|
sharedInformers.Velero().V1().Restores(),
|
|
client.VeleroV1(),
|
|
client.VeleroV1(),
|
|
restorer,
|
|
sharedInformers.Velero().V1().Backups(),
|
|
sharedInformers.Velero().V1().BackupStorageLocations(),
|
|
sharedInformers.Velero().V1().VolumeSnapshotLocations(),
|
|
logger,
|
|
logrus.InfoLevel,
|
|
nil,
|
|
"default",
|
|
metrics.NewServerMetrics(),
|
|
formatFlag,
|
|
).(*restoreController)
|
|
|
|
if test.restore != nil {
|
|
sharedInformers.Velero().V1().Restores().Informer().GetStore().Add(test.restore)
|
|
}
|
|
|
|
err := c.processQueueItem(test.restoreKey)
|
|
|
|
assert.Equal(t, test.expectError, err != nil)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestProcessQueueItem(t *testing.T) {
|
|
defaultStorageLocation := builder.ForBackupStorageLocation("velero", "default").Provider("myCloud").Bucket("bucket").Result()
|
|
|
|
tests := []struct {
|
|
name string
|
|
restoreKey string
|
|
location *api.BackupStorageLocation
|
|
restore *api.Restore
|
|
backup *api.Backup
|
|
restorerError error
|
|
expectedErr bool
|
|
expectedPhase string
|
|
expectedValidationErrors []string
|
|
expectedRestoreErrors int
|
|
expectedRestorerCall *api.Restore
|
|
backupStoreGetBackupMetadataErr error
|
|
backupStoreGetBackupContentsErr error
|
|
putRestoreLogErr error
|
|
expectedFinalPhase string
|
|
}{
|
|
{
|
|
name: "restore with both namespace in both includedNamespaces and excludedNamespaces fails validation",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "another-1", "*", api.RestorePhaseNew).ExcludedNamespaces("another-1").Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{"Invalid included/excluded namespace lists: excludes list cannot contain an item in the includes list: another-1"},
|
|
},
|
|
{
|
|
name: "restore with resource in both includedResources and excludedResources fails validation",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "*", "a-resource", api.RestorePhaseNew).ExcludedResources("a-resource").Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{"Invalid included/excluded resource lists: excludes list cannot contain an item in the includes list: a-resource"},
|
|
},
|
|
{
|
|
name: "new restore with empty backup and schedule names fails validation",
|
|
restore: NewRestore("foo", "bar", "", "ns-1", "", api.RestorePhaseNew).Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{"Either a backup or schedule must be specified as a source for the restore, but not both"},
|
|
},
|
|
{
|
|
name: "new restore with backup and schedule names provided fails validation",
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "", api.RestorePhaseNew).Schedule("sched-1").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{"Either a backup or schedule must be specified as a source for the restore, but not both"},
|
|
},
|
|
{
|
|
name: "valid restore with schedule name gets executed",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "", "ns-1", "", api.RestorePhaseNew).Schedule("sched-1").Result(),
|
|
backup: defaultBackup().StorageLocation("default").ObjectMeta(builder.WithLabels(api.ScheduleNameLabel, "sched-1")).Phase(api.BackupPhaseCompleted).Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseInProgress),
|
|
expectedRestorerCall: NewRestore("foo", "bar", "backup-1", "ns-1", "", api.RestorePhaseInProgress).Schedule("sched-1").Result(),
|
|
},
|
|
{
|
|
name: "restore with non-existent backup name fails",
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "*", api.RestorePhaseNew).Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{"Error retrieving backup: backup.velero.io \"backup-1\" not found"},
|
|
backupStoreGetBackupMetadataErr: errors.New("no backup here"),
|
|
},
|
|
{
|
|
name: "restorer throwing an error causes the restore to fail",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "", api.RestorePhaseNew).Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
restorerError: errors.New("blarg"),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseInProgress),
|
|
expectedFinalPhase: string(api.RestorePhasePartiallyFailed),
|
|
expectedRestoreErrors: 1,
|
|
expectedRestorerCall: NewRestore("foo", "bar", "backup-1", "ns-1", "", api.RestorePhaseInProgress).Result(),
|
|
},
|
|
{
|
|
name: "valid restore gets executed",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "", api.RestorePhaseNew).Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseInProgress),
|
|
expectedRestorerCall: NewRestore("foo", "bar", "backup-1", "ns-1", "", api.RestorePhaseInProgress).Result(),
|
|
},
|
|
{
|
|
name: "restoration of nodes is not supported",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "nodes", api.RestorePhaseNew).Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{
|
|
"nodes are non-restorable resources",
|
|
"Invalid included/excluded resource lists: excludes list cannot contain an item in the includes list: nodes",
|
|
},
|
|
},
|
|
{
|
|
name: "restoration of events is not supported",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "events", api.RestorePhaseNew).Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{
|
|
"events are non-restorable resources",
|
|
"Invalid included/excluded resource lists: excludes list cannot contain an item in the includes list: events",
|
|
},
|
|
},
|
|
{
|
|
name: "restoration of events.events.k8s.io is not supported",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "events.events.k8s.io", api.RestorePhaseNew).Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{
|
|
"events.events.k8s.io are non-restorable resources",
|
|
"Invalid included/excluded resource lists: excludes list cannot contain an item in the includes list: events.events.k8s.io",
|
|
},
|
|
},
|
|
{
|
|
name: "restoration of backups.velero.io is not supported",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "backups.velero.io", api.RestorePhaseNew).Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{
|
|
"backups.velero.io are non-restorable resources",
|
|
"Invalid included/excluded resource lists: excludes list cannot contain an item in the includes list: backups.velero.io",
|
|
},
|
|
},
|
|
{
|
|
name: "restoration of restores.velero.io is not supported",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore("foo", "bar", "backup-1", "ns-1", "restores.velero.io", api.RestorePhaseNew).Result(),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
expectedErr: false,
|
|
expectedPhase: string(api.RestorePhaseFailedValidation),
|
|
expectedValidationErrors: []string{
|
|
"restores.velero.io are non-restorable resources",
|
|
"Invalid included/excluded resource lists: excludes list cannot contain an item in the includes list: restores.velero.io",
|
|
},
|
|
},
|
|
{
|
|
name: "backup download error results in failed restore",
|
|
location: defaultStorageLocation,
|
|
restore: NewRestore(api.DefaultNamespace, "bar", "backup-1", "ns-1", "", api.RestorePhaseNew).Result(),
|
|
expectedPhase: string(api.RestorePhaseInProgress),
|
|
expectedFinalPhase: string(api.RestorePhaseFailed),
|
|
backupStoreGetBackupContentsErr: errors.New("Couldn't download backup"),
|
|
backup: defaultBackup().StorageLocation("default").Result(),
|
|
},
|
|
}
|
|
|
|
formatFlag := logging.FormatText
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
var (
|
|
client = fake.NewSimpleClientset()
|
|
restorer = &fakeRestorer{}
|
|
sharedInformers = informers.NewSharedInformerFactory(client, 0)
|
|
logger = velerotest.NewLogger()
|
|
pluginManager = &pluginmocks.Manager{}
|
|
backupStore = &persistencemocks.BackupStore{}
|
|
)
|
|
|
|
defer restorer.AssertExpectations(t)
|
|
defer backupStore.AssertExpectations(t)
|
|
|
|
c := NewRestoreController(
|
|
api.DefaultNamespace,
|
|
sharedInformers.Velero().V1().Restores(),
|
|
client.VeleroV1(),
|
|
client.VeleroV1(),
|
|
restorer,
|
|
sharedInformers.Velero().V1().Backups(),
|
|
sharedInformers.Velero().V1().BackupStorageLocations(),
|
|
sharedInformers.Velero().V1().VolumeSnapshotLocations(),
|
|
logger,
|
|
logrus.InfoLevel,
|
|
func(logrus.FieldLogger) clientmgmt.Manager { return pluginManager },
|
|
"default",
|
|
metrics.NewServerMetrics(),
|
|
formatFlag,
|
|
).(*restoreController)
|
|
|
|
c.newBackupStore = func(*api.BackupStorageLocation, persistence.ObjectStoreGetter, logrus.FieldLogger) (persistence.BackupStore, error) {
|
|
return backupStore, nil
|
|
}
|
|
|
|
if test.location != nil {
|
|
sharedInformers.Velero().V1().BackupStorageLocations().Informer().GetStore().Add(test.location)
|
|
}
|
|
if test.backup != nil {
|
|
sharedInformers.Velero().V1().Backups().Informer().GetStore().Add(test.backup)
|
|
}
|
|
|
|
if test.restore != nil {
|
|
sharedInformers.Velero().V1().Restores().Informer().GetStore().Add(test.restore)
|
|
|
|
// this is necessary so the Patch() call returns the appropriate object
|
|
client.PrependReactor("patch", "restores", func(action core.Action) (bool, runtime.Object, error) {
|
|
if test.restore == nil {
|
|
return true, nil, nil
|
|
}
|
|
|
|
patch := action.(core.PatchAction).GetPatch()
|
|
patchMap := make(map[string]interface{})
|
|
|
|
if err := json.Unmarshal(patch, &patchMap); err != nil {
|
|
t.Logf("error unmarshalling patch: %s\n", err)
|
|
return false, nil, err
|
|
}
|
|
|
|
phase, found, err := unstructured.NestedString(patchMap, "status", "phase")
|
|
if err != nil {
|
|
t.Logf("error getting status.phase: %s\n", err)
|
|
return false, nil, err
|
|
}
|
|
if !found {
|
|
t.Logf("status.phase not found")
|
|
return false, nil, errors.New("status.phase not found")
|
|
}
|
|
|
|
res := test.restore.DeepCopy()
|
|
|
|
// these are the fields that we expect to be set by
|
|
// the controller
|
|
|
|
res.Status.Phase = api.RestorePhase(phase)
|
|
|
|
backupName, found, err := unstructured.NestedString(patchMap, "spec", "backupName")
|
|
if found {
|
|
res.Spec.BackupName = backupName
|
|
}
|
|
|
|
return true, res, nil
|
|
})
|
|
}
|
|
|
|
if test.backup != nil {
|
|
sharedInformers.Velero().V1().Backups().Informer().GetStore().Add(test.backup)
|
|
}
|
|
|
|
var warnings, errors pkgrestore.Result
|
|
if test.restorerError != nil {
|
|
errors.Namespaces = map[string][]string{"ns-1": {test.restorerError.Error()}}
|
|
}
|
|
if test.putRestoreLogErr != nil {
|
|
errors.Velero = append(errors.Velero, "error uploading log file to object storage: "+test.putRestoreLogErr.Error())
|
|
}
|
|
if test.expectedRestorerCall != nil {
|
|
backupStore.On("GetBackupContents", test.backup.Name).Return(ioutil.NopCloser(bytes.NewReader([]byte("hello world"))), nil)
|
|
|
|
restorer.On("Restore", mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(warnings, errors)
|
|
|
|
backupStore.On("PutRestoreLog", test.backup.Name, test.restore.Name, mock.Anything).Return(test.putRestoreLogErr)
|
|
|
|
backupStore.On("PutRestoreResults", test.backup.Name, test.restore.Name, mock.Anything).Return(nil)
|
|
|
|
volumeSnapshots := []*volume.Snapshot{
|
|
{
|
|
Spec: volume.SnapshotSpec{
|
|
PersistentVolumeName: "test-pv",
|
|
BackupName: test.backup.Name,
|
|
},
|
|
},
|
|
}
|
|
backupStore.On("GetBackupVolumeSnapshots", test.backup.Name).Return(volumeSnapshots, nil)
|
|
}
|
|
|
|
var (
|
|
key = test.restoreKey
|
|
err error
|
|
)
|
|
if key == "" && test.restore != nil {
|
|
key, err = cache.MetaNamespaceKeyFunc(test.restore)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
|
|
if test.backupStoreGetBackupMetadataErr != nil {
|
|
// TODO why do I need .Maybe() here?
|
|
backupStore.On("GetBackupMetadata", test.restore.Spec.BackupName).Return(nil, test.backupStoreGetBackupMetadataErr).Maybe()
|
|
}
|
|
|
|
if test.backupStoreGetBackupContentsErr != nil {
|
|
// TODO why do I need .Maybe() here?
|
|
backupStore.On("GetBackupContents", test.restore.Spec.BackupName).Return(nil, test.backupStoreGetBackupContentsErr).Maybe()
|
|
}
|
|
|
|
if test.restore != nil {
|
|
pluginManager.On("GetRestoreItemActions").Return(nil, nil)
|
|
pluginManager.On("CleanupClients")
|
|
}
|
|
|
|
err = c.processQueueItem(key)
|
|
|
|
assert.Equal(t, test.expectedErr, err != nil, "got error %v", err)
|
|
actions := client.Actions()
|
|
|
|
if test.expectedPhase == "" {
|
|
require.Equal(t, 0, len(actions), "len(actions) should be zero")
|
|
return
|
|
}
|
|
|
|
// structs and func for decoding patch content
|
|
type SpecPatch struct {
|
|
BackupName string `json:"backupName"`
|
|
}
|
|
|
|
type StatusPatch struct {
|
|
Phase api.RestorePhase `json:"phase"`
|
|
ValidationErrors []string `json:"validationErrors"`
|
|
Errors int `json:"errors"`
|
|
}
|
|
|
|
type Patch struct {
|
|
Spec SpecPatch `json:"spec,omitempty"`
|
|
Status StatusPatch `json:"status"`
|
|
}
|
|
|
|
decode := func(decoder *json.Decoder) (interface{}, error) {
|
|
actual := new(Patch)
|
|
err := decoder.Decode(actual)
|
|
|
|
return *actual, err
|
|
}
|
|
|
|
// validate Patch call 1 (setting phase, validation errs)
|
|
require.True(t, len(actions) > 0, "len(actions) is too small")
|
|
|
|
expected := Patch{
|
|
Status: StatusPatch{
|
|
Phase: api.RestorePhase(test.expectedPhase),
|
|
ValidationErrors: test.expectedValidationErrors,
|
|
},
|
|
}
|
|
|
|
if test.restore.Spec.ScheduleName != "" && test.backup != nil {
|
|
expected.Spec = SpecPatch{
|
|
BackupName: test.backup.Name,
|
|
}
|
|
}
|
|
|
|
velerotest.ValidatePatch(t, actions[0], expected, decode)
|
|
|
|
// if we don't expect a restore, validate it wasn't called and exit the test
|
|
if test.expectedRestorerCall == nil {
|
|
assert.Empty(t, restorer.Calls)
|
|
assert.Zero(t, restorer.calledWithArg)
|
|
return
|
|
}
|
|
assert.Equal(t, 1, len(restorer.Calls))
|
|
|
|
// validate Patch call 2 (setting phase)
|
|
|
|
expected = Patch{
|
|
Status: StatusPatch{
|
|
Phase: api.RestorePhaseCompleted,
|
|
Errors: test.expectedRestoreErrors,
|
|
},
|
|
}
|
|
// Override our default expectations if the case requires it
|
|
if test.expectedFinalPhase != "" {
|
|
expected = Patch{
|
|
Status: StatusPatch{
|
|
Phase: api.RestorePhase(test.expectedFinalPhase),
|
|
Errors: test.expectedRestoreErrors,
|
|
},
|
|
}
|
|
}
|
|
|
|
velerotest.ValidatePatch(t, actions[2], expected, decode)
|
|
|
|
// explicitly capturing the argument passed to Restore myself because
|
|
// I want to validate the called arg as of the time of calling, but
|
|
// the mock stores the pointer, which gets modified after
|
|
assert.Equal(t, *test.expectedRestorerCall, restorer.calledWithArg)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestvalidateAndCompleteWhenScheduleNameSpecified(t *testing.T) {
|
|
formatFlag := logging.FormatText
|
|
|
|
var (
|
|
client = fake.NewSimpleClientset()
|
|
sharedInformers = informers.NewSharedInformerFactory(client, 0)
|
|
logger = velerotest.NewLogger()
|
|
pluginManager = &pluginmocks.Manager{}
|
|
)
|
|
|
|
c := NewRestoreController(
|
|
api.DefaultNamespace,
|
|
sharedInformers.Velero().V1().Restores(),
|
|
client.VeleroV1(),
|
|
client.VeleroV1(),
|
|
nil,
|
|
sharedInformers.Velero().V1().Backups(),
|
|
sharedInformers.Velero().V1().BackupStorageLocations(),
|
|
sharedInformers.Velero().V1().VolumeSnapshotLocations(),
|
|
logger,
|
|
logrus.DebugLevel,
|
|
nil,
|
|
"default",
|
|
nil,
|
|
formatFlag,
|
|
).(*restoreController)
|
|
|
|
restore := &api.Restore{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: api.DefaultNamespace,
|
|
Name: "restore-1",
|
|
},
|
|
Spec: api.RestoreSpec{
|
|
ScheduleName: "schedule-1",
|
|
},
|
|
}
|
|
|
|
// no backups created from the schedule: fail validation
|
|
require.NoError(t, sharedInformers.Velero().V1().Backups().Informer().GetStore().Add(
|
|
defaultBackup().
|
|
ObjectMeta(builder.WithLabels(api.ScheduleNameLabel, "non-matching-schedule")).
|
|
Phase(api.BackupPhaseCompleted).
|
|
Result(),
|
|
))
|
|
|
|
errs := c.validateAndComplete(restore, pluginManager)
|
|
assert.Equal(t, []string{"No backups found for schedule"}, errs)
|
|
assert.Empty(t, restore.Spec.BackupName)
|
|
|
|
// no completed backups created from the schedule: fail validation
|
|
require.NoError(t, sharedInformers.Velero().V1().Backups().Informer().GetStore().Add(
|
|
defaultBackup().
|
|
ObjectMeta(
|
|
builder.WithName("backup-2"),
|
|
builder.WithLabels(api.ScheduleNameLabel, "schedule-1"),
|
|
).
|
|
Phase(api.BackupPhaseInProgress).
|
|
Result(),
|
|
))
|
|
|
|
errs = c.validateAndComplete(restore, pluginManager)
|
|
assert.Equal(t, []string{"No completed backups found for schedule"}, errs)
|
|
assert.Empty(t, restore.Spec.BackupName)
|
|
|
|
// multiple completed backups created from the schedule: use most recent
|
|
now := time.Now()
|
|
|
|
require.NoError(t, sharedInformers.Velero().V1().Backups().Informer().GetStore().Add(
|
|
defaultBackup().
|
|
ObjectMeta(
|
|
builder.WithName("foo"),
|
|
builder.WithLabels(api.ScheduleNameLabel, "schedule-1"),
|
|
).
|
|
Phase(api.BackupPhaseCompleted).
|
|
StartTimestamp(now).
|
|
Result(),
|
|
))
|
|
require.NoError(t, sharedInformers.Velero().V1().Backups().Informer().GetStore().Add(
|
|
defaultBackup().
|
|
ObjectMeta(
|
|
builder.WithName("foo"),
|
|
builder.WithLabels(api.ScheduleNameLabel, "schedule-1"),
|
|
).
|
|
Phase(api.BackupPhaseCompleted).
|
|
StartTimestamp(now.Add(time.Second)).
|
|
Result(),
|
|
))
|
|
|
|
errs = c.validateAndComplete(restore, pluginManager)
|
|
assert.Nil(t, errs)
|
|
assert.Equal(t, "bar", restore.Spec.BackupName)
|
|
}
|
|
|
|
func TestBackupXorScheduleProvided(t *testing.T) {
|
|
r := &api.Restore{}
|
|
assert.False(t, backupXorScheduleProvided(r))
|
|
|
|
r.Spec.BackupName = "backup-1"
|
|
r.Spec.ScheduleName = "schedule-1"
|
|
assert.False(t, backupXorScheduleProvided(r))
|
|
|
|
r.Spec.BackupName = "backup-1"
|
|
r.Spec.ScheduleName = ""
|
|
assert.True(t, backupXorScheduleProvided(r))
|
|
|
|
r.Spec.BackupName = ""
|
|
r.Spec.ScheduleName = "schedule-1"
|
|
assert.True(t, backupXorScheduleProvided(r))
|
|
}
|
|
|
|
func TestMostRecentCompletedBackup(t *testing.T) {
|
|
backups := []*api.Backup{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "a",
|
|
},
|
|
Status: api.BackupStatus{
|
|
Phase: "",
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "b",
|
|
},
|
|
Status: api.BackupStatus{
|
|
Phase: api.BackupPhaseNew,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "c",
|
|
},
|
|
Status: api.BackupStatus{
|
|
Phase: api.BackupPhaseInProgress,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "d",
|
|
},
|
|
Status: api.BackupStatus{
|
|
Phase: api.BackupPhaseFailedValidation,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "e",
|
|
},
|
|
Status: api.BackupStatus{
|
|
Phase: api.BackupPhaseFailed,
|
|
},
|
|
},
|
|
}
|
|
|
|
assert.Nil(t, mostRecentCompletedBackup(backups))
|
|
|
|
now := time.Now()
|
|
|
|
backups = append(backups, &api.Backup{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "foo",
|
|
},
|
|
Status: api.BackupStatus{
|
|
Phase: api.BackupPhaseCompleted,
|
|
StartTimestamp: &metav1.Time{Time: now},
|
|
},
|
|
})
|
|
|
|
expected := &api.Backup{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "bar",
|
|
},
|
|
Status: api.BackupStatus{
|
|
Phase: api.BackupPhaseCompleted,
|
|
StartTimestamp: &metav1.Time{Time: now.Add(time.Second)},
|
|
},
|
|
}
|
|
backups = append(backups, expected)
|
|
|
|
assert.Equal(t, expected, mostRecentCompletedBackup(backups))
|
|
}
|
|
|
|
func NewRestore(ns, name, backup, includeNS, includeResource string, phase api.RestorePhase) *builder.RestoreBuilder {
|
|
restore := builder.ForRestore(ns, name).Phase(phase).Backup(backup)
|
|
|
|
if includeNS != "" {
|
|
restore = restore.IncludedNamespaces(includeNS)
|
|
}
|
|
|
|
if includeResource != "" {
|
|
restore = restore.IncludedResources(includeResource)
|
|
}
|
|
|
|
restore.ExcludedResources(nonRestorableResources...)
|
|
|
|
return restore
|
|
}
|
|
|
|
type fakeRestorer struct {
|
|
mock.Mock
|
|
calledWithArg api.Restore
|
|
}
|
|
|
|
func (r *fakeRestorer) Restore(
|
|
info pkgrestore.Request,
|
|
actions []velero.RestoreItemAction,
|
|
snapshotLocationLister listers.VolumeSnapshotLocationLister,
|
|
volumeSnapshotterGetter pkgrestore.VolumeSnapshotterGetter,
|
|
) (pkgrestore.Result, pkgrestore.Result) {
|
|
res := r.Called(info.Log, info.Restore, info.Backup, info.BackupReader, actions)
|
|
|
|
r.calledWithArg = *info.Restore
|
|
|
|
return res.Get(0).(pkgrestore.Result), res.Get(1).(pkgrestore.Result)
|
|
}
|