806234e043
Add more information for failing to get path or snapshot in restic backup and restore.
...
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-06-13 11:32:55 +08:00
d16bdf1f80
Bugs fixing: use patch to update status and set default GC period
...
1. Use patch rather status patch in backup sync controller as we have disable status as sub resource
2. Set the GC period with default value if it isn't set
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-06-10 17:15:19 +08:00
c3a32a116f
Merge pull request #4976 from reasonerjt/vsc-policy-reset-undo
...
Undo setting the VSC's deletion policy during backup
2022-06-10 09:12:46 +08:00
f5649bcc1f
Undo setting the VSC's deletion policy during backup
...
It's not necessary to set the deletion policy as the delete item action
plugin in CSI plugin will set it to Delete when the backup is deleted.
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2022-06-09 16:26:05 +08:00
34087fe5f4
Disable status as sub resource in CRDs
...
When enabling the status as sub resource in CRD, the status will be ignored when creating the CR with status, this will cause issues when syncing backups/pvbs
Fixes #4950
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-06-09 07:52:08 +08:00
6fa4d7d606
Mark in-progress CRs as failed when starting the server
...
Mark in-progress CRs as failed when starting the server
Fixes #4953
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-06-07 17:02:17 +08:00
9b5257663a
Merge pull request #4650 from shubham-pampattiwar/add-label-selectors
...
Add multiple label selector support to Velero Backup and Restore APIs
2022-05-11 23:16:28 +08:00
bfdb68a35a
add multiple label selector support to backup API
...
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
remove backup CLI bits
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
labelselectors spec option for velero restore
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
add changelog file
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
update spec name to OrLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
minor fixes
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
add validations for labelSelector and orLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
update crds.gp after fixing conflicts
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
fix CI and add unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
updated OrLabelSelector spec description and added validation failure unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
add comments and change log level
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
update site docs
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
wrap pager client calls in a function
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
resolve confilcts and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
rebase and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
combine listing items for a given label
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com>
2022-05-11 09:57:47 -04:00
879d03398b
Merge pull request #4894 from blackpiglet/bsl-refactor
...
Refactor BSL controller with periodical enqueue source
2022-05-11 19:23:51 +08:00
989a1e3ebb
Refactor BSL controller with periodical enqueue source.
...
Add filter functions for PeriodicalEnqueueSource.
Move BSL's valication frequency check test case to PeriodicalEnqueueSource's test.
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-05-11 15:31:47 +08:00
d48e1d9db7
Merge pull request #4897 from ywk253100/220609_gc
...
Make garbage collection for expired backups configurable
2022-05-11 10:46:03 +08:00
6a551e546e
Make garbage collection for expired backups configurable
...
Make garbage collection for expired backups configurable
Fixes #4875
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-05-11 10:33:59 +08:00
40a36d2941
Merge pull request #4859 from qiuming-best/restic-repo-tmp
...
Convert Restic Repository resource/controller to the Kubebuilder framework
2022-05-09 17:57:01 +08:00
ef7e5a8388
change func name and repository description
...
Signed-off-by: Ming <mqiu@vmware.com>
2022-05-09 13:57:02 +08:00
62dde34f86
Merge pull request #4893 from ywk253100/220506_restart
...
Make in-progress PVB/PVR as failed when restic controller restarts to avoid hanging backup/restore
2022-05-07 17:32:40 +08:00
034cda2571
Make in-progress PVB/PVR as failed when restic controller restarts to avoid hanging backup/restore
...
Make in-progress PVB/PVR as failed when restic controller restarts to avoid hanging backup/restore
Fixes #4772
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-05-07 16:51:06 +08:00
752b28166f
Merge branch 'main' of https://github.com/qiuming-best/velero into restic-repo-tmp
2022-05-06 14:43:00 +08:00
a69bd8b1f3
Remove VolumeSnapshot created during backup, when the VolumeSnapshotClass's DeletionPolicy is set to Delete.
...
1. Delete VolumeSnapshot directly when DeletionPolicy set to Retain.
2. Change VolumeSnapshotContent's DeletionPolicy to Retain, then delete VolumeSnapshot. After that delete VolumeSnapshotContent and change VSC DeletionPolicy to Delete back, then re-create the VolumeSnapshotContent.
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-05-05 18:30:59 +08:00
6421f8ad02
Make waiting VolumeSnapshot to ready process parallel.
...
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-05-05 14:32:55 +08:00
aa71427576
Merge pull request #4887 from reasonerjt/delete-orphan-vs
...
Delete orphan CSI snapshots in backup sync controller
2022-05-05 11:27:44 +08:00
89e90d9be4
Delete orphan CSI snapshots in backup sync controller
...
This commit makes backup sync controller delete the volumesnapshot and
volumesnapshotcontent created by the backup which is cleaned up as orphan
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2022-05-05 10:54:34 +08:00
628164668f
Merge pull request #4655 from ywk253100/220214_pod_volume_restore
...
Convert Pod Volume Restore resource/controller to the Kubebuilder framework
2022-05-05 10:33:41 +08:00
06d3d731ed
Refactor restic repository
...
Signed-off-by: Ming <mqiu@vmware.com>
2022-04-29 10:26:00 +08:00
ad6c5a5ad6
Change the name of UT to be more consistent
...
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2022-04-28 14:47:37 +08:00
001229a8b3
Merge pull request #4855 from reasonerjt/bak-delete-refact
...
Refactor backup deletion controller based on kubebuilder
2022-04-28 10:48:11 +08:00
58a8371ca2
Merge pull request #4833 from ywk253100/220413_restart
...
Make in-progress backup/restore as failed when doing the reconcile
2022-04-27 11:45:01 -04:00
74fd158a1c
Refactor backup deletion controller based on kubebuilder
...
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2022-04-27 17:00:54 +08:00
c2c211fefb
Convert Pod Volume Restore resource/controller to the Kubebuilder framework
...
Convert Pod Volume Restore resource/controller to the Kubebuilder framework
Fixes #4134
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-04-26 16:23:38 +08:00
dfc86566b8
Make in-progress backup/restore as failed when doing the reconcile
...
Make in-progress backup/restore as failed when doing the reconcile to avoid hanging in in-progress status
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-04-26 11:05:03 +08:00
22dd0b2ebb
Modify CSI VolumeSnapshot metric related code.
...
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-04-23 12:59:56 +08:00
ff4f63b6e3
Merge pull request #4844 from ywk253100/220418_schedule
...
Return the error when running reconcile to trigger the handling logic again
2022-04-20 17:57:20 +08:00
9e786d681b
Merge pull request #4832 from reasonerjt/fix-rm-csi-bak-tmp
...
Make the vsc created by backup sync controller deletable
2022-04-20 17:19:09 +08:00
4f9e445142
Make the vsc created by backup sync controller deletable
...
Fixes #4760
This commit make changes in 2 parts:
1) When a volumesnapshotcontent is persisted during backup, velero will reset its
`Source` field to remove the VolumeHandle, so that the
csi-snapshotter will not try to call `CreateSnapshot` when its synced
to another cluster with a backup.
2) Make sure the referenced volumesnapshotclasses are persisted and
synced with the backup, so that when the volumesnapshotcontent is
deleted the storage snapshot is also removed.
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2022-04-19 15:06:59 +08:00
fb48c5a301
Return the error when running reconcile to trigger the handling logic again
...
Return the error when running reconcile to trigger the handling logic again
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-04-19 09:23:40 +08:00
8064421e83
Update integrated Restic version and add insecureSkipTLSVerify for Restic CLI
...
1. Add --insecure-tls for ResticManager's commands.
2. Add --insecure-tls in PodVolumeBackup and PodVolumeRestore controller.
3. Upgrade integrated Restic version to v0.13.1
4. Change --last flag in Restic command to --latest=1 due to Restic version update.
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-04-18 21:29:33 +08:00
9373c8a383
Merge pull request #4818 from blackpiglet/2499-add-metric-for-csi-snapshot
...
Add CSI VolumeSnapshot related metrics.
2022-04-15 16:55:37 +08:00
9aa4e9e860
Update according to comments. Remove csiVolumeSnapshotsStorageTotal related code.
...
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-04-15 08:05:56 +00:00
22189e8e19
Merge pull request #4436 from codegold79/3454-convert-pod-volume-backup-controller-to-kubebuilder-v3-framework
...
Convert Pod Volume Backup resource/controller to the Kubebuilder V3 framework
2022-04-15 15:07:09 +08:00
4daeec7ab9
Update CRD and GRPC.
...
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-04-09 12:35:09 +00:00
368a1ddf3c
Add CSI VolumeSnapshot related metrics.
...
Signed-off-by: Xun Jiang <jxun@vmware.com>
2022-04-09 00:57:28 +08:00
016ac129c6
Refactor schedule controller with kubebuilder
...
Refactor schedule controller with kubebuilder
fixes #4671
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-04-07 17:32:52 +08:00
7c40949992
Merge pull request #4800 from reasonerjt/bump-up-csi-to-v1
...
Bump up to v1 API for CSI snapshot
2022-04-01 13:46:00 +08:00
04f59ce003
Bump up to v1 API for CSI snapshot
...
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2022-03-31 22:55:03 +08:00
8e4f88db68
Merge pull request #4295 from mercedes-benz/tobiasgiese/items-metrics
...
Add metrics backup_items_total and backup_items_errors
2022-03-25 16:40:43 -04:00
d1fdaecc94
Add labels to expired backups failing garbage collection. ( #4757 )
...
* Add bsl related TTL gc errors to labelSelectors
* if backup label map is nil, make map
* clear label if not BSL error
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2022-03-25 17:01:55 +08:00
1b8da68fc2
metrics: add items gauges
...
Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
2022-03-22 18:36:55 +01:00
09ec3ba994
Insert all restore errors and warnings into restore log ( #4743 )
...
This allows a user inspecting the restore logs to see any
errors or warnings generated by the restore so that they
will be seen even without having to use the describe cli.
Signed-off-by: Scott Seago <sseago@redhat.com>
2022-03-21 14:29:03 +08:00
bcc9aa8d69
Update BSL CR as long as there is any error
...
1. Mark the BSL as "Unavailable" when gets any error
2. Add a new field "Message" to the BSL status to record the error message
Fixes #4485
Fixes #4405
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-03-07 10:25:18 +08:00
a610194aa1
Replace r.Client.Update with patch helper
...
Signed-off-by: F. Gold <fgold@vmware.com>
2022-01-28 15:31:05 -08:00
2dd85c9c42
Convert PodVolumeBackup to Kubebuilder framework
...
Signed-off-by: F. Gold <fgold@vmware.com>
2022-01-26 20:09:24 -08:00
Xun Jiang
Wenkai Yin(尹文开)
Daniel Jiang
Shubham Pampattiwar
qiuming
Xun Jiang/Bruce Jiang
Scott Seago
Tiger Kaovilai
Tobias Giese
F. Gold