Dinesh Yadav
83ef4eb4d0
Support AWS_PROFILE for restic backups/restore operations ( #2096 )
...
* Support AWS_PROFILE for restic backups/restore operations
It enables Velero to switch credentials if multiple s3-compatible
backupLocations are present.
Signed-off-by: dinesh <dinesh1042@gmail.com>
* better comments and fixing typos
Signed-off-by: dinesh <dinesh1042@gmail.com>
* add changelog entry
Signed-off-by: dinesh <dinesh1042@gmail.com>
2019-12-09 09:46:02 -05:00
Antony S Bett
121dc02d2f
Ensure object store plugin processes are cleaned up after restore and after BSL validation during server start up ( #2041 )
...
* Ensure child object store plugin processes are cleaned up during restore
Signed-off-by: Antony Bett <antony.bett@gmail.com>
2019-11-05 08:58:08 -08:00
Antony S Bett
0450567bba
Allow backup storage locations to specify backup sync period or toggle off sync ( #1936 )
...
* Allow backup storage locations to specify backup sync period or toggle off sync
Signed-off-by: Antony Bett <antony.bett@gmail.com>
* Add --backup-sync-period flag to backup location create command
Signed-off-by: Antony Bett <antony.bett@gmail.com>
2019-10-24 08:32:45 -06:00
Adnan Abdulhussein
e3d64d9dd9
use pointer types for metav1.Time fields ( #1951 )
...
* use pointer types for metav1.Time fields
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* simpler metav1.Time ptrs
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove test debug println
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-10-14 10:20:28 -06:00
Steve Kriss
48792ece1f
Updates for org move to vmware-tanzu ( #1920 )
...
* update import paths to github.com/vmware-tanzu/...
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update other GH org refs to vmware-tanzu
Signed-off-by: Steve Kriss <krisss@vmware.com>
* site and docs: update GH org to vmware-tanzu
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update travis badge links on docs readmes
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-30 17:26:56 -04:00
Steve Kriss
d96186473c
sync controller: replace revision file with full diff each interval ( #1892 )
...
* backup sync controller: replace revision file with full diff each interval
Signed-off-by: Steve Kriss <krisss@vmware.com>
* remove getting/setting of metadata/revision file
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* tweak logging
Signed-off-by: Steve Kriss <krisss@vmware.com>
* don't keep podVolumeBackup log field around after syncing PVBs
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update generated CRDs
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-27 16:23:11 -04:00
Adnan Abdulhussein
23376e6293
record restic restore progress in PodVolumeRestore ( #1854 )
...
* record restic restore progress in PodVolumeRestore
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add progress output to velero describe restore --details
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* test getVolumeSize
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* block on send to finish goroutine
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove sync import
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* make update
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-09-10 15:50:57 -06:00
Steve Kriss
6623e1f273
Change restic prune default interval to 7d and make user-configurable ( #1864 )
...
* change restic prune default interval to 7d, add server flag for it
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-10 11:58:42 -07:00
Adnan Abdulhussein
1e182e5837
record restic backup progress in PodVolumeBackup ( #1821 )
...
* record restic backup progress in PodVolumeBackup
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-09-10 11:28:19 -07:00
Steve Kriss
ef911ff21b
when backing up PVCs with restic, explicitly specify --parent ( #1807 )
...
* when backing up PVCs with restic, explicitly specify --parent
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* address review feedback
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-27 16:37:51 -07:00
Adnan Abdulhussein
6aa0215137
create backups from schedules using velero create backup ( #1734 )
...
* add --from-schedule to `velero backup create` to create backups from schedules
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-23 13:03:51 -07:00
Steve Kriss
686f41ebec
remove calls to restic check before/after prune ( #1794 )
...
* remove calls to restic check before/after prune
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-23 10:53:00 -07:00
Steve Kriss
8b6c505817
error if restic repo identifier can't be determined
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-22 10:19:22 -06:00
Steve Kriss
5ef0a84128
create pod volume backups in backup's namespace during sync ( #1760 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-13 10:20:25 -07:00
Steve Kriss
ffa3251efc
move contents of pkg/util/test into pkg/test
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-07 08:26:00 -06:00
KubeKween
4accb8512a
Restore from PodVolumeBackups ( #1723 )
...
* Restore from PodVolumeBackups
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Partially address code reviews
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Partially address code reviews #2
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Clean up struct
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix log messages
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix tests
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Clean up
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Add changelog
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-08-06 13:17:36 -07:00
Steve Kriss
6522ba7c42
fix bugs preventing pod volume backups from syncing properly
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-06 09:23:49 -06:00
Adnan Abdulhussein
07525bd593
store backup resource list metadata in object storage ( #1709 )
...
* move backedUpItems to pkg/backup.Request struct
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* construct resource itemKey field from gvk
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* store backup resource list metadata in object storage
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove debug log
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* fix formatting
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add missing license blocks and split BackupInfo struct lines
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add test for checking BackedUpItems matches tarball contents
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add comment to explain test
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-05 11:15:55 -06:00
Steve Kriss
b24a603711
periodically check for stale restic repo locks ( #1708 )
...
* periodically check for stale restic repo locks
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* only try to init a restic repo if it doesn't already exist
Signed-off-by: Steve Kriss <krisss@vmware.com>
* reword comment
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-31 10:52:23 -07:00
Steve Kriss
f2d06bc5e9
strip leading/trailing slashes from BSL bucket & prefix vals ( #1694 )
...
* strip leading/trailing slashes from BSL bucket & prefix vals
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-31 08:27:12 -07:00
Steve Kriss
4543258970
Update tests to use object builders in pkg/builder ( #1707 )
...
* add pkg/builder with BackupBuilder and ObjectMeta functional options
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-31 07:46:48 -07:00
carthewd
22eca22ac8
Add JSON as an option for log output ( #1654 )
...
* Add JSON as an option for log output
Signed-off-by: Donovan Carthew <donovan.carthew@gmail.com>
2019-07-30 16:29:34 -07:00
KubeKween
3b9af8c654
Store PodVolumeBackups in obj storage & use as source of truth ( #1577 )
...
* Store PodVolumeBackups in object storage
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-07-24 15:51:20 -04:00
Nolan Brubaker
63964fc6f9
Append "/mount" to directory for CSI volumes ( #1615 )
...
CSI volumes are mounted one level deeper than "native" kubernetes
volumes, and this needs to be appended for proper restic support.
Fixes #1313 .
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-10 15:16:21 -07:00
Adnan Abdulhussein
2156124dfc
record PodVolumeBackup/Restore start and completion timestamps ( #1609 )
...
* record PodVolumeBackup start and completion timestamps
adds startTimestamp and completionTimestamp fields to the
PodVolumeBackup status spec
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* record PodVolumeRestore start and completion timestamps
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-28 11:58:02 -04:00
Steve Kriss
19052994ed
replace TestBackup with pkg/backup.Builder ( #1593 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-21 17:08:08 -04:00
Adnan Abdulhussein
d6c60b2dd5
fix panic when processing DeleteBackupRequest objs without labels ( #1556 )
...
This fix initialises an empty map if the request object's Labels map
is nil, allowing the controller to later add and modify labels on the
object.
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-10 10:04:51 -07:00
KubeKween
0a771e6a53
Add cmd to list plugins ( #1535 )
...
* Add cmd to list plugins
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-06-05 13:41:02 -04:00
KubeKween
0804f34644
Don't log error if restic volume is empty ( #1480 )
...
* Don't log error if restic volume is empty
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-05-30 12:48:21 -04:00
Steve Kriss
411d44a673
allow individual backup storage locations to be read-only ( #1517 )
...
* allow individual backup storage locations to be read-only
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-29 14:21:25 -04:00
Steve Kriss
9287505f62
fixes for breaking changes
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-20 13:25:36 -06:00
Anshul Chandra
4e12b08953
Validate restore name label length
...
Velero should handle cases when the label length exceeds 63 characters.
- if the length of the backup/restore name is <= 63 characters, use it as the value of the label
- if it's > 63 characters, take the SHA256 hash of the name. the value of
the label will be the first 57 characters of the backup/restore name
plus the first six characters of the SHA256 hash.
Fixes heptio#1021
Signed-off-by: Anshul Chandra <anshulc@vmware.com>
2019-05-01 10:25:11 -07:00
Steve Kriss
660080e6f3
remove all remaining legacy Ark references ( #1415 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-29 12:33:54 -07:00
Steve Kriss
8392e6d83f
add PartiallyFailed phase for backups, log+continue on errors ( #1386 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-26 09:14:26 -07:00
Nolan Brubaker
bf19623e82
Merge pull request #1389 from skriss/restore-partially-failed
...
Add PartiallyFailed phase for restores
2019-04-25 17:06:26 -04:00
Carlisia
6f496a8921
Bug fix
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-24 14:18:24 -07:00
Steve Kriss
eb30ec0666
move restores to PartiallyFailed if >=1 error in restore results
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 12:57:40 -06:00
Carlisia
7d28f82540
Address code review
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-24 10:54:43 -07:00
Carlisia
38ccb40ca1
Add back code and tests
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-23 16:19:49 -07:00
Carlisia
05a88345e5
Code clean up
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-22 15:22:58 -07:00
Andy Goldstein
01d0b026e9
Fail backup if it already exists in object storage
...
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
2019-04-22 15:22:58 -07:00
fabito
475cf2ab60
add new metrics (gauges): backup_total and restore_total
...
Signed-off-by: fabito <fuechi@ciandt.com>
2019-04-18 01:28:38 -03:00
Nolan Brubaker
0750b2c789
Merge pull request #1367 from skriss/restic-repo-fixes
...
Restic repository management fixes
2019-04-17 11:49:17 -04:00
Steve Kriss
5bc6695109
move RestoreResult from api to pkg/restore, rename to Result
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-16 12:57:02 -06:00
Steve Kriss
c59544cb79
remove backup.status.volumeBackups and all related code
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:40 -06:00
Steve Kriss
7f36f78aee
remove code that removes legacy GC finalizer from backups
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
Steve Kriss
77e648eafa
remove Ark field from RestoreResult
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:02 -06:00
Steve Kriss
5d06bd4ab9
restic repo controller: lower resync period to 5min
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 14:43:40 -06:00
Steve Kriss
3116185e5b
instantiate plugin manager with per-restore logger so plugin logs are captured
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 10:36:20 -06:00
Rohan Vora
4beb8aab3c
Set default backup TTL
...
Set default backup TTL to 30 days when TTL
is not provided in the backup yaml configuration.
Updates #138
Signed-off-by: Rohan Vora <vorar@vmware.com>
2019-04-09 14:13:29 -07:00