89ca2571f3
AWS zone on volume IDs
...
Signed-off-by: Travis Sturzl<travis@metismachine.com>
2019-03-12 13:04:33 -06:00
394548afcd
Merge pull request #1254 from skriss/remove-wait-for-pv
...
remove restore code that waits for a PV to become Available
2019-03-11 13:20:59 -04:00
4ee41a13a0
Merge pull request #1261 from asaf-erlich/patch-1
...
Update ark restore to not open every single file open during extracti…
2019-03-08 14:59:09 -08:00
4041044a93
Update ark restore to not open every single file open during extraction of the data
...
Original error was:
```
ark -n <redacted> restore logs <redacted>
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=nodes logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events.events.k8s.io logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=backups.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=restores.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Starting restore of backup backup/<redacted>" logSource="pkg/restore/restore.go:342"
time="2019-03-06T18:31:06Z" level=info msg="error unzipping and extracting: open /tmp/604421455/resources/rolebindings.rbac.authorization.k8s.io/namespaces/<redacted>/<redacted>: too many open files" logSource="pkg/restore/restore.go:346"
```
Downloading the directory from s3 and untarring it I found 1036 files. The ulimit -n output says 1024. This is our team's best guess at a root cause. But the code fixed in the PR definitely is holding all the files open until the method closes: https://blog.learngoprogramming.com/gotchas-of-defer-in-go-1-8d070894cb01
Please note my go code abilities are not great and I did not test this. I just edited the file in github. All I did was remove the defer and put fileClose after the copy is done. Theoretically this should only hold one file open at a time now. Let me know if you want me to do any further steps.
Thank you,
-Asaf
Signed-off-by: Asaf Erlich <aerlich@groupon.com>
2019-03-07 11:23:35 -05:00
5e12a921b5
Merge pull request #1256 from carlisia/c-plugins
...
Add original item to restore plugin interface
2019-03-06 19:02:47 -05:00
1354e2b6ff
Add original item to restore plugin interface
...
Signed-off-by: Michal Wieczorek <wieczorek-michal@wp.pl>
2019-03-05 17:09:42 -08:00
e29aa74a23
remove restore code that waits for a PV to become Available
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-05 17:04:52 -07:00
ce3f43e876
Merge pull request #1251 from skriss/backup-extractor
...
move backup extraction logic to its own type
2019-03-05 16:37:48 -05:00
5912fe66e5
Merge pull request #1250 from skriss/extract-pv-restorer
...
move pvRestorer and tests to their own files
2019-03-05 16:37:32 -05:00
c006d9246f
Merge pull request #1248 from DheerajSShetty/describe_ouput
...
Improve `describe` output
2019-03-04 13:34:42 -08:00
1b031f0cc4
Improve `describe` output
...
* Move Phase to right under Metadata(name/namespace/label/annotations)
* Move Validation errors: section right after Phase: section and only
show it if the item has a phase of FailedValidation
* For restores move Warnings and Errors under Validation errors. Do not
show Warnings or Errors if there are none.
Signed-off-by: DheerajSShetty <dheerajs@vmware.com>
Fixes #987
2019-03-04 13:21:18 -08:00
88e6a740f2
move pvRestorer and tests to their own files
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-01 15:07:25 -07:00
0fec56f488
move backup extraction logic to its own type
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-01 15:05:58 -07:00
e21940bee1
Merge pull request #1231 from skriss/k8s-1.12-deps
...
update kubernetes and azure dependencies to 1.12
2019-02-28 15:09:06 -08:00
421b64b1fa
Merge pull request #1247 from skriss/pr-1146-changelog
...
add changelog for PR 1146
2019-02-28 18:08:32 -05:00
81e741ebfc
add changelog for PR 1146
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 16:02:23 -07:00
fcf21813a5
Merge pull request #1246 from skriss/preserve-storageclass
...
when restoring a PV, don't remove its spec.storageClassName
2019-02-28 18:02:20 -05:00
8dd1cbf62b
add changelog
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:58:18 -07:00
65f3926caa
Merge pull request #1146 from skriss/replace-map-utils-final
...
replace ark's map_utils.go with structured types and apimachinery's unstructured helpers
2019-02-28 14:37:07 -08:00
31501b79b2
when deleting snapshot, don't error if it doesn't exist
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:33:05 -07:00
6bf837b233
address breaking changes in Azure SDK
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:33:05 -07:00
f908d5f8c0
upgrade Azure SDK to a GA version matching Kubernetes
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:33:05 -07:00
f8548e1ca1
tweak a couple of dependency versions
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:33:05 -07:00
58e471bda0
fix breaking changes
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:33:05 -07:00
61eab7dca3
update generated code using 1.12 generator
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:33:05 -07:00
efc490138c
update to 1.12 dependencies
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 15:33:04 -07:00
80fe640b98
add changelog
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 14:36:38 -07:00
21c57c46b3
when restoring a PV, don't remove its spec.storageClassName
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-28 14:34:36 -07:00
7353294b7f
Merge pull request #1236 from DheerajSShetty/squashed_feature
...
defer closing the ReadCloser in ObjectStoreGRPCServer.GetObject
2019-02-28 13:12:05 -08:00
7e736ab79d
Merge pull request #1244 from carlisia/c-fiximages
...
Fix readme links
2019-02-28 13:07:49 -08:00
5468ccf5cb
Fix readme links
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-02-28 12:33:15 -08:00
032aaac508
defer closing the ReadCloser in ObjectStoreGRPCServer.GetObject
...
Signed-off-by: DheerajSShetty <dheerajs@vmware.com>
Fixes #1093
2019-02-28 11:51:10 -08:00
ab2fc65c02
Merge pull request #1243 from skriss/changelogs
...
v0.10.2 and v0.11.0 changelogs
2019-02-28 07:03:24 -08:00
03b8f5397f
Merge pull request #1203 from skriss/v0.11-changes
...
v0.11 changes
2019-02-28 07:01:23 -08:00
431602e852
add v0.11.0 changelog
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-27 12:40:42 -08:00
cb0a9281f6
add v0.10.2 changelog
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-27 08:23:21 -08:00
783c7d850c
Merge pull request #1235 from skriss/restic-race-fix
...
Fix bugs in restic repository ensurer
2019-02-27 11:09:47 -05:00
e3e76c2067
pkg/restic: fix concurrency bugs causing dupe repos, panics
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-25 18:30:26 -08:00
e4771f582b
Merge pull request #1232 from skriss/install-docs-updates
...
add more documentation about using official releases
2019-02-22 12:04:20 -08:00
4e0b0c87bb
add more documentation about using official releases
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-22 12:56:52 -07:00
3724af259c
Merge pull request #1227 from skriss/update-logo
...
update to logo with name
2019-02-21 09:10:17 -08:00
522ee9ad36
update to logo with name
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-02-21 10:00:06 -07:00
1b3c444720
Merge pull request #1190 from nrb/document-velero-migration
...
Instructions for migrating from Ark to Velero
2019-02-20 12:26:41 -08:00
3d2b031ee4
Document steps for migrating from Ark to Velero
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-02-20 15:18:31 -05:00
8be6f03ef0
Merge pull request #1212 from nrb/list-link-fix
...
Update support link to the google group
2019-02-14 11:28:15 -07:00
e2f84a1242
Update support link to the google group
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-02-14 13:19:22 -05:00
49eeeb04f0
Merge pull request #1204 from skriss/deprecation-notices
...
add deprecation notices to pkg/apis/ark/v1 types
2019-02-12 16:02:47 -05:00
e1d414338c
Merge pull request #1200 from nrb/fix-1183
...
Fix restoring GCP regional disks
2019-02-12 13:48:42 -07:00
0ffaeb949d
Fix restoring GCP regional disks
...
To create a regional disk, the URLs for the zones in which the disk is
replicated must be provided to the GCP API.
Fixes #1183
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-02-12 15:42:50 -05:00
ed73be44fd
Merge pull request #1206 from nzoueidi/master
...
Add UTC time to --schedule
2019-02-12 09:19:53 -07:00
tsturzl
Nolan Brubaker
KubeKween
asaf-erlich
Michal Wieczorek
Steve Kriss
DheerajSShetty
Steve Kriss
Carlisia
Nolan Brubaker