dbd0aa4915
Add a BSL controller to handle validation + update BSL status phase ( #2674 )
...
* Add BSL controller
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add changelog
Signed-off-by: Carlisia <carlisia@vmware.com>
* Make update
Signed-off-by: Carlisia <carlisia@vmware.com>
* Update docs
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add kubebuilder dependency
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add export
Signed-off-by: Carlisia <carlisia@vmware.com>
* add kubebuilder binaries into velero builder image
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* Reset velero dockerfile
Signed-off-by: Carlisia <carlisia@vmware.com>
* Consolidate all logic
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add copyright header
Signed-off-by: Carlisia <carlisia@vmware.com>
* Clean up + add "last validated" column
Signed-off-by: Carlisia <carlisia@vmware.com>
* Better tests
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add more tests
Signed-off-by: Carlisia <carlisia@vmware.com>
* Better logging
Signed-off-by: Carlisia <carlisia@vmware.com>
* Format
Signed-off-by: Carlisia <carlisia@vmware.com>
* Code reviews
Signed-off-by: Carlisia <carlisia@vmware.com>
* Address code review
Signed-off-by: Carlisia <carlisia@vmware.com>
* Remove redundant logic
Signed-off-by: Carlisia <carlisia@vmware.com>
Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
2020-07-14 17:47:00 -04:00
3d3b9e312a
Revert " 🐛 fix file perissions on the manifest JSON in backup archive ( #2685 )" ( #2700 )
...
dae5230aae
2020-07-10 14:07:05 -07:00
54aa75a4cd
Adjust restic timeout and pod values up ( #2696 )
...
* Adjust restic timeout and pod values up
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-07-08 14:59:19 -07:00
dae5230aae
🐛 fix file perissions on the manifest JSON in backup archive ( #2685 )
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-07-08 06:37:59 -07:00
b4465e92b8
🐛 Use CRD version prior to remap_crd_version backup item action ( #2683 )
...
* 🐛 preserve crd version before remapping
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-07-07 10:59:41 -07:00
94a9522f75
updated acceptable values on cron schedule for day of the week from 0-7 to 0-6 ( #2676 )
...
* updated acceptable values on cron schedule for day of the week from 0-7 to 0-6
Signed-off-by: Daniel Thrasher <dannythrasher@gmail.com>
* added a changelog file to changelog directory
Signed-off-by: Daniel Thrasher <dannythrasher@gmail.com>
Co-authored-by: Daniel Thrasher <dannythrasher@gmail.com>
2020-07-06 17:14:44 -04:00
4048c020a8
Convert manifests + BSL api client to kubebuilder ( #2561 )
...
* kubebuilder init - minimalist version
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add back main.go, apparently kb needs it
Signed-off-by: Carlisia <carlisia@vmware.com>
* Tweak makefile to accomodate kubebuilder expectations
Signed-off-by: Carlisia <carlisia@vmware.com>
* Port BSL to kubebuilder api client
Signed-off-by: Carlisia <carlisia@vmware.com>
* s/cache/client bc client fetches from cache
And other naming improvements
Signed-off-by: Carlisia <carlisia@vmware.com>
* So, .GetAPIReader is how we bypass the cache
In this case, the cache hasn't started yet
Signed-off-by: Carlisia <carlisia@vmware.com>
* Oh that's what this code was for... adding back
We still need to embed the CRDs as binary data in the Velero binary to
access the generated CRDs at runtime.
Signed-off-by: Carlisia <carlisia@vmware.com>
* Tie in CRD/code generation w/ existing scripts
Signed-off-by: Carlisia <carlisia@vmware.com>
* Mostly result of running update-fmt, updated file formatting
Signed-off-by: Carlisia <carlisia@vmware.com>
* Just a copyright fix
Signed-off-by: Carlisia <carlisia@vmware.com>
* All the test fixes
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add changelog + some cleanup
Signed-off-by: Carlisia <carlisia@vmware.com>
* Update backup manifest
Signed-off-by: Carlisia <carlisia@vmware.com>
* Remove unneeded auto-generated files
Signed-off-by: Carlisia <carlisia@vmware.com>
* Keep everything in the same (existing) package
Signed-off-by: Carlisia <carlisia@vmware.com>
* Fix/clean scripts, generated code, and calls
Deleting the entire `generated` directory and running `make update`
works. Modifying an api and running `make verify` works as expected.
Signed-off-by: Carlisia <carlisia@vmware.com>
* Clean up schema and client calls + code reviews
Signed-off-by: Carlisia <carlisia@vmware.com>
* Move all code gen to inside builder container
Signed-off-by: Carlisia <carlisia@vmware.com>
* Address code review
Signed-off-by: Carlisia <carlisia@vmware.com>
* Fix imports/aliases
Signed-off-by: Carlisia <carlisia@vmware.com>
* More code reviews
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add waitforcachesync
Signed-off-by: Carlisia <carlisia@vmware.com>
* Have manager register ALL controllers
This will allow for proper cache management.
Signed-off-by: Carlisia <carlisia@vmware.com>
* Status subresource is now enabled; cleanup
Signed-off-by: Carlisia <carlisia@vmware.com>
* More code reviews
Signed-off-by: Carlisia <carlisia@vmware.com>
* Clean up
Signed-off-by: Carlisia <carlisia@vmware.com>
* Manager registers ALL controllers for restic too
Signed-off-by: Carlisia <carlisia@vmware.com>
* More code reviews
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add deprecation warning/todo
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add documentation
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add helpful comments
Signed-off-by: Carlisia <carlisia@vmware.com>
* Address code review
Signed-off-by: Carlisia <carlisia@vmware.com>
* More idiomatic Runnable
Signed-off-by: Carlisia <carlisia@vmware.com>
* Clean up imports
Signed-off-by: Carlisia <carlisia@vmware.com>
2020-06-24 12:55:18 -04:00
0b8e2cbbe5
Improve velero download doc ( #2660 )
...
* Improve velero download doc
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add changelog
Signed-off-by: Carlisia <carlisia@vmware.com>
* Better message
Signed-off-by: Carlisia <carlisia@vmware.com>
2020-06-23 11:12:01 -07:00
e5e7c025dd
fix copyright boilerplate
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-18 14:14:15 -07:00
7abd2c6db9
doc updates
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-18 13:57:59 -07:00
6a8dca6b84
add default-volumes-to-restic flag to velero installation
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-16 14:46:36 -07:00
63f7690f44
more tests
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-16 14:46:36 -07:00
b0fd3d35c1
rename field
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-15 15:26:44 -07:00
b71173228a
add velero server flag to allow default restic use on all pod volumes
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-15 14:46:06 -07:00
8a2a852b87
use backup's defaultRestic flag to identify pod volumes using restic
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-15 14:46:06 -07:00
f34aab251e
add default restic flag to backup create cli
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-15 14:46:06 -07:00
69cceb0d7e
add backup level flag to opt-in for default restic use
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-06-15 14:46:06 -07:00
a5346c1a87
azure: support aad-pod-identity auth when using restic ( #2602 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-06-08 11:17:43 -07:00
d9d9dc60da
Log when a hook timeout duration can't be parsed ( #2610 )
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-06-05 12:45:50 -07:00
1c80ba903e
don't error during backup when additional items returned by plugin don't exist ( #2595 )
...
* log a warning instead of erroring if additional item can't be found
Signed-off-by: Steve Kriss <krisss@vmware.com>
* always show backup warning/error count in get/describe
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-06-04 16:29:55 -07:00
ceae7a2fdc
When creating backup from schedule, allow default name ( #2569 )
...
* When creating backup from schedule, allow default name
Signed-off-by: Christoph Blecker <admin@toph.ca>
2020-05-28 12:31:25 -07:00
40d8511f64
Add status column to get BSL output ( #2493 )
...
* Add status column to get BSL output
Signed-off-by: Carlisia <carlisia@vmware.com>
* Address code review
Signed-off-by: Carlisia <carlisia@vmware.com>
2020-05-28 10:52:46 -07:00
5b52fd3efd
re-instantiate backup store just before persisting artifacts ( #2550 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-05-27 16:03:52 -07:00
d10eea3ba3
Add up and down votes to the issue templates and contributing guide ( #2583 )
...
Signed-off-by: jonasrosland <jrosland@vmware.com>
2020-05-27 14:09:07 -07:00
0effb5d74b
Merge pull request #2576 from skriss/fix-2562
...
bug fix: pass ca cert file to restic stats command on restore
2020-05-26 15:16:28 -04:00
98c1a34558
bug fix: pass ca cert file to restic stats command on restore
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-05-26 10:16:03 -06:00
92693ad422
update backup struct with progress updates
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-05-21 15:40:59 -06:00
3f6183b522
add missing kubebuilder tags
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-05-21 15:30:12 -06:00
532c6c5dc3
increment restic volumesnapshot count after successful pvb create ( #2542 )
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-05-20 09:05:23 -07:00
c1494d6804
Tweak VolumeSnapshotContent describe output ( #2534 )
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-05-12 13:58:47 -07:00
e400be9c8f
Include CSI volume snapshot information in `velero backup describe` ( #2448 )
...
* Add download methods for CSI objects
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add support for downloading CSI volume objects
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add new methods to mock.
Remove generated information from file since mockery no longer appears
to work. It isn't maintained anymore and doesn't support go module-based
projects.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add describe command for CSI
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add csi package with helpers
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove duplicate import from server
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove CSI API that will not be used with describe
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add VolumeSnapshotContents output to describe command
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Document NewCSIListOptions function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Document csi package
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove stutter in function name
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fix CI
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fix nil pointer error when not using CSI snapshots
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove unused CSI download request kinds
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add back mocks
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Change persistent volumes to velero-native snapshots
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove unused function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Address review feedback
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add changelog
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove unnecessary doc.go
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-05-08 12:42:30 -07:00
e91dfe3d91
Remove comment that has been turned into an issue ( #2500 )
...
Logged comment as issue #2499
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-05-08 09:27:01 -07:00
de8962ea18
Bug fix: Calculate label using backup name for CSI objects ( #2510 )
...
* Use a helper function when querying w/ backup label
Setting or querying for a backup label name should always pass the value
through the GetValidName function. This change passes query uses of the
backup label value through the GetValidName function by introducing 2
new helpers, one for making a Selector, one for making a ListOptions.
It also removes functions returning the same data, but under
unecessarily specific names.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Document using the label.GetValidName function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Update copyright year
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Clarify labels.GetValidName and annotations
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Move functions to pkg/label
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fix function comments
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-05-07 11:56:13 -07:00
abae81ddc8
Merge pull request #2440 from skriss/backup-progress
...
report backup progress
2020-05-07 14:51:20 -04:00
c49afd44bd
Use label selector to list VSCs to persist ( #2502 )
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-05-06 11:04:34 -07:00
911a607cf8
Allow feature flags to be passed from install CLI ( #2503 )
...
* allow feature flags to be passed from install CLI
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-05-06 10:52:44 -07:00
577e87d1b8
Sync CSI API objects during backup sync ( #2496 )
...
* add changelog
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* Sync CSI API volumesnapshotcontents during backup sync
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-05-06 08:00:05 -06:00
8671a639c9
Backup entire v1beta1 CRD instead of just changing version string ( #2478 )
...
* Switch to backing up v1beta1 CRDs from API server
Instead of simply switching out the APIVersion string on a v1
CustomResourceDefinition object, re-download the object from the API
server entirely to get the correct fields.
This should fix validation errors upon restore.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fix existing tests
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add full example CRDs to automated tests
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Move beta CRD lookup into helper function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add case for preserveUnknownFields CRDs
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add PreserveUnknownFields case and refactor execute
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add older prometheus CRD test cases
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add changelog
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-05-05 13:21:28 -07:00
6b5a084f32
Delete dangling volumesnapshotcontents from velero backups ( #2480 )
...
* Delete dangling volumesnapshotcontents from velero backups
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* add changelog
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* handle not found errors from VSC delete
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* clean up unit tests
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-05-04 15:41:27 -04:00
4b0f654a1e
add progress info to backup status
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-05-01 15:30:50 -06:00
30ca0e4322
split out collecting items from backing up items
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-05-01 15:30:42 -06:00
19c52434b4
simplify group/resource/item backupper structure
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-05-01 15:29:01 -06:00
577af5a5b1
Merge pull request #2487 from skriss/fix-error-logging
...
don't return an error from log hook if value is not an error type
2020-05-01 16:11:16 -04:00
1ed5a13012
Merge pull request #2484 from skriss/fix-2319
...
bug fix: fix int/float conversion issue with CRD type in restore plugin
2020-05-01 16:09:57 -04:00
bf52caf658
Delete CSI volumesnapshots created as part of a backup in its deletion ( #2411 )
...
* delete CSI volumesnapshots in backup on backup delete
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* set vsc deletionpolicy to delete prior to vs deletion
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* add more unit tests
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* add change log
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* passes build need to pass unit tests
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* remove GetNamespacesInBackup
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* fix unit tests
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* check feature flag instead of nil check
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* cleanup
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-05-01 16:05:20 -04:00
0d97f9400e
Backup all groups and versions with backward compatibility ( #2373 )
...
* Backup all API Groups versions while keeping backward compatibility
Signed-off-by: Rafael Brito <rbrito@vmware.com>
* Backup all API Groups versions while keeping backward compatibility
Signed-off-by: Rafael Brito <rbrito@vmware.com>
* Adding feature flag to enable backup of multiple API group versions
Signed-off-by: Rafael Brito <rbrito@vmware.com>
2020-05-01 15:54:57 -04:00
26f67f1b10
add support for getting Azure Storage Account key from ENV variable ( #2455 )
...
Signed-off-by: Martin Odstrcilik <martin.odstrcilik@gmail.com>
2020-05-01 07:55:50 -07:00
5cc6c12eb4
don't return an error from log hook if value is not an error type
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-04-30 15:30:22 -06:00
e148ddad8f
Add backwards-compatibility for flags passed to plugins ( #2479 )
...
* update plugin server to ignore unknown flags during parse
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-04-30 13:19:55 -07:00
2d55cd2ed8
bug fix: fix int/float conversion issue with CRD type in restore plugin
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-04-30 09:06:03 -06:00
15b2a1c9c6
bug fix: don't remove unresolvable includes from includes-excludes lists ( #2462 )
...
* bug fix: don't remove unresolvable includes from includes-excludes lists
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-04-27 17:17:39 -04:00
98d2fc732e
clarify the wording for restore describe for namespaces included ( #2449 )
...
* clarify the wording for restore describe for namespaces included
Instead of showing it as "*" explicitly mention that all the namespaces
from the backup object are included.
refer to https://github.com/vmware-tanzu/velero/issues/1918
Signed-off-by: Raghavendra M <raghavendra@redhat.com>
* Update pkg/cmd/util/output/restore_describer.go
Co-Authored-By: Ashish Amarnath <ashisham@vmware.com>
Signed-off-by: Raghavendra M <raghavendra@redhat.com>
* Update pkg/cmd/util/output/restore_describer.go
Co-Authored-By: Ashish Amarnath <ashisham@vmware.com>
Signed-off-by: Raghavendra M <raghavendra@redhat.com>
Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
2020-04-24 14:44:20 -07:00
962f5d6859
Skipping validation for volumesnapshotlocation for backup if snapshotvolume set to false ( #2450 )
...
* Disabling validation for volumesnapshotlocation if the backup has snapshotvolume set to false
Signed-off-by: mayank <mayank.patel@mayadata.io>
* adding a changelog
Signed-off-by: mayank <mayank.patel@mayadata.io>
* addressing review comment
Signed-off-by: mayank <mayank.patel@mayadata.io>
2020-04-24 09:46:20 -07:00
aa3abefdbf
Address review feedback
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
16cf2780d8
Fetch contents based on volumesnapshots found
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
bc04c568cd
Return list of errors for encoding/zipping
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
eefd12b3e4
Rename CSI variables to be more descriptive
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
b567859655
Add data description for encoding JSON in case of error
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
d31951c81c
Add CSI feature flag constant
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
15d4c11305
Wrap CSI lister access in a nil check
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
b4e18b489c
Clean up object contents when other files fail
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
ad18318bb1
Rename snapshotter factory variable, return nil in wrapper
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
6c3fc8c780
Addresss simple review feedback
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
9372eaa31b
Reduce duplication in object serialization
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
850554911f
Reduce duplication in object storage uploads
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
9c1a2e884b
Update comments
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
5202885349
Remove unused CSI client variable
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
9719e4de9d
Don't defer cancelFunc, since it causes issues
...
Infomers won't start if cancelFunc is invoked as soon as the newServer
function exits via the defer
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
b7142465fc
Wrap usage of the CSI informer in flag checks
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:18 -04:00
c71318bf19
Address more review feedback
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:17 -04:00
5bde12939e
Address review feedback on object store
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:17 -04:00
5de15c450b
Address some review feedback on server
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:17 -04:00
aff529e5d5
Upload CSI volumesnapshots associated with backup
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:17 -04:00
6a7beaf5ce
Plumb CSI listers through to backup controller
...
Account for having CSI enabled or not, as well as having the snapshot
CRDs installed in the kubernetes cluster.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:17 -04:00
232e1d8927
Add clients for CSI snapshots
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:17 -04:00
b4be7eccb9
Document locations for CSI support
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-20 13:49:17 -04:00
29769eeb5b
Merge pull request #2439 from skriss/dynamic-list-refactor
...
change dynamic client's List return type to UnstructuredList
2020-04-16 15:16:30 -04:00
bf2ef69aa7
Merge pull request #2431 from nrb/fix2429
...
Annotate backups with kubernetes version information
2020-04-15 11:45:10 -07:00
ca58d7ab90
change dynamic client's List return type to UnstructuredList
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-04-15 12:41:47 -06:00
1826b6b67b
bug fix: populate namespace in logs for backup errors ( #2438 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-04-15 10:31:40 -07:00
67322d555e
Write kubernetes version info to annoations
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-04-14 17:11:04 -04:00
824bc8eec5
Merge pull request #2390 from skriss/fix-2366
...
bug fix: save PVBs even if no snapshot was taken
2020-04-08 12:21:43 -07:00
c8223608ba
Add --cacert flag to velero cli commands ( #2364 )
...
* Add --cacert flag to velero cli commands
Adds a --cacert flag to the log and describe commands
that takes a path to a PEM-encoded certificate bundle
as an alternative to --insecure-skip-tls-verify for
dealing with self-signed certificates.
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
2020-04-03 08:02:41 -07:00
016868ecd3
add restore item action to update PVC selected-node annotation ( #2377 )
...
* New RestoreItemAction for PVC with annotation `volume.kubernetes.io/selected-node`
Signed-off-by: mayank <mayank.patel@mayadata.io>
2020-04-03 08:01:34 -07:00
061b4463ce
ensure target namespace exists prior to retoring a resource ( #2389 )
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-04-03 07:57:01 -07:00
91228522be
bug fix: save PVBs even if no snapshot was taken
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-04-02 13:17:41 -06:00
969526cee5
Merge pull request #2381 from nrb/plugin-feature-flag
...
Add features flag to plugin server
2020-03-31 16:57:02 -07:00
02b5578810
Add --cacert flag to the installer ( #2368 )
...
* Add --cacert flag to the installer
Allows setting the cacert field on the BSL during
the install process using the file at the path
specified by the --cacert field.
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
* Add changelog for #2368
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
2020-03-31 14:48:16 -06:00
bc2717fca1
Add features flag to plugin server
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-03-31 14:01:47 -04:00
7c87aebe5f
Only add CA cert to plugin config if it's defined
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-03-31 13:59:37 -04:00
4961040652
add secrets to kuberesource ( #2369 )
...
CSI plugin for velero will use this to return secrets as additional
resource while backing up CSI objects
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-03-30 09:43:58 -07:00
4d49b5971c
Support setting a custom CA bundle to use with a BackupStorageLocation ( #2353 )
...
* Support setting a custom CA certificate for a BSL
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
* update CRDS
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
* Add changelog for #2353
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
* Clean up temp file from TestTempCACertFile
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
2020-03-24 15:50:48 -06:00
f6cd53c6cb
Adding k8s version labels on backup CRD #2342 ( #2346 )
...
Signed-off-by: Rafael Brito <rbrito@vmware.com>
2020-03-19 09:18:05 -07:00
4a5e70e00d
allow plugins/ as a valid directory in the BSL bucket
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-03-17 11:14:41 -06:00
7258167548
Merge pull request #2248 from skriss/refactor-restore-priorities
...
refactor restore priorities code to use single loop and lazy discovery
2020-03-10 12:16:42 -04:00
040f6806f1
Fix int/float conversion issues in CRD version remapping plugin ( #2322 )
...
* Add builders for CRD schemas
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add test case for #2319
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add failing test case
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove unnecessary print and temporary variable
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add some options for fixing the test case
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Switch to a JSON middle step to "fix" conversions
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add comment and changelog
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-03-10 09:24:22 -06:00
583ef4258a
refactor restore priorities code to use single loop and lazy discovery
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-03-10 08:57:50 -06:00
ed42d5a9f1
Merge pull request #2318 from ashish-amarnath/csi-core-changes
...
Add CSI snapshot API types into default restore priorities
2020-03-06 13:53:43 -05:00
b7cbc4873e
add csi types into restore priorities
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-03-06 10:37:03 -08:00
fd95a59cf7
bug fix: don't panic on nil restic repo maintenance time ( #2315 )
...
* bug fix: don't panic on nil restic repo maintenance time
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-03-05 17:11:59 -05:00
c7f283c7fa
wait for informer caches to sync before running controllers
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-03-03 15:55:17 -07:00
ac7a84cc58
update generated CRDs
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-03-02 10:55:08 -07:00
ea418ceda7
update generated CRDs
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-03-02 10:55:08 -07:00
9e19c1d3bd
fix goimport noise in prep for bump to latest
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-03-02 10:55:08 -07:00
31dca0ea1b
add GroupResources for volumesnapshot types ( #2288 )
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-02-24 11:47:35 -08:00
766ab5d3ee
Account for possible missing schemas on v1 CRDs ( #2264 )
...
* Account for possible missing schemas on v1 CRDs
If a v1beta1 CRD without a Schema was submitted to a Kubernets v1.16
cluster, then Kubernetes will server it back as a v1 CRD without a
schema.
However, when Velero tries to restore this document, the request will be
rejected as a v1 CRD must have a schema.
This commit has some defensive coding on the restore side, as well as
potential fixes on the backup side for getting around this.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Back up nonstructural CRDs as v1beta1
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add tests for remapping plugin
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add builders for v1 CRDs
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Address review feedback
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Remove extraneous log message
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add changelog
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-02-24 12:07:50 -07:00
e681759178
export restic pod annotation ( #2283 )
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-02-19 12:37:40 -07:00
b4446bd358
Fix restic backup volume snapshot to the second location failed ( #2244 )
...
* Fix restic backup volume snapshot to the second location failed
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
2020-02-19 11:01:21 -08:00
1a1372550d
Use PV name returned from volumesnapshotter while creating a PV ( #2216 )
...
* Using PV name returned from volumesnapshotter while creating a PV
Signed-off-by: mayank <mayank.patel@mayadata.io>
2020-02-10 13:17:15 -07:00
44d3f91e97
backup describer: reword resource list not found msg
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-02-06 11:40:15 -07:00
b25fea3bea
properly handle empty restic stdout during progress updates ( #2231 )
...
* properly handle empty restic stdout during progress updates
Signed-off-by: Brad Koehn <brad@koehn.com>
2020-02-03 12:49:23 -07:00
08c549a092
Restore result refactoring ( #2234 )
...
* move Result helper funcs to be methods
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-02-03 10:56:57 -08:00
c9bc6646a5
use GA topology labels for PVs ( #2219 )
...
* use GA toplogy labels for PVs
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
2020-02-03 10:47:18 -08:00
21264a11ec
Merge pull request #2218 from cpanato/GH-1168
...
remove schedule validation
2020-01-31 13:00:24 -08:00
37011ee5ac
bug fix: back up server-preferred version of CRD ( #2230 )
...
* bug fix: back up server-preferred version of CRD
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-01-31 08:45:46 -07:00
42b6126458
update variable name
...
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
2020-01-31 09:22:46 +01:00
6745979a7b
Wait for CRDs to be ready before restoring CRs ( #1937 )
...
* Wait for CRDs to be available and ready
When restoring CRDs, we should wait for the definition to be ready and
available before moving on to restoring specific CRs.
While the CRDs are often ready by the time we get to restoring a CR,
there is a race condition where the CRD isn't ready.
This change waits on each CRD at restore time.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-01-30 09:19:13 -08:00
f7adc4dfd1
check if schedule have a backup
...
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
2020-01-29 18:24:32 +01:00
445b5b781e
remove schedule validation
...
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
2020-01-29 18:24:32 +01:00
b19097f825
Pruning unknown fields ( #2187 )
...
* Pruning unknown fields
In CRD apiversion v1beta1, default preserveUnknownFields=true.
In CRD apiversion v1, the preserveUnknownFields can only be false.
Otherwise, the k8s validation bumps out error message for the
invalid preserveUnknownFields value.
Deploy Velero on k8s 1.16+ with CRD apiversion v1beta1, the
k8s cluster converts apiversion from v1beta1 to v1 automatically.
Fully backup and restore the cluster, restore bumps out error message
due to the preserveUnknownFields=true is not allowed on k8s 1.16+.
Since the CRD structural schema had been defined, enable the preserveUnknownFields
to false to solves the restore bumps out error message on k8s 1.16+.
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
* Add changelog
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
2020-01-28 14:04:28 -05:00
5b1280c2cd
Fix restore issues for CRD v1 on Kubernetes v1.16 clusters ( #2197 )
...
Fix restore issues for CRD v1 on Kubernetes v1.16 clusters
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2020-01-27 13:59:08 -08:00
ec22f2c88d
Merge pull request #2196 from skriss/fix-1777
...
recompute backup_last_successful_timestamp metric during resync
2020-01-21 17:01:51 -08:00
421dcd4e8d
Merge pull request #2201 from skriss/fix-2121
...
fix race condition in waiting for restic restores to complete
2020-01-21 15:16:08 -08:00
71201fe929
extract helper func and add unit tests
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-01-21 13:21:28 -07:00
ae316193ea
move log statement
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-01-21 12:36:46 -07:00
3b80e00d62
fix race condition in waiting for restic restores to complete
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-01-15 16:09:54 -07:00
ee0cbcf11e
Merge pull request #2199 from jnaulty/jnaulty/improve-config-file-perms
...
Restrict file permissions for config file/dir
2020-01-15 15:13:22 -05:00
254a5eebb5
Restrict file permissions for config file/dir
...
Velero client config file should have restricted file permissions to be
read/write-able for the user that creates it--similiar to files like
`.ssh/id_rsa`
Refer to OTG-CONFIG-009: Test File Permission
> Impoper file permission configuration may result in privilledge
escalation, information explousure, DLL injection, or unauthorized file
access.
Therefore, files permission must be properly configured with minium
access permission by default.
[source](https://www.owasp.org/index.php/Test_File_Permission_(OTG-CONFIG-009) )
Ticket: #1758
Signed-off-by: John Naulty <johnnaulty@bitgo.com>
2020-01-15 09:41:25 -08:00
aa44cf1c32
Check for nil LastMaintenanceTime in dueForMaintenance ( #2200 )
...
* Check for nil LastMaintenanceTime in dueForMaintenance
ResticRepository.dueForMaintenance causes a panic in the velero pod
("invalid memory address or nil pointer dereference") if
repository.Status.LastMaintenanceTime is nil. This fix returns 'true'
if it's nil, so the repository is due for maintenance if LastMaintenanceTime
is nil *or* the time elapsed since the last maintenance is greater than
repository.Spec.MaintenanceFrequency.Duration
Signed-off-by: Scott Seago <sseago@redhat.com>
* changelog for PR#2200
Signed-off-by: Scott Seago <sseago@redhat.com>
2020-01-15 12:06:16 -05:00
9fa302aa8b
recompute backup_last_successful_timestamp metric during resync
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-01-14 14:11:21 -07:00
b2acd3b683
bump go-hclog and prometheus dependency versions in prep for go modules ( #2188 )
...
* update revision of go-hclog to match go.mod requirement
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update prometheus dep to prepare for go module migration
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-01-14 11:29:37 -05:00
04d8b47d3e
update to k8s 1.17 deps and fix breaks ( #2180 )
...
* update to k8s 1.17 deps
Signed-off-by: Steve Kriss <krisss@vmware.com>
2020-01-10 08:55:58 -08:00
97b33402a4
Assign default CPU/Memory resource value if not present ( #2176 )
...
Install restic with CPU/Memory limits is optional.
If velero cannot parse resource requirements, use default value instead.
After that, the administrator won't get confused that something recovered failed.
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
2020-01-09 08:48:35 -07:00
c832e52905
add ALIBABA_CLOUD_CREDENTIALS_FILE env in deployment and daemonset installation ( #2166 )
...
Signed-off-by: haoshuwei <haoshuwei24@gmail.com>
2020-01-06 14:56:23 -08:00
408c0dfb5a
Add documentation for velero install cli ( #2155 )
...
* Add documentation for velero install cli
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* mirror doc changes into v1.2.0
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
2020-01-06 13:13:02 -07:00
93e4737258
Fix incorrect output log format ( #2165 )
...
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
2020-01-06 09:05:38 -07:00
be140985c5
bug fix: only prioritize restoring replicasets.apps ( #2157 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-12-19 09:44:08 -08:00
cd860771c2
Add error return to pvRenamer func ( #2138 )
...
Migrate logic from NewUUID function into the pvRenamer function.
PR #2133 switched to a new NewUUID function that returns an error, but
the invocation of that function needs to happen within the pvRenamer
closure. Because the new function returns an error, the pvRenamer should
return the error, the signature needs to be changed and the return
checked.
Signed-off-by: John Naulty <johnnaulty@bitgo.com>
2019-12-17 10:23:58 -08:00
ff889283b8
Switch from satori/go.uuid to gofrs/uuid
...
satori/go.uuid has a known issue with random uuid generation.
gofrs/uuid is still maintained and has fixed the random uuid generation
issue present in satori/go.uuid
Signed-off-by: John Naulty <johnnaulty@bitgo.com>
2019-12-14 10:27:00 -08:00
7c60829f38
bug fix: don't restore cluster-scoped resources by default when restoring specific namespaces ( #2118 )
...
* add failing test case for bug
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-12-12 12:45:41 -08:00
96297ea437
add replicasets.apps to prioritized restore resources ( #2120 )
...
* add replicasets.apps to prioritized restore resources
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-12-11 15:32:33 -05:00
83ef4eb4d0
Support AWS_PROFILE for restic backups/restore operations ( #2096 )
...
* Support AWS_PROFILE for restic backups/restore operations
It enables Velero to switch credentials if multiple s3-compatible
backupLocations are present.
Signed-off-by: dinesh <dinesh1042@gmail.com>
* better comments and fixing typos
Signed-off-by: dinesh <dinesh1042@gmail.com>
* add changelog entry
Signed-off-by: dinesh <dinesh1042@gmail.com>
2019-12-09 09:46:02 -05:00
f42406723c
bug fix: deep-copy backup's labels for snapshot tags ( #2075 )
...
* bug fix: deep-copy backup's labels for snapshot tags
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-12-05 12:54:19 -08:00
87be775139
Add support for private registry with custom port in restic-helper image ( #1999 )
...
* Add support for private registry with custom port in restic-helper image definition
Signed-off-by: Roman Klimenko <cognoz@ya.ru>
2019-12-04 08:01:39 -08:00
e5a85f140a
use field selector on name when watching download requests ( #2065 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-11-14 16:50:24 -08:00
5a31a78df5
add better error message when cluster config can't be found
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-11-08 15:01:12 -07:00
121dc02d2f
Ensure object store plugin processes are cleaned up after restore and after BSL validation during server start up ( #2041 )
...
* Ensure child object store plugin processes are cleaned up during restore
Signed-off-by: Antony Bett <antony.bett@gmail.com>
2019-11-05 08:58:08 -08:00
4fb1bc2ef3
restic: don't try to restore PVBs with no snapshotID ( #2031 )
...
* restic: don't try to restore PVBs with no snapshotID
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-11-04 16:18:08 -07:00
636a5b9db6
add velero install --crds-only to easily update CRDs ( #2038 )
...
* add velero install --crds-only to easily update CRDs
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* make update
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-11-04 14:36:04 -08:00
83752d28d7
Restic restore fixes ( #2013 )
...
* restic: use restore cmd's env when getting snapshot size
Signed-off-by: Steve Kriss <krisss@vmware.com>
* restic: remove code that considers 0-byte backups an error
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-10-29 07:42:12 -07:00
5d6b129ea5
fix typo in download request validation tag ( #2009 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-10-28 16:00:03 -07:00
0c1fc8195a
add --allow-partially-failed flag to velero restore create ( #1994 )
...
* add --allow-partially-failed flag to velero restore create
Signed-off-by: Steve Kriss <krisss@vmware.com>
* remove extraneous client creation
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add godoc to helper func
Signed-off-by: Steve Kriss <krisss@vmware.com>
* todo
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-10-24 14:20:57 -07:00
0450567bba
Allow backup storage locations to specify backup sync period or toggle off sync ( #1936 )
...
* Allow backup storage locations to specify backup sync period or toggle off sync
Signed-off-by: Antony Bett <antony.bett@gmail.com>
* Add --backup-sync-period flag to backup location create command
Signed-off-by: Antony Bett <antony.bett@gmail.com>
2019-10-24 08:32:45 -06:00
d26bf05b33
Extract providers ( #1985 )
...
* Remove cloud providers and reorg code
Signed-off-by: Carlisia <carlisia@vmware.com>
* Update dependencies
Signed-off-by: Carlisia <carlisia@vmware.com>
* Fix tests
Signed-off-by: Carlisia <carlisia@vmware.com>
* fix dependency issues
Signed-off-by: Carlisia <carlisia@vmware.com>
* Delete dup test
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add back spaces to file
Signed-off-by: Carlisia <carlisia@vmware.com>
* Remove and update docs
Signed-off-by: Carlisia <carlisia@vmware.com>
* Make the plugins flag required
Signed-off-by: Carlisia <carlisia@vmware.com>
* Add changelog
Signed-off-by: Carlisia <carlisia@vmware.com>
* Make the plugins flag conditional
Signed-off-by: Carlisia <carlisia@vmware.com>
2019-10-22 15:31:27 -07:00
69f993aebd
update gcr.io/heptio-images/ references to velero/ ( #1988 )
...
* update gcr.io/heptio-images/ references to velero/
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-10-22 14:39:43 -07:00
1564317cef
Restore action for cluster/namespace role bindings ( #1974 )
...
Signed-off-by: Alexander Demichev <ademicev@redhat.com>
2019-10-21 15:11:26 -06:00
f2eb072694
fix controller-gen version in builder image ( #1984 )
...
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-10-21 13:49:32 -07:00
ae33441500
Add --no-default-storage-location flag to velero install to enable velero deployment without default BSL ( #1931 )
...
This closes #1853 .
Signed-off-by: Yunqian <specyq@gmail.com>
2019-10-18 08:41:59 -06:00
92ea44e8e6
tweak test case names for clarity ( #1976 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-10-17 12:39:42 -07:00
970f17c1ef
If includeClusterResources is nil/auto, pull in necessary CRDs ( #1831 )
...
Related issue: https://github.com/heptio/velero/issues/1830
This accomplishes everything
that's needed, although there might be room for improvement in avoiding
a GET call for matching CRDs for each resource backed up. An alternative
could be a single call to get all CRDs prior to iterating over resources
and passing this into the backupResource function.
Signed-off-by: Scott Seago <sseago@redhat.com>
2019-10-17 12:31:04 -06:00
e3d64d9dd9
use pointer types for metav1.Time fields ( #1951 )
...
* use pointer types for metav1.Time fields
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* simpler metav1.Time ptrs
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove test debug println
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-10-14 10:20:28 -06:00
d868b71e29
Move validation of plugins ( #1953 )
...
* Move validation of plugins
Signed-off-by: Carlisia <carlisia@vmware.com>
2019-10-09 10:48:37 -06:00
557d170541
restic: only backup ReadWriteMany PVC's once per velero backup ( #1896 )
...
* restic: only backup ReadWriteMany PVC's once per velero backup
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-10-08 17:16:35 -04:00
d3e30dd58b
Azure china/germany support ( #1938 )
...
* feat: add azure china support
Signed-off-by: andyzhangx <xiazhang@microsoft.com>
* remove AZURE_CLOUD_NAME from required env var fetching
Signed-off-by: Steve Kriss <krisss@vmware.com>
* minor simplification of parseAzureEnvironment
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* remove cloudNameEnvVar from getRequiredValues call
Signed-off-by: Steve Kriss <krisss@vmware.com>
* just check for err != nil
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-10-08 17:13:51 -04:00
f009fe9bd1
Add --plugins flag to velero install ( #1930 )
...
* Add plugins flag to install
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-10-03 16:44:52 -07:00
db59d8d4bc
Revert "Revert "allow self signed certs with insecureSkipVerify"" ( #1793 )
...
* handle self-signed certs with insecureSkipTLSVerify server config
Signed-off-by: Steven Chung <schung@d2iq.com>
2019-10-03 13:46:46 -07:00
46822aea2c
Add support for GKE Workload Identity ( #1810 )
...
* Allow the velero server to be created on GCP even without a provided service account key in order to support workload identity and default compute engine credentials. Add option for adding service account annotations.
Signed-off-by: Joshua Wong <joshua99wong@gmail.com>
2019-10-03 13:45:18 -07:00
eadac44e10
Add option for Azure cross subscription backups ( #1895 )
...
* add option for different subscription id
Signed-off-by: Moritz Schmitz von Hülst <msc@marketlogicsoftware.com>
2019-10-03 13:31:35 -07:00
e054a2f0b3
Make "not restored" message a bit better ( #1901 )
...
* Make "not restoring" message a bit better
Signed-off-by: Carlisia <carlisia@vmware.com>
* Tweak error msg
Signed-off-by: Carlisia <carlisia@vmware.com>
* Address feedback
Signed-off-by: Carlisia <carlisia@vmware.com>
2019-10-01 16:47:21 -04:00
48792ece1f
Updates for org move to vmware-tanzu ( #1920 )
...
* update import paths to github.com/vmware-tanzu/...
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update other GH org refs to vmware-tanzu
Signed-off-by: Steve Kriss <krisss@vmware.com>
* site and docs: update GH org to vmware-tanzu
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update travis badge links on docs readmes
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-30 17:26:56 -04:00
d96186473c
sync controller: replace revision file with full diff each interval ( #1892 )
...
* backup sync controller: replace revision file with full diff each interval
Signed-off-by: Steve Kriss <krisss@vmware.com>
* remove getting/setting of metadata/revision file
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* tweak logging
Signed-off-by: Steve Kriss <krisss@vmware.com>
* don't keep podVolumeBackup log field around after syncing PVBs
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update generated CRDs
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-27 16:23:11 -04:00
ca6c0a5a3d
Increment logging for item backupper ( #1904 )
...
Signed-off-by: Christopher Phillips <cphillips918@gmail.com>
2019-09-27 13:17:54 -07:00
2d845683a2
Add LD_LIBRARY_PATH as an env varible for the use of vsphere plugin ( #1893 )
...
* Add LD_LIBRARY_PATH as an env varible for the use of vsphere plugin
Signed-off-by: Lintong Jiang <lintongj@vmware.com>
2019-09-27 13:10:00 -07:00
2e849dcb99
Fix for #1888 : check item's original namespace, not remapped one, for inclusion/exclusion ( #1909 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-25 18:01:16 -07:00
dd088e3475
velero API type changes for structural schema CRDs ( #1898 )
...
* velero API type changes for structural schema CRDs
- make optional fields consistent with comment and omitempty struct tags
- adds kubebuilder annotations for structural schema validations
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* update generated crds
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* update velero install to use structural schema generated crds
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* move enum declarations closer to type declarations
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add labels to generated crds
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* allow null values in some fields
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* allow labelSelector to be null
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove debug statement
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* make update
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add enum validations for CRD phases
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-09-24 18:37:28 -04:00
5e22f9c1c8
Generate CRDs with structural schema ( #1885 )
...
* generating CRDs with controller-tools and embedding in binary
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-09-23 10:25:48 -06:00
8ec1548b3c
Add features package ( #1849 )
...
* Add features package
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-09-18 10:57:04 -06:00
fdd04b4d90
GCP: support specifying Cloud KMS key name for backup storage locations ( #1879 )
...
GCP: support specifying Cloud KMS key for backup storage location
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-17 16:35:28 -04:00
bc60412f29
AWS: add support for arbitrary SSE algorithms, e.g. AES256 ( #1869 )
...
* AWS: add support for arbitrary SSE algorithms, e.g. AES256
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-12 10:13:46 -07:00
23376e6293
record restic restore progress in PodVolumeRestore ( #1854 )
...
* record restic restore progress in PodVolumeRestore
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add progress output to velero describe restore --details
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* test getVolumeSize
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* block on send to finish goroutine
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove sync import
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* make update
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-09-10 15:50:57 -06:00
6623e1f273
Change restic prune default interval to 7d and make user-configurable ( #1864 )
...
* change restic prune default interval to 7d, add server flag for it
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-10 11:58:42 -07:00
26e06dae53
fix excluding additional items with the exclude-from-backup label ( #1843 )
...
* fix excluding additional items with the exclude-from-backup label
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-09-10 11:45:55 -07:00
1e182e5837
record restic backup progress in PodVolumeBackup ( #1821 )
...
* record restic backup progress in PodVolumeBackup
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-09-10 11:28:19 -07:00
fc39ac6d51
Add a check to avoid nil pointer ( #1861 )
...
Signed-off-by: Carlisia <carlisia@vmware.com>
2019-09-10 09:29:32 -06:00
11190065fd
velero install: wait for restic daemonset to be ready ( #1859 )
...
* velero install: wait for restic daemonset to be ready
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-09-09 17:54:47 -04:00
8da9ef2b03
Make GCP credentials parsing errors less ambiguous ( #1850 )
...
A user encountered the following error on a GCP project:
An error occurred: some backup storage locations are invalid: error getting backup store for location "default": rpc error: code = Unknown desc = invalid character '-' in numeric literal
This error was ambiguous and took some time to track down to the fact
that their credentials file wasn't a JSON file, but instead the contents
of the private key field. This change makes the problem slightly easier
to debug.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-09-09 08:22:00 -06:00
29f29f9d61
Merge pull request #1828 from carlisia/c-1826-test-bug
...
Sort mounts in test case to avoid intermittent fail
2019-09-03 12:39:59 -06:00
966222ac0f
Sort mounts in test case to avoid intermitent fail
...
Closes #1826 .
Signed-off-by: Carlisia <carlisia@vmware.com>
2019-08-29 17:55:13 -07:00
e210626a36
create pkg/archive with functionality extracted from pkg/restore ( #1801 )
...
* move pkg/restore's backup extractor to pkg/archive
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-28 18:03:01 -07:00
60f9898ca0
restore: rename PV when remapping a namespace if PV exists in-cluster ( #1779 )
...
* rename PV during restore when cloning a namespace
Signed-off-by: Steve Kriss <krisss@vmware.com>
* rename func and vars, switch to if..else
Signed-off-by: Steve Kriss <krisss@vmware.com>
* make pv renamer func configurable for testing purposes
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add unit test cases
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* address review feedback
Signed-off-by: Steve Kriss <krisss@vmware.com>
* address review feedback
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-27 16:42:38 -07:00
ef911ff21b
when backing up PVCs with restic, explicitly specify --parent ( #1807 )
...
* when backing up PVCs with restic, explicitly specify --parent
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* address review feedback
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-27 16:37:51 -07:00
6b66a49a21
Unit tests for restic restore ( #1747 )
...
* Add unit tests for PVB restore functionality
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Add tests for restore action
Signed-off-by: Carlisia <carlisiac@vmware.com>
* TestRestoreWithRestic wip
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix build
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Mockery
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Cleanup mocks
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Remove unused mock
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Use consistent pattern for test building
Signed-off-by: Carlisia <carlisia@vmware.com>
* Test cleanup
Signed-off-by: Carlisia <carlisia@vmware.com>
* Better godoc
Signed-off-by: Carlisia <carlisia@vmware.com>
* Improve test cases
Signed-off-by: Carlisia <carlisia@vmware.com>
* Fix build
Signed-off-by: Carlisia <carlisia@vmware.com>
* Minor test cleanup
Signed-off-by: Carlisia <carlisia@vmware.com>
* New pvb test input names
Signed-off-by: Carlisia <carlisia@vmware.com>
2019-08-27 15:49:23 -07:00
7ea065a94f
Upgrade kubernetes dependencies to 1.15.3 ( #1808 )
...
* bump kubernetes dependency to 1.15.3
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-27 13:58:15 -07:00
6aa0215137
create backups from schedules using velero create backup ( #1734 )
...
* add --from-schedule to `velero backup create` to create backups from schedules
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-23 13:03:51 -07:00
686f41ebec
remove calls to restic check before/after prune ( #1794 )
...
* remove calls to restic check before/after prune
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-23 10:53:00 -07:00
32d46871cc
allow custom restic repo prefix to be specified in BSL config
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-22 10:19:22 -06:00
8b6c505817
error if restic repo identifier can't be determined
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-22 10:19:22 -06:00
efc0be5e48
Merge pull request #1781 from mesosphere/fix_url
...
fix error formatting
2019-08-22 09:32:14 -06:00
8ae40b55ec
fix error formatting
...
would interpret % as printf formatted strings
Signed-off-by: Steven Chung <schung@d2iq.com>
2019-08-21 12:49:59 -04:00
b25865f5bb
Revert "allow self signed certs with insecureSkipVerify ( #1769 )"
...
This reverts commit 8e35ce0bde
2019-08-20 11:02:27 -07:00
8e35ce0bde
allow self signed certs with insecureSkipVerify ( #1769 )
...
* patch velero to handle self-signed certs on client
you'll get this error otherwise:
x509: certificate signed by unknown authority
Signed-off-by: Steven Chung <schung@d2iq.com>
2019-08-20 10:29:02 -07:00
cfb663f795
Add the prefix to BSL config map so that object stores can use it when initializing ( #1767 )
...
Signed-off-by: Antony Bett <antony.bett@gmail.com>
2019-08-19 14:05:38 -06:00
3c8020e922
Merge pull request #1748 from nrb/fix-1743
...
Use custom namespace when creating Velero clients
2019-08-13 12:08:30 -06:00
5ef0a84128
create pod volume backups in backup's namespace during sync ( #1760 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-13 10:20:25 -07:00
363c2692a1
Use custom namespace when creating Velero clients
...
The Velero deployment did not have a way of exposing the namespace it
was installed in to the API client. This is a problem for plugins that
need to query for resources in that namespaces, such as the restic
restore process that needs to find PodVolume(Backup|Restore)s.
While the Velero client is consulted for a configured namespace, this
cannot be set in the server pod since there is no valid home directory
in which to place it.
This change provides the namespace to the deployment via the downward
API, and updates the API client factory to use the VELERO_NAMESPACE
before looking at the config file, so that any plugins using the client
will look at the appropriate namespace.
Fixes #1743
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-08-13 13:06:12 -04:00
7b7b96de74
velero install: support velero/restic pod cpu/mem requests with unbounded limits ( #1745 )
...
* support velero/restic pod cpu/mem requests with unbounded limits
explicitly treat "0" value as unbounded
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* update flag documentation
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* update restic configmap docs
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-09 12:54:04 -06:00
92b930d351
sort GVKs in output
...
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-08 15:13:35 -07:00
faef20d45a
ensure backup resource list per gvk is sorted
...
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-08 13:53:40 -07:00
c69fa4d0e1
bug fix: upload pod volume backups from *all* pods to obj storage
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-08 09:27:46 -06:00
ffa3251efc
move contents of pkg/util/test into pkg/test
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-07 08:26:00 -06:00
80692a8a39
Properly restore PVs with a reclaim policy of Retain and restic backups ( #1713 )
...
* reorganize persistent volume restore code for clarity
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-06 13:40:35 -07:00
4accb8512a
Restore from PodVolumeBackups ( #1723 )
...
* Restore from PodVolumeBackups
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Partially address code reviews
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Partially address code reviews #2
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Clean up struct
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix log messages
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix tests
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Clean up
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Add changelog
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-08-06 13:17:36 -07:00
4e1b1f9457
use Backup CR labels as tags for snapshots ( #1729 )
...
* use Backup CR labels as tags for snapshots
This allows users to define custom tags to be added to snapshots, by
specifying custom labels on the Backup CR with the `velero backup create
--labels` flag.
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-06 13:01:36 -07:00
6522ba7c42
fix bugs preventing pod volume backups from syncing properly
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-06 09:23:49 -06:00
a590fc9468
refactor GetBackupVolumeSnapshots and GetPodVolumeBackups ( #1721 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-05 15:42:01 -06:00
539e0b54c6
use the persistent --namespace flag in 'velero install' ( #1722 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-05 15:40:39 -06:00
a4e70456a1
Add resource limits to restic init container ( #1677 )
...
* Add resource limits to restic init container
Fixes #1201
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Start restic restore item action tests
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Get initial tests for restore action working
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add new test case
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Move resource parsing into a shared function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fetch request/limits from plugin's ConfigMap
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Use builders
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Use moved ParseResourceRequirements function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Move init container building inline
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Drop CPU limit down a bit and clarify error message
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fix godoc
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add resource requirements to doc
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-08-05 13:18:11 -06:00
2254635bcb
print resource list metadata in velero backup describe --details ( #1714 )
...
* print resource list metadata in velero backup describe details
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* rewrite TestGetDownloadURL to test more scenarios
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* move backup printer helpers to backup_printer.go
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* move describe printer helpers back to backup_describer
and rename to prefix with describe* to indicate that they are used for the describe command
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* split backup and restore tests for TestGetDownloadURL
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* friendlier error message when backup resource list missing
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-05 12:23:20 -06:00
07525bd593
store backup resource list metadata in object storage ( #1709 )
...
* move backedUpItems to pkg/backup.Request struct
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* construct resource itemKey field from gvk
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* store backup resource list metadata in object storage
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove debug log
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* fix formatting
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add missing license blocks and split BackupInfo struct lines
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add test for checking BackedUpItems matches tarball contents
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* add comment to explain test
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-05 11:15:55 -06:00
635dd27e1a
Make secret file optional on install ( #1699 )
...
* Make secret file optional on install
Fixes #1689
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-08-01 15:57:36 -07:00
2a6929d453
add velero install flags for configuring restic resource requirements ( #1710 )
...
* add velero install flags for configuring restic resource requirements
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-07-31 12:24:47 -07:00
b24a603711
periodically check for stale restic repo locks ( #1708 )
...
* periodically check for stale restic repo locks
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* only try to init a restic repo if it doesn't already exist
Signed-off-by: Steve Kriss <krisss@vmware.com>
* reword comment
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-31 10:52:23 -07:00
f2d06bc5e9
strip leading/trailing slashes from BSL bucket & prefix vals ( #1694 )
...
* strip leading/trailing slashes from BSL bucket & prefix vals
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-31 08:27:12 -07:00
4543258970
Update tests to use object builders in pkg/builder ( #1707 )
...
* add pkg/builder with BackupBuilder and ObjectMeta functional options
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-31 07:46:48 -07:00
22eca22ac8
Add JSON as an option for log output ( #1654 )
...
* Add JSON as an option for log output
Signed-off-by: Donovan Carthew <donovan.carthew@gmail.com>
2019-07-30 16:29:34 -07:00
bf247836e6
Migrate restic backup tests ( #1703 )
...
* migrate pkg/backup restic tests to new structure
Signed-off-by: Steve Kriss <krisss@vmware.com>
* rename backup_new_test.go to backup_test.go
Signed-off-by: Steve Kriss <krisss@vmware.com>
* use pod volume backup builder
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-29 15:29:44 -07:00
248ee89123
add configurable CPU/memory requests/limits for velero pod on install ( #1678 )
...
* add configurable CPU/memory requests/limits for velero pod on install
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-07-29 15:13:06 -04:00
52d97e7bd7
proposal: expose list of backed up resources in backup details ( #1682 )
...
* proposal: expose list of backed up resources in backup details
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-07-29 14:00:56 -04:00
3b9af8c654
Store PodVolumeBackups in obj storage & use as source of truth ( #1577 )
...
* Store PodVolumeBackups in object storage
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-07-24 15:51:20 -04:00
3c4dd3e526
fix typo in schedule create example ( #1693 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-23 11:02:38 -07:00
5f409f12c8
Document --pod-annotations install argument ( #1674 )
...
* Document --pod-annotations install argument
Fixes #1667
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Revert v1.0.0 edits
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Make pod annotations example commands complete
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-19 12:12:57 -07:00
aa8c0cd471
Honor kube client flags in install command ( #1656 )
...
Flags specifying the kubeconfig or kubecontext to use weren't actually
being used by the install command.
Fixes #1651
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-17 14:19:14 -07:00
3124570c7f
Remove references to apps/v1beta1 API group ( #1673 )
...
* Remove references to apps/v1beta1 API group
In Kubernetes v1.16, the apps/v1 API group will be the default served
for relevant resources.
Update any references to apps/v1beta1 for fowards compatibility.
Fixes #1672
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Update API group on plugin commands
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-17 15:03:48 -06:00
1bb167ef90
add restore item action to change PVC/PV storage class name ( #1621 )
...
* add restore item action to change PVC/PV storage class name
Signed-off-by: Steve Kriss <krisss@vmware.com>
* code review
Signed-off-by: Steve Kriss <krisss@vmware.com>
* change existing plugin names to lowercase/hyphenated
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add validation for new storage class name
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add test cases
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* fix imports
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update plugin names to be more consistent
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update unit tests to use pkg/test object constructors
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-15 11:19:38 -07:00
63964fc6f9
Append "/mount" to directory for CSI volumes ( #1615 )
...
CSI volumes are mounted one level deeper than "native" kubernetes
volumes, and this needs to be appended for proper restic support.
Fixes #1313 .
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-10 15:16:21 -07:00
d1025f7547
rename restore_new_test.go to restore_test.go
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-10 09:59:27 -06:00
678c02c560
move contents of restore_test.go into other files and delete it
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-10 09:59:01 -06:00
afa49f398f
bug fix: Fixed namespace usage with cli command 'version'
...
Signed-off-by: John Matthews <jwmatthews@gmail.com>
2019-07-07 13:54:46 -04:00
f829dabcf4
Add pod-annotations CLI flag to the install command ( #1626 )
...
* allow users to specify additional Velero/restic pod annotations on the command line with the pod-annotations flag
Signed-off-by: Traci Kamp <traci.kamp@gmail.com>
2019-07-03 15:22:34 -07:00
eec5cc687e
validate pod volumes hostpath mount on restic server startup ( #1616 )
...
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-07-03 14:20:31 -06:00
bf00754280
fix schedule create examples to use hours as units ( #1625 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-03 12:20:49 -07:00
567802299b
move PV/PVC setup helpers into pkg/test
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-03 08:50:11 -06:00
adb93c33b1
migrate restore PV tests
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-03 08:50:09 -06:00
e371ba78b0
Merge pull request #1612 from skriss/restore-addl-items-bugs
...
properly filter additional items returned from restore item actions
2019-06-28 17:12:38 -04:00
2156124dfc
record PodVolumeBackup/Restore start and completion timestamps ( #1609 )
...
* record PodVolumeBackup start and completion timestamps
adds startTimestamp and completionTimestamp fields to the
PodVolumeBackup status spec
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* record PodVolumeRestore start and completion timestamps
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-28 11:58:02 -04:00
db393ec199
properly filter additional items returned from restore item actions
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-28 08:59:23 -06:00
022099a62e
Refactor pkg/restore tests (part 3) ( #1611 )
...
* add modifying restore item action tests
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add restore item action additional items tests
Signed-off-by: Steve Kriss <krisss@vmware.com>
* migrate ShouldRestore test
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-27 15:43:59 -07:00
75a96dfa92
fix bugs in finding applicable restore item actions
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-27 13:06:16 -06:00
81c2adc059
Refactor pkg/restore tests (part 2) ( #1606 )
...
* update TestPrioritizeResources to use real discovery helper
Signed-off-by: Steve Kriss <krisss@vmware.com>
* migrate invalid tarball contents tests
Signed-off-by: Steve Kriss <krisss@vmware.com>
* migrate item restore tests
Signed-off-by: Steve Kriss <krisss@vmware.com>
* migrate restore item action tests
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-27 11:57:47 -07:00
0089fa4d93
migrate restore resource priorities test
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-26 10:24:02 -06:00
5d8ba1b90d
migrate namespace mapping tests
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-24 16:57:30 -06:00
1a339f06ac
migrate restore resource filtering tests
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-24 15:53:15 -06:00
b0bdaeea73
ensure correct backup item actions run with namespace selector ( #1601 )
...
* ensure correct backup item actions run with namespace selector
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* don't run backup item actions for namespace resources
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* simplify cluster-scope resources checks
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-24 15:50:25 -06:00
08fe7be851
Fix test conflicts from #1595 and #1598 ( #1602 )
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-06-24 15:34:56 -06:00
67512a3808
Merge pull request #1595 from skriss/restore-test-refactor-1
...
initial refactoring for pkg/restore tests
2019-06-24 17:08:51 -04:00
37c7b618ad
Merge pull request #1598 from skriss/rm-has-controller-owner
...
remove unused hasControllerOwner func and tests
2019-06-24 16:51:28 -04:00
5634a4f463
migrate backup hooks tests ( #1591 )
...
* migrate hooks tests
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add more test cases
Signed-off-by: Steve Kriss <krisss@vmware.com>
* refactor to strongly typed expectation, add pre+post hook test case
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-24 12:23:17 -07:00
19052994ed
replace TestBackup with pkg/backup.Builder ( #1593 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-21 17:08:08 -04:00
0d326a3903
remove unused hasControllerOwner func and tests
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-21 11:44:13 -06:00
d421fcd85c
initial structure for refactored pkg/restore tests
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-21 09:15:18 -06:00
0735ee7218
extract shared API test helpers to pkg/test
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-20 14:57:31 -06:00
1f4139a5bf
allow exclusion of resources using standard label ( #1588 )
...
* allow exclusion of resources using standard label
excludes any resources with the velero.io/exclude-from-backup=true label
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-19 10:58:02 -04:00
2d81e29276
ensure backup item action modifications reflected in tarball filepath ( #1587 )
...
* ensure backup item action modifications reflected in tarball filepath
This patch ensures the updated backup item's name and namespace are used
when constructing the filepath for the tarball.
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-18 12:19:00 -06:00
e2bf39a027
migrate PV snapshot tests
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-12 13:03:32 -06:00
6513e8f30e
migrate more backup action tests, remove obsolete test code ( #1564 )
...
* migrate more backup action tests, remove obsolete test code
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-12 14:45:04 -04:00
49f52b54b2
Merge pull request #1562 from carlisia/c-bug-sort
...
Fix test comparison
2019-06-11 12:34:35 -06:00
74b575200c
hide server commands in velero CLI ( #1561 )
...
* hide server commands in velero CLI
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove unnecessary comment
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-10 19:20:17 -06:00
520077c3a9
Fix test comparison
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-06-10 16:34:29 -07:00
e183c4b597
remove glog ( #1559 )
...
* remove glog refs, replace with klog equivalents
Signed-off-by: Steve Kriss <krisss@vmware.com>
* remove glog from deps
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-10 15:44:44 -07:00
d6c60b2dd5
fix panic when processing DeleteBackupRequest objs without labels ( #1556 )
...
This fix initialises an empty map if the request object's Labels map
is nil, allowing the controller to later add and modify labels on the
object.
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-10 10:04:51 -07:00
9e7ff4e3d9
Refactoring for backup item action tests ( #1545 )
...
* migrate and enhance backup item action tests
Signed-off-by: Steve Kriss <krisss@vmware.com>
* migrate terminating resource test
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add godoc for test functions
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-09 21:02:49 -07:00
bb12cbd2d7
Support for multiple AWS profiles ( #1548 )
...
* added support for multiple AWS credential profiles
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
2019-06-07 11:01:39 -07:00
0a771e6a53
Add cmd to list plugins ( #1535 )
...
* Add cmd to list plugins
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-06-05 13:41:02 -04:00
bc7ee686d7
Merge pull request #1428 from guilhem/glob
...
Add ability to use wildcard in includes/excludes
2019-06-05 09:53:37 -06:00
81a26e4aad
Add ability to use wildcard in includes/excludes
...
Use https://github.com/gobwas/glob as glob engine
Fix #373
Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>
2019-06-05 16:28:25 +02:00
caa0bff5a3
Initial pkg/backup test refactoring ( #1532 )
...
Initial pkg/backup test refactoring
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-04 19:47:22 -07:00
0804f34644
Don't log error if restic volume is empty ( #1480 )
...
* Don't log error if restic volume is empty
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-05-30 12:48:21 -04:00
411d44a673
allow individual backup storage locations to be read-only ( #1517 )
...
* allow individual backup storage locations to be read-only
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-29 14:21:25 -04:00
9287505f62
fixes for breaking changes
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-20 13:25:36 -06:00
02c7df9ea0
update generated code
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-20 13:25:36 -06:00
b3c6e5e483
Add more examples to schedule create ( #1473 )
...
Partially addresses #1464
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-05-13 09:25:25 -07:00
c209f0c0c3
Add snapshot-location to `velero create` command ( #1472 )
...
`velero snapshot-location create` existed, but not `velero create
snapshot-location`; update subcommand for parity with backup-location
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-05-13 09:23:25 -07:00
e0bc14d56b
Add flag to disable creation of VSL on install
...
Fixes #1453
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-05-09 15:04:42 -04:00
58d34700da
Add new gauge to hold the timestamp of the last successful backup ( #1448 )
...
* add new gauge to hold the timestamp of the last sucessfull backup
Signed-off-by: fabito <fuechi@ciandt.com>
* add changelog entry
Signed-off-by: fabito <fuechi@ciandt.com>
* fix gauge name
Signed-off-by: fabito <fuechi@ciandt.com>
* renaming metric to backup_last_successful_timestamp
Signed-off-by: fabito <fuechi@ciandt.com>
* fix typo
Signed-off-by: fabito <fuechi@ciandt.com>
* ✏️ fix typo II
Signed-off-by: fabito <fuechi@ciandt.com>
* 🔀 rename method
Signed-off-by: fabito <fuechi@ciandt.com>
2019-05-08 07:00:26 -06:00
05b8edf894
Merge pull request #1457 from skriss/shortcuts-perf-issue
...
shortcut expander: use discovery helper's cached resource list
2019-05-07 15:57:12 -04:00
90c89f764e
shortcut expander: use discovery helper's cached resource list
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-07 12:23:45 -06:00
24d28c8633
Check for backup existence before download ( #1447 )
...
* check for backup existence in download command
Signed-off-by: fabito <fuechi@ciandt.com>
2019-05-06 12:24:29 -04:00
884e512f93
Use latest container image when version is empty ( #1439 )
...
When using `velero install`, the image used should be a reasonable
default, even if buildinfo.Version is missing (such as when using `go
build` directly).
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-05-03 11:10:47 -07:00
de79f4d0b7
Merge pull request #1405 from skriss/gcp-project
...
GCP: add optional 'project' config to volume snapshot location
2019-05-03 11:24:42 -04:00
2406994740
remove ref to v0.10 from BSL validation error msg ( #1429 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-02 11:20:50 -07:00
4e12b08953
Validate restore name label length
...
Velero should handle cases when the label length exceeds 63 characters.
- if the length of the backup/restore name is <= 63 characters, use it as the value of the label
- if it's > 63 characters, take the SHA256 hash of the name. the value of
the label will be the first 57 characters of the backup/restore name
plus the first six characters of the SHA256 hash.
Fixes heptio#1021
Signed-off-by: Anshul Chandra <anshulc@vmware.com>
2019-05-01 10:25:11 -07:00
28612afa27
Merge pull request #1416 from skriss/restic-connect
...
switch to snapshots cmd for checking repo exists
2019-04-30 12:24:17 -04:00
660080e6f3
remove all remaining legacy Ark references ( #1415 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-29 12:33:54 -07:00
dea81bbe15
switch to snapshots cmd for checking repo exists
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-29 12:19:03 -06:00
3b5de11c74
update to optionally use distinct snapshot vs volume project
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-29 09:47:13 -06:00
4ed63edea0
GCP: add optional 'project' config to volume snapshot location
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-29 09:47:13 -06:00
8392e6d83f
add PartiallyFailed phase for backups, log+continue on errors ( #1386 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-26 09:14:26 -07:00
42f351b000
Merge pull request #1407 from nrb/bucket-dashes
...
Throw an error on an invalid bucket name
2019-04-25 15:41:19 -06:00
bf19623e82
Merge pull request #1389 from skriss/restore-partially-failed
...
Add PartiallyFailed phase for restores
2019-04-25 17:06:26 -04:00
9e19ab8d8b
Throw an error on an invalid bucket name
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-25 16:26:03 -04:00
011db15f1c
azure: restore volumes with zone ( #1298 )
...
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
2019-04-25 11:25:57 -07:00
58bb7ed3aa
Merge pull request #1390 from carlisia/c-check-for-backup-III
...
Fail backup if it already exists in object storage
2019-04-24 17:31:48 -04:00
6f496a8921
Bug fix
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-24 14:18:24 -07:00
3155bb159f
remove VolumeBackupInfo from API pkg ( #1388 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 13:16:03 -07:00
dcd663b8cf
bug fix: set discovery helper's logger in constructor ( #1399 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 13:12:03 -07:00
fc25f0ae89
Clean up + changelog
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-24 12:04:19 -07:00
c201a2c103
fix describer output
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 12:57:40 -06:00
1a55964326
update CLI outputs for PartiallyFailed phase
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 12:57:40 -06:00
eb30ec0666
move restores to PartiallyFailed if >=1 error in restore results
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 12:57:40 -06:00
7d28f82540
Address code review
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-24 10:54:43 -07:00
38ccb40ca1
Add back code and tests
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-23 16:19:49 -07:00
c59d03dfb1
Fix test?
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-22 15:22:58 -07:00
c7bb288d87
More clean up
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-22 15:22:58 -07:00
05a88345e5
Code clean up
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-22 15:22:58 -07:00
01d0b026e9
Fail backup if it already exists in object storage
...
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
2019-04-22 15:22:58 -07:00
134323fbf7
Merge pull request #1385 from nrb/deploy-tags
...
Provide more specific label for velero deployment
2019-04-19 12:37:28 -06:00
8870281afc
Merge pull request #1353 from fabito/gauge-for-number-of-backups-and-restores
...
Add gauge metrics for number of existing backups and restores
2019-04-19 12:52:55 -04:00
6dd007b507
remove deprecated hooks (replaced by pre hooks) ( #1384 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-19 08:40:35 -07:00
e85c367ce5
Provide more specific label for velero deployment
...
Using only the `component: velero` selector caused the restic pods to be
matched, as well, which made things such as `kubectl logs` return too
much information.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-18 14:18:21 -04:00
b01b12472f
Merge pull request #1375 from ctrox/gcp-snapshot-location
...
GCP: Implement configurable snapshot location
2019-04-18 12:06:18 -04:00
475cf2ab60
add new metrics (gauges): backup_total and restore_total
...
Signed-off-by: fabito <fuechi@ciandt.com>
2019-04-18 01:28:38 -03:00
f8f0d15da2
Add --namespace parameter to install command ( #1380 )
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-17 09:38:14 -07:00
6020823aaf
Add config parameter for gcp to customize the snapshot location
...
Signed-off-by: Cyrill Troxler <cyrill@nine.ch>
2019-04-17 18:34:09 +02:00
0750b2c789
Merge pull request #1367 from skriss/restic-repo-fixes
...
Restic repository management fixes
2019-04-17 11:49:17 -04:00
975bec692b
Merge pull request #1378 from skriss/move-restore-result
...
move RestoreResult from api to pkg/restore, rename to Result
2019-04-17 11:29:18 -04:00
5bc6695109
move RestoreResult from api to pkg/restore, rename to Result
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-16 12:57:02 -06:00
8c9ae491f0
Fix restic repository identifier
...
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
2019-04-16 12:24:25 -04:00
6f474016a6
Add velero install command ( #1287 )
...
Add velero install command
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-15 14:10:11 -07:00
bc8f07f963
Azure: add support for loading env vars from a file, $AZURE_CREDENTIALS_FILE ( #1364 )
...
* azure: load env vars from AZURE_CREDENTIALS_FILE if it exists
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 14:05:13 -07:00
94f014101d
Merge pull request #1323 from skriss/v1.0-removals
...
v1.0 removals
2019-04-15 16:24:02 -04:00
c38def0849
Merge pull request #1370 from skriss/install-fixes
...
add some missing config to pkg/install daemonset, deployment
2019-04-15 15:45:52 -04:00
66c6d7a026
add some missing config to pkg/install daemonset, deployment
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 13:12:35 -06:00
373e4c9abe
update daemonset log to show version and SHA
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 11:27:04 -06:00
c59544cb79
remove backup.status.volumeBackups and all related code
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:40 -06:00
6ed4e1f147
remove legacy metrics
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
b04d6b02f3
remove support for legacy restic annotations
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
7f36f78aee
remove code that removes legacy GC finalizer from backups
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
892673816b
remove legacy restore label
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
c8c03a38e9
remove support for legacy Azure snapshot ID format
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
ede9a8f5b4
remove support for legacy client config file
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
b87de94723
remove legacy hook annotation support
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
77e648eafa
remove Ark field from RestoreResult
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:02 -06:00
d49008dec0
remove Ark API pkg and generated code
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:15:18 -06:00
b03da3c0ed
remove code referencing Ark API pkg
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:15:18 -06:00
3ed97db550
Merge pull request #1362 from nrb/include-resources-examples
...
Add example for restoring with --include-resources
2019-04-12 14:45:15 -06:00
44acdcbc60
repo ensurer: fix channel lifecycles
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 14:43:40 -06:00
5d06bd4ab9
restic repo controller: lower resync period to 5min
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 14:43:40 -06:00
0328a70ff0
repo ensurer: rename readyChans to repoChans
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 14:43:40 -06:00
8d61cb0384
repo ensurer: wait at most one minute for repo to become ready
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 14:43:40 -06:00
f879670906
repo ensurer: return error if new repo becomes NotReady
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 14:43:40 -06:00
7251c8ca81
restic: change log statement from error to debug
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 14:43:40 -06:00
02cbb77dea
Merge pull request #1366 from nrb/fix-1363
...
Prepend velero.io to non-namespaced names
2019-04-12 14:43:17 -06:00
d679498c8a
Add example for restoring with --include-resources
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-12 16:36:39 -04:00
c326f59627
Prepend velero.io to non-namespaced names
...
Prior to 1.0, user-provided values such as cloud provider names didn't
need to be namespaced. This change allows those values to continue
working without the user editing the fields manually.
Fixes #1363
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-12 16:31:16 -04:00
3116185e5b
instantiate plugin manager with per-restore logger so plugin logs are captured
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-12 10:36:20 -06:00
abee09aa2d
Add validation for plugin name format and dups ( #1339 )
...
* Add validation for plugin name format and dups
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Bug fix
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Add changelog
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Address code reviews
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix code
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Address code reviews
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Add documentation
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Update godoc
Signed-off-by: Carlisia <carlisiac@vmware.com>
* More doc
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-12 08:25:04 -06:00
0e0f357cef
Added ability to disable controllers ( #1326 )
...
Signed-off-by: James King <james.king@emc.com>
2019-04-10 15:41:28 -04:00
23c0d3f612
Merge pull request #1352 from rohandvora/default-backup-ttl
...
Set default backup TTL
2019-04-09 15:34:32 -06:00
4beb8aab3c
Set default backup TTL
...
Set default backup TTL to 30 days when TTL
is not provided in the backup yaml configuration.
Updates #138
Signed-off-by: Rohan Vora <vorar@vmware.com>
2019-04-09 14:13:29 -07:00
13eaad0e64
Refactor protobuf ( #1354 )
...
* Update protobuffs
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-09 13:50:05 -04:00
956152d6e1
Merge pull request #1355 from nrb/backup-examples
...
Add examples to backup create command
2019-04-09 08:15:00 -06:00
bca21a1ec0
Add examples to backup create command
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-05 14:40:05 -04:00
2f47ca62ad
always allow 'bucket' as a config key for object stores ( #1349 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-05 11:24:55 -07:00
a519547efc
Adds support for allowing a RestoreItemAction to skip item restore ( #1336 )
...
* Adds support for allowing a RestoreItemAction to skip item restore
This allows a RestoreItemAction plugin to signal to velero that
the returned item should be skipped rather than restored to the
cluster.
To support this, a boolean SkipRestore attribute is added to
RestoreItemActionExecuteOutput. If restore.restoreResource finds
this set to true, any remaining actions on this item are skipped,
and restore on this item is skipped. Execution continues with
the next item of this resource type.
To signal this for a particular item, the RestoreItemAction's
Execute method should call WithoutRestore() on the
RestoreItemActionExecuteOutput before returning it.
Signed-off-by: Scott Seago <sseago@redhat.com>
* Autogenerated code to support SkipRestore
Signed-off-by: Scott Seago <sseago@redhat.com>
* Added changelog for #1336
Signed-off-by: Scott Seago <sseago@redhat.com>
2019-04-04 13:39:54 -06:00
0167539a14
add new counter metrics for backup deletion ( #1280 )
...
* compute backup deletion metrics (attempt, success, fail)
Signed-off-by: fabito <fuechi@ciandt.com>
2019-04-04 14:25:59 -04:00
2e3f00f64d
Merge pull request #1340 from carlisia/c-copy
...
Fix copyright
2019-04-01 15:49:06 -06:00
c3a933d3e3
Merge pull request #1338 from skriss/validate-config-keys
...
objectstores/volumesnapshotters: check for invalid keys in config
2019-04-01 15:11:15 -04:00
bbd28a9fb9
Merge pull request #1337 from skriss/logs-cmd-validation
...
logs commands: validate item exists & is finished processing
2019-04-01 15:10:52 -04:00
23b1098950
Fix copyright
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-04-01 12:06:14 -07:00
1d3d66aa77
logs commands: validate backup/restore exists & is finished processing
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-01 12:39:02 -06:00
40c7fbce09
Gracefully handle failed API groups from the discovery API ( #1293 )
...
* log details and continue executing if error of type ErrGroupDiscoveryFailed is returned by discovery API
Signed-off-by: fabito <fuechi@ciandt.com>
2019-04-01 14:27:37 -04:00
6bf29e17aa
objectstores/volumesnapshotters: check for invalid keys in config
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-01 08:15:24 -06:00
7298a4eda0
allow restic restore helper image to be specified via ConfigMap ( #1311 )
...
* allow restic restore helper image to be specified via ConfigMap
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-29 17:11:34 -04:00
2a36cdcbf6
set backup start timestamp before patching to inprogress ( #1330 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-29 13:33:50 -07:00
dcee310745
improve handling of custom S3 URLs ( #1331 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-29 13:32:43 -07:00
a696cd09f2
remove Warning from restore item action output ( #1318 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-28 13:08:37 -07:00
be42ea782d
turn down log levels in plugin server to DEBUG ( #1325 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-28 12:44:26 -07:00
9b635c0e14
add additionalItems to restore item actions ( #1304 )
...
* add additionalItems to restore item actions
Signed-off-by: Steve Kriss <krisss@vmware.com>
Co-authored-by: Andy Goldstein <goldsteina@vmware.com>
2019-03-28 12:21:56 -07:00
477e42286c
Bump plugin client version ( #1319 )
...
* Bump plugin client version
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-03-28 11:34:43 -04:00
21f3169ad3
Merge pull request #1321 from skriss/rename-block-store
...
rename BlockStore to VolumeSnapshotter
2019-03-28 11:33:06 -04:00
86293b68b3
don't wrap io.EOF errors during gRPC streaming
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-27 16:22:28 -06:00
bb9c3f6a1a
rename BlockStore to VolumeSnapshotter
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-27 14:55:28 -06:00
3f2c28f6bb
Merge pull request #1301 from skriss/plugins-error-location
...
log error locations from plugin logger and don't overwrite in client
2019-03-27 11:21:52 -04:00
7b0d8217de
send plugin error stack traces over gRPC and log error locations
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-27 08:34:03 -06:00
f8baf4f4f0
Fix for #1312 , use describe to determine if AWS EBS snapshot is encrypted and explicitly pass that value in EC2 CreateVolume call. ( #1316 )
...
Signed-off-by: Matt Stump <mstump@vorstella.com>
2019-03-26 17:30:27 -07:00
b1c0e9c49b
update plugins to work with updated go-plugin ( #1308 )
...
* update plugins to work with updated go-plugin
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-21 12:32:18 -07:00
7af9f8d74e
compile only once for regexp.MustCompile
...
Signed-off-by: pei0804 <peeeei0804@gmail.com>
2019-03-21 21:51:48 +09:00
ff2db31b32
log error locations from plugin logger and don't overwrite in client
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-20 16:13:37 -06:00
a111eed2af
update license headers to Velero contributors ( #1302 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-20 12:32:48 -07:00
a71e43b2b7
Split velero plugin client into its own package
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-03-19 16:05:37 -07:00
1eac10ca9f
Merge pull request #1288 from carlisia/c-plugins-II
...
Split plugin framework into its own package
2019-03-19 16:44:58 -06:00
7dfe58d37f
Split plugin framework into its own package
...
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-03-19 15:36:31 -07:00
7d66fc31bd
pkg/restic: check for & skip hostPath PVC/PVs
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-19 08:57:47 -06:00
183bea369d
make resticrepositories non-restorable resources ( #1296 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-18 11:38:37 -07:00
73514a003b
Move plugin interfaces to same package ( #1264 )
...
* Move plugin interfaces to same package
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-03-14 16:35:06 -04:00
7674332313
pass --log-level to plugins ( #1278 )
...
Plumb the log level through to plugin processes
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-14 10:53:36 -07:00
409116fce8
add basic plugin panic handlers ( #1270 )
...
* add server-side panic handlers to all plugin methods
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-03-13 14:07:52 -04:00
503b112638
Add location resources and tests ( #1277 )
...
Add locations and tests to install package
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-03-13 11:23:00 -06:00
89ca2571f3
AWS zone on volume IDs
...
Signed-off-by: Travis Sturzl<travis@metismachine.com>
2019-03-12 13:04:33 -06:00
394548afcd
Merge pull request #1254 from skriss/remove-wait-for-pv
...
remove restore code that waits for a PV to become Available
2019-03-11 13:20:59 -04:00
Carlisia Campos
Ashish Amarnath
Nolan Brubaker
Daniel Thrasher
Steve Kriss
Christoph Blecker
Jonas Rosland
Rafael Brito
Martin Odstrčilík
FNU Raghavendra Manjunath
Mayank
Samuel Lucidi
Samuel Lucidi
JenTing Hsiao
Brad Koehn
Carlos Tadeu Panato Junior
John Naulty
Scott Seago
Shuwei Hao
Dinesh Yadav
Roman Klimenko
Antony S Bett
Adnan Abdulhussein
Adnan Abdulhussein
Alexander Demichev
FrankChen7
Steve Chung
Joshua Wong
Moritz Schmitz von Hülst
Christopher Angelo Phillips
lintongj
KubeKween
Steven Chung
carthewd
John Matthews
Traci Kamp
Carlisia
Pranav Gaikwad
Guilhem Lettron
Fábio Franco Uechi
Anshul Chandra
Sylvain Rabot
Andy Goldstein
Steve Kriss
Nolan Brubaker
Cyrill Troxler
Jason Montleon
Aman Wangde
Rohan Vora
Fábio Franco Uechi
Matt Stump
pei0804
tsturzl