vmware-tanzu
/
velero
mirror of https://github.com/vmware-tanzu/velero.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,406 Commits
33 Branches
161 Tags
122 MiB
Commit Graph

772 Commits (069c9a07512c48743ecd7bf22089f5b1c5d9b49d)

Author SHA1 Message Date
Nolan Brubaker c326f59627 Prepend velero.io to non-namespaced names 
Prior to 1.0, user-provided values such as cloud provider names didn't
need to be namespaced. This change allows those values to continue
working without the user editing the fields manually.

Fixes #1363

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
 2019-04-12 16:31:16 -04:00
Steve Kriss 3116185e5b instantiate plugin manager with per-restore logger so plugin logs are captured 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-04-12 10:36:20 -06:00
KubeKween abee09aa2d Add validation for plugin name format and dups (#1339) 
* Add validation for plugin name format and dups

Signed-off-by: Carlisia <carlisiac@vmware.com>

* Bug fix

Signed-off-by: Carlisia <carlisiac@vmware.com>

* Add changelog

Signed-off-by: Carlisia <carlisiac@vmware.com>

* Address code reviews

Signed-off-by: Carlisia <carlisiac@vmware.com>

* Fix code

Signed-off-by: Carlisia <carlisiac@vmware.com>

* Address code reviews

Signed-off-by: Carlisia <carlisiac@vmware.com>

* Add documentation

Signed-off-by: Carlisia <carlisiac@vmware.com>

* Update godoc

Signed-off-by: Carlisia <carlisiac@vmware.com>

* More doc

Signed-off-by: Carlisia <carlisiac@vmware.com>
 2019-04-12 08:25:04 -06:00
Aman Wangde 0e0f357cef Added ability to disable controllers (#1326) 
Signed-off-by: James King <james.king@emc.com>
 2019-04-10 15:41:28 -04:00
Rohan Vora 4beb8aab3c Set default backup TTL 
Set default backup TTL to 30 days when TTL
is not provided in the backup yaml configuration.

Updates #138

Signed-off-by: Rohan Vora <vorar@vmware.com>
 2019-04-09 14:13:29 -07:00
sseago a519547efc Adds support for allowing a RestoreItemAction to skip item restore (#1336) 
* Adds support for allowing a RestoreItemAction to skip item restore

This allows a RestoreItemAction plugin to signal to velero that
the returned item should be skipped rather than restored to the
cluster.

To support this, a boolean SkipRestore attribute is added to
RestoreItemActionExecuteOutput. If restore.restoreResource finds
this set to true, any remaining actions on this item are skipped,
and restore on this item is skipped. Execution continues with
the next item of this resource type.

To signal this for a particular item, the RestoreItemAction's
Execute method should call WithoutRestore() on the
RestoreItemActionExecuteOutput before returning it.

Signed-off-by: Scott Seago <sseago@redhat.com>

* Autogenerated code to support SkipRestore

Signed-off-by: Scott Seago <sseago@redhat.com>

* Added changelog for #1336

Signed-off-by: Scott Seago <sseago@redhat.com>
 2019-04-04 13:39:54 -06:00
Fábio Franco Uechi 0167539a14 add new counter metrics for backup deletion (#1280) 
* compute backup deletion metrics (attempt, success, fail)

Signed-off-by: fabito <fuechi@ciandt.com>
 2019-04-04 14:25:59 -04:00
Steve Kriss a774b54ae7 changelog fixes 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-04-02 15:16:47 -06:00
Nolan Brubaker c3a933d3e3
Merge pull request #1338 from skriss/validate-config-keys 
objectstores/volumesnapshotters: check for invalid keys in config
 2019-04-01 15:11:15 -04:00
Nolan Brubaker bbd28a9fb9
Merge pull request #1337 from skriss/logs-cmd-validation 
logs commands: validate item exists & is finished processing
 2019-04-01 15:10:52 -04:00
Steve Kriss 1d3d66aa77 logs commands: validate backup/restore exists & is finished processing 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-04-01 12:39:02 -06:00
Fábio Franco Uechi 40c7fbce09 Gracefully handle failed API groups from the discovery API (#1293) 
* log details and continue executing if error of type ErrGroupDiscoveryFailed is returned by discovery API

Signed-off-by: fabito <fuechi@ciandt.com>
 2019-04-01 14:27:37 -04:00
Steve Kriss 6bf29e17aa objectstores/volumesnapshotters: check for invalid keys in config 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-04-01 08:15:24 -06:00
Steve Kriss 7298a4eda0 allow restic restore helper image to be specified via ConfigMap (#1311) 
* allow restic restore helper image to be specified via ConfigMap

Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-29 17:11:34 -04:00
Steve Kriss 2a36cdcbf6 set backup start timestamp before patching to inprogress (#1330) 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-29 13:33:50 -07:00
Steve Kriss dcee310745 improve handling of custom S3 URLs (#1331) 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-29 13:32:43 -07:00
Steve Kriss a696cd09f2 remove Warning from restore item action output (#1318) 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-28 13:08:37 -07:00
Steve Kriss 9b635c0e14 add additionalItems to restore item actions (#1304) 
* add additionalItems to restore item actions

Signed-off-by: Steve Kriss <krisss@vmware.com>
Co-authored-by: Andy Goldstein <goldsteina@vmware.com>
 2019-03-28 12:21:56 -07:00
KubeKween 477e42286c Bump plugin client version (#1319) 
* Bump plugin client version

Signed-off-by: Carlisia <carlisiac@vmware.com>
 2019-03-28 11:34:43 -04:00
Steve Kriss e4e0ed68a6 changelog 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-27 14:58:11 -06:00
Nolan Brubaker 3f2c28f6bb
Merge pull request #1301 from skriss/plugins-error-location 
log error locations from plugin logger and don't overwrite in client
 2019-03-27 11:21:52 -04:00
Steve Kriss 7b0d8217de send plugin error stack traces over gRPC and log error locations 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-27 08:34:03 -06:00
Matt Stump f8baf4f4f0 Fix for #1312, use describe to determine if AWS EBS snapshot is encrypted and explicitly pass that value in EC2 CreateVolume call. (#1316) 
Signed-off-by: Matt Stump <mstump@vorstella.com>
 2019-03-26 17:30:27 -07:00
pei0804 7af9f8d74e compile only once for regexp.MustCompile 
Signed-off-by: pei0804 <peeeei0804@gmail.com>
 2019-03-21 21:51:48 +09:00
Steve Kriss ff2db31b32 log error locations from plugin logger and don't overwrite in client 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-20 16:13:37 -06:00
Steve Kriss 7d66fc31bd pkg/restic: check for & skip hostPath PVC/PVs 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-19 08:57:47 -06:00
Steve Kriss 183bea369d make resticrepositories non-restorable resources (#1296) 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-18 11:38:37 -07:00
KubeKween 73514a003b Move plugin interfaces to same package (#1264) 
* Move plugin interfaces to same package

Signed-off-by: Carlisia <carlisiac@vmware.com>
 2019-03-14 16:35:06 -04:00
Steve Kriss 7674332313 pass --log-level to plugins (#1278) 
Plumb the log level through to plugin processes


Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-14 10:53:36 -07:00
Steve Kriss 409116fce8 add basic plugin panic handlers (#1270) 
* add server-side panic handlers to all plugin methods

Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-13 14:07:52 -04:00
tsturzl 89ca2571f3 AWS zone on volume IDs 
Signed-off-by: Travis Sturzl<travis@metismachine.com>
 2019-03-12 13:04:33 -06:00
Nolan Brubaker 394548afcd
Merge pull request #1254 from skriss/remove-wait-for-pv 
remove restore code that waits for a PV to become Available
 2019-03-11 13:20:59 -04:00
KubeKween 4ee41a13a0
Merge pull request #1261 from asaf-erlich/patch-1 
Update ark restore to not open every single file open during extracti…
 2019-03-08 14:59:09 -08:00
asaf-erlich 4041044a93
Update ark restore to not open every single file open during extraction of the data 
Original error was:

```
ark -n <redacted> restore logs <redacted>
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=nodes logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=events.events.k8s.io logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=backups.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Not including resource" groupResource=restores.ark.heptio.com logSource="pkg/restore/restore.go:124"
time="2019-03-06T18:31:06Z" level=info msg="Starting restore of backup backup/<redacted>" logSource="pkg/restore/restore.go:342"
time="2019-03-06T18:31:06Z" level=info msg="error unzipping and extracting: open /tmp/604421455/resources/rolebindings.rbac.authorization.k8s.io/namespaces/<redacted>/<redacted>: too many open files" logSource="pkg/restore/restore.go:346"
```

Downloading the directory from s3 and untarring it I found 1036 files. The ulimit -n output says 1024. This is our team's best guess at a root cause. But the code fixed in the PR definitely is holding all the files open until the method closes: https://blog.learngoprogramming.com/gotchas-of-defer-in-go-1-8d070894cb01

Please note my go code abilities are not great and I did not test this. I just edited the file in github. All I did was remove the defer and put fileClose after the copy is done. Theoretically this should only hold one file open at a time now. Let me know if you want me to do any further steps.

Thank you,
-Asaf

Signed-off-by: Asaf Erlich <aerlich@groupon.com>
 2019-03-07 11:23:35 -05:00
Michal Wieczorek 1354e2b6ff
Add original item to restore plugin interface 
Signed-off-by: Michal Wieczorek <wieczorek-michal@wp.pl>
 2019-03-05 17:09:42 -08:00
Steve Kriss e29aa74a23 remove restore code that waits for a PV to become Available 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-03-05 17:04:52 -07:00
DheerajSShetty 1b031f0cc4 Improve `describe` output 
* Move Phase to right under Metadata(name/namespace/label/annotations)
 * Move Validation errors: section right after Phase: section and only
   show it if the item has a phase of FailedValidation
 * For restores move Warnings and Errors under Validation errors. Do not
   show Warnings or Errors if there are none.

Signed-off-by: DheerajSShetty <dheerajs@vmware.com>

Fixes #987
 2019-03-04 13:21:18 -08:00
KubeKween e21940bee1
Merge pull request #1231 from skriss/k8s-1.12-deps 
update kubernetes and azure dependencies to 1.12
 2019-02-28 15:09:06 -08:00
Nolan Brubaker 421b64b1fa
Merge pull request #1247 from skriss/pr-1146-changelog 
add changelog for PR 1146
 2019-02-28 18:08:32 -05:00
Steve Kriss 81e741ebfc add changelog for PR 1146 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-02-28 16:02:23 -07:00
Nolan Brubaker fcf21813a5
Merge pull request #1246 from skriss/preserve-storageclass 
when restoring a PV, don't remove its spec.storageClassName
 2019-02-28 18:02:20 -05:00
Steve Kriss 8dd1cbf62b add changelog 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-02-28 15:58:18 -07:00
Steve Kriss 80fe640b98 add changelog 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-02-28 14:36:38 -07:00
KubeKween 7353294b7f
Merge pull request #1236 from DheerajSShetty/squashed_feature 
defer closing the ReadCloser in ObjectStoreGRPCServer.GetObject
 2019-02-28 13:12:05 -08:00
DheerajSShetty 032aaac508 defer closing the ReadCloser in ObjectStoreGRPCServer.GetObject 
Signed-off-by: DheerajSShetty <dheerajs@vmware.com>

Fixes #1093
 2019-02-28 11:51:10 -08:00
Steve Kriss 431602e852 add v0.11.0 changelog 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-02-27 12:40:42 -08:00
Steve Kriss cb0a9281f6 add v0.10.2 changelog 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-02-27 08:23:21 -08:00
Steve Kriss e3e76c2067 pkg/restic: fix concurrency bugs causing dupe repos, panics 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-02-25 18:30:26 -08:00
Steve Kriss e1d414338c
Merge pull request #1200 from nrb/fix-1183 
Fix restoring GCP regional disks
 2019-02-12 13:48:42 -07:00
Nolan Brubaker 0ffaeb949d Fix restoring GCP regional disks 
To create a regional disk, the URLs for the zones in which the disk is
replicated must be provided to the GCP API.

Fixes #1183

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
 2019-02-12 15:42:50 -05:00
KubeKween 378011baf6
Merge pull request #1153 from daved/fix/1142-restore_log 
Clarify conditional nature of restore in log
 2019-02-11 09:22:25 -08:00
Daved b2b1ee44ea Clarify restore log when object unchanged 
Signed-off-by: Daved <daved@codemodus.com>
 2019-02-11 09:12:07 -08:00
Steve Kriss 4583aa7078
Merge pull request #826 from nrb/fix-691 
Wait for namespace to terminate before restoring
 2019-02-07 11:07:25 -07:00
Nolan Brubaker 890202f2e4 Wait for PV/namespace to delete before restore 
If a PV already exists, wait for it, it's associated PVC, and associated
namespace to be deleted before attempting to restore it.

If a namespace already exists, wait for it to be deleted before
attempting to restore it.

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
 2019-02-06 15:43:50 -05:00
Steve Kriss 8ee406b4bd add/fix changelogs for recent PRs 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-02-06 12:42:29 -07:00
Nolan Brubaker 43714caaec Rename Ark to Velero!!! 
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
 2019-02-04 17:35:22 -05:00
Steve Kriss 8a58b217be show server version in ark version output using ServerStatusRequest CRD 
Signed-off-by: Steve Kriss <steve@heptio.com>
 2019-01-23 12:51:13 -07:00
Andy Goldstein 5847dcabba
Merge pull request #1117 from wwitzel3/issue-134 
Add backup-version file in backup tarball
 2019-01-22 09:01:34 -08:00
Steve Kriss 7c2a6caa5a v0.10.1 changelog 
Signed-off-by: Steve Kriss <krisss@vmware.com>
 2019-01-10 13:10:39 -07:00
Wayne Witzel III d08c2e1b9c Add backup-version file in backup tarball 
Signed-off-by: Wayne Witzel III <wwitzel3@vmware.com>
 2019-01-09 16:36:32 -05:00
Jun Gong 702d0f76c2 Add debugging-install link in doc get-started.md 
Signed-off-by: Jun Gong <jungong@tencent.com>
 2019-01-03 09:19:42 +08:00
Steve Kriss 32dd33e211 changelog 
Signed-off-by: Steve Kriss <steve@heptio.com>
 2018-12-07 09:59:03 -07:00
Jon Whitcraft f983f4fb21
Fix output of Schedule Delete 
It should be `\n` and not `/n/` when doing the printf on a schedule delete.

Signed-off-by: Jon Whitcraft <jwhitcraft@mac.com>
 2018-12-06 15:33:14 -05:00
Steve Kriss 6a60a55ba5 rename 'make goreleaser' to 'make release', remove obsolete targets 
Signed-off-by: Steve Kriss <steve@heptio.com>
 2018-12-06 11:06:24 -07:00
Wayne Witzel III 1b7a64a812 Add changelog make target helper 
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
 2018-12-05 13:32:02 -05:00
Wayne Witzel III 1da5702c0f Move changelog entries to their own files 
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
 2018-12-05 11:00:11 -05:00
Andy Goldstein aa9d96f3b7
Add pprof support to ark server 
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
 2018-12-05 10:13:39 -05:00
Wayne Witzel III 7bdd7f8c87 Fixes for CHANGELOG from review 
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
 2018-12-03 13:26:03 -05:00
Wayne Witzel III 6b94f68201 adjust changelog layout 
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
 2018-11-16 16:00:35 -05:00
Steve Kriss 38c212ecf8 update changelog for v0.10.0 GA release 
Signed-off-by: Steve Kriss <steve@heptio.com>
 2018-11-14 15:22:07 -07:00
Steve Kriss 22959071bc add doc explaining locations 
Signed-off-by: Steve Kriss <steve@heptio.com>
 2018-11-14 08:57:23 -07:00
Steve Kriss 9063808606 v0.10 changelog 
Signed-off-by: Steve Kriss <steve@heptio.com>
 2018-10-26 11:37:31 -06:00