Steven Chung
8ae40b55ec
fix error formatting
...
would interpret % as printf formatted strings
Signed-off-by: Steven Chung <schung@d2iq.com>
2019-08-21 12:49:59 -04:00
Nolan Brubaker
363c2692a1
Use custom namespace when creating Velero clients
...
The Velero deployment did not have a way of exposing the namespace it
was installed in to the API client. This is a problem for plugins that
need to query for resources in that namespaces, such as the restic
restore process that needs to find PodVolume(Backup|Restore)s.
While the Velero client is consulted for a configured namespace, this
cannot be set in the server pod since there is no valid home directory
in which to place it.
This change provides the namespace to the deployment via the downward
API, and updates the API client factory to use the VELERO_NAMESPACE
before looking at the config file, so that any plugins using the client
will look at the appropriate namespace.
Fixes #1743
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-08-13 13:06:12 -04:00
Adnan Abdulhussein
7b7b96de74
velero install: support velero/restic pod cpu/mem requests with unbounded limits ( #1745 )
...
* support velero/restic pod cpu/mem requests with unbounded limits
explicitly treat "0" value as unbounded
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* update flag documentation
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* update restic configmap docs
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-09 12:54:04 -06:00
Adnan Abdulhussein
92b930d351
sort GVKs in output
...
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-08 15:13:35 -07:00
Steve Kriss
ffa3251efc
move contents of pkg/util/test into pkg/test
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-07 08:26:00 -06:00
KubeKween
4accb8512a
Restore from PodVolumeBackups ( #1723 )
...
* Restore from PodVolumeBackups
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Partially address code reviews
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Partially address code reviews #2
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Clean up struct
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix log messages
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Fix tests
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Clean up
Signed-off-by: Carlisia <carlisiac@vmware.com>
* Add changelog
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-08-06 13:17:36 -07:00
Steve Kriss
539e0b54c6
use the persistent --namespace flag in 'velero install' ( #1722 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-08-05 15:40:39 -06:00
Nolan Brubaker
a4e70456a1
Add resource limits to restic init container ( #1677 )
...
* Add resource limits to restic init container
Fixes #1201
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Start restic restore item action tests
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Get initial tests for restore action working
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add new test case
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Move resource parsing into a shared function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fetch request/limits from plugin's ConfigMap
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Use builders
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Use moved ParseResourceRequirements function
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Move init container building inline
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Drop CPU limit down a bit and clarify error message
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Fix godoc
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Add resource requirements to doc
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-08-05 13:18:11 -06:00
Adnan Abdulhussein
2254635bcb
print resource list metadata in velero backup describe --details ( #1714 )
...
* print resource list metadata in velero backup describe details
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* rewrite TestGetDownloadURL to test more scenarios
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* move backup printer helpers to backup_printer.go
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* move describe printer helpers back to backup_describer
and rename to prefix with describe* to indicate that they are used for the describe command
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* split backup and restore tests for TestGetDownloadURL
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* friendlier error message when backup resource list missing
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-08-05 12:23:20 -06:00
Nolan Brubaker
635dd27e1a
Make secret file optional on install ( #1699 )
...
* Make secret file optional on install
Fixes #1689
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-08-01 15:57:36 -07:00
Adnan Abdulhussein
2a6929d453
add velero install flags for configuring restic resource requirements ( #1710 )
...
* add velero install flags for configuring restic resource requirements
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-07-31 12:24:47 -07:00
Steve Kriss
4543258970
Update tests to use object builders in pkg/builder ( #1707 )
...
* add pkg/builder with BackupBuilder and ObjectMeta functional options
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-31 07:46:48 -07:00
carthewd
22eca22ac8
Add JSON as an option for log output ( #1654 )
...
* Add JSON as an option for log output
Signed-off-by: Donovan Carthew <donovan.carthew@gmail.com>
2019-07-30 16:29:34 -07:00
Adnan Abdulhussein
248ee89123
add configurable CPU/memory requests/limits for velero pod on install ( #1678 )
...
* add configurable CPU/memory requests/limits for velero pod on install
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-07-29 15:13:06 -04:00
KubeKween
3b9af8c654
Store PodVolumeBackups in obj storage & use as source of truth ( #1577 )
...
* Store PodVolumeBackups in object storage
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-07-24 15:51:20 -04:00
Steve Kriss
3c4dd3e526
fix typo in schedule create example ( #1693 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-23 11:02:38 -07:00
Nolan Brubaker
5f409f12c8
Document --pod-annotations install argument ( #1674 )
...
* Document --pod-annotations install argument
Fixes #1667
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Revert v1.0.0 edits
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Make pod annotations example commands complete
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-19 12:12:57 -07:00
Nolan Brubaker
aa8c0cd471
Honor kube client flags in install command ( #1656 )
...
Flags specifying the kubeconfig or kubecontext to use weren't actually
being used by the install command.
Fixes #1651
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-17 14:19:14 -07:00
Nolan Brubaker
3124570c7f
Remove references to apps/v1beta1 API group ( #1673 )
...
* Remove references to apps/v1beta1 API group
In Kubernetes v1.16, the apps/v1 API group will be the default served
for relevant resources.
Update any references to apps/v1beta1 for fowards compatibility.
Fixes #1672
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
* Update API group on plugin commands
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-17 15:03:48 -06:00
Steve Kriss
1bb167ef90
add restore item action to change PVC/PV storage class name ( #1621 )
...
* add restore item action to change PVC/PV storage class name
Signed-off-by: Steve Kriss <krisss@vmware.com>
* code review
Signed-off-by: Steve Kriss <krisss@vmware.com>
* change existing plugin names to lowercase/hyphenated
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add validation for new storage class name
Signed-off-by: Steve Kriss <krisss@vmware.com>
* add test cases
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
* fix imports
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update plugin names to be more consistent
Signed-off-by: Steve Kriss <krisss@vmware.com>
* update unit tests to use pkg/test object constructors
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-15 11:19:38 -07:00
Nolan Brubaker
63964fc6f9
Append "/mount" to directory for CSI volumes ( #1615 )
...
CSI volumes are mounted one level deeper than "native" kubernetes
volumes, and this needs to be appended for proper restic support.
Fixes #1313 .
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-07-10 15:16:21 -07:00
John Matthews
afa49f398f
bug fix: Fixed namespace usage with cli command 'version'
...
Signed-off-by: John Matthews <jwmatthews@gmail.com>
2019-07-07 13:54:46 -04:00
Traci Kamp
f829dabcf4
Add pod-annotations CLI flag to the install command ( #1626 )
...
* allow users to specify additional Velero/restic pod annotations on the command line with the pod-annotations flag
Signed-off-by: Traci Kamp <traci.kamp@gmail.com>
2019-07-03 15:22:34 -07:00
Adnan Abdulhussein
eec5cc687e
validate pod volumes hostpath mount on restic server startup ( #1616 )
...
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-07-03 14:20:31 -06:00
Steve Kriss
bf00754280
fix schedule create examples to use hours as units ( #1625 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-07-03 12:20:49 -07:00
Adnan Abdulhussein
74b575200c
hide server commands in velero CLI ( #1561 )
...
* hide server commands in velero CLI
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* changelog
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
* remove unnecessary comment
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
2019-06-10 19:20:17 -06:00
Steve Kriss
e183c4b597
remove glog ( #1559 )
...
* remove glog refs, replace with klog equivalents
Signed-off-by: Steve Kriss <krisss@vmware.com>
* remove glog from deps
Signed-off-by: Steve Kriss <krisss@vmware.com>
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-06-10 15:44:44 -07:00
KubeKween
0a771e6a53
Add cmd to list plugins ( #1535 )
...
* Add cmd to list plugins
Signed-off-by: Carlisia <carlisiac@vmware.com>
2019-06-05 13:41:02 -04:00
Steve Kriss
411d44a673
allow individual backup storage locations to be read-only ( #1517 )
...
* allow individual backup storage locations to be read-only
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-29 14:21:25 -04:00
Nolan Brubaker
b3c6e5e483
Add more examples to schedule create ( #1473 )
...
Partially addresses #1464
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-05-13 09:25:25 -07:00
Nolan Brubaker
c209f0c0c3
Add snapshot-location to `velero create` command ( #1472 )
...
`velero snapshot-location create` existed, but not `velero create
snapshot-location`; update subcommand for parity with backup-location
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-05-13 09:23:25 -07:00
Nolan Brubaker
e0bc14d56b
Add flag to disable creation of VSL on install
...
Fixes #1453
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-05-09 15:04:42 -04:00
Fábio Franco Uechi
24d28c8633
Check for backup existence before download ( #1447 )
...
* check for backup existence in download command
Signed-off-by: fabito <fuechi@ciandt.com>
2019-05-06 12:24:29 -04:00
Steve Kriss
2406994740
remove ref to v0.10 from BSL validation error msg ( #1429 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-05-02 11:20:50 -07:00
Steve Kriss
660080e6f3
remove all remaining legacy Ark references ( #1415 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-29 12:33:54 -07:00
Steve Kriss
8392e6d83f
add PartiallyFailed phase for backups, log+continue on errors ( #1386 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-26 09:14:26 -07:00
Steve Kriss
42f351b000
Merge pull request #1407 from nrb/bucket-dashes
...
Throw an error on an invalid bucket name
2019-04-25 15:41:19 -06:00
Nolan Brubaker
9e19ab8d8b
Throw an error on an invalid bucket name
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-25 16:26:03 -04:00
Steve Kriss
c201a2c103
fix describer output
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 12:57:40 -06:00
Steve Kriss
1a55964326
update CLI outputs for PartiallyFailed phase
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-24 12:57:40 -06:00
Steve Kriss
6dd007b507
remove deprecated hooks (replaced by pre hooks) ( #1384 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-19 08:40:35 -07:00
Nolan Brubaker
f8f0d15da2
Add --namespace parameter to install command ( #1380 )
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-17 09:38:14 -07:00
Steve Kriss
5bc6695109
move RestoreResult from api to pkg/restore, rename to Result
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-16 12:57:02 -06:00
Nolan Brubaker
6f474016a6
Add velero install command ( #1287 )
...
Add velero install command
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
2019-04-15 14:10:11 -07:00
Nolan Brubaker
94f014101d
Merge pull request #1323 from skriss/v1.0-removals
...
v1.0 removals
2019-04-15 16:24:02 -04:00
Steve Kriss
373e4c9abe
update daemonset log to show version and SHA
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 11:27:04 -06:00
Steve Kriss
c59544cb79
remove backup.status.volumeBackups and all related code
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:40 -06:00
Steve Kriss
7f36f78aee
remove code that removes legacy GC finalizer from backups
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:03 -06:00
Steve Kriss
77e648eafa
remove Ark field from RestoreResult
...
Signed-off-by: Steve Kriss <krisss@vmware.com>
2019-04-15 10:17:02 -06:00
Steve Kriss
3ed97db550
Merge pull request #1362 from nrb/include-resources-examples
...
Add example for restoring with --include-resources
2019-04-12 14:45:15 -06:00