178b6e3db5
add more maintenance interval unit tests
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-21 14:22:11 -06:00
bf0d909524
issue 8706: for immediate volumes, get node from volumeattachment
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-02-21 13:27:44 +08:00
3fb8c72b6c
empty string case
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:49 -06:00
92617d07c5
log only if not equal
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:49 -06:00
1b7d9014a5
add to unmarshal test
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:49 -06:00
271ff180e9
lint
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:48 -06:00
21ae1cbe82
Address https://github.com/vmware-tanzu/velero/pull/8581#pullrequestreview-2622445640
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:48 -06:00
3bb39d9331
Address https://github.com/vmware-tanzu/velero/pull/8581#pullrequestreview-2622443771
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:48 -06:00
c153651044
Pass all backupRepoConfig keys to storageVariables, and thus RepoOptions.
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:48 -06:00
5a79e70d79
Configurable Kopia Maintenance Interval
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
comment update
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
comment
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-20 16:40:48 -06:00
e2a7986629
issue 8706: for immediate volumes, get node from volumeattachment
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-02-20 19:19:28 +08:00
eb77151f48
Delete VSC after backup completes.
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2025-02-19 14:36:59 +08:00
620a116e7f
Modify CSI related DeleteItemActions.
...
Remove the VS DIA.
Modify the VSC DIA: create then delete the VSC.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2025-02-19 14:36:59 +08:00
3843ae7030
Delete VolumeSnapshotContent from the backup sync process.
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2025-02-19 14:36:59 +08:00
80cea31a84
Merge pull request #8694 from ywk253100/250214_hook
...
Run backup post hooks inside ItemBlock synchronously
2025-02-18 14:37:27 +08:00
a3cee616dc
Upgrade go.mod k8s.io/ go.mod to v0.31.3 and set klog.SetLogger() for client-go ( #8450 )
...
Also bumped to support upgraded k8s.io/ deps.
- controller-gen to v0.16.5
- sigs.k8s.io/controller-runtime v0.19.2
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2025-02-17 15:05:10 -05:00
7aa8040c09
Run backup post hooks inside ItemBlock synchronously
...
Run backup post hooks inside ItemBlock synchronously as the ItemBlocks are handled asynchronously
Fixes #8516
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2025-02-17 13:27:41 +08:00
d9721fddb5
Merge pull request #8665 from aj-2000/user/aj-2000/validate-from-schedule-flag
...
Validate `--from-schedule` flag in create backup command
2025-02-14 18:57:39 +08:00
c0c4407657
Merge pull request #8681 from blackpiglet/8238_fix
...
Don't run maintenance on the ReadOnly BackupRepositories.
2025-02-14 11:32:49 +08:00
e3a64065f1
Merge pull request #8659 from sseago/parallel-itemblocks
...
Implement parallel ItemBlock processing via backup_controller goroutines
2025-02-14 10:42:14 +08:00
fa156c3961
Don't run maintenance on the ReadOnly BackupRepositories.
...
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
2025-02-13 13:46:53 +08:00
e446d92d4c
Merge pull request #8464 from shubham-pampattiwar/obj-status-restore-impl
...
Allowing Object-Level Resource Status Restore
2025-02-13 13:37:58 +08:00
893621c1ad
Allowing Object-Level Resource Status Restore
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
add changelog
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
Update impl according to design
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
make update
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
update logging
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
2025-02-12 18:59:25 -08:00
fcfb2fd9ee
Implement parallel ItemBlock processing via backup_controller goroutines
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2025-02-12 12:03:37 -05:00
cdcd6eb99d
Fix WaitGroup panic issue
...
Make sure WaitGroup.Add() is called before WaitGroup.Done() to avoid WaitGroup panic issue
Fixes #8657
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2025-02-12 13:56:05 +08:00
9010d9b13e
chore: enable unnecessary-stmt from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-02-08 12:11:22 +00:00
ae5e94e822
chore: enable increment-decrement from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-02-07 20:58:39 +01:00
06fc9da925
refactor code
...
Signed-off-by: Ajay Sharma <ajaysharma.13122000@gmail.com>
2025-02-07 15:16:34 +00:00
10a5b7b702
Merge pull request #8624 from mmorel-35/revive/use-any
...
chore: enable use-any from revive
2025-02-07 15:09:05 +08:00
de170043ea
rename cancel function
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-02-06 10:58:04 +08:00
3ca547f186
validate `--from-schedule` flag
...
Signed-off-by: Ajay Sharma <ajaysharma.13122000@gmail.com>
2025-02-05 14:01:31 +00:00
5fd9df3e2c
refactor pod volume context
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-02-05 16:16:44 +08:00
ec1eadc501
Merge pull request #8643 from Lyndon-Li/windows-support-smoking-test
...
Windows support smoking test
2025-01-24 10:41:58 +08:00
9afad9a2db
Merge pull request #8630 from ywk253100/250116_update
...
Handle update conflict when restoring the status
2025-01-23 13:16:46 +08:00
bedea9c74c
Merge pull request #8637 from reasonerjt/rm-leaked-vs
...
Clean up leaked CSI snapshot for incomplete backup
2025-01-23 12:56:12 +08:00
1e54f1cb15
chore: enable var-declaration from revive ( #8636 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-01-22 15:56:44 -05:00
1c372893ec
Clean up leaked CSI snapshot for incomplete backup
...
This commit makes sure when a backup is deleted the controller will
delete the CSI snapshot even when the bakckup tarball is not uploaded.
fixes #8160
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
2025-01-22 17:17:41 +08:00
43fcaa2706
windows support smoking test
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-22 13:44:45 +08:00
f0efe2aaa1
Handle update conflict when restoring the status
...
Handle update conflict when restoring the status
Fixes #8184
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2025-01-21 13:06:24 +08:00
0a4b05cb6e
repo maintenance for windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-17 19:06:57 +08:00
cbba3bdde7
chore: enable use-any from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-01-17 07:58:10 +01:00
5b1738abf8
Merge pull request #8580 from Lyndon-Li/recall-repo-maintenance-history-on-restart
...
Recall repo maintenance history on restart
2025-01-17 14:08:27 +08:00
91fcb65118
add maintenance wait backoff log
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-16 13:38:51 +08:00
d090d0ad44
Always create DataUpload configmap in restore namespace
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2025-01-15 16:30:13 -05:00
0045e94072
get maintenance result only for failed jobs
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-15 17:35:12 +08:00
3900f2f117
recall repo maintenance history on restart
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-15 15:05:02 +08:00
054375093d
Merge pull request #8615 from Lyndon-Li/avoid-creating-repo-when-bsl-is-readonly
...
Avoid to create new repo when BSL is readonly
2025-01-15 14:41:14 +08:00
1d3af6d160
Merge pull request #8611 from Lyndon-Li/distribute-dd-evenly
...
Distribute dd evenly across nodes
2025-01-14 17:21:45 +08:00
34c26dd476
avoid to create new repo when BSL is readonly
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-14 17:12:46 +08:00
b52b45012b
distribute dd evenly across nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-14 14:37:30 +08:00
97ce5662ba
Merge branch 'main' into update-du-dd-progress-when-terminal-event-is-missing
2025-01-13 19:17:53 +08:00
411469b90c
update du/dd progress on completion
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-13 18:33:32 +08:00
5f7bf64d06
Merge pull request #8606 from Lyndon-Li/data-mover-pod-misc-enhancement-for-windows
...
Add Windows toleration to data mover pods
2025-01-13 18:22:21 +08:00
094ba59160
Merge pull request #8602 from Lyndon-Li/change-udmrepo-config-to-tmp
...
Change udmrepo config file location to tmp
2025-01-13 17:10:08 +08:00
e79dbb8d60
change udmrepo config file location to tmp
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-13 15:53:54 +08:00
5dedaca148
data mover pod misc enhancement for windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-13 15:30:47 +08:00
e92069247d
Merge pull request #8603 from ywk253100/250113_pvb
...
[cherry-pick]Check the PVB status via podvolume Backupper rather than calling API server to avoid API server issue
2025-01-13 14:22:17 +07:00
fb7cf9e4ba
Merge pull request #8598 from mmorel-35/partially-fix-dupword
...
fix: dupword on tests
2025-01-13 13:37:28 +07:00
3207619f30
Merge pull request #8594 from Lyndon-Li/data-mover-restore-for-windows
...
Data mover restore for Windows
2025-01-13 13:04:29 +08:00
1f39943291
Check the PVB status via podvolume Backupper rather than calling API server to avoid API server issue
...
Check the PVB status via podvolume Backupper rather than calling API server to avoid API server issue
Fixes #8587
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2025-01-13 12:56:26 +08:00
fc9683688a
move maintenance to a separate folder
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-13 10:57:14 +08:00
29a77958d5
fix: dupword on tests
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-01-10 11:44:06 +01:00
a8469126d8
data mover restore for Windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-10 08:58:32 +00:00
225db5e8c0
Merge pull request #8385 from mmorel-35/golangci-lint/perfsprint
...
golangci-lint: enable int-conversion and fiximports rule of perfsprint
2025-01-10 15:28:21 +07:00
46b8a31ef0
Merge pull request #8590 from Lyndon-Li/fix-data-mover-progress-missing-after-25-updates
...
Issue 8579 - set event burst
2025-01-10 15:12:51 +08:00
32ae4091ac
add event burst
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-10 14:18:07 +08:00
42d2e9bfc4
Merge pull request #8591 from reasonerjt/finalize-async-op
...
Skip patching the PV in finalization for failed operation
2025-01-10 14:02:42 +08:00
05765fb2fd
golangci-lint: enable int-conversion and fiximports rule of perfsprint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-01-09 22:31:29 +00:00
dc02caf2b0
Skip patching the PV in finalization for failed operation
...
This commit makes change in restore finalizer controller, to make it
check the status in item operation of a PVC before patch the PV that is
bound to it. If the operation is not successful it will skip patching
the PV.
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
2025-01-09 01:42:50 +08:00
be5f56ab18
Merge pull request #8550 from Lyndon-Li/restore-pvc-ignore-wait-for-first-consumer
...
Issue 8044: generic restore - allow to ignore delay binding for WaitForFirstConsumer
2025-01-08 15:14:20 +08:00
dce97770cd
Merge pull request #8572 from sseago/exclude-pvs-from-backup
...
Don't include excluded items in ItemBlocks
2025-01-07 13:21:36 +07:00
4ce7361f5a
recall repo maintenance history on restart
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-07 12:58:43 +08:00
4b09b63c2d
Don't include excluded items in ItemBlocks
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2025-01-06 18:11:45 -05:00
ceeab10b6e
Merge branch 'main' into recall-repo-maintenance-history-on-restart
2025-01-06 17:21:52 +08:00
6b73a256d5
recall repo maintenance history on restart
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-06 17:11:03 +08:00
db69829fd7
repo maintenance job out of repo manager
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-06 16:25:33 +08:00
3eaa73962b
Merge pull request #8574 from ywk253100/241223_restore_helper
...
Merge restore helper image into Velero server image
2025-01-06 13:48:28 +08:00
3120e33ed7
Clear validation errors when schedule is valid ( #8575 )
...
Clear validation errors when schedule is valid
Fixes #8571
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2025-01-03 15:13:43 -05:00
912b116bdb
always use job's time
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-03 16:50:35 +08:00
cfad06b701
Merge branch 'main' into restore-pvc-ignore-wait-for-first-consumer
2025-01-03 14:14:37 +08:00
eb5230e12f
Merge restore helper image into Velero server image
...
Merge restore helper image into Velero server image
Fixes #8484
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2025-01-03 14:12:23 +08:00
cb22dfc482
fs uploader and block uploader support Windows nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-02 13:25:23 +08:00
d2a25cd446
fs uploader skip system folders on windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-02 11:30:40 +08:00
bc6414672e
disable block volume data mover on windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-02 11:28:21 +08:00
6ff0aa32e3
recall existing repo maintenance to history
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2025-01-02 11:16:46 +08:00
f5d13aeb17
data mover backup for Windows nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-26 02:46:08 +00:00
a56b06bab1
issue 8044: generic restore - allow to ignore WaitForFirstConsumer
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-26 10:29:15 +08:00
78c97d93b5
Merge pull request #8518 from Lyndon-Li/fail-fs-backup-on-windows-nodes
...
fs-backup for clusters with windows nodes
2024-12-24 15:15:15 +08:00
4e0a0e0b72
fail fs-backup for windows nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-24 14:26:02 +08:00
eeee79e551
Merge pull request #8532 from Lyndon-Li/isolate-message-in-backup-repo
...
Add maintenance history for backupRepository CRs
2024-12-23 19:29:52 +08:00
623e023bb3
wait node-agent for Windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-23 19:04:40 +08:00
14e71fa2cd
Bug fix: increase the WaitGroup counter before start the goroutine
...
Bug fix: increase the WaitGroup counter before start the goroutine
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-12-23 17:26:36 +08:00
92390e9af5
add repo maintain result in history
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-23 15:37:27 +08:00
77f1141ef5
backup repo crd changes for repo maintenance history
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-23 15:24:17 +08:00
be97a5c1c6
hide restic deprecation warning for install with crd-only
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-20 14:48:03 +08:00
3504546ba9
Merge branch 'main' into fail-fs-backup-on-windows-nodes
2024-12-20 13:20:01 +08:00
cae7a7a901
Merge branch 'main' into fail-fs-backup-on-windows-nodes
2024-12-20 11:41:45 +08:00
ea93c00cc2
Merge pull request #8504 from Lyndon-Li/linux-windows-hybrid-deploy
...
Linux windows hybrid deploy
2024-12-20 11:40:25 +08:00
3b2c50b459
add repo maintain result in history
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-19 16:20:15 +08:00
c9bfd33077
isolate repo maintenane history
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-19 15:33:58 +08:00
dfdb1c139d
backup repo crd changes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-18 10:56:46 +00:00
a663cc4a76
Merge pull request #8512 from ywk253100/251213_pause
...
Fix issue: backup schedule pause/unpause doesn't work
2024-12-18 17:24:02 +08:00
4ad9c2485a
hybrid deploy
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-18 10:50:23 +08:00
a711b1067b
fail fs-backup for windows nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-18 10:46:00 +08:00
99ba81e5d1
add use-node-agent-windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-17 13:54:03 +08:00
617411fa5a
Merge branch 'main' into linux-windows-hybrid-deploy
2024-12-17 13:46:52 +08:00
fe0a45eac6
restict velero server in linux nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-17 13:38:33 +08:00
a5a6e47e42
add use-node-agent-windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-17 13:27:51 +08:00
11cd6d922b
hybrid deploy
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-17 13:05:46 +08:00
010fd1cb1d
Merge pull request #8509 from ywk253100/241212_hook_fix
...
Fix backup post hook issue
2024-12-17 13:02:25 +08:00
6e34c09d84
Fix issue: backup schedule pause/unpause doesn't work
...
The issue is caused by the changes of controller-runtime: WithEventFilter() doesn't apply to WatchesRawSource(),
this commit set Predicate for WatchesRawSource() seperatedly
Fixes #8437
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-12-13 16:07:53 +08:00
0224d99889
Merge pull request #8482 from Lyndon-Li/data-mover-exposer-diagnostic
...
Data mover exposer diagnostic
2024-12-13 14:28:37 +08:00
c43fc42c25
Fix backup post hook issue
...
Fix backup post hook issue
Fixes #8159
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-12-13 12:25:45 +08:00
cd01222d8e
Merge pull request #8508 from Lyndon-Li/issue-fix-8267-info-when-expose-error
...
Issue 8267: enhance the error message when expose fails
2024-12-12 17:00:44 +08:00
cb7758f72b
Merge pull request #8441 from blackpiglet/refactor_migration_e2e
...
Refactor migration E2E case
2024-12-12 12:14:24 +08:00
8b545532e2
issue 8267: add informative logs when expose error
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-12 11:19:26 +08:00
eb48cbd60f
Merge pull request #8297 from kaovilai/aws-getbucketregion-hint
...
Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go
2024-12-11 14:19:11 +08:00
26661c775f
Merge pull request #8498 from Lyndon-Li/move-accept-info-to-du-dd-cr
...
Move the accepted info from annotations to DU/DD CR
2024-12-11 13:22:39 +08:00
0ea4eb563a
hybrid deploy
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-10 18:28:18 +08:00
34e417bdac
add diagnostic for data mover exposer
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-10 14:00:31 +08:00
a1cf952b8d
Issue 8433: add third party labels to data mover pods when the same labels exist in node-agent pods ( #8487 )
...
* issue 8433: add ask label to data mover pods
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
* check existence of the same label from node-agent
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
---------
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-09 12:44:39 -05:00
86082eb137
move the accepted info from annotations to DU/DD CR
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-09 16:39:04 +08:00
11f100fc59
Merge pull request #8486 from Lyndon-Li/fix-issue-8485-prepare-timeout-not-work
...
Fix prepare timeout issue
2024-12-09 14:54:03 +08:00
b588dc926d
Merge pull request #8491 from reasonerjt/restore-help-secctx
...
Add SecurityContext to restore-helper
2024-12-06 10:27:36 -05:00
4b7f93189d
Add SecurityContext to restore-helper
...
This commit adds SecurityContext that complies with "restricted" level
per Pod Security Standards to "restore-helper" initContainer.
It ensures the restore won't fail when the cluster enforces PSA.
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
2024-12-06 17:30:41 +08:00
cbdbbe26c2
fix prepare timeout issue
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-05 17:24:12 +08:00
04d6c79179
Merge pull request #8471 from vmware-tanzu/8440_fix_main
...
[main] Add nil check for updating DataUpload VolumeInfo in finalizing phase
2024-12-05 01:17:19 -05:00
6c0ed1e5d2
Merge pull request #8366 from sseago/synchronise-backedupitems
...
Make BackedUpItems thread safe
2024-12-04 07:50:45 -08:00
b607259563
add diagnostic for data mover exposer
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-04 14:49:58 +08:00
abbfac09f4
Merge branch 'main' into data-mover-exposer-diagnostic
2024-12-04 10:33:57 +08:00
e4e9b18b37
add diagnostic for data mover exposer
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-04 10:28:50 +08:00
015b1e69f6
Make BackedUpItems thread safe
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2024-12-03 15:23:45 -05:00
3cd85f5b43
ping kopia to 0.18.2
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-12-03 13:06:26 +08:00
226370d035
Add nil check for updating DataUpload VolumeInfo in finalizing phase.
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2024-12-03 10:50:55 +08:00
8fcb6de323
Refactor the migration cases.
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2024-11-26 11:04:54 +08:00
aed944cb0e
Merge pull request #8257 from shubham-pampattiwar/add-warn-argocd
...
Add Backup warning for inclusion of NS managed by ArgoCD
2024-11-19 20:21:17 -08:00
738bb79a99
Add Backup warning for inclusion of NS managed by ArgoCD
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
add changelog file
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
run make update
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
re-position import
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
update argo cd label comment
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
add nil check for backupRequest.Spec.IncludedNamespaces
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
minor fix
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
fix edge cases
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
add gh issue link in code comments
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
2024-11-19 16:06:22 -08:00
a9c9f19368
Merge pull request #8169 from mpryc/aws_creds_exposed
...
Fix #8168 - AWS secrets should not be exposed while running tests
2024-11-18 20:34:05 +08:00
e7da6727cf
Merge pull request #8343 from evhan/maintenance-job-env-from
...
Copy "envFrom" from Velero server when creating maintenance jobs
2024-11-18 20:28:44 +08:00
74790d9f60
Added tracking for deleted namespace status check in restore flow ( #8233 )
...
* Added tracking for deleted namespace status check in restore flow
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
fixed unittest
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
refactored tracker execution and caller
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
added change log
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
Author: sangitaray2021 <sangitaray@microsft.com>
Author: sangitaray2021 <sangitaray@microsoft.com>
Date: Thu Sep 19 02:26:14 2024 +0530
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
* fixed linter issuer
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
* incorporated PR comments
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
* resolved comments
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
---------
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com>
2024-11-18 13:41:07 +05:30
dacd5eff93
Merge pull request #8380 from sseago/worker-count
...
Add --item-block-worker-count flag to velero install and server
2024-11-15 16:04:25 +08:00
32a8c62920
Merge pull request #8395 from Lyndon-Li/issue-fix-8394
...
Issue 8394: move closeDataPath outside callbacks
2024-11-13 10:39:13 +08:00
7feda11e54
issue 8391: check ErrCancelled from suffix
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-11-12 18:32:38 +08:00
e5d6c48fea
issue 8394: move closeDataPath outside callbacks
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-11-12 17:07:50 +08:00
6588141090
Add --item-block-worker-count flag to velero install and server
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2024-11-07 10:58:36 -05:00
d0cffa3d19
Merge pull request #8354 from alromeros/add-annotations-flag
...
Include --annotations flag in backup and restore create commands
2024-11-06 01:17:17 +08:00
f981dd4ab2
Copy "envFrom" from Velero node-agent when creating data mover pods
...
Signed-off-by: Evan Hanson <evanhanson@catalyst.net.nz>
2024-10-31 16:32:54 +13:00
70d88901b9
Copy "envFrom" from Velero server when creating maintenance jobs
...
Signed-off-by: Evan Hanson <evanhanson@catalyst.net.nz>
2024-10-30 15:01:59 +13:00
e2839bbdec
Include --annotations flag in backup and restore create commands
...
This commit implements a new --annotations flag in the backup and restore create commands.
This allows users to specify key-value pairs for annotations directly at the time of backup and restore creation, in the same way as the --labels flag.
Signed-off-by: Alvaro Romero <alromero@redhat.com>
2024-10-28 09:52:31 +01:00
07847925fe
Use aggregated discovery API to discovery API groups and resources
...
Use aggregated discovery API to discovery API groups and resources
Fixes #7526
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-10-28 13:59:16 +08:00
8320df44fd
Merge pull request #8275 from ywk253100/241008_discovery
...
Bump up version of client-go and controller-runtime
2024-10-28 13:51:17 +08:00
8058a38058
Merge pull request #8271 from mcluseau/main
...
fix(pkg/repository/maintenance): handle when there's no container status
2024-10-28 13:50:25 +08:00
53ef988c15
fix windows cli compile problem
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-10-23 14:49:44 +08:00
e770f0c308
fix(pkg/repository/maintenance): don't panic when there's no container statuses
...
Signed-off-by: Mikaël Cluseau <mikael.cluseau@gmail.com>
2024-10-22 07:07:45 +02:00
d06601e977
fix: use Contains or ErrorContains with testify
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-18 20:36:45 +02:00
226a4c1138
golangci-lint: enable and fix thelper linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-17 08:12:57 +02:00
fe14fb235c
Merge pull request #8301 from msfrucht/revert_expose_sourcevolumemode
...
Revert "Expose VSC SourceVolumeMode" 1.15
2024-10-16 10:04:46 +08:00
6fa81ec9b9
fixed error message typo for item block action
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2024-10-15 15:22:19 -04:00
d9b278edb9
Revert "Expose VSC SourceVolumeMode"
...
This reverts commit 7580538f03
2024-10-14 12:01:05 -07:00
69b456af70
Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2024-10-14 10:08:12 -05:00
b1035dd49d
add no-relabeling option to backupPVC configmap
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2024-10-14 10:26:55 -04:00
de7a414511
only set spec.volumes readonly if PVC is readonly for datamover
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2024-10-10 10:51:33 -04:00
23ca089d40
Use '"' rather than '`' in the log to avoid unexpected new line
...
Use '"' rather than '`' in the log to avoid unexpected new line
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-10-09 14:44:13 +08:00
db2eb89a26
Merge pull request #8245 from shubham-pampattiwar/fix-err-str
...
Remove multiple single quotes from Velero backup.status.validationErrors field
2024-10-09 08:33:19 +08:00
0a4e417aab
Bump up version of client-go and controller-runtime
...
Bump up version of client-go to v0.30.5
Bump up version of controller-runtime to v0.18.5
Fixes #8274
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-10-08 18:53:12 +08:00
7580538f03
Expose VSC SourceVolumeMode
...
Add changelog and unittest
Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>
2024-10-03 15:05:58 -07:00
f15cde5dfd
Remove mutiple single quotes from Velero backup.status.validationErrors field
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
update error message
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
2024-09-30 14:20:44 -07:00
42de654372
Revert "issue 8249: disable selinux relabel for backupPod ( #8250 )" ( #8253 )
...
This reverts commit 0ccdc7c6e1
2024-09-27 12:31:38 -04:00
0ccdc7c6e1
issue 8249: disable selinux relabel for backupPod ( #8250 )
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-09-27 11:57:29 -04:00
c0d51a5465
Add labels to maintanance job pods
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
add changelog
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
2024-09-24 17:09:13 -07:00
025d66d5fd
Merge pull request #8237 from Lyndon-Li/issue-fix-8232
...
Issue 8232: ensure the ending event sinked before shutdown
2024-09-24 11:20:52 +08:00
9deaa819aa
issue 8232: ensure the ending event sinked before shutdown
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
2024-09-23 18:35:56 +08:00
390ac497bb
Add the Carvel package related resources to the restore priority list
...
Add the Carvel package related resources to the restore priority list
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-09-19 16:47:00 +08:00
3f9c2dc789
Reduces ~140 indirect imports for plugin/framework importers ( #8208 )
...
* Avoid plugin framework importers from needing cloud provider imports
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2024-09-13 10:21:51 +08:00
da291467d7
Merge pull request #8199 from AlbeeSo/fix/use-new-gr
...
use newGR instead of groupResource after apiversion convert
2024-09-12 10:20:39 -07:00
efcf836d16
Merge pull request #8201 from blackpiglet/update_velero_install_parameter
...
Add the ConfigMap-specified parameters into velero install CLI
2024-09-12 13:08:56 +08:00
68f3545424
Add the ConfigMap-specified parameters into `velero install` CLI.
...
Rename backup-repository-config to backup-repository-configmap.
Rename repo-maintenance-job-config to repo-maintenance-job-configmap.
Rename node-agent-config to node-agent-configmap.
Add those three parameters to `velero install` CLI.
Modify the design and the site documents.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2024-09-12 11:24:14 +08:00
7e8a3c0bbc
Merge pull request #8206 from kaovilai/pkgpodvolumebackupper_test.go59714thecancelfunctionreturnedbycontext.WithTimeout
...
pkg/podvolume/backupper_test.go:597:14: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
2024-09-12 10:43:02 +08:00
670338e02f
Merge pull request #8210 from kaovilai/pvc_pv_test.go-32-2
...
pvc_pv_test.go:32:2: other import of "k8s.io/api/core/v1"
2024-09-12 10:42:19 +08:00
5b4c8cd5b1
Merge pull request #8198 from kaovilai/pes-controller
...
Add controller name to periodical_enqueue_source
2024-09-12 10:41:46 +08:00
70168634cb
pvc_pv_test.go:32:2: other import of "k8s.io/api/core/v1"
...
package "k8s.io/api/core/v1" is being imported more than once (ST1019)
pvc_pv_test.go:32:2: other import of "k8s.io/api/core/v1"
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2024-09-11 17:21:04 -04:00
c8aa37d852
Remove additional param, use pkg/constant
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2024-09-11 17:13:37 -04:00
bf6215c894
Merge pull request #7793 from kaovilai/upgrade_robfig/cron/v3
...
Upgrade to robfig/cron/v3 to support time zone specification
2024-09-11 14:02:58 +08:00
3c777cb09f
pkg/podvolume/backupper_test.go:597:14: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2024-09-10 19:26:58 -04:00
c643ee5fd4
Retry completion status patch for backup and restore resources
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
update to design #8063
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2024-09-10 17:01:14 -04:00
c2192a75aa
typo
...
Signed-off-by: AlbeeSo <suyashi1321@163.com>
2024-09-10 17:48:43 +08:00
02ac1069fe
use newGR instead of groupResource if plugin has modified the group
...
Signed-off-by: AlbeeSo <suyashi1321@163.com>
2024-09-10 14:33:36 +08:00
5c4c66bee9
Add controller name to periodical_enqueue_source
...
The code changes are related to the `NewPeriodicalEnqueueSource` function in the `kube/periodical_enqueue_source.go` file. This function is used to create a new instance of the `PeriodicalEnqueueSource` struct, which is responsible for periodically enqueueing objects into a work queue.
The changes involve adding two new parameters to this function: `controllerName string` and modifying the existing `logger` parameter to include additional fields.
Here's what changed:
1. A new `controllerName` parameter was added to the `NewPeriodicalEnqueueSource` function.
These changes are to adding more context or metadata to the logging output, possibly for debugging or monitoring purposes.
The other files (`restore_operations_controller.go`, `schedule_controller.go`, and their respective test files) were modified to use this updated `NewPeriodicalEnqueueSource` function with the new `controllerName` parameter.
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2024-09-09 12:07:07 -04:00
26cc41f26d
Implement the Repo maintanence Job configuration design.
...
Remove the resource parameters from the velero server CLI.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2024-09-09 22:42:56 +08:00
b92143dad1
Merge pull request #8102 from sseago/itemblock-workflow
...
ItemBlock model and phase 1 (single-thread) workflow changes
2024-09-09 05:59:51 -07:00
7439db57b3
Merge pull request #8166 from ywk253100/240705_plugin_args
...
Pass Velero server command args to the plugins
2024-09-06 14:29:42 +08:00
6d0f726c2f
Fix #8168 - AWS secrets should not be exposed while running tests
...
Changed the tests to use mocked function that will not read actual
secrets from env variables nor AWS config file that may be
on the system that is running tests.
As a second guard against exposed secrets comparison for the values
does not shows the actual values for the AWS data. This is to prevent
situation where programming error may still allow the test to read
AWS config/env variables instead of using mocked function.
Signed-off-by: Michal Pryc <mpryc@redhat.com>
2024-09-04 10:45:29 +02:00
dc6eeafe98
Pass Velero server command args to the plugins
...
Pass Velero server command args to the plugins
Fixes #7806
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2024-09-04 13:43:27 +08:00
9d6f4d2db5
ItemBlock model and phase 1 (single-thread) workflow changes
...
Signed-off-by: Scott Seago <sseago@redhat.com>
2024-09-03 19:04:18 -04:00
2d3521a56c
fix
...
Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>
2024-09-02 09:18:44 +00:00
434bd2f3ae
linter
...
Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>
2024-09-02 05:08:59 +00:00
79156bedad
Merge branch 'main' into pvnullfix
...
Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>
2024-09-02 04:53:53 +00:00
8be8fc6671
Add check for PV claimref nil
...
Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>
2024-09-02 04:50:16 +00:00
3408ffefac
Merge pull request #8141 from shubham-pampattiwar/fix-backup-pvc-config
...
Apply backupPVCConfig to backupPod volume spec
2024-08-30 11:09:46 +08:00
f6e2b0107f
Apply backupPVCConfig to backupPod volume spec
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
add changelog file
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
make backupPod volume mount always readOnly
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
use assert.True()
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
Add readOnly param for MakePodPVCAttachment func
lint fix
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
2024-08-29 13:18:17 -07:00
Tiger Kaovilai
Lyndon-Li
Xun Jiang
Wenkai Yin(尹文开)
Daniel Jiang
Xun Jiang/Bruce Jiang
Shubham Pampattiwar
Scott Seago
Matthieu MOREL
Ajay Sharma
lyndon-li
sangitaray2021
Evan Hanson
Alvaro Romero
Mikaël Cluseau
MICHAEL S FRUCHTMAN
AlbeeSo
Michal Pryc
Anshul Ahuja