by changing output type to image.
Then you can execute command like so to create a multi-arch image
```
BUILDX_PLATFORMS=linux/amd64,linux/arm64 BUILDX_OUTPUT_TYPE=image make container
```
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Set `GOBIN` so Makefile don't modify $PATH on `go install`
Fix realPath resolving when cloud credentials is prefixed by `~` for home dir
Use `~/.docker/config.json` if REGISTRY_CREDENTIAL_FILE not defined and skip step if does not exists since it is optional
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Add kind testdata storageclass
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Add kind testdata storageclass
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
log `Start to install Azure VolumeSnapshotClass ...` only on azure when csi is enabled
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Add BSL_CONFIG example and notes
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Makefile: Set `GOBIN` for `_output/...`
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
README spacing
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
StandbyClusterObjectStoreProvider typo
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Specify velero namespace during get/delete command
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Use object stores rather than cloudProvider for bucket queries
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Remove debug print
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
simplify NS get changes, add velero NS to `DeleteBackupResource`
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Skip file system backups on kind which uses hostPath volumes
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Add StorageClass change test to PR kind e2e
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Add more tests to pr
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Add NS mapping to PR e2e
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Add `SKIP_KIND` to some jobs containing volumes
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Remove kind from kibishii tests
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Label volume resource policies as restic, skip restic/snapshot tests, add more tests
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
TTLTest is a snapshot test
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Remove non working tests
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Resolve https://github.com/vmware-tanzu/velero/pull/7353#issuecomment-1925660077
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
address https://github.com/vmware-tanzu/velero/pull/7353/files#r1477218762
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Address https://github.com/vmware-tanzu/velero/pull/7353#issuecomment-1923414840
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
This commit mitigates the issue for running "make update" locally when
the network is not friendly for accessing the default "proxy.golang.org"
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
This commit makes backup sync controller delete the volumesnapshot and
volumesnapshotcontent created by the backup which is cleaned up as orphan
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
1. Add --insecure-tls for ResticManager's commands.
2. Add --insecure-tls in PodVolumeBackup and PodVolumeRestore controller.
3. Upgrade integrated Restic version to v0.13.1
4. Change --last flag in Restic command to --latest=1 due to Restic version update.
Signed-off-by: Xun Jiang <jxun@vmware.com>
Bump up restic to v0.12.1 to fix CVE-2020-26160.
Bump up module "github.com/vmware-tanzu/crash-diagnostics" to v0.3.7 to fix CVE-2020-29652.
The "github.com/vmware-tanzu/crash-diagnostics" updates client-go to v0.22.2 which introduces several break changes, this commit updates the related codes as well
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
The `push-build-image` target was broken in #3634. The `ifneq`
conditional block had tabs for indentation which results in incorrect
behaviour. Instead, remove whitespace before the conditional block like
we do for other similar blocks.
Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
This adds a new `buildinfo` variable `ImageRegistry` that can set at
build time like the `Version` variable. This allows us to customise the
Velero binary to use different registries.
If the variable is set, this variable wille be used when creating the
URIs for both the main `velero` and `velero-restic-restore-helper`
images. If it is not set, default to using Dockerhub (`velero/velero`,
`velero/velero-restic-restore-helper`).
There are numerous ways in which the Velero binary can be built so all
of them have been updated to add the new link time flag to set the
variable:
* `make local` (used for local developer builds to build for the local
OS and ARCH)
* `make build` (used by developers and also VMware internal builds to
build a specific OS and ARCH)
* Goreleaser config (used when creating OSS release binaries)
* Dockerfile (used to build the Velero binary used within the image)
All of these workflows are currently triggered from our Makefile where
the variable `REGISTRY` is already available with the default value of
`velero` and used to build the image tag. Where the new `ImageRegistry`
build variable is needed, we pass through this Makefile variable to
those tasks so it can be used accordingly.
The GitHub action and the `./hack/docker-push.sh` script used to push
container images has not been modified. This will continue to use the
default registry specified in the Makefile and will not explicitly pass
it in.
Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
For internal builds of Velero, we need to be able to specify an
alternative Dockerfile which uses an alternative image registry to pull
the base images from. This change adapts our Makefile such that both the
main Dockerfile and build image Dockerfile can be overridden.
We have some special handling for the build image to only build when the
Dockerfile has changed. In this case, we check whether a custom
Dockerfile has been provided, and always rebuild in that case. For
custom build image Dockerfiles, use a fixed tag rather than the one
based on commit SHA of the original file.
Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
* Basic end-to-end tests, generate data/backup/remove/restore/verify
Uses distributed data generator
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
* Moved backup/restore into velero_utils, started using a name for the restore
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
* remove checked in binary and update test/e2e Makefile
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* Ran make update
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
* Save
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
* Ran make update
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
* Basic end-to-end test, generate data/backup/remove/restore/verify
Uses distributed data generator
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
* Changed tests/e2e Makefile to just use go get to install ginkgo in the GOPATH/bin
Updated to ginkgo 1.14.2
Put cobra back to v0.0.7
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
* Added CLOUD_PLATFORM env variable to Makefile, updated README, removed ginkgo from .gitignore
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
* choose velero CLI binary based on local env
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
This change addresses some issues in the documentation and scripts that
were found during the v1.5.1 release:
* Fix the path to the changelog script in the Makefile
* Fix the path to the pre-release TOC in the docs
* Improve the instructions for creating/updating the upgrade
instructions page.
Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Wenkai Yin(尹文开)
Lyndon-Li
lyndon-li
Tiger Kaovilai
Shubham Pampattiwar
Daniel Jiang
Ming Qiu
Ming Qiu
Xun Jiang/Bruce Jiang
Mateus Oliveira
Xun Jiang
danfengliu
Daniel Jiang
Xun Jiang
Aditya Sharma
Bridget McErlean
Ashish Amarnath
David L. Smith-Uchida
Carlisia Thompson