From f1846be634f220cff95fa8c0527e71233fe83bc3 Mon Sep 17 00:00:00 2001 From: Xun Jiang Date: Tue, 10 Sep 2024 22:25:08 +0800 Subject: [PATCH] Enable --fail-fast by default for E2E and performance tests. Signed-off-by: Xun Jiang --- test/Makefile | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/Makefile b/test/Makefile index fce0b9d8e..2cec6307d 100644 --- a/test/Makefile +++ b/test/Makefile @@ -50,6 +50,10 @@ OUTPUT_DIR := _output/$(GOOS)/$(GOARCH)/bin # Please reference to this document for Ginkgo label spec format. # https://onsi.github.io/ginkgo/#spec-labels GINKGO_LABELS ?= +# When --fail-fast is set, the entire suite will stop when the first failure occurs. +# Enable --fail-fast by default. +# https://onsi.github.io/ginkgo/#mental-model-how-ginkgo-handles-failure +FAIL_FAST ?= true VELERO_CLI ?=$$(pwd)/../_output/bin/$(GOOS)/$(GOARCH)/velero VELERO_IMAGE ?= velero/velero:main PLUGINS ?= @@ -170,6 +174,7 @@ run-e2e: ginkgo --junit-report e2e/report.xml \ --label-filter="$(GINKGO_LABELS)" \ --timeout=5h \ + --fail-fast=$(FAIL_FAST) \ ./e2e \ -- $(COMMON_ARGS) \ --upgrade-from-velero-cli=$(UPGRADE_FROM_VELERO_CLI) \ @@ -210,6 +215,7 @@ run-perf: ginkgo --junit-report perf/report.xml \ --label-filter="$(GINKGO_LABELS)" \ --timeout=5h \ + --fail-fast=$(FAIL_FAST) \ ./perf \ -- $(COMMON_ARGS) \ --nfs-server-path=$(NFS_SERVER_PATH) \