From cd4e9f5336cb7089a98c030c973cd24a574efef3 Mon Sep 17 00:00:00 2001 From: Steve Kriss Date: Thu, 23 Aug 2018 16:14:37 -0700 Subject: [PATCH] azure: fix for breaking change in blob.GetSASURI Signed-off-by: Steve Kriss --- pkg/cloudprovider/azure/object_store.go | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/pkg/cloudprovider/azure/object_store.go b/pkg/cloudprovider/azure/object_store.go index 392030b2a..11cf232c0 100644 --- a/pkg/cloudprovider/azure/object_store.go +++ b/pkg/cloudprovider/azure/object_store.go @@ -147,8 +147,6 @@ func (o *objectStore) DeleteObject(bucket string, key string) error { return errors.WithStack(blob.Delete(nil)) } -const sasURIReadPermission = "r" - func (o *objectStore) CreateSignedURL(bucket, key string, ttl time.Duration) (string, error) { container, err := getContainerReference(o.blobClient, bucket) if err != nil { @@ -160,7 +158,16 @@ func (o *objectStore) CreateSignedURL(bucket, key string, ttl time.Duration) (st return "", err } - return blob.GetSASURI(time.Now().Add(ttl), sasURIReadPermission) + opts := storage.BlobSASOptions{ + SASOptions: storage.SASOptions{ + Expiry: time.Now().Add(ttl), + }, + BlobServiceSASPermissions: storage.BlobServiceSASPermissions{ + Read: true, + }, + } + + return blob.GetSASURI(opts) } func getContainerReference(blobClient *storage.BlobStorageClient, bucket string) (*storage.Container, error) {