Merge pull request #2655 from carlisia/c-header

Add header info + fix broken tags
pull/2661/head
Nolan Brubaker 2020-06-19 12:54:12 -04:00 committed by GitHub
commit 7b1126ff28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 20 additions and 4 deletions

View File

@ -14,6 +14,14 @@ Add that to the PR.
If a PR does not warrant a changelog, the CI check for a changelog can be skipped by applying a `changelog-not-required` label on the PR.
## Copyright header
Whenever a source code file is being modified, the copyright notice should be updated to our standard copyright notice. That is, it should read “Copyright [insert current year] the Velero contributors.”
For new files, the entire copyright and license header must be added.
Please note that doc files do not need a copyright header.
## Code
- Log messages are capitalized.
@ -36,7 +44,7 @@ If a PR does not warrant a changelog, the CI check for a changelog can be skippe
For imports, we use the following convention:
<group><version><api | client | informer | ...>
`<group><version><api | client | informer | ...>`
Example:

View File

@ -34,7 +34,7 @@ Add that to the PR.
For imports, we use the following convention:
<group><version><api | client | informer | ...>
`<group><version><api | client | informer | ...>`
Example:

View File

@ -34,7 +34,7 @@ Add that to the PR.
For imports, we use the following convention:
<group><version><api | client | informer | ...>
`<group><version><api | client | informer | ...>`
Example:

View File

@ -12,6 +12,14 @@ changelog.
Add that to the PR.
## Copyright header
Whenever a source code file is being modified, the copyright notice should be updated to our standard copyright notice. That is, it should read “Copyright [insert current year] the Velero contributors.”
For new files, the entire copyright and license header must be added.
Please note that doc files do not need a copyright header.
## Code
- Log messages are capitalized.
@ -34,7 +42,7 @@ Add that to the PR.
For imports, we use the following convention:
<group><version><api | client | informer | ...>
`<group><version><api | client | informer | ...>`
Example: