Merge pull request #1562 from carlisia/c-bug-sort

Fix test comparison
pull/1574/head
Steve Kriss 2019-06-11 12:34:35 -06:00 committed by GitHub
commit 49f52b54b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions

View File

@ -17,6 +17,7 @@ limitations under the License.
package serverstatusrequest
import (
"sort"
"testing"
"time"
@ -164,6 +165,9 @@ func TestProcess(t *testing.T) {
assert.Nil(t, res)
assert.True(t, apierrors.IsNotFound(err))
} else {
sortPluginsByKindAndName(tc.expected.Status.Plugins)
sortPluginsByKindAndName(res.Status.Plugins)
assert.Equal(t, tc.expected.Status.Plugins, res.Status.Plugins)
assert.Equal(t, tc.expected, res)
assert.Nil(t, err)
}
@ -171,6 +175,15 @@ func TestProcess(t *testing.T) {
}
}
func sortPluginsByKindAndName(plugins []velerov1api.PluginInfo) {
sort.Slice(plugins, func(i, j int) bool {
if plugins[i].Kind != plugins[j].Kind {
return plugins[i].Kind < plugins[j].Kind
}
return plugins[i].Name < plugins[j].Name
})
}
type fakePluginLister struct {
plugins []framework.PluginIdentifier
}