From 37f8be093f86f8f2b4fbf2d4e2745e462d5d2eab Mon Sep 17 00:00:00 2001 From: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Date: Thu, 16 Dec 2021 10:54:11 -0500 Subject: [PATCH] =?UTF-8?q?Update=20code=20standards=20to=20direct=20folks?= =?UTF-8?q?=20to=20create=20changelogs=20on=20release=E2=80=A6=20(#4443)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update code standards to direct folks to create changelogs on release branches * Fix wording Signed-off-by: Abigail McCarthy --- site/content/docs/main/code-standards.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/site/content/docs/main/code-standards.md b/site/content/docs/main/code-standards.md index 6e18f0c6d..a6dfa12c6 100644 --- a/site/content/docs/main/code-standards.md +++ b/site/content/docs/main/code-standards.md @@ -20,11 +20,11 @@ changelog. Add that to the PR. -If a PR does not warrant a changelog, the CI check for a changelog can be skipped by applying a `changelog-not-required` label on the PR. +If a PR does not warrant a changelog, the CI check for a changelog can be skipped by applying a `changelog-not-required` label on the PR. If you are making a PR on a release branch, you should still make a new file in the `changelogs/unreleased` folder on the release branch for your change. -## Copyright header +## Copyright header -Whenever a source code file is being modified, the copyright notice should be updated to our standard copyright notice. That is, it should read “Copyright the Velero contributors.” +Whenever a source code file is being modified, the copyright notice should be updated to our standard copyright notice. That is, it should read “Copyright the Velero contributors.” For new files, the entire copyright and license header must be added. @@ -61,7 +61,7 @@ Example: metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" corev1client "k8s.io/client-go/kubernetes/typed/core/v1" corev1listers "k8s.io/client-go/listers/core/v1" - + velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1" velerov1client "github.com/vmware-tanzu/velero/pkg/generated/clientset/versioned/typed/velero/v1" )