From 2dc8a920cac2c3efae3baff95c8f791bcb1f6e70 Mon Sep 17 00:00:00 2001 From: Lyndon-Li Date: Fri, 24 Mar 2023 14:38:26 +0800 Subject: [PATCH] fix issue 5972 Signed-off-by: Lyndon-Li --- changelogs/unreleased/6028-Lyndon-Li | 1 + pkg/util/logging/log_counter_hook.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/6028-Lyndon-Li diff --git a/changelogs/unreleased/6028-Lyndon-Li b/changelogs/unreleased/6028-Lyndon-Li new file mode 100644 index 000000000..74a95bf90 --- /dev/null +++ b/changelogs/unreleased/6028-Lyndon-Li @@ -0,0 +1 @@ +Fix issue #5972, don't assume errorField as error type when dealing with logger.WithError \ No newline at end of file diff --git a/pkg/util/logging/log_counter_hook.go b/pkg/util/logging/log_counter_hook.go index a14b790f6..7ee37e660 100644 --- a/pkg/util/logging/log_counter_hook.go +++ b/pkg/util/logging/log_counter_hook.go @@ -71,7 +71,7 @@ func (h *LogHook) Fire(entry *logrus.Entry) error { entryMessage = fmt.Sprintf("%s name: /%s", entryMessage, nameField.(string)) } if isErrorFieldPresent { - entryMessage = fmt.Sprintf("%s error: /%s", entryMessage, errorField.(error).Error()) + entryMessage = fmt.Sprintf("%s error: /%v", entryMessage, errorField) } if isNamespacePresent {