vmware-tanzu
/
velero
mirror of https://github.com/vmware-tanzu/velero.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add LD_LIBRARY_PATH as an env varible for the use of vsphere plugin (#1893) 

* Add LD_LIBRARY_PATH as an env varible for the use of vsphere plugin

Signed-off-by: Lintong Jiang <lintongj@vmware.com>
pull/1922/head
lintongj 2019-09-27 13:10:00 -07:00 committed by KubeKween
parent a1545b7d32
commit 2d845683a2
4 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelogs/unreleased/1893-lintongj Normal file
View File

@ -0,0 +1 @@
Add LD_LIBRARY_PATH (=/plugins) to the env variables of velero deployment.

4
pkg/install/deployment.go
View File

@ -161,6 +161,10 @@ func Deployment(namespace string, opts ...podTemplateOption) *appsv1.Deployment
},
},
},
{
Name: "LD_LIBRARY_PATH",
Value: "/plugins",
},
},
Resources: c.resources,
},

4
pkg/install/deployment_test.go
View File

@ -33,7 +33,7 @@ func TestDeployment(t *testing.T) {
assert.Equal(t, "--restore-only", deploy.Spec.Template.Spec.Containers[0].Args[1])
deploy = Deployment("velero", WithEnvFromSecretKey("my-var", "my-secret", "my-key"))
envSecret := deploy.Spec.Template.Spec.Containers[0].Env[2]
envSecret := deploy.Spec.Template.Spec.Containers[0].Env[3]
assert.Equal(t, "my-var", envSecret.Name)
assert.Equal(t, "my-secret", envSecret.ValueFrom.SecretKeyRef.LocalObjectReference.Name)
assert.Equal(t, "my-key", envSecret.ValueFrom.SecretKeyRef.Key)
@ -43,7 +43,7 @@ func TestDeployment(t *testing.T) {
assert.Equal(t, corev1.PullIfNotPresent, deploy.Spec.Template.Spec.Containers[0].ImagePullPolicy)
deploy = Deployment("velero", WithSecret(true))
assert.Equal(t, 5, len(deploy.Spec.Template.Spec.Containers[0].Env))
assert.Equal(t, 6, len(deploy.Spec.Template.Spec.Containers[0].Env))
assert.Equal(t, 3, len(deploy.Spec.Template.Spec.Volumes))
deploy = Deployment("velero", WithDefaultResticMaintenanceFrequency(24*time.Hour))

4
site/docs/master/plugins.md
View File

@ -82,6 +82,10 @@ Velero will pass any known features flags as a comma-separated list of strings t
Once parsed into a `[]string`, the features can then be registered using the `NewFeatureFlagSet` function and queried with `features.Enabled(<featureName>)`.
## Environment Variables
Velero adds the `LD_LIBRARY_PATH` into the list of environment variables to provide the convenience for plugins that requires C libraries/extensions in the runtime.
[1]: https://github.com/heptio/velero-plugin-example
[2]: https://github.com/heptio/velero/blob/master/pkg/plugin/logger.go
[3]: https://github.com/heptio/velero/blob/master/pkg/restore/restic_restore_action.go