From 2a36cdcbf6a6c3eae6cc3d2058006152019ca7dc Mon Sep 17 00:00:00 2001 From: Steve Kriss Date: Fri, 29 Mar 2019 14:33:50 -0600 Subject: [PATCH] set backup start timestamp before patching to inprogress (#1330) Signed-off-by: Steve Kriss --- changelogs/unreleased/1330-skriss | 1 + pkg/controller/backup_controller.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/1330-skriss diff --git a/changelogs/unreleased/1330-skriss b/changelogs/unreleased/1330-skriss new file mode 100644 index 000000000..ad4f73dbc --- /dev/null +++ b/changelogs/unreleased/1330-skriss @@ -0,0 +1 @@ +set backup's start timestamp before patching it to InProgress so start times display in `velero backup get` while in progress diff --git a/pkg/controller/backup_controller.go b/pkg/controller/backup_controller.go index b2f28fa05..9dc2abf2a 100644 --- a/pkg/controller/backup_controller.go +++ b/pkg/controller/backup_controller.go @@ -175,6 +175,7 @@ func (c *backupController) processBackup(key string) error { request.Status.Phase = velerov1api.BackupPhaseFailedValidation } else { request.Status.Phase = velerov1api.BackupPhaseInProgress + request.Status.StartTimestamp.Time = c.clock.Now() } // update status @@ -390,7 +391,6 @@ func (c *backupController) validateAndGetSnapshotLocations(backup *velerov1api.B func (c *backupController) runBackup(backup *pkgbackup.Request) error { log := c.logger.WithField("backup", kubeutil.NamespaceAndName(backup)) log.Info("Starting backup") - backup.Status.StartTimestamp.Time = c.clock.Now() logFile, err := ioutil.TempFile("", "") if err != nil {