vmware-tanzu
/
velero
mirror of https://github.com/vmware-tanzu/velero.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Check for backup existence before download (#1447) 

* check for backup existence in download command

Signed-off-by: fabito <fuechi@ciandt.com>
pull/1461/head
Fábio Franco Uechi 2019-05-06 13:24:29 -03:00 committed by Nolan Brubaker
parent 0462217c9b
commit 24d28c8633
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelogs/unreleased/1447-fabito Normal file
View File

@ -0,0 +1 @@
check backup existence before download

12
pkg/cmd/cli/backup/download.go
View File

@ -25,6 +25,7 @@ import (
"github.com/pkg/errors"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
v1 "github.com/heptio/velero/pkg/apis/velero/v1"
"github.com/heptio/velero/pkg/client"
@ -40,7 +41,7 @@ func NewDownloadCommand(f client.Factory) *cobra.Command {
Args: cobra.ExactArgs(1),
Run: func(c *cobra.Command, args []string) {
cmd.CheckError(o.Complete(args))
cmd.CheckError(o.Validate(c, args))
cmd.CheckError(o.Validate(c, args, f))
cmd.CheckError(o.Run(c, f))
},
}
@ -70,7 +71,14 @@ func (o *DownloadOptions) BindFlags(flags *pflag.FlagSet) {
flags.DurationVar(&o.Timeout, "timeout", o.Timeout, "maximum time to wait to process download request")
}
func (o *DownloadOptions) Validate(c *cobra.Command, args []string) error {
func (o *DownloadOptions) Validate(c *cobra.Command, args []string, f client.Factory) error {
veleroClient, err := f.Client()
cmd.CheckError(err)
if _, err := veleroClient.VeleroV1().Backups(f.Namespace()).Get(o.Name, metav1.GetOptions{}); err != nil {
return err
}
return nil
}