From 8e525c41b4c87b221ed640a771131007762e4f0f Mon Sep 17 00:00:00 2001 From: Daniel Tehranian Date: Sun, 15 Feb 2026 23:44:31 -0600 Subject: [PATCH] Fix typos and logic bug in remote_install.sh and Makefile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - remote_install.sh: Fix $FASE typo → $FALSE so FROM_CURL initializes correctly - remote_install.sh: Fix else → elif in check_can_upgrade so logerr only fires when there are actual errors, not unconditionally - Makefile: Fix missing closing paren in $(shell ...) and 'realease' typo in dockerbuildnrun target Co-Authored-By: Claude Opus 4.6 --- Makefile | 2 +- release/remote_install.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 365d233..84a5844 100755 --- a/Makefile +++ b/Makefile @@ -224,7 +224,7 @@ quickbuild: armhf arm64 # This is run inside container Dockerfile.releaseBinariies (aqualinkd-releasebin) dockerbuildnrun: ./release/aqualinkd - $(shell ./release/aqualinkd -d -c ./realease/aqualinkd.test.conf + $(shell ./release/aqualinkd -d -c ./release/aqualinkd.test.conf) debugbuild: CFLAGS = $(DFLAGS) diff --git a/release/remote_install.sh b/release/remote_install.sh index 7b87b7c..475ec5c 100755 --- a/release/remote_install.sh +++ b/release/remote_install.sh @@ -34,7 +34,7 @@ ERROR_ON_GLIBC=$FALSE # $TRUE will error and not continue, $FALSE will give a wa REQUIRED_GLIBC_VERSION="2.31" -FROM_CURL=$FASE +FROM_CURL=$FALSE SYSTEMD_LOG=$FALSE USE_RELEASE_PKG=$TRUE @@ -225,9 +225,9 @@ function check_can_upgrade { fi fi - if [[ "$output" == "" ]] && [[ "$REL_VERSION" != "" ]]; then + if [[ "$output" == "" ]] && [[ "$REL_VERSION" != "" ]]; then return "$TRUE" - else [[ "$output" != "" ]] + elif [[ "$output" != "" ]]; then logerr "$output"; return "$FALSE" fi